All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: shh.xie@gmail.com
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
	mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
	catalin.marinas@arm.com, will.deacon@arm.com,
	linux-kernel@vger.kernel.org, Mihai Bantea <mihai.bantea@nxp.com>,
	Chenhui Zhao <chenhui.zhao@nxp.com>,
	arnd@arndb.de, Shaohui Xie <Shaohui.Xie@nxp.com>,
	Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
	Minghuan Lian <Minghuan.Lian@nxp.com>,
	Mingkai Hu <Mingkai.Hu@nxp.com>,
	Horia Geant? <horia.geanta@nxp.com>,
	Gong Qianyu <Qianyu.Gong@nxp.com>
Subject: Re: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support
Date: Thu, 8 Sep 2016 21:05:49 +0800	[thread overview]
Message-ID: <20160908130549.GA16911@tiger> (raw)
In-Reply-To: <1473069695-33092-4-git-send-email-shh.xie@gmail.com>

On Mon, Sep 05, 2016 at 06:01:31PM +0800, shh.xie@gmail.com wrote:
> +	soc {
> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		clockgen: clocking@1ee1000 {
> +			compatible = "fsl,ls1046a-clockgen";
> +			reg = <0x0 0x1ee1000 0x0 0x1000>;
> +			#clock-cells = <2>;
> +			clocks = <&sysclk>;
> +		};
> +
> +		scfg: scfg@1570000 {

Instead of having device node in arbitrary place, can we sort all the
nodes under 'simple-bus' in order of unit-address?

Shawn

> +			compatible = "fsl,ls1046a-scfg", "syscon";
> +			reg = <0x0 0x1570000 0x0 0x10000>;
> +			big-endian;
> +		};

WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support
Date: Thu, 8 Sep 2016 21:05:49 +0800	[thread overview]
Message-ID: <20160908130549.GA16911@tiger> (raw)
In-Reply-To: <1473069695-33092-4-git-send-email-shh.xie@gmail.com>

On Mon, Sep 05, 2016 at 06:01:31PM +0800, shh.xie at gmail.com wrote:
> +	soc {
> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		clockgen: clocking at 1ee1000 {
> +			compatible = "fsl,ls1046a-clockgen";
> +			reg = <0x0 0x1ee1000 0x0 0x1000>;
> +			#clock-cells = <2>;
> +			clocks = <&sysclk>;
> +		};
> +
> +		scfg: scfg at 1570000 {

Instead of having device node in arbitrary place, can we sort all the
nodes under 'simple-bus' in order of unit-address?

Shawn

> +			compatible = "fsl,ls1046a-scfg", "syscon";
> +			reg = <0x0 0x1570000 0x0 0x10000>;
> +			big-endian;
> +		};

  reply	other threads:[~2016-09-08 13:06 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 10:01 [PATCH 0/7] [v2] arm64: dts: add QorIQ LS1046A SoC and boards support shh.xie
2016-09-05 10:01 ` shh.xie at gmail.com
2016-09-05 10:01 ` shh.xie
2016-09-05 10:01 ` [PATCH 1/7] [v2] dt-bindings: fsl: updates bindings for some SoC-specific devices shh.xie
2016-09-05 10:01   ` shh.xie at gmail.com
2016-09-05 10:01   ` shh.xie
2016-09-08  2:30   ` Shawn Guo
2016-09-08  2:30     ` Shawn Guo
2016-09-08  2:30     ` Shawn Guo
2016-09-08 10:57     ` S.H. Xie
2016-09-08 10:57       ` S.H. Xie
2016-09-08 10:57       ` S.H. Xie
2016-09-05 10:01 ` [PATCH 2/7] [v2] dt-bindings: i2c: adds two more nxp devices shh.xie
2016-09-05 10:01   ` shh.xie at gmail.com
2016-09-05 10:01   ` shh.xie
2016-09-12 16:33   ` Rob Herring
2016-09-12 16:33     ` Rob Herring
2016-09-12 16:33     ` Rob Herring
2016-09-05 10:01 ` [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support shh.xie
2016-09-05 10:01   ` shh.xie at gmail.com
2016-09-05 10:01   ` shh.xie
2016-09-08 13:05   ` Shawn Guo [this message]
2016-09-08 13:05     ` Shawn Guo
2016-09-09  6:46     ` S.H. Xie
2016-09-09  6:46       ` S.H. Xie
2016-09-09  6:46       ` S.H. Xie
2016-09-08 13:13   ` Mark Rutland
2016-09-08 13:13     ` Mark Rutland
2016-09-08 13:18     ` Mark Rutland
2016-09-08 13:18       ` Mark Rutland
2016-09-08 13:18       ` Mark Rutland
2016-09-09  6:55       ` S.H. Xie
2016-09-09  6:55         ` S.H. Xie
2016-09-09  6:55         ` S.H. Xie
2016-09-09  9:10         ` Mark Rutland
2016-09-09  9:10           ` Mark Rutland
2016-09-09  9:10           ` Mark Rutland
2016-09-09  9:17           ` S.H. Xie
2016-09-09  9:17             ` S.H. Xie
2016-09-09  9:17             ` S.H. Xie
2016-09-09  6:48     ` S.H. Xie
2016-09-09  6:48       ` S.H. Xie
2016-09-09  6:48       ` S.H. Xie
2016-09-08 13:23   ` Marc Zyngier
2016-09-08 13:23     ` Marc Zyngier
2016-09-08 13:23     ` Marc Zyngier
2016-09-09  9:00     ` S.H. Xie
2016-09-09  9:00       ` S.H. Xie
2016-09-09  9:00       ` S.H. Xie
2016-09-05 10:01 ` [PATCH 4/7] [v2] Documentation: DT: Add entry for QorIQ LS1046A-RDB board shh.xie
2016-09-05 10:01   ` shh.xie at gmail.com
2016-09-05 10:01   ` shh.xie
2016-09-05 10:01 ` [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support shh.xie
2016-09-05 10:01   ` shh.xie at gmail.com
2016-09-05 10:01   ` shh.xie
2016-09-08 13:12   ` Shawn Guo
2016-09-08 13:12     ` Shawn Guo
2016-09-09  6:44     ` S.H. Xie
2016-09-09  6:44       ` S.H. Xie
2016-09-09  6:44       ` S.H. Xie
2016-09-05 10:01 ` [PATCH 6/7] [v2] Documentation: DT: Add entry for QorIQ LS1046A-QDS board shh.xie
2016-09-05 10:01   ` shh.xie at gmail.com
2016-09-05 10:01   ` shh.xie
2016-09-05 10:01 ` [PATCH 7/7] [v2] arm64: dts: add LS1046A-QDS board support shh.xie
2016-09-05 10:01   ` shh.xie at gmail.com
2016-09-05 10:01   ` shh.xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160908130549.GA16911@tiger \
    --to=shawnguo@kernel.org \
    --cc=Minghuan.Lian@nxp.com \
    --cc=Mingkai.Hu@nxp.com \
    --cc=Qianyu.Gong@nxp.com \
    --cc=Shaohui.Xie@nxp.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=chenhui.zhao@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=horia.geanta@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mihai.bantea@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shh.xie@gmail.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.