All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <mawilcox@microsoft.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Theodore Ts'o <tytso@mit.edu>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
	Dave Chinner <david@fromorbit.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jan Kara <jack@suse.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes
Date: Sun, 11 Sep 2016 16:57:40 -0600	[thread overview]
Message-ID: <20160911225740.GA32049@linux.intel.com> (raw)
In-Reply-To: <20160911124741.GA746@infradead.org>

On Sun, Sep 11, 2016 at 05:47:41AM -0700, Christoph Hellwig wrote:
> On Sat, Sep 10, 2016 at 07:52:53AM +0000, Matthew Wilcox wrote:
> > DAX code over to using iomap requires converting all of ext2 away from
> > buffer_head; are you saying he's wrong?
> 
> Not sure if he's really saying that, but it's wrong for sure.  Just
> to prove that I came up with a working ext2 iomap DAX implementation
> in a few hours today.  I'll take a stab at ext4 and the block device
> as well and will post the updated series early next week - I'll need
> to take care of a few high priority todo list items first.

Yay!  Sorry if I was unclear, I wasn't trying to say that we had to change all
of ext2 over to using struct iomap.  If we can (and apparently we can) just
switch over the DAX interfaces, that's good enough to me.  I understand that
this will mean that we may have overlapping DAX paths for a while (an iomap
version and a buffer_head version).  I just wanted to figure out whether this
overlap would need to be permanent - sounds like not, which is ideal.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <mawilcox@microsoft.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
	Dave Chinner <david@fromorbit.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jan Kara <jack@suse.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes
Date: Sun, 11 Sep 2016 16:57:40 -0600	[thread overview]
Message-ID: <20160911225740.GA32049@linux.intel.com> (raw)
In-Reply-To: <20160911124741.GA746@infradead.org>

On Sun, Sep 11, 2016 at 05:47:41AM -0700, Christoph Hellwig wrote:
> On Sat, Sep 10, 2016 at 07:52:53AM +0000, Matthew Wilcox wrote:
> > DAX code over to using iomap requires converting all of ext2 away from
> > buffer_head; are you saying he's wrong?
> 
> Not sure if he's really saying that, but it's wrong for sure.  Just
> to prove that I came up with a working ext2 iomap DAX implementation
> in a few hours today.  I'll take a stab at ext4 and the block device
> as well and will post the updated series early next week - I'll need
> to take care of a few high priority todo list items first.

Yay!  Sorry if I was unclear, I wasn't trying to say that we had to change all
of ext2 over to using struct iomap.  If we can (and apparently we can) just
switch over the DAX interfaces, that's good enough to me.  I understand that
this will mean that we may have overlapping DAX paths for a while (an iomap
version and a buffer_head version).  I just wanted to figure out whether this
overlap would need to be permanent - sounds like not, which is ideal.

  reply	other threads:[~2016-09-11 22:57 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 22:04 [PATCH v2 0/9] re-enable DAX PMD support Ross Zwisler
2016-08-23 22:04 ` Ross Zwisler
2016-08-23 22:04 ` Ross Zwisler
2016-08-23 22:04 ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 1/9] ext4: allow DAX writeback for hole punch Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-09-21 15:22   ` Ross Zwisler
2016-09-21 15:22     ` Ross Zwisler
2016-09-21 15:22     ` Ross Zwisler
2016-09-21 15:22     ` Ross Zwisler
2016-09-21 15:22     ` Ross Zwisler
2016-09-22  6:59     ` Jan Kara
2016-09-22  6:59       ` Jan Kara
2016-09-22  6:59       ` Jan Kara
2016-09-22  6:59       ` Jan Kara
2016-09-22 15:51     ` Theodore Ts'o
2016-09-22 15:51       ` Theodore Ts'o
2016-08-23 22:04 ` [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
     [not found]   ` <20160823220419.11717-3-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-08-25  7:57     ` Christoph Hellwig
2016-08-25  7:57       ` Christoph Hellwig
2016-08-25  7:57       ` Christoph Hellwig
     [not found]       ` <20160825075728.GA11235-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-08-25 19:25         ` Ross Zwisler
2016-08-25 19:25           ` Ross Zwisler
2016-08-25 19:25           ` Ross Zwisler
2016-08-26 21:29         ` Ross Zwisler
2016-08-26 21:29           ` Ross Zwisler
2016-08-26 21:29           ` Ross Zwisler
2016-08-29  0:42           ` Dave Chinner
2016-08-29  0:42             ` Dave Chinner
     [not found]           ` <20160826212934.GA11265-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-08-29  7:41             ` Christoph Hellwig
2016-08-29  7:41               ` Christoph Hellwig
2016-08-29  7:41               ` Christoph Hellwig
     [not found]               ` <20160829074116.GA16491-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-08-29 12:57                 ` Theodore Ts'o
2016-08-29 12:57                   ` Theodore Ts'o
2016-08-29 12:57                   ` Theodore Ts'o
     [not found]                   ` <20160829125741.cdnbb2uaditcmnw2-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2016-08-30  7:21                     ` Christoph Hellwig
2016-08-30  7:21                       ` Christoph Hellwig
2016-08-30  7:21                       ` Christoph Hellwig
2016-09-09 16:48                     ` Ross Zwisler
2016-09-09 16:48                       ` Ross Zwisler
2016-09-09 16:48                       ` Ross Zwisler
2016-09-09 20:35                       ` Matthew Wilcox
2016-09-09 20:35                         ` Matthew Wilcox
     [not found]                         ` <DM2PR21MB0089BCA980B67D8C53B25A1BCBFA0-B2pw06WL+/BAVFCO9/lqPs1VXTxX1y3OvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-09-09 22:34                           ` Dan Williams
2016-09-09 22:34                             ` Dan Williams
2016-09-09 22:34                             ` Dan Williams
     [not found]                             ` <CAPcyv4hjna08+Yw23w_V2f-RbBE6ar220+YGCuBVA-TACKWNug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-10  7:31                               ` Christoph Hellwig
2016-09-10  7:31                                 ` Christoph Hellwig
2016-09-10  7:31                                 ` Christoph Hellwig
2016-09-10  7:50                                 ` Matthew Wilcox
2016-09-10  7:50                                   ` Matthew Wilcox
2016-09-10 17:49                                 ` Theodore Ts'o
2016-09-10 17:49                                   ` Theodore Ts'o
     [not found]                                   ` <20160910174910.yyirb7smiob7evt5-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2016-09-11  0:42                                     ` Matthew Wilcox
2016-09-11  0:42                                       ` Matthew Wilcox
2016-09-11  0:42                                       ` Matthew Wilcox
2016-09-10  8:15                               ` Matthew Wilcox
2016-09-10  8:15                                 ` Matthew Wilcox
2016-09-10  8:15                                 ` Matthew Wilcox
2016-09-10 14:56                                 ` Dan Williams
2016-09-10 14:56                                   ` Dan Williams
2016-09-10  7:30                         ` Christoph Hellwig
2016-09-10  7:30                           ` Christoph Hellwig
2016-09-10  7:33                           ` Matthew Wilcox
2016-09-10  7:33                             ` Matthew Wilcox
2016-09-10  7:42                             ` Christoph Hellwig
2016-09-10  7:42                               ` Christoph Hellwig
2016-09-10  7:52                               ` Matthew Wilcox
2016-09-10  7:52                                 ` Matthew Wilcox
     [not found]                                 ` <DM2PR21MB0089C20EF469AA91A916867CCBFD0-B2pw06WL+/BAVFCO9/lqPs1VXTxX1y3OvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-09-11 12:47                                   ` Christoph Hellwig
2016-09-11 12:47                                     ` Christoph Hellwig
2016-09-11 12:47                                     ` Christoph Hellwig
2016-09-11 22:57                                     ` Ross Zwisler [this message]
2016-09-11 22:57                                       ` Ross Zwisler
2016-09-10 15:55                           ` Matthew Wilcox
2016-09-10 15:55                             ` Matthew Wilcox
2016-09-15 20:09   ` Ross Zwisler
2016-09-15 20:09     ` Ross Zwisler
2016-09-15 20:09     ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 3/9] ext4: " Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 4/9] dax: remove buffer_size_valid() Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 5/9] dax: make 'wait_table' global variable static Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 6/9] dax: consistent variable naming for DAX entries Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 7/9] dax: coordinate locking for offsets in PMD range Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 8/9] dax: re-enable DAX PMD support Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 9/9] dax: remove "depends on BROKEN" from FS_DAX_PMD Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-23 22:04   ` Ross Zwisler
2016-08-30 23:01 ` [PATCH v2 0/9] re-enable DAX PMD support Ross Zwisler
2016-08-30 23:01   ` Ross Zwisler
2016-08-30 23:01   ` Ross Zwisler
2016-08-30 23:01   ` Ross Zwisler
2016-08-31 20:20   ` Kani, Toshimitsu
2016-08-31 20:20     ` Kani, Toshimitsu
2016-08-31 20:20     ` Kani, Toshimitsu
2016-08-31 21:36     ` Ross Zwisler
2016-08-31 21:36       ` Ross Zwisler
2016-08-31 21:36       ` Ross Zwisler
2016-08-31 21:36       ` Ross Zwisler
2016-08-31 21:36       ` Ross Zwisler
2016-08-31 22:08       ` Kani, Toshimitsu
2016-08-31 22:08         ` Kani, Toshimitsu
2016-08-31 22:08         ` Kani, Toshimitsu
2016-08-31 22:08         ` Kani, Toshimitsu
2016-09-01 16:21         ` Ross Zwisler
2016-09-01 16:21           ` Ross Zwisler
2016-09-01 16:21           ` Ross Zwisler
2016-09-01 16:21           ` Ross Zwisler
2016-09-01 16:21           ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160911225740.GA32049@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=mawilcox@microsoft.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.