From: Alexandre Belloni <alexandre.belloni@free-electrons.com> To: Stephen Boyd <sboyd@codeaurora.org> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, Michael Turquette <mturquette@baylibre.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c Date: Wed, 21 Sep 2016 10:03:10 +0200 [thread overview] Message-ID: <20160921080310.szxig3mzebq2oseo@piout.net> (raw) In-Reply-To: <20160921000211.GH8319@codeaurora.org> On 20/09/2016 at 17:02:11 -0700, Stephen Boyd wrote : > On 09/20, Alexandre Belloni wrote: > > Move all clocks related to the slow clock controller to sckc.c. This avoids > > extern definitions and allows to remove sckc.h > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > --- > > Applied to clk-next > Thanks for the fix! > drivers/clk/at91/sckc.c:146:13: > warning: symbol 'of_at91sam9x5_clk_slow_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:260:13: > warning: symbol 'of_at91sam9x5_clk_slow_rc_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:359:13: > warning: symbol 'of_at91sam9x5_clk_slow_setup' was not declared. > Should it be static? > > ----8<---- > diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c > index f6ed711af738..311956abf4aa 100644 > --- a/drivers/clk/at91/sckc.c > +++ b/drivers/clk/at91/sckc.c > @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_name; > @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > u32 frequency = 0; > @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_names[2]; > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c Date: Wed, 21 Sep 2016 10:03:10 +0200 [thread overview] Message-ID: <20160921080310.szxig3mzebq2oseo@piout.net> (raw) In-Reply-To: <20160921000211.GH8319@codeaurora.org> On 20/09/2016 at 17:02:11 -0700, Stephen Boyd wrote : > On 09/20, Alexandre Belloni wrote: > > Move all clocks related to the slow clock controller to sckc.c. This avoids > > extern definitions and allows to remove sckc.h > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > --- > > Applied to clk-next > Thanks for the fix! > drivers/clk/at91/sckc.c:146:13: > warning: symbol 'of_at91sam9x5_clk_slow_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:260:13: > warning: symbol 'of_at91sam9x5_clk_slow_rc_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:359:13: > warning: symbol 'of_at91sam9x5_clk_slow_setup' was not declared. > Should it be static? > > ----8<---- > diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c > index f6ed711af738..311956abf4aa 100644 > --- a/drivers/clk/at91/sckc.c > +++ b/drivers/clk/at91/sckc.c > @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_name; > @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > u32 frequency = 0; > @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_names[2]; > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
next prev parent reply other threads:[~2016-09-21 8:03 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-20 20:58 [PATCH v3 0/5] AT91: sckc improvements Alexandre Belloni 2016-09-20 20:58 ` Alexandre Belloni 2016-09-20 20:58 ` [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c Alexandre Belloni 2016-09-20 20:58 ` Alexandre Belloni 2016-09-21 0:02 ` Stephen Boyd 2016-09-21 0:02 ` Stephen Boyd 2016-09-21 8:03 ` Alexandre Belloni [this message] 2016-09-21 8:03 ` Alexandre Belloni 2016-09-20 20:58 ` [PATCH v3 2/5] clk: at91: Add sama5d4 sckc support Alexandre Belloni 2016-09-20 20:58 ` Alexandre Belloni 2016-09-21 0:04 ` Stephen Boyd 2016-09-21 0:04 ` Stephen Boyd 2016-09-20 20:58 ` [PATCH v3 3/5] clk: at91: sckc: optimize boot time Alexandre Belloni 2016-09-20 20:58 ` Alexandre Belloni 2016-09-21 0:04 ` Stephen Boyd 2016-09-21 0:04 ` Stephen Boyd 2016-09-20 20:58 ` [PATCH v3 4/5] ARM: dts: at91: sama5d4: use proper sckc compatible Alexandre Belloni 2016-09-20 20:58 ` Alexandre Belloni 2016-09-20 20:58 ` [PATCH v3 5/5] ARM: dts: at91: sama5d2: use correct " Alexandre Belloni 2016-09-20 20:58 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160921080310.szxig3mzebq2oseo@piout.net \ --to=alexandre.belloni@free-electrons.com \ --cc=boris.brezillon@free-electrons.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=nicolas.ferre@atmel.com \ --cc=sboyd@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.