All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	linux-hexagon@vger.kernel.org, Richard Kuo <rkuo@codeaurora.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo()
Date: Fri, 21 Oct 2016 11:46:24 -0400	[thread overview]
Message-ID: <20161021154624.maiwbgjmzlzhin2l@thunk.org> (raw)
In-Reply-To: <e9daa136-c6ab-2f96-3d20-6e143fa1170b@users.sourceforge.net>

On Fri, Oct 21, 2016 at 11:00:22AM +0200, SF Markus Elfring wrote:
> 
> > It is harder to see how the arguments fit into the strings
> > and it is harder to see where the strings end and the arguments begin.
> 
> Is it really so difficult to interpret the suggested construction
> of a single (and relatively small) format string?

It's not so difficult, so much as it makes things worse.  It's easier
the way it originally was.  It might be interesting to see if the
compiler could be taught to collapse the function calls, but (a) this
isn't performance critical, and (b) the number of bytes saved is
really tiny.  But at least if the compiler was doing the work, it
would at least deal with it everywhere.

					- Ted

WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	linux-hexagon@vger.kernel.org, Richard Kuo <rkuo@codeaurora.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo()
Date: Fri, 21 Oct 2016 15:46:24 +0000	[thread overview]
Message-ID: <20161021154624.maiwbgjmzlzhin2l@thunk.org> (raw)
In-Reply-To: <e9daa136-c6ab-2f96-3d20-6e143fa1170b@users.sourceforge.net>

On Fri, Oct 21, 2016 at 11:00:22AM +0200, SF Markus Elfring wrote:
> 
> > It is harder to see how the arguments fit into the strings
> > and it is harder to see where the strings end and the arguments begin.
> 
> Is it really so difficult to interpret the suggested construction
> of a single (and relatively small) format string?

It's not so difficult, so much as it makes things worse.  It's easier
the way it originally was.  It might be interesting to see if the
compiler could be taught to collapse the function calls, but (a) this
isn't performance critical, and (b) the number of bytes saved is
really tiny.  But at least if the compiler was doing the work, it
would at least deal with it everywhere.

					- Ted

  reply	other threads:[~2016-10-21 15:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  6:33 [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() SF Markus Elfring
2016-10-21  6:33 ` SF Markus Elfring
2016-10-21  7:20 ` Julia Lawall
2016-10-21  7:20   ` Julia Lawall
2016-10-21  9:00   ` SF Markus Elfring
2016-10-21  9:00     ` SF Markus Elfring
2016-10-21 15:46     ` Theodore Ts'o [this message]
2016-10-21 15:46       ` Theodore Ts'o
2016-10-21 17:33       ` SF Markus Elfring
2016-10-21 17:33         ` SF Markus Elfring
2016-10-21 17:53         ` Theodore Ts'o
2016-10-21 17:53           ` Theodore Ts'o
2016-10-21 18:28           ` SF Markus Elfring
2016-10-21 18:28             ` SF Markus Elfring
2016-10-21 18:50           ` SF Markus Elfring
2016-10-21 18:50             ` SF Markus Elfring
2016-10-25 21:37             ` Richard Kuo
2016-10-25 21:37               ` Richard Kuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021154624.maiwbgjmzlzhin2l@thunk.org \
    --to=tytso@mit.edu \
    --cc=elfring@users.sourceforge.net \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkuo@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.