From: Richard Kuo <rkuo@codeaurora.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Julia Lawall <julia.lawall@lip6.fr>,
linux-hexagon@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo()
Date: Tue, 25 Oct 2016 16:37:35 -0500 [thread overview]
Message-ID: <20161025213735.GA27715@codeaurora.org> (raw)
In-Reply-To: <20c77dde-a1a0-8383-f344-a6f788af68d9@users.sourceforge.net>
I wrote it the original way precisely for readability; it's easier, at least
to me, to read and modify the old way.
However, in my development version I happen to be printing a lot more
stuff.
To test, I collapsed 18 of my seq_printf's into one call. That reduced the
function size by a couple hundred bytes. (Didn't do anything for the final
kernel size though.)
If it makes things better, even if only slightly, doesn't introduce bugs,
and doesn't otherwise violate any other rules (correct me if I'm wrong), I
would personally accept the minor readability tradeoff in this case.
Acked-by: Richard Kuo <rkuo@codeaurora.org>
On Fri, Oct 21, 2016 at 08:50:11PM +0200, SF Markus Elfring wrote:
> > When the author of the semantic patch language is telling you to stand down,
>
> The collaboration evolved between Julia and me during the years somehow.
> Different software development opinions occur then as usual.
> Further opinions from contributors like you can eventually show variations
> between disagreement and acceptance.
>
>
> > and you still want to try to argue for blind application of patches,
>
> I guess that we have got different views about "blind" tries.
>
>
> > we have a really big problem.
>
> I hope that potential communication difficulties can still be resolved.
>
>
> > Especially when some of your patches have actually introduced bugs.
>
> I assume that these incidents could be clarified further, couldn't they?
>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Richard Kuo <rkuo@codeaurora.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Theodore Ts'o <tytso@mit.edu>,
Julia Lawall <julia.lawall@lip6.fr>,
linux-hexagon@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo()
Date: Tue, 25 Oct 2016 21:37:35 +0000 [thread overview]
Message-ID: <20161025213735.GA27715@codeaurora.org> (raw)
In-Reply-To: <20c77dde-a1a0-8383-f344-a6f788af68d9@users.sourceforge.net>
I wrote it the original way precisely for readability; it's easier, at least
to me, to read and modify the old way.
However, in my development version I happen to be printing a lot more
stuff.
To test, I collapsed 18 of my seq_printf's into one call. That reduced the
function size by a couple hundred bytes. (Didn't do anything for the final
kernel size though.)
If it makes things better, even if only slightly, doesn't introduce bugs,
and doesn't otherwise violate any other rules (correct me if I'm wrong), I
would personally accept the minor readability tradeoff in this case.
Acked-by: Richard Kuo <rkuo@codeaurora.org>
On Fri, Oct 21, 2016 at 08:50:11PM +0200, SF Markus Elfring wrote:
> > When the author of the semantic patch language is telling you to stand down,
>
> The collaboration evolved between Julia and me during the years somehow.
> Different software development opinions occur then as usual.
> Further opinions from contributors like you can eventually show variations
> between disagreement and acceptance.
>
>
> > and you still want to try to argue for blind application of patches,
>
> I guess that we have got different views about "blind" tries.
>
>
> > we have a really big problem.
>
> I hope that potential communication difficulties can still be resolved.
>
>
> > Especially when some of your patches have actually introduced bugs.
>
> I assume that these incidents could be clarified further, couldn't they?
>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-25 21:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 6:33 [PATCH] Hexagon-setup: Combine four seq_printf() calls into one call in show_cpuinfo() SF Markus Elfring
2016-10-21 6:33 ` SF Markus Elfring
2016-10-21 7:20 ` Julia Lawall
2016-10-21 7:20 ` Julia Lawall
2016-10-21 9:00 ` SF Markus Elfring
2016-10-21 9:00 ` SF Markus Elfring
2016-10-21 15:46 ` Theodore Ts'o
2016-10-21 15:46 ` Theodore Ts'o
2016-10-21 17:33 ` SF Markus Elfring
2016-10-21 17:33 ` SF Markus Elfring
2016-10-21 17:53 ` Theodore Ts'o
2016-10-21 17:53 ` Theodore Ts'o
2016-10-21 18:28 ` SF Markus Elfring
2016-10-21 18:28 ` SF Markus Elfring
2016-10-21 18:50 ` SF Markus Elfring
2016-10-21 18:50 ` SF Markus Elfring
2016-10-25 21:37 ` Richard Kuo [this message]
2016-10-25 21:37 ` Richard Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025213735.GA27715@codeaurora.org \
--to=rkuo@codeaurora.org \
--cc=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.