* [PATCH net-next] net/mlx5e: remove napi_hash_del() calls
@ 2016-11-16 13:55 Eric Dumazet
2016-11-16 14:20 ` Eric Dumazet
2016-11-16 14:21 ` [PATCH v2 " Eric Dumazet
0 siblings, 2 replies; 5+ messages in thread
From: Eric Dumazet @ 2016-11-16 13:55 UTC (permalink / raw)
To: David Miller; +Cc: Saeed Mahameed, netdev
From: Eric Dumazet <edumazet@google.com>
Calling napi_hash_del() after netif_napi_del() is pointless.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ----
1 file changed, 4 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net/mlx5e: remove napi_hash_del() calls
2016-11-16 13:55 [PATCH net-next] net/mlx5e: remove napi_hash_del() calls Eric Dumazet
@ 2016-11-16 14:20 ` Eric Dumazet
2016-11-16 14:21 ` [PATCH v2 " Eric Dumazet
1 sibling, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2016-11-16 14:20 UTC (permalink / raw)
To: David Miller; +Cc: Saeed Mahameed, netdev
On Wed, 2016-11-16 at 05:55 -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Calling napi_hash_del() after netif_napi_del() is pointless.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Saeed Mahameed <saeedm@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ----
> 1 file changed, 4 deletions(-)
Hmmm... missing body. Will send a v2.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 net-next] net/mlx5e: remove napi_hash_del() calls
2016-11-16 13:55 [PATCH net-next] net/mlx5e: remove napi_hash_del() calls Eric Dumazet
2016-11-16 14:20 ` Eric Dumazet
@ 2016-11-16 14:21 ` Eric Dumazet
2016-11-16 14:34 ` Saeed Mahameed
2016-11-17 17:06 ` David Miller
1 sibling, 2 replies; 5+ messages in thread
From: Eric Dumazet @ 2016-11-16 14:21 UTC (permalink / raw)
To: David Miller; +Cc: Saeed Mahameed, netdev
From: Eric Dumazet <edumazet@google.com>
Calling napi_hash_del() after netif_napi_del() is pointless.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 52b4fd53b1a74d17b7b40efc279305fdb9ed7521..00579ce0e96fb8f992d93ddfa0e5fd58df25813a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -1533,7 +1533,6 @@ static int mlx5e_open_channel(struct mlx5e_priv *priv, int ix,
err_napi_del:
netif_napi_del(&c->napi);
- napi_hash_del(&c->napi);
kfree(c);
return err;
@@ -1554,9 +1553,6 @@ static void mlx5e_close_channel(struct mlx5e_channel *c)
mlx5e_close_cq(&c->icosq.cq);
netif_napi_del(&c->napi);
- napi_hash_del(&c->napi);
- synchronize_rcu();
-
kfree(c);
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 net-next] net/mlx5e: remove napi_hash_del() calls
2016-11-16 14:21 ` [PATCH v2 " Eric Dumazet
@ 2016-11-16 14:34 ` Saeed Mahameed
2016-11-17 17:06 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Saeed Mahameed @ 2016-11-16 14:34 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, Saeed Mahameed, netdev
On Wed, Nov 16, 2016 at 4:21 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Calling napi_hash_del() after netif_napi_del() is pointless.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Saeed Mahameed <saeedm@mellanox.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 net-next] net/mlx5e: remove napi_hash_del() calls
2016-11-16 14:21 ` [PATCH v2 " Eric Dumazet
2016-11-16 14:34 ` Saeed Mahameed
@ 2016-11-17 17:06 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2016-11-17 17:06 UTC (permalink / raw)
To: eric.dumazet; +Cc: saeedm, netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 16 Nov 2016 06:21:34 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Calling napi_hash_del() after netif_napi_del() is pointless.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-17 17:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-16 13:55 [PATCH net-next] net/mlx5e: remove napi_hash_del() calls Eric Dumazet
2016-11-16 14:20 ` Eric Dumazet
2016-11-16 14:21 ` [PATCH v2 " Eric Dumazet
2016-11-16 14:34 ` Saeed Mahameed
2016-11-17 17:06 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.