All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Kim Phillips <kim.phillips@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com,
	alex.bennee@linaro.org, christoffer.dall@linaro.org,
	tglx@linutronix.de, peterz@infradead.org,
	alexander.shishkin@linux.intel.com, robh@kernel.org,
	suzuki.poulose@arm.com, pawel.moll@arm.com,
	mathieu.poirier@linaro.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 10/10] dt-bindings: Document devicetree binding for ARM SPE
Date: Tue, 17 Jan 2017 16:50:01 +0000	[thread overview]
Message-ID: <20170117165001.GH11939@leverpostej> (raw)
In-Reply-To: <20170117103100.55e98029aac55ef7770350f3@arm.com>

On Tue, Jan 17, 2017 at 10:31:00AM -0600, Kim Phillips wrote:
> On Mon, 16 Jan 2017 10:59:04 +0000 Will Deacon <will.deacon@arm.com> wrote:
> > On Fri, Jan 13, 2017 at 06:43:52PM +0000, Mark Rutland wrote:
> > > On Fri, Jan 13, 2017 at 04:03:49PM +0000, Will Deacon wrote:
> > > > +- compatible : should be one of:
> > > > +	       "arm,arm-spe-pmu-v1"
> > > 
> > > The second "arm" here doesn't seem to add much. Should that be "armv8.2"
> > > instead?
> > 
> > I don't think armv8.2 is particularly helpful, because that effectively ties
> > together the SPE version and the architecture version, which I don't think
> > is strictly required. The reason I added it was so that you could describe
> > a partner implementation as something like:
> > 
> >   acme,arm-spe-pmu-v1
> > 
> > and know that it was acme's implementation of an ARM architectural feature.
> 
> Wouldn't such an implementation be compatible with an
> "arm,arm-spe-pmu-v1" (or one with less "arm"s)?

We'd expect that, but in the case of significant divergence (e.g.
errata), we may not expect the fallback to the ARM compatible string.

That said, I'm not keen on the duplicate "arm" here, regardless.

> > If I drop the second "arm", I was worried that it might conflict with other
> > namespaces (e.g. acme's signal-processing-element's power-management-unit).
> 
> I'd personally let them worry about that, esp. because this problem
> would come up first and hopefully be fixed in the marketing domain
> before it reaches its device tree specification stage.

FWIW, I think that marketing is completely unrelated.

I can imagine we might have a clash, but I suspect it's unlikely if we
have enough oversight of the bindings (i.e. so long as we keep an eye
out, and the DT maintainers get Cc'd on anything likely to clash).

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 10/10] dt-bindings: Document devicetree binding for ARM SPE
Date: Tue, 17 Jan 2017 16:50:01 +0000	[thread overview]
Message-ID: <20170117165001.GH11939@leverpostej> (raw)
In-Reply-To: <20170117103100.55e98029aac55ef7770350f3@arm.com>

On Tue, Jan 17, 2017 at 10:31:00AM -0600, Kim Phillips wrote:
> On Mon, 16 Jan 2017 10:59:04 +0000 Will Deacon <will.deacon@arm.com> wrote:
> > On Fri, Jan 13, 2017 at 06:43:52PM +0000, Mark Rutland wrote:
> > > On Fri, Jan 13, 2017 at 04:03:49PM +0000, Will Deacon wrote:
> > > > +- compatible : should be one of:
> > > > +	       "arm,arm-spe-pmu-v1"
> > > 
> > > The second "arm" here doesn't seem to add much. Should that be "armv8.2"
> > > instead?
> > 
> > I don't think armv8.2 is particularly helpful, because that effectively ties
> > together the SPE version and the architecture version, which I don't think
> > is strictly required. The reason I added it was so that you could describe
> > a partner implementation as something like:
> > 
> >   acme,arm-spe-pmu-v1
> > 
> > and know that it was acme's implementation of an ARM architectural feature.
> 
> Wouldn't such an implementation be compatible with an
> "arm,arm-spe-pmu-v1" (or one with less "arm"s)?

We'd expect that, but in the case of significant divergence (e.g.
errata), we may not expect the fallback to the ARM compatible string.

That said, I'm not keen on the duplicate "arm" here, regardless.

> > If I drop the second "arm", I was worried that it might conflict with other
> > namespaces (e.g. acme's signal-processing-element's power-management-unit).
> 
> I'd personally let them worry about that, esp. because this problem
> would come up first and hopefully be fixed in the marketing domain
> before it reaches its device tree specification stage.

FWIW, I think that marketing is completely unrelated.

I can imagine we might have a clash, but I suspect it's unlikely if we
have enough oversight of the bindings (i.e. so long as we keep an eye
out, and the DT maintainers get Cc'd on anything likely to clash).

Thanks,
Mark.

  reply	other threads:[~2017-01-17 16:51 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 16:03 [RFC PATCH v2 00/10] Add support for the ARMv8.2 Statistical Profiling Extension Will Deacon
2017-01-13 16:03 ` Will Deacon
2017-01-13 16:03 ` [RFC PATCH v2 01/10] arm64: cpufeature: allow for version discrepancy in PMU implementations Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 16:03 ` [RFC PATCH v2 02/10] arm64: cpufeature: Don't enforce system-wide SPE capability Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 16:03 ` [RFC PATCH v2 03/10] arm64: KVM: Save/restore the host SPE state when entering/leaving a VM Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-16 11:25   ` Marc Zyngier
2017-01-16 11:25     ` Marc Zyngier
2017-01-18 15:24     ` Will Deacon
2017-01-18 15:24       ` Will Deacon
2017-01-13 16:03 ` [RFC PATCH v2 04/10] arm64: head.S: Enable EL1 (host) access to SPE when entered at EL2 Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 19:21   ` Marc Zyngier
2017-01-13 19:21     ` Marc Zyngier
2017-01-13 16:03 ` [RFC PATCH v2 05/10] genirq: export irq_get_percpu_devid_partition to modules Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 19:04   ` Marc Zyngier
2017-01-13 19:04     ` Marc Zyngier
2017-01-16  9:06   ` Thomas Gleixner
2017-01-16  9:06     ` Thomas Gleixner
2017-01-13 16:03 ` [RFC PATCH v2 06/10] perf/core: Export AUX buffer helpers " Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 16:03 ` [RFC PATCH v2 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 16:03 ` [RFC PATCH v2 08/10] perf/core: Add PERF_AUX_FLAG_COLLISION to report colliding samples Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 16:03 ` [RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 16:40   ` Kim Phillips
2017-01-13 16:40     ` Kim Phillips
2017-01-13 17:03     ` Will Deacon
2017-01-13 17:03       ` Will Deacon
2017-01-13 18:17       ` Kim Phillips
2017-01-13 18:17         ` Kim Phillips
2017-01-13 16:03 ` [RFC PATCH v2 10/10] dt-bindings: Document devicetree binding for ARM SPE Will Deacon
2017-01-13 16:03   ` Will Deacon
2017-01-13 18:43   ` Mark Rutland
2017-01-13 18:43     ` Mark Rutland
2017-01-16 10:59     ` Will Deacon
2017-01-16 10:59       ` Will Deacon
2017-01-17 16:31       ` Kim Phillips
2017-01-17 16:31         ` Kim Phillips
2017-01-17 16:50         ` Mark Rutland [this message]
2017-01-17 16:50           ` Mark Rutland
2017-01-17 16:45       ` Mark Rutland
2017-01-17 16:45         ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170117165001.GH11939@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=alex.bennee@linaro.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=christoffer.dall@linaro.org \
    --cc=kim.phillips@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=pawel.moll@arm.com \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.