* [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list
@ 2017-01-24 17:22 Darrick J. Wong
2017-01-24 17:31 ` Christoph Hellwig
2017-01-25 5:01 ` Chandan Rajendra
0 siblings, 2 replies; 4+ messages in thread
From: Darrick J. Wong @ 2017-01-24 17:22 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
Fix a stupid typo in the original commit.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tools/find-api-violations.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/find-api-violations.sh b/tools/find-api-violations.sh
index 7937749..b4b8de5 100755
--- a/tools/find-api-violations.sh
+++ b/tools/find-api-violations.sh
@@ -6,7 +6,7 @@
# NOTE: This script doesn't look for API violations in function parameters.
-tool_dirs="copy db estimate fs fsck fsr growfs io mdrestore mkfs quota repair rtcp"
+tool_dirs="copy db estimate fsr fsck fsr growfs io mdrestore mkfs quota repair rtcp"
# Calls to xfs_* functions in libxfs/*.c without the libxfs_ prefix
find_possible_api_calls() {
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list
2017-01-24 17:22 [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list Darrick J. Wong
@ 2017-01-24 17:31 ` Christoph Hellwig
2017-01-25 5:01 ` Chandan Rajendra
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2017-01-24 17:31 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, linux-xfs
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list
2017-01-24 17:22 [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list Darrick J. Wong
2017-01-24 17:31 ` Christoph Hellwig
@ 2017-01-25 5:01 ` Chandan Rajendra
2017-01-25 5:28 ` Darrick J. Wong
1 sibling, 1 reply; 4+ messages in thread
From: Chandan Rajendra @ 2017-01-25 5:01 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, linux-xfs
On Tuesday, January 24, 2017 09:22:10 AM Darrick J. Wong wrote:
> Fix a stupid typo in the original commit.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tools/find-api-violations.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/find-api-violations.sh b/tools/find-api-violations.sh
> index 7937749..b4b8de5 100755
> --- a/tools/find-api-violations.sh
> +++ b/tools/find-api-violations.sh
> @@ -6,7 +6,7 @@
>
> # NOTE: This script doesn't look for API violations in function parameters.
>
> -tool_dirs="copy db estimate fs fsck fsr growfs io mdrestore mkfs quota repair rtcp"
> +tool_dirs="copy db estimate fsr fsck fsr growfs io mdrestore mkfs quota repair rtcp"
>
fsr is already part of the list. With this patch, we now have a duplicate
entry. Or, Am I missing something very obvious?
--
chandan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list
2017-01-25 5:01 ` Chandan Rajendra
@ 2017-01-25 5:28 ` Darrick J. Wong
0 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2017-01-25 5:28 UTC (permalink / raw)
To: Chandan Rajendra; +Cc: Eric Sandeen, linux-xfs
On Wed, Jan 25, 2017 at 10:31:07AM +0530, Chandan Rajendra wrote:
> On Tuesday, January 24, 2017 09:22:10 AM Darrick J. Wong wrote:
> > Fix a stupid typo in the original commit.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > tools/find-api-violations.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/find-api-violations.sh b/tools/find-api-violations.sh
> > index 7937749..b4b8de5 100755
> > --- a/tools/find-api-violations.sh
> > +++ b/tools/find-api-violations.sh
> > @@ -6,7 +6,7 @@
> >
> > # NOTE: This script doesn't look for API violations in function parameters.
> >
> > -tool_dirs="copy db estimate fs fsck fsr growfs io mdrestore mkfs quota repair rtcp"
> > +tool_dirs="copy db estimate fsr fsck fsr growfs io mdrestore mkfs quota repair rtcp"
> >
>
> fsr is already part of the list. With this patch, we now have a duplicate
> entry. Or, Am I missing something very obvious?
Pah, it's missing logprint too.
Ok, respin....
--D
>
> --
> chandan
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-25 5:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 17:22 [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list Darrick J. Wong
2017-01-24 17:31 ` Christoph Hellwig
2017-01-25 5:01 ` Chandan Rajendra
2017-01-25 5:28 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.