[PATCH] tools/find-api-violations: fix fs -> fsr in the directory list

[PATCH] tools/find-api-violations: fix fs -> fsr in the directory list

[Darrick J. Wong]

Fix a stupid typo in the original commit.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tools/find-api-violations.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/find-api-violations.sh b/tools/find-api-violations.sh
index 7937749..b4b8de5 100755
--- a/tools/find-api-violations.sh
+++ b/tools/find-api-violations.sh
@@ -6,7 +6,7 @@
 
 # NOTE: This script doesn't look for API violations in function parameters.
 
-tool_dirs="copy db estimate fs fsck fsr growfs io mdrestore mkfs quota repair rtcp"
+tool_dirs="copy db estimate fsr fsck fsr growfs io mdrestore mkfs quota repair rtcp"
 
 # Calls to xfs_* functions in libxfs/*.c without the libxfs_ prefix
 find_possible_api_calls() {

Re: [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list

[Christoph Hellwig]

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list

[Chandan Rajendra]

On Tuesday, January 24, 2017 09:22:10 AM Darrick J. Wong wrote:
> Fix a stupid typo in the original commit.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  tools/find-api-violations.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/find-api-violations.sh b/tools/find-api-violations.sh
> index 7937749..b4b8de5 100755
> --- a/tools/find-api-violations.sh
> +++ b/tools/find-api-violations.sh
> @@ -6,7 +6,7 @@
> 
>  # NOTE: This script doesn't look for API violations in function parameters.
> 
> -tool_dirs="copy db estimate fs fsck fsr growfs io mdrestore mkfs quota repair rtcp"
> +tool_dirs="copy db estimate fsr fsck fsr growfs io mdrestore mkfs quota repair rtcp"
>
                               
fsr is already part of the list. With this patch, we now have a duplicate
entry. Or, Am I missing something very obvious?

-- 
chandan

Re: [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list

[Darrick J. Wong]

On Wed, Jan 25, 2017 at 10:31:07AM +0530, Chandan Rajendra wrote:
> On Tuesday, January 24, 2017 09:22:10 AM Darrick J. Wong wrote:
> > Fix a stupid typo in the original commit.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> >  tools/find-api-violations.sh |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/find-api-violations.sh b/tools/find-api-violations.sh
> > index 7937749..b4b8de5 100755
> > --- a/tools/find-api-violations.sh
> > +++ b/tools/find-api-violations.sh
> > @@ -6,7 +6,7 @@
> > 
> >  # NOTE: This script doesn't look for API violations in function parameters.
> > 
> > -tool_dirs="copy db estimate fs fsck fsr growfs io mdrestore mkfs quota repair rtcp"
> > +tool_dirs="copy db estimate fsr fsck fsr growfs io mdrestore mkfs quota repair rtcp"
> >
>                                
> fsr is already part of the list. With this patch, we now have a duplicate
> entry. Or, Am I missing something very obvious?

Pah, it's missing logprint too.

Ok, respin....

--D

> 
> -- 
> chandan
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html