From: Will Deacon <will.deacon@arm.com>
To: Christopher Covington <cov@codeaurora.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Christoffer Dall" <christoffer.dall@linaro.org>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
shankerd@codeaurora.org, timur@codeaurora.org,
"Mark Langsdorf" <mlangsdo@redhat.com>,
"Mark Salter" <msalter@redhat.com>,
"Jon Masters" <jcm@redhat.com>,
"Neil Leeder" <nleeder@codeaurora.org>
Subject: Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code
Date: Fri, 27 Jan 2017 15:03:22 +0000 [thread overview]
Message-ID: <20170127150321.GM21144@arm.com> (raw)
In-Reply-To: <20170125155232.10277-3-cov@codeaurora.org>
On Wed, Jan 25, 2017 at 10:52:31AM -0500, Christopher Covington wrote:
> Refactor the KVM code to use the __tlbi macros, which will allow an errata
> workaround that repeats tlbi dsb sequences to only change one location.
> This is not intended to change the generated assembly and comparing before
> and after vmlinux objdump shows no functional changes.
>
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
> arch/arm64/kvm/hyp/tlb.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
[...]
> @@ -82,7 +83,7 @@ void __hyp_text __kvm_tlb_flush_local_vmid(struct kvm_vcpu *vcpu)
> void __hyp_text __kvm_flush_vm_context(void)
> {
> dsb(ishst);
> - asm volatile("tlbi alle1is \n"
> - "ic ialluis ": : );
> + __tlbi(alle1is);
> + asm volatile("ic ialluis" : : );
> dsb(ish);
Should be a separate patch, but this can now be a __flush_icache_all instead
of the open-coded asm.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Christopher Covington <cov@codeaurora.org>
Cc: Mark Langsdorf <mlangsdo@redhat.com>,
Jon Masters <jcm@redhat.com>,
kvm@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
timur@codeaurora.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Neil Leeder <nleeder@codeaurora.org>,
Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code
Date: Fri, 27 Jan 2017 15:03:22 +0000 [thread overview]
Message-ID: <20170127150321.GM21144@arm.com> (raw)
In-Reply-To: <20170125155232.10277-3-cov@codeaurora.org>
On Wed, Jan 25, 2017 at 10:52:31AM -0500, Christopher Covington wrote:
> Refactor the KVM code to use the __tlbi macros, which will allow an errata
> workaround that repeats tlbi dsb sequences to only change one location.
> This is not intended to change the generated assembly and comparing before
> and after vmlinux objdump shows no functional changes.
>
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
> arch/arm64/kvm/hyp/tlb.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
[...]
> @@ -82,7 +83,7 @@ void __hyp_text __kvm_tlb_flush_local_vmid(struct kvm_vcpu *vcpu)
> void __hyp_text __kvm_flush_vm_context(void)
> {
> dsb(ishst);
> - asm volatile("tlbi alle1is \n"
> - "ic ialluis ": : );
> + __tlbi(alle1is);
> + asm volatile("ic ialluis" : : );
> dsb(ish);
Should be a separate patch, but this can now be a __flush_icache_all instead
of the open-coded asm.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code
Date: Fri, 27 Jan 2017 15:03:22 +0000 [thread overview]
Message-ID: <20170127150321.GM21144@arm.com> (raw)
In-Reply-To: <20170125155232.10277-3-cov@codeaurora.org>
On Wed, Jan 25, 2017 at 10:52:31AM -0500, Christopher Covington wrote:
> Refactor the KVM code to use the __tlbi macros, which will allow an errata
> workaround that repeats tlbi dsb sequences to only change one location.
> This is not intended to change the generated assembly and comparing before
> and after vmlinux objdump shows no functional changes.
>
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
> arch/arm64/kvm/hyp/tlb.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
[...]
> @@ -82,7 +83,7 @@ void __hyp_text __kvm_tlb_flush_local_vmid(struct kvm_vcpu *vcpu)
> void __hyp_text __kvm_flush_vm_context(void)
> {
> dsb(ishst);
> - asm volatile("tlbi alle1is \n"
> - "ic ialluis ": : );
> + __tlbi(alle1is);
> + asm volatile("ic ialluis" : : );
> dsb(ish);
Should be a separate patch, but this can now be a __flush_icache_all instead
of the open-coded asm.
Will
next prev parent reply other threads:[~2017-01-27 15:13 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 15:52 [PATCH v4 1/4] arm64: Define Falkor v1 CPU Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-25 15:52 ` [PATCH v4 2/4] arm64: Work around Falkor erratum 1003 Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-27 14:38 ` Mark Rutland
2017-01-27 14:38 ` Mark Rutland
2017-01-27 14:38 ` Mark Rutland
2017-01-27 14:43 ` Mark Rutland
2017-01-27 14:43 ` Mark Rutland
2017-01-27 14:43 ` Mark Rutland
2017-01-27 21:52 ` Christopher Covington
2017-01-27 21:52 ` Christopher Covington
2017-01-27 21:52 ` Christopher Covington
2017-01-30 10:56 ` Mark Rutland
2017-01-30 10:56 ` Mark Rutland
2017-01-30 10:56 ` Mark Rutland
2017-01-30 22:09 ` Christopher Covington
2017-01-30 22:09 ` Christopher Covington
2017-01-30 22:09 ` Christopher Covington
2017-01-27 19:18 ` Timur Tabi
2017-01-27 19:18 ` Timur Tabi
2017-01-27 19:18 ` Timur Tabi
2017-01-31 12:37 ` Mark Rutland
2017-01-31 12:37 ` Mark Rutland
2017-01-31 12:37 ` Mark Rutland
2017-01-31 17:48 ` Christopher Covington
2017-01-31 17:48 ` Christopher Covington
2017-01-31 17:48 ` Christopher Covington
2017-01-31 17:56 ` Marc Zyngier
2017-01-31 17:56 ` Marc Zyngier
2017-01-31 17:56 ` Marc Zyngier
2017-02-01 16:29 ` Christopher Covington
2017-02-01 16:29 ` Christopher Covington
2017-02-01 16:33 ` Will Deacon
2017-02-01 16:33 ` Will Deacon
2017-02-01 16:33 ` Will Deacon
2017-02-01 17:36 ` Catalin Marinas
2017-02-01 17:36 ` Catalin Marinas
2017-02-01 17:41 ` Will Deacon
2017-02-01 17:41 ` Will Deacon
2017-02-01 17:41 ` Will Deacon
2017-02-01 17:49 ` Catalin Marinas
2017-02-01 17:49 ` Catalin Marinas
2017-02-01 17:49 ` Catalin Marinas
2017-02-01 17:51 ` Catalin Marinas
2017-02-01 17:51 ` Catalin Marinas
2017-02-01 17:59 ` Will Deacon
2017-02-01 17:59 ` Will Deacon
2017-02-01 18:22 ` Catalin Marinas
2017-02-01 18:22 ` Catalin Marinas
2017-02-01 18:34 ` Will Deacon
2017-02-01 18:34 ` Will Deacon
2017-02-01 18:34 ` Will Deacon
2017-02-01 18:38 ` Catalin Marinas
2017-02-01 18:38 ` Catalin Marinas
2017-02-08 0:36 ` Christopher Covington
2017-02-08 0:36 ` Christopher Covington
2017-02-08 0:36 ` Christopher Covington
2017-01-25 15:52 ` [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-25 19:39 ` Christoffer Dall
2017-01-25 19:39 ` Christoffer Dall
2017-01-27 13:53 ` Will Deacon
2017-01-27 13:53 ` Will Deacon
2017-01-27 13:53 ` Will Deacon
2017-02-01 17:02 ` Punit Agrawal
2017-02-01 17:02 ` Punit Agrawal
2017-02-01 17:02 ` Punit Agrawal
2017-02-01 17:08 ` Will Deacon
2017-02-01 17:08 ` Will Deacon
2017-02-01 17:08 ` Will Deacon
2017-02-01 17:14 ` Punit Agrawal
2017-02-01 17:14 ` Punit Agrawal
2017-02-01 17:14 ` Punit Agrawal
2017-01-27 15:03 ` Will Deacon [this message]
2017-01-27 15:03 ` Will Deacon
2017-01-27 15:03 ` Will Deacon
2017-01-25 15:52 ` [PATCH v4 4/4] arm64: Work around Falkor erratum 1009 Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-27 15:07 ` Will Deacon
2017-01-27 15:07 ` Will Deacon
2017-01-27 15:07 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127150321.GM21144@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=cov@codeaurora.org \
--cc=jcm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mlangsdo@redhat.com \
--cc=msalter@redhat.com \
--cc=nleeder@codeaurora.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=shankerd@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.