All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "Christopher Covington" <cov@codeaurora.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Mark Langsdorf" <mlangsdo@redhat.com>,
	kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
	"Marc Zyngier" <marc.zyngier@arm.com>,
	timur@codeaurora.org, "Jonathan Corbet" <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	shankerd@codeaurora.org, linux-arm-kernel@lists.infradead.org,
	"Neil Leeder" <nleeder@codeaurora.org>,
	"Jon Masters" <jcm@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	kvmarm@lists.cs.columbia.edu,
	"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [PATCH v4 2/4] arm64: Work around Falkor erratum 1003
Date: Wed, 1 Feb 2017 17:36:09 +0000	[thread overview]
Message-ID: <20170201173609.GE26507@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170201163358.GG8177@arm.com>

On Wed, Feb 01, 2017 at 04:33:58PM +0000, Will Deacon wrote:
> On Wed, Feb 01, 2017 at 11:29:22AM -0500, Christopher Covington wrote:
> > On 01/31/2017 12:56 PM, Marc Zyngier wrote:
> > > Given that all ARMv8 CPUs can support SW_PAN, it is more likely to be
> > > enabled than the ARMv8.1 PAN. I'd vote for supporting the workaround in
> > > that case too, and hope that people do enable the HW version.
> > 
> > Okay, I'll do my best to add support for the SW PAN case. I rebased and
> > submitted v6 of the E1009 patch [1] so that it no longer depends on this
> > patch landing first, if you all are inclined to pick it up while work on
> > this E1003 patch continues.
> 
> The alternative is not enabling SW_PAN (at runtime) if this errata is
> present, along with a warning stating that hardware-PAN should be
> enabled in kconfig instead. Not sure what distributions will make of that
> though.

The problem with this patch is that when ARM64_SW_TTBR0_PAN is enabled
and in the absence of hardware PAN (or ARM64_PAN disabled),
cpu_do_switch_mm is no longer called for user process switching, so the
workaround is pretty much useless.

I'm ok with adding the Kconfig dependency below to
QCOM_FALKOR_ERRATUM_1003:

	depends on !ARM64_SW_TTBR0_PAN || ARM64_PAN

together with a run-time warning if ARM64_SW_TTBR0_PAN is being used.

I'm not keen on adding the workaround to the uaccess macros. They are
complex enough already and people who do want SW PAN (and single Image)
would end up with 6-8 extra unnecessary nops on each side of a uaccess
(and nops are not entirely free).

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] arm64: Work around Falkor erratum 1003
Date: Wed, 1 Feb 2017 17:36:09 +0000	[thread overview]
Message-ID: <20170201173609.GE26507@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170201163358.GG8177@arm.com>

On Wed, Feb 01, 2017 at 04:33:58PM +0000, Will Deacon wrote:
> On Wed, Feb 01, 2017 at 11:29:22AM -0500, Christopher Covington wrote:
> > On 01/31/2017 12:56 PM, Marc Zyngier wrote:
> > > Given that all ARMv8 CPUs can support SW_PAN, it is more likely to be
> > > enabled than the ARMv8.1 PAN. I'd vote for supporting the workaround in
> > > that case too, and hope that people do enable the HW version.
> > 
> > Okay, I'll do my best to add support for the SW PAN case. I rebased and
> > submitted v6 of the E1009 patch [1] so that it no longer depends on this
> > patch landing first, if you all are inclined to pick it up while work on
> > this E1003 patch continues.
> 
> The alternative is not enabling SW_PAN (at runtime) if this errata is
> present, along with a warning stating that hardware-PAN should be
> enabled in kconfig instead. Not sure what distributions will make of that
> though.

The problem with this patch is that when ARM64_SW_TTBR0_PAN is enabled
and in the absence of hardware PAN (or ARM64_PAN disabled),
cpu_do_switch_mm is no longer called for user process switching, so the
workaround is pretty much useless.

I'm ok with adding the Kconfig dependency below to
QCOM_FALKOR_ERRATUM_1003:

	depends on !ARM64_SW_TTBR0_PAN || ARM64_PAN

together with a run-time warning if ARM64_SW_TTBR0_PAN is being used.

I'm not keen on adding the workaround to the uaccess macros. They are
complex enough already and people who do want SW PAN (and single Image)
would end up with 6-8 extra unnecessary nops on each side of a uaccess
(and nops are not entirely free).

-- 
Catalin

  reply	other threads:[~2017-02-01 17:36 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 15:52 [PATCH v4 1/4] arm64: Define Falkor v1 CPU Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-25 15:52 ` Christopher Covington
2017-01-25 15:52 ` [PATCH v4 2/4] arm64: Work around Falkor erratum 1003 Christopher Covington
2017-01-25 15:52   ` Christopher Covington
2017-01-25 15:52   ` Christopher Covington
2017-01-27 14:38   ` Mark Rutland
2017-01-27 14:38     ` Mark Rutland
2017-01-27 14:38     ` Mark Rutland
2017-01-27 14:43     ` Mark Rutland
2017-01-27 14:43       ` Mark Rutland
2017-01-27 14:43       ` Mark Rutland
2017-01-27 21:52     ` Christopher Covington
2017-01-27 21:52       ` Christopher Covington
2017-01-27 21:52       ` Christopher Covington
2017-01-30 10:56       ` Mark Rutland
2017-01-30 10:56         ` Mark Rutland
2017-01-30 10:56         ` Mark Rutland
2017-01-30 22:09         ` Christopher Covington
2017-01-30 22:09           ` Christopher Covington
2017-01-30 22:09           ` Christopher Covington
2017-01-27 19:18   ` Timur Tabi
2017-01-27 19:18     ` Timur Tabi
2017-01-27 19:18     ` Timur Tabi
2017-01-31 12:37   ` Mark Rutland
2017-01-31 12:37     ` Mark Rutland
2017-01-31 12:37     ` Mark Rutland
2017-01-31 17:48     ` Christopher Covington
2017-01-31 17:48       ` Christopher Covington
2017-01-31 17:48       ` Christopher Covington
2017-01-31 17:56       ` Marc Zyngier
2017-01-31 17:56         ` Marc Zyngier
2017-01-31 17:56         ` Marc Zyngier
2017-02-01 16:29         ` Christopher Covington
2017-02-01 16:29           ` Christopher Covington
2017-02-01 16:33           ` Will Deacon
2017-02-01 16:33             ` Will Deacon
2017-02-01 16:33             ` Will Deacon
2017-02-01 17:36             ` Catalin Marinas [this message]
2017-02-01 17:36               ` Catalin Marinas
2017-02-01 17:41               ` Will Deacon
2017-02-01 17:41                 ` Will Deacon
2017-02-01 17:41                 ` Will Deacon
2017-02-01 17:49                 ` Catalin Marinas
2017-02-01 17:49                   ` Catalin Marinas
2017-02-01 17:49                   ` Catalin Marinas
2017-02-01 17:51                   ` Catalin Marinas
2017-02-01 17:51                     ` Catalin Marinas
2017-02-01 17:59                   ` Will Deacon
2017-02-01 17:59                     ` Will Deacon
2017-02-01 18:22                     ` Catalin Marinas
2017-02-01 18:22                       ` Catalin Marinas
2017-02-01 18:34                       ` Will Deacon
2017-02-01 18:34                         ` Will Deacon
2017-02-01 18:34                         ` Will Deacon
2017-02-01 18:38                         ` Catalin Marinas
2017-02-01 18:38                           ` Catalin Marinas
2017-02-08  0:36                           ` Christopher Covington
2017-02-08  0:36                             ` Christopher Covington
2017-02-08  0:36                             ` Christopher Covington
2017-01-25 15:52 ` [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Christopher Covington
2017-01-25 15:52   ` Christopher Covington
2017-01-25 15:52   ` Christopher Covington
2017-01-25 19:39   ` Christoffer Dall
2017-01-25 19:39     ` Christoffer Dall
2017-01-27 13:53     ` Will Deacon
2017-01-27 13:53       ` Will Deacon
2017-01-27 13:53       ` Will Deacon
2017-02-01 17:02       ` Punit Agrawal
2017-02-01 17:02         ` Punit Agrawal
2017-02-01 17:02         ` Punit Agrawal
2017-02-01 17:08         ` Will Deacon
2017-02-01 17:08           ` Will Deacon
2017-02-01 17:08           ` Will Deacon
2017-02-01 17:14           ` Punit Agrawal
2017-02-01 17:14             ` Punit Agrawal
2017-02-01 17:14             ` Punit Agrawal
2017-01-27 15:03   ` Will Deacon
2017-01-27 15:03     ` Will Deacon
2017-01-27 15:03     ` Will Deacon
2017-01-25 15:52 ` [PATCH v4 4/4] arm64: Work around Falkor erratum 1009 Christopher Covington
2017-01-25 15:52   ` Christopher Covington
2017-01-25 15:52   ` Christopher Covington
2017-01-27 15:07   ` Will Deacon
2017-01-27 15:07     ` Will Deacon
2017-01-27 15:07     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170201173609.GE26507@e104818-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=corbet@lwn.net \
    --cc=cov@codeaurora.org \
    --cc=jcm@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mlangsdo@redhat.com \
    --cc=nleeder@codeaurora.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=shankerd@codeaurora.org \
    --cc=timur@codeaurora.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.