All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: elena.reshetova@intel.com, gregkh@linuxfoundation.org,
	arnd@arndb.de, tglx@linutronix.de, mingo@kernel.org,
	h.peter.anvin@intel.com, will.deacon@arm.com, dwindsor@gmail.com,
	Hans Liljestrand <ishkamiel@gmail.com>,
	dhowells@redhat.com, linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 4/4] refcount: Report failures through CHECK_DATA_CORRUPTION
Date: Sun, 5 Feb 2017 16:40:46 +0100	[thread overview]
Message-ID: <20170205154046.GF6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1486164412-7338-5-git-send-email-keescook@chromium.org>

On Fri, Feb 03, 2017 at 03:26:52PM -0800, Kees Cook wrote:
> This converts from WARN_ON() to CHECK_DATA_CORRUPTION() in the
> CONFIG_DEBUG_REFCOUNT case. Additionally moves refcount_t sanity check
> conditionals into regular function flow. Since CHECK_DATA_CORRUPTION()
> is marked __much_check, we override few cases where the failure has
> already been handled but we want to explicitly report it.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  include/linux/refcount.h | 35 ++++++++++++++++++++++-------------
>  lib/Kconfig.debug        |  2 ++
>  2 files changed, 24 insertions(+), 13 deletions(-)
> 
> diff --git a/include/linux/refcount.h b/include/linux/refcount.h
> index 5b89cad62237..ef32910c7dd8 100644
> --- a/include/linux/refcount.h
> +++ b/include/linux/refcount.h
> @@ -43,10 +43,10 @@
>  #include <linux/spinlock.h>
>  
>  #if CONFIG_DEBUG_REFCOUNT
> -#define REFCOUNT_WARN(cond, str) WARN_ON(cond)
> +#define REFCOUNT_CHECK(cond, str) CHECK_DATA_CORRUPTION(cond, str)

OK, so that goes back to a full WARN() which will make the generated
code gigantic due to the whole printk() trainwreck :/

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: elena.reshetova@intel.com, gregkh@linuxfoundation.org,
	arnd@arndb.de, tglx@linutronix.de, mingo@kernel.org,
	h.peter.anvin@intel.com, will.deacon@arm.com, dwindsor@gmail.com,
	Hans Liljestrand <ishkamiel@gmail.com>,
	dhowells@redhat.com, linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH 4/4] refcount: Report failures through CHECK_DATA_CORRUPTION
Date: Sun, 5 Feb 2017 16:40:46 +0100	[thread overview]
Message-ID: <20170205154046.GF6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1486164412-7338-5-git-send-email-keescook@chromium.org>

On Fri, Feb 03, 2017 at 03:26:52PM -0800, Kees Cook wrote:
> This converts from WARN_ON() to CHECK_DATA_CORRUPTION() in the
> CONFIG_DEBUG_REFCOUNT case. Additionally moves refcount_t sanity check
> conditionals into regular function flow. Since CHECK_DATA_CORRUPTION()
> is marked __much_check, we override few cases where the failure has
> already been handled but we want to explicitly report it.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  include/linux/refcount.h | 35 ++++++++++++++++++++++-------------
>  lib/Kconfig.debug        |  2 ++
>  2 files changed, 24 insertions(+), 13 deletions(-)
> 
> diff --git a/include/linux/refcount.h b/include/linux/refcount.h
> index 5b89cad62237..ef32910c7dd8 100644
> --- a/include/linux/refcount.h
> +++ b/include/linux/refcount.h
> @@ -43,10 +43,10 @@
>  #include <linux/spinlock.h>
>  
>  #if CONFIG_DEBUG_REFCOUNT
> -#define REFCOUNT_WARN(cond, str) WARN_ON(cond)
> +#define REFCOUNT_CHECK(cond, str) CHECK_DATA_CORRUPTION(cond, str)

OK, so that goes back to a full WARN() which will make the generated
code gigantic due to the whole printk() trainwreck :/

  reply	other threads:[~2017-02-05 15:41 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 23:26 [PATCH 0/4] refcount_t followups Kees Cook
2017-02-03 23:26 ` [kernel-hardening] " Kees Cook
2017-02-03 23:26 ` [PATCH 1/4] refcount_t: fix Kconfig help Kees Cook
2017-02-03 23:26   ` [kernel-hardening] " Kees Cook
2017-02-03 23:26 ` [PATCH 2/4] lkdtm: convert to refcount_t testing Kees Cook
2017-02-03 23:26   ` [kernel-hardening] " Kees Cook
2017-02-10  8:32   ` [tip:locking/core] lkdtm: Convert " tip-bot for Kees Cook
2017-02-03 23:26 ` [PATCH 3/4] bug: Switch data corruption check to __must_check Kees Cook
2017-02-03 23:26   ` [kernel-hardening] " Kees Cook
2017-02-03 23:26 ` [PATCH 4/4] refcount: Report failures through CHECK_DATA_CORRUPTION Kees Cook
2017-02-03 23:26   ` [kernel-hardening] " Kees Cook
2017-02-05 15:40   ` Peter Zijlstra [this message]
2017-02-05 15:40     ` [kernel-hardening] " Peter Zijlstra
2017-02-05 23:33     ` Kees Cook
2017-02-05 23:33       ` [kernel-hardening] " Kees Cook
2017-02-06  8:57       ` Peter Zijlstra
2017-02-06  8:57         ` [kernel-hardening] " Peter Zijlstra
2017-02-06 16:54         ` Kees Cook
2017-02-06 16:54           ` [kernel-hardening] " Kees Cook
2017-02-07  8:34           ` Peter Zijlstra
2017-02-07  8:34             ` [kernel-hardening] " Peter Zijlstra
2017-02-07 11:10             ` Mark Rutland
2017-02-07 11:10               ` Mark Rutland
2017-02-07 12:36               ` Peter Zijlstra
2017-02-07 12:36                 ` Peter Zijlstra
2017-02-07 13:50                 ` Mark Rutland
2017-02-07 13:50                   ` Mark Rutland
2017-02-07 15:07                   ` Peter Zijlstra
2017-02-07 15:07                     ` Peter Zijlstra
2017-02-07 16:03                     ` Mark Rutland
2017-02-07 16:03                       ` Mark Rutland
2017-02-07 17:30                       ` Peter Zijlstra
2017-02-07 17:30                         ` Peter Zijlstra
2017-02-07 17:55                         ` Mark Rutland
2017-02-07 17:55                           ` Mark Rutland
2017-02-08  9:12                           ` Peter Zijlstra
2017-02-08  9:12                             ` Peter Zijlstra
2017-02-08  9:43                             ` Peter Zijlstra
2017-02-08  9:43                               ` Peter Zijlstra
2017-02-08 14:10                             ` Mark Rutland
2017-02-08 14:10                               ` Mark Rutland
2017-02-08 21:20                             ` Kees Cook
2017-02-08 21:20                               ` Kees Cook
2017-02-09 10:27                               ` Peter Zijlstra
2017-02-09 10:27                                 ` Peter Zijlstra
2017-02-10 23:39                                 ` Kees Cook
2017-02-10 23:39                                   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170205154046.GF6515@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=arnd@arndb.de \
    --cc=dhowells@redhat.com \
    --cc=dwindsor@gmail.com \
    --cc=elena.reshetova@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=h.peter.anvin@intel.com \
    --cc=ishkamiel@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.