From: Kees Cook <keescook@chromium.org> To: Peter Zijlstra <peterz@infradead.org> Cc: "Reshetova, Elena" <elena.reshetova@intel.com>, Greg KH <gregkh@linuxfoundation.org>, Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <h.peter.anvin@intel.com>, Will Deacon <will.deacon@arm.com>, David Windsor <dwindsor@gmail.com>, Hans Liljestrand <ishkamiel@gmail.com>, David Howells <dhowells@redhat.com>, LKML <linux-kernel@vger.kernel.org>, "kernel-hardening@lists.openwall.com" <kernel-hardening@lists.openwall.com> Subject: Re: [PATCH 4/4] refcount: Report failures through CHECK_DATA_CORRUPTION Date: Mon, 6 Feb 2017 08:54:38 -0800 [thread overview] Message-ID: <CAGXu5j+VrKBrU7op8wD1Ry4nzR0cN7Vvke8W6_KOzp3wsoEF1g@mail.gmail.com> (raw) In-Reply-To: <20170206085739.GH6515@twins.programming.kicks-ass.net> On Mon, Feb 6, 2017 at 12:57 AM, Peter Zijlstra <peterz@infradead.org> wrote: > On Sun, Feb 05, 2017 at 03:33:36PM -0800, Kees Cook wrote: >> On Sun, Feb 5, 2017 at 7:40 AM, Peter Zijlstra <peterz@infradead.org> wrote: >> > On Fri, Feb 03, 2017 at 03:26:52PM -0800, Kees Cook wrote: >> >> This converts from WARN_ON() to CHECK_DATA_CORRUPTION() in the >> >> CONFIG_DEBUG_REFCOUNT case. Additionally moves refcount_t sanity check >> >> conditionals into regular function flow. Since CHECK_DATA_CORRUPTION() >> >> is marked __much_check, we override few cases where the failure has >> >> already been handled but we want to explicitly report it. >> >> >> >> Signed-off-by: Kees Cook <keescook@chromium.org> >> >> --- >> >> include/linux/refcount.h | 35 ++++++++++++++++++++++------------- >> >> lib/Kconfig.debug | 2 ++ >> >> 2 files changed, 24 insertions(+), 13 deletions(-) >> >> >> >> diff --git a/include/linux/refcount.h b/include/linux/refcount.h >> >> index 5b89cad62237..ef32910c7dd8 100644 >> >> --- a/include/linux/refcount.h >> >> +++ b/include/linux/refcount.h >> >> @@ -43,10 +43,10 @@ >> >> #include <linux/spinlock.h> >> >> >> >> #if CONFIG_DEBUG_REFCOUNT >> >> -#define REFCOUNT_WARN(cond, str) WARN_ON(cond) >> >> +#define REFCOUNT_CHECK(cond, str) CHECK_DATA_CORRUPTION(cond, str) >> > >> > OK, so that goes back to a full WARN() which will make the generated >> > code gigantic due to the whole printk() trainwreck :/ >> >> Hrm, perhaps we need three levels? WARN_ON, WARN, and BUG? > > Did consider that, didn't really know if that made sense. > > Like I wrote, ideally we'd end up using something like the x86 exception > table with a custom handler. Just no idea how to pull that off without > doing a full blown arch specific implementation, so I didn't go there > quite yet. I haven't spent much time looking at the extable stuff. (Though coincidentally, I was poking at it for x86's test_nx stuff...) I thought there was a way to build arch-agnostic extables already? kernel/extable.c is unconditionally built-in, for example. > That way refcount_inc() would end up being inlined to something like: > > mov 0x148(%rdi),%eax > jmp 2f > 1: lock cmpxchg %edx,0x148(%rdi) > je 4f > 2: lea -0x1(%rax),%ecx > lea 0x1(%rax),%edx > cmp $0xfffffffd,%ecx > jbe 1b > 3: ud2 > 4: > > _ASM_EXTABLE_HANDLE(3b, 4b, ex_handler_refcount_inc) > > > where: > > bool ex_handler_refcount_inc(const struct exception_table_entry *fixup, > struct pt_regs *regs, int trapnr) > { > regs->ip = ex_fixup_addr(fixup); > > if (!regs->ax) > WARN(1, "refcount_t: increment on 0; use-after-free.\n"); > else > WARN(1, "refcount_t: saturated; leaking memory.\n"); > > return true; > } > > and the handler is shared between all instances and can be as big and > fancy as we'd like. I'll dig a bit to see what I can build. Can you add the lkdtm tests to the series, though? That should be fine as-is. Thanks! -Kees -- Kees Cook Pixel Security
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org> To: Peter Zijlstra <peterz@infradead.org> Cc: "Reshetova, Elena" <elena.reshetova@intel.com>, Greg KH <gregkh@linuxfoundation.org>, Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <h.peter.anvin@intel.com>, Will Deacon <will.deacon@arm.com>, David Windsor <dwindsor@gmail.com>, Hans Liljestrand <ishkamiel@gmail.com>, David Howells <dhowells@redhat.com>, LKML <linux-kernel@vger.kernel.org>, "kernel-hardening@lists.openwall.com" <kernel-hardening@lists.openwall.com> Subject: [kernel-hardening] Re: [PATCH 4/4] refcount: Report failures through CHECK_DATA_CORRUPTION Date: Mon, 6 Feb 2017 08:54:38 -0800 [thread overview] Message-ID: <CAGXu5j+VrKBrU7op8wD1Ry4nzR0cN7Vvke8W6_KOzp3wsoEF1g@mail.gmail.com> (raw) In-Reply-To: <20170206085739.GH6515@twins.programming.kicks-ass.net> On Mon, Feb 6, 2017 at 12:57 AM, Peter Zijlstra <peterz@infradead.org> wrote: > On Sun, Feb 05, 2017 at 03:33:36PM -0800, Kees Cook wrote: >> On Sun, Feb 5, 2017 at 7:40 AM, Peter Zijlstra <peterz@infradead.org> wrote: >> > On Fri, Feb 03, 2017 at 03:26:52PM -0800, Kees Cook wrote: >> >> This converts from WARN_ON() to CHECK_DATA_CORRUPTION() in the >> >> CONFIG_DEBUG_REFCOUNT case. Additionally moves refcount_t sanity check >> >> conditionals into regular function flow. Since CHECK_DATA_CORRUPTION() >> >> is marked __much_check, we override few cases where the failure has >> >> already been handled but we want to explicitly report it. >> >> >> >> Signed-off-by: Kees Cook <keescook@chromium.org> >> >> --- >> >> include/linux/refcount.h | 35 ++++++++++++++++++++++------------- >> >> lib/Kconfig.debug | 2 ++ >> >> 2 files changed, 24 insertions(+), 13 deletions(-) >> >> >> >> diff --git a/include/linux/refcount.h b/include/linux/refcount.h >> >> index 5b89cad62237..ef32910c7dd8 100644 >> >> --- a/include/linux/refcount.h >> >> +++ b/include/linux/refcount.h >> >> @@ -43,10 +43,10 @@ >> >> #include <linux/spinlock.h> >> >> >> >> #if CONFIG_DEBUG_REFCOUNT >> >> -#define REFCOUNT_WARN(cond, str) WARN_ON(cond) >> >> +#define REFCOUNT_CHECK(cond, str) CHECK_DATA_CORRUPTION(cond, str) >> > >> > OK, so that goes back to a full WARN() which will make the generated >> > code gigantic due to the whole printk() trainwreck :/ >> >> Hrm, perhaps we need three levels? WARN_ON, WARN, and BUG? > > Did consider that, didn't really know if that made sense. > > Like I wrote, ideally we'd end up using something like the x86 exception > table with a custom handler. Just no idea how to pull that off without > doing a full blown arch specific implementation, so I didn't go there > quite yet. I haven't spent much time looking at the extable stuff. (Though coincidentally, I was poking at it for x86's test_nx stuff...) I thought there was a way to build arch-agnostic extables already? kernel/extable.c is unconditionally built-in, for example. > That way refcount_inc() would end up being inlined to something like: > > mov 0x148(%rdi),%eax > jmp 2f > 1: lock cmpxchg %edx,0x148(%rdi) > je 4f > 2: lea -0x1(%rax),%ecx > lea 0x1(%rax),%edx > cmp $0xfffffffd,%ecx > jbe 1b > 3: ud2 > 4: > > _ASM_EXTABLE_HANDLE(3b, 4b, ex_handler_refcount_inc) > > > where: > > bool ex_handler_refcount_inc(const struct exception_table_entry *fixup, > struct pt_regs *regs, int trapnr) > { > regs->ip = ex_fixup_addr(fixup); > > if (!regs->ax) > WARN(1, "refcount_t: increment on 0; use-after-free.\n"); > else > WARN(1, "refcount_t: saturated; leaking memory.\n"); > > return true; > } > > and the handler is shared between all instances and can be as big and > fancy as we'd like. I'll dig a bit to see what I can build. Can you add the lkdtm tests to the series, though? That should be fine as-is. Thanks! -Kees -- Kees Cook Pixel Security
next prev parent reply other threads:[~2017-02-06 16:54 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-03 23:26 [PATCH 0/4] refcount_t followups Kees Cook 2017-02-03 23:26 ` [kernel-hardening] " Kees Cook 2017-02-03 23:26 ` [PATCH 1/4] refcount_t: fix Kconfig help Kees Cook 2017-02-03 23:26 ` [kernel-hardening] " Kees Cook 2017-02-03 23:26 ` [PATCH 2/4] lkdtm: convert to refcount_t testing Kees Cook 2017-02-03 23:26 ` [kernel-hardening] " Kees Cook 2017-02-10 8:32 ` [tip:locking/core] lkdtm: Convert " tip-bot for Kees Cook 2017-02-03 23:26 ` [PATCH 3/4] bug: Switch data corruption check to __must_check Kees Cook 2017-02-03 23:26 ` [kernel-hardening] " Kees Cook 2017-02-03 23:26 ` [PATCH 4/4] refcount: Report failures through CHECK_DATA_CORRUPTION Kees Cook 2017-02-03 23:26 ` [kernel-hardening] " Kees Cook 2017-02-05 15:40 ` Peter Zijlstra 2017-02-05 15:40 ` [kernel-hardening] " Peter Zijlstra 2017-02-05 23:33 ` Kees Cook 2017-02-05 23:33 ` [kernel-hardening] " Kees Cook 2017-02-06 8:57 ` Peter Zijlstra 2017-02-06 8:57 ` [kernel-hardening] " Peter Zijlstra 2017-02-06 16:54 ` Kees Cook [this message] 2017-02-06 16:54 ` Kees Cook 2017-02-07 8:34 ` Peter Zijlstra 2017-02-07 8:34 ` [kernel-hardening] " Peter Zijlstra 2017-02-07 11:10 ` Mark Rutland 2017-02-07 11:10 ` Mark Rutland 2017-02-07 12:36 ` Peter Zijlstra 2017-02-07 12:36 ` Peter Zijlstra 2017-02-07 13:50 ` Mark Rutland 2017-02-07 13:50 ` Mark Rutland 2017-02-07 15:07 ` Peter Zijlstra 2017-02-07 15:07 ` Peter Zijlstra 2017-02-07 16:03 ` Mark Rutland 2017-02-07 16:03 ` Mark Rutland 2017-02-07 17:30 ` Peter Zijlstra 2017-02-07 17:30 ` Peter Zijlstra 2017-02-07 17:55 ` Mark Rutland 2017-02-07 17:55 ` Mark Rutland 2017-02-08 9:12 ` Peter Zijlstra 2017-02-08 9:12 ` Peter Zijlstra 2017-02-08 9:43 ` Peter Zijlstra 2017-02-08 9:43 ` Peter Zijlstra 2017-02-08 14:10 ` Mark Rutland 2017-02-08 14:10 ` Mark Rutland 2017-02-08 21:20 ` Kees Cook 2017-02-08 21:20 ` Kees Cook 2017-02-09 10:27 ` Peter Zijlstra 2017-02-09 10:27 ` Peter Zijlstra 2017-02-10 23:39 ` Kees Cook 2017-02-10 23:39 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGXu5j+VrKBrU7op8wD1Ry4nzR0cN7Vvke8W6_KOzp3wsoEF1g@mail.gmail.com \ --to=keescook@chromium.org \ --cc=arnd@arndb.de \ --cc=dhowells@redhat.com \ --cc=dwindsor@gmail.com \ --cc=elena.reshetova@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=h.peter.anvin@intel.com \ --cc=ishkamiel@gmail.com \ --cc=kernel-hardening@lists.openwall.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.