From: Juri Lelli <juri.lelli@arm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux@arm.linux.org.uk,
sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com,
morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
juri.lelli@arm.com, broonie@kernel.org,
gregkh@linuxfoundation.org
Subject: [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c
Date: Mon, 27 Mar 2017 14:18:22 +0100 [thread overview]
Message-ID: <20170327131825.32134-7-juri.lelli@arm.com> (raw)
In-Reply-To: <20170327131825.32134-1-juri.lelli@arm.com>
Printing out an error message when we failed to get the cpu device is
not helping anyone. Remove it.
Signed-off-by: Juri Lelli <juri.lelli@arm.com>
---
drivers/base/arch_topology.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index c33482121b7d..b24d9a2af2c5 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -81,11 +81,9 @@ static int register_cpu_capacity_sysctl(void)
for_each_possible_cpu(i) {
cpu = get_cpu_device(i);
- if (!cpu) {
- pr_err("%s: too early to get CPU%d device!\n",
- __func__, i);
+ if (!cpu)
continue;
- }
+
device_create_file(cpu, &dev_attr_cpu_capacity);
}
--
2.10.0
WARNING: multiple messages have this Message-ID (diff)
From: Juri Lelli <juri.lelli-5wv7dgnIgG8@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
sudeep.holla-5wv7dgnIgG8@public.gmane.org,
lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
morten.rasmussen-5wv7dgnIgG8@public.gmane.org,
dietmar.eggemann-5wv7dgnIgG8@public.gmane.org,
juri.lelli-5wv7dgnIgG8@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org
Subject: [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c
Date: Mon, 27 Mar 2017 14:18:22 +0100 [thread overview]
Message-ID: <20170327131825.32134-7-juri.lelli@arm.com> (raw)
In-Reply-To: <20170327131825.32134-1-juri.lelli-5wv7dgnIgG8@public.gmane.org>
Printing out an error message when we failed to get the cpu device is
not helping anyone. Remove it.
Signed-off-by: Juri Lelli <juri.lelli-5wv7dgnIgG8@public.gmane.org>
---
drivers/base/arch_topology.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index c33482121b7d..b24d9a2af2c5 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -81,11 +81,9 @@ static int register_cpu_capacity_sysctl(void)
for_each_possible_cpu(i) {
cpu = get_cpu_device(i);
- if (!cpu) {
- pr_err("%s: too early to get CPU%d device!\n",
- __func__, i);
+ if (!cpu)
continue;
- }
+
device_create_file(cpu, &dev_attr_cpu_capacity);
}
--
2.10.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: juri.lelli@arm.com (Juri Lelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c
Date: Mon, 27 Mar 2017 14:18:22 +0100 [thread overview]
Message-ID: <20170327131825.32134-7-juri.lelli@arm.com> (raw)
In-Reply-To: <20170327131825.32134-1-juri.lelli@arm.com>
Printing out an error message when we failed to get the cpu device is
not helping anyone. Remove it.
Signed-off-by: Juri Lelli <juri.lelli@arm.com>
---
drivers/base/arch_topology.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index c33482121b7d..b24d9a2af2c5 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -81,11 +81,9 @@ static int register_cpu_capacity_sysctl(void)
for_each_possible_cpu(i) {
cpu = get_cpu_device(i);
- if (!cpu) {
- pr_err("%s: too early to get CPU%d device!\n",
- __func__, i);
+ if (!cpu)
continue;
- }
+
device_create_file(cpu, &dev_attr_cpu_capacity);
}
--
2.10.0
next prev parent reply other threads:[~2017-03-27 13:20 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 13:18 [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 1/9] Documentation: arm: fix wrong reference number in DT definition Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 2/9] Documentation/ABI: add information about cpu_capacity Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-29 7:37 ` Vincent Guittot
2017-03-29 7:37 ` Vincent Guittot
2017-03-29 8:06 ` Juri Lelli
2017-03-29 8:06 ` Juri Lelli
2017-03-29 8:06 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 4/9] arm: remove wrong CONFIG_PROC_SYSCTL ifdef Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-29 7:39 ` Vincent Guittot
2017-03-29 7:39 ` Vincent Guittot
2017-03-29 7:39 ` Vincent Guittot
2017-03-27 13:18 ` [PATCH v3 5/9] arm, arm64: factorize common cpu capacity default code Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-04-08 16:25 ` Greg KH
2017-04-08 16:25 ` Greg KH
2017-04-08 16:25 ` Greg KH
2017-04-10 8:18 ` Catalin Marinas
2017-04-10 8:18 ` Catalin Marinas
2017-04-10 16:23 ` Juri Lelli
2017-04-10 16:23 ` Juri Lelli
2017-04-10 16:23 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli [this message]
2017-03-27 13:18 ` [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-04-10 13:51 ` Russell King - ARM Linux
2017-04-10 13:51 ` Russell King - ARM Linux
2017-04-10 14:02 ` Juri Lelli
2017-04-10 14:02 ` Juri Lelli
2017-04-10 16:33 ` Russell King - ARM Linux
2017-04-10 16:33 ` Russell King - ARM Linux
2017-04-11 10:43 ` Juri Lelli
2017-04-11 10:43 ` Juri Lelli
2017-04-11 10:43 ` Juri Lelli
2017-03-27 13:18 ` [PATCH v3 7/9] arm,arm64,drivers: reduce scope of cap_parsing_failed Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-04-10 8:31 ` Catalin Marinas
2017-04-10 8:31 ` Catalin Marinas
2017-03-27 13:18 ` [PATCH v3 8/9] arm,arm64,drivers: move externs in a new header file Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-03-27 13:18 ` Juri Lelli
2017-04-10 8:31 ` Catalin Marinas
2017-04-10 8:31 ` Catalin Marinas
2017-04-10 8:31 ` Catalin Marinas
2017-03-27 13:18 ` [PATCH v3 9/9] arm,arm64,drivers: add a prefix to drivers arch_topology interfaces Juri Lelli
2017-03-27 13:18 ` [PATCH v3 9/9] arm, arm64, drivers: " Juri Lelli
2017-04-10 8:32 ` Catalin Marinas
2017-04-10 8:32 ` Catalin Marinas
2017-04-10 8:32 ` Catalin Marinas
2017-04-06 14:14 ` [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-04-06 14:14 ` Juri Lelli
2017-04-06 14:14 ` Juri Lelli
2017-04-10 15:05 ` Russell King - ARM Linux
2017-04-10 15:05 ` Russell King - ARM Linux
2017-04-10 15:05 ` Russell King - ARM Linux
2017-04-10 16:21 ` Juri Lelli
2017-04-10 16:21 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327131825.32134-7-juri.lelli@arm.com \
--to=juri.lelli@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.