* Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
[not found] <20170411071911.1A8EF203634@relay.mailchannels.net>
@ 2017-04-11 7:58 ` Viresh Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2017-04-11 7:58 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Linux PM list, linux-clk, linux-kernel, Quentin Schulz,
Maxime Ripard, linux-arm-kernel, Chen-Yu Tsai, linux-sunxi
On 11-04-17, 15:18, Icenowy Zheng wrote:
>
> 2017年4月11日 15:03于 Viresh Kumar <viresh.kumar@linaro.org>写道：
> >
> > On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> > > Some new Allwinner SoCs get supported in the kernel after the
> > > compatibles are added to cpufreq-dt-platdev driver.
> > >
> > > Add their compatible strings in the cpufreq-dt-platdev driver.
> > >
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > ---
> > > drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > index 921b4a6c3d16..2180e509e383 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
> > > { .compatible = "allwinner,sun8i-a23", },
> > > { .compatible = "allwinner,sun8i-a33", },
> > > { .compatible = "allwinner,sun8i-a83t", },
> > > + { .compatible = "allwinner,sun8i-h2-plus", },
> > > { .compatible = "allwinner,sun8i-h3", },
> > > + { .compatible = "allwinner,sun8i-v3s", },
> > > + { .compatible = "allwinner,sun50i-a64", },
> > > + { .compatible = "allwinner,sun50i-h5", },
> > > + { .compatible = "nextthing,gr8", },
> >
> >
> > This needs to be in alphabetical order and please cc cpufreq
>
> However I prefer these sequence -- sun50i is later than sun8i.
>
> Place sun50i between sun4i and sun5i is meaningless, as sun50i in fact have a deep relationship with sun8i, but not sun4/5i.
We aren't really worried about relationship here. The order is important to find
missing entries as soon as possible and that's why I have been forcing people to
add entries in alphabetical order.
--
viresh
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
@ 2017-04-11 7:58 ` Viresh Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2017-04-11 7:58 UTC (permalink / raw)
To: linux-arm-kernel
On 11-04-17, 15:18, Icenowy Zheng wrote:
>
> 2017?4?11? 15:03? Viresh Kumar <viresh.kumar@linaro.org>???
> >
> > On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> > > Some new Allwinner SoCs get supported in the kernel after the
> > > compatibles are added to cpufreq-dt-platdev driver.
> > >
> > > Add their compatible strings in the cpufreq-dt-platdev driver.
> > >
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > ---
> > >? drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> > >? 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > index 921b4a6c3d16..2180e509e383 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
> > >???????? { .compatible = "allwinner,sun8i-a23", },
> > >???????? { .compatible = "allwinner,sun8i-a33", },
> > >???????? { .compatible = "allwinner,sun8i-a83t", },
> > > +?????? { .compatible = "allwinner,sun8i-h2-plus", },
> > >???????? { .compatible = "allwinner,sun8i-h3", },
> > > +?????? { .compatible = "allwinner,sun8i-v3s", },
> > > +?????? { .compatible = "allwinner,sun50i-a64", },
> > > +?????? { .compatible = "allwinner,sun50i-h5", },
> > > +?????? { .compatible = "nextthing,gr8", },
> >
> >
> > This needs to be in alphabetical order and please cc cpufreq
>
> However I prefer these sequence -- sun50i is later than sun8i.
>
> Place sun50i between sun4i and sun5i is meaningless, as sun50i in fact have a deep relationship with sun8i, but not sun4/5i.
We aren't really worried about relationship here. The order is important to find
missing entries as soon as possible and that's why I have been forcing people to
add entries in alphabetical order.
--
viresh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
@ 2017-04-11 7:18 Icenowy Zheng
0 siblings, 0 replies; 8+ messages in thread
From: Icenowy Zheng @ 2017-04-11 7:18 UTC (permalink / raw)
To: Viresh Kumar
Cc: Linux PM list, linux-clk-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Quentin Schulz,
Maxime Ripard, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Chen-Yu Tsai, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
2017年4月11日 15:03于 Viresh Kumar <viresh.kumar@linaro.org>写道：
>
> On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote:
> > Some new Allwinner SoCs get supported in the kernel after the
> > compatibles are added to cpufreq-dt-platdev driver.
> >
> > Add their compatible strings in the cpufreq-dt-platdev driver.
> >
> > Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
> > ---
> > drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> > index 921b4a6c3d16..2180e509e383 100644
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
> > { .compatible = "allwinner,sun8i-a23", },
> > { .compatible = "allwinner,sun8i-a33", },
> > { .compatible = "allwinner,sun8i-a83t", },
> > + { .compatible = "allwinner,sun8i-h2-plus", },
> > { .compatible = "allwinner,sun8i-h3", },
> > + { .compatible = "allwinner,sun8i-v3s", },
> > + { .compatible = "allwinner,sun50i-a64", },
> > + { .compatible = "allwinner,sun50i-h5", },
> > + { .compatible = "nextthing,gr8", },
>
>
> This needs to be in alphabetical order and please cc cpufreq
However I prefer these sequence -- sun50i is later than sun8i.
Place sun50i between sun4i and sun5i is meaningless, as sun50i in fact have a deep relationship with sun8i, but not sun4/5i.
> maintainers next time.
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
2017-04-08 18:50 ` Icenowy Zheng
(?)
@ 2017-04-11 7:03 ` Viresh Kumar
-1 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2017-04-11 7:03 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Maxime Ripard, Chen-Yu Tsai, Quentin Schulz, linux-arm-kernel,
linux-kernel, linux-clk, Linux PM list, linux-sunxi
On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Some new Allwinner SoCs get supported in the kernel after the
> compatibles are added to cpufreq-dt-platdev driver.
>
> Add their compatible strings in the cpufreq-dt-platdev driver.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 921b4a6c3d16..2180e509e383 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
> { .compatible = "allwinner,sun8i-a23", },
> { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> + { .compatible = "allwinner,sun8i-h2-plus", },
> { .compatible = "allwinner,sun8i-h3", },
> + { .compatible = "allwinner,sun8i-v3s", },
> + { .compatible = "allwinner,sun50i-a64", },
> + { .compatible = "allwinner,sun50i-h5", },
> + { .compatible = "nextthing,gr8", },
This needs to be in alphabetical order and please cc cpufreq
maintainers next time.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
@ 2017-04-11 7:03 ` Viresh Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2017-04-11 7:03 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Maxime Ripard, Chen-Yu Tsai, Quentin Schulz, linux-arm-kernel,
linux-kernel, linux-clk, Linux PM list, linux-sunxi
On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Some new Allwinner SoCs get supported in the kernel after the
> compatibles are added to cpufreq-dt-platdev driver.
>
> Add their compatible strings in the cpufreq-dt-platdev driver.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 921b4a6c3d16..2180e509e383 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
> { .compatible = "allwinner,sun8i-a23", },
> { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> + { .compatible = "allwinner,sun8i-h2-plus", },
> { .compatible = "allwinner,sun8i-h3", },
> + { .compatible = "allwinner,sun8i-v3s", },
> + { .compatible = "allwinner,sun50i-a64", },
> + { .compatible = "allwinner,sun50i-h5", },
> + { .compatible = "nextthing,gr8", },
This needs to be in alphabetical order and please cc cpufreq
maintainers next time.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
@ 2017-04-11 7:03 ` Viresh Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2017-04-11 7:03 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Some new Allwinner SoCs get supported in the kernel after the
> compatibles are added to cpufreq-dt-platdev driver.
>
> Add their compatible strings in the cpufreq-dt-platdev driver.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 921b4a6c3d16..2180e509e383 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
> { .compatible = "allwinner,sun8i-a23", },
> { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> + { .compatible = "allwinner,sun8i-h2-plus", },
> { .compatible = "allwinner,sun8i-h3", },
> + { .compatible = "allwinner,sun8i-v3s", },
> + { .compatible = "allwinner,sun50i-a64", },
> + { .compatible = "allwinner,sun50i-h5", },
> + { .compatible = "nextthing,gr8", },
This needs to be in alphabetical order and please cc cpufreq
maintainers next time.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
2017-04-08 18:50 [PATCH 0/5] Some Allwinner CCU tweaks and basical DVFS support for H3/H2+ Icenowy Zheng
@ 2017-04-08 18:50 ` Icenowy Zheng
0 siblings, 0 replies; 8+ messages in thread
From: Icenowy Zheng @ 2017-04-08 18:50 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Quentin Schulz
Cc: linux-arm-kernel, linux-kernel, linux-clk, linux-pm, linux-sunxi,
Icenowy Zheng
Some new Allwinner SoCs get supported in the kernel after the
compatibles are added to cpufreq-dt-platdev driver.
Add their compatible strings in the cpufreq-dt-platdev driver.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 921b4a6c3d16..2180e509e383 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
{ .compatible = "allwinner,sun8i-a23", },
{ .compatible = "allwinner,sun8i-a33", },
{ .compatible = "allwinner,sun8i-a83t", },
+ { .compatible = "allwinner,sun8i-h2-plus", },
{ .compatible = "allwinner,sun8i-h3", },
+ { .compatible = "allwinner,sun8i-v3s", },
+ { .compatible = "allwinner,sun50i-a64", },
+ { .compatible = "allwinner,sun50i-h5", },
+ { .compatible = "nextthing,gr8", },
{ .compatible = "apm,xgene-shadowcat", },
--
2.12.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
@ 2017-04-08 18:50 ` Icenowy Zheng
0 siblings, 0 replies; 8+ messages in thread
From: Icenowy Zheng @ 2017-04-08 18:50 UTC (permalink / raw)
To: linux-arm-kernel
Some new Allwinner SoCs get supported in the kernel after the
compatibles are added to cpufreq-dt-platdev driver.
Add their compatible strings in the cpufreq-dt-platdev driver.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 921b4a6c3d16..2180e509e383 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
{ .compatible = "allwinner,sun8i-a23", },
{ .compatible = "allwinner,sun8i-a33", },
{ .compatible = "allwinner,sun8i-a83t", },
+ { .compatible = "allwinner,sun8i-h2-plus", },
{ .compatible = "allwinner,sun8i-h3", },
+ { .compatible = "allwinner,sun8i-v3s", },
+ { .compatible = "allwinner,sun50i-a64", },
+ { .compatible = "allwinner,sun50i-h5", },
+ { .compatible = "nextthing,gr8", },
{ .compatible = "apm,xgene-shadowcat", },
--
2.12.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-04-11 7:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170411071911.1A8EF203634@relay.mailchannels.net>
2017-04-11 7:58 ` [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs Viresh Kumar
2017-04-11 7:58 ` Viresh Kumar
2017-04-11 7:18 Icenowy Zheng
-- strict thread matches above, loose matches on Subject: below --
2017-04-08 18:50 [PATCH 0/5] Some Allwinner CCU tweaks and basical DVFS support for H3/H2+ Icenowy Zheng
2017-04-08 18:50 ` [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs Icenowy Zheng
2017-04-08 18:50 ` Icenowy Zheng
2017-04-11 7:03 ` Viresh Kumar
2017-04-11 7:03 ` Viresh Kumar
2017-04-11 7:03 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.