Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Viresh Kumar]

On 11-04-17, 15:18, Icenowy Zheng wrote:
> 
> 2017年4月11日 15:03于 Viresh Kumar <viresh.kumar@linaro.org>写道：
> >
> > On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote: 
> > > Some new Allwinner SoCs get supported in the kernel after the 
> > > compatibles are added to cpufreq-dt-platdev driver. 
> > > 
> > > Add their compatible strings in the cpufreq-dt-platdev driver. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> 
> > > --- 
> > >  drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++ 
> > >  1 file changed, 5 insertions(+) 
> > > 
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > index 921b4a6c3d16..2180e509e383 100644 
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = { 
> > >         { .compatible = "allwinner,sun8i-a23", }, 
> > >         { .compatible = "allwinner,sun8i-a33", }, 
> > >         { .compatible = "allwinner,sun8i-a83t", }, 
> > > +       { .compatible = "allwinner,sun8i-h2-plus", }, 
> > >         { .compatible = "allwinner,sun8i-h3", }, 
> > > +       { .compatible = "allwinner,sun8i-v3s", }, 
> > > +       { .compatible = "allwinner,sun50i-a64", }, 
> > > +       { .compatible = "allwinner,sun50i-h5", }, 
> > > +       { .compatible = "nextthing,gr8", }, 
> >
> >
> > This needs to be in alphabetical order and please cc cpufreq 
> 
> However I prefer these sequence -- sun50i is later than sun8i.
> 
> Place sun50i between sun4i and sun5i is meaningless, as sun50i in fact have a deep relationship with sun8i, but not sun4/5i.

We aren't really worried about relationship here. The order is important to find
missing entries as soon as possible and that's why I have been forcing people to
add entries in alphabetical order.

-- 
viresh

[PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Viresh Kumar]

On 11-04-17, 15:18, Icenowy Zheng wrote:
> 
> 2017?4?11? 15:03? Viresh Kumar <viresh.kumar@linaro.org>???
> >
> > On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote: 
> > > Some new Allwinner SoCs get supported in the kernel after the 
> > > compatibles are added to cpufreq-dt-platdev driver. 
> > > 
> > > Add their compatible strings in the cpufreq-dt-platdev driver. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> 
> > > --- 
> > >? drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++ 
> > >? 1 file changed, 5 insertions(+) 
> > > 
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > index 921b4a6c3d16..2180e509e383 100644 
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = { 
> > >???????? { .compatible = "allwinner,sun8i-a23", }, 
> > >???????? { .compatible = "allwinner,sun8i-a33", }, 
> > >???????? { .compatible = "allwinner,sun8i-a83t", }, 
> > > +?????? { .compatible = "allwinner,sun8i-h2-plus", }, 
> > >???????? { .compatible = "allwinner,sun8i-h3", }, 
> > > +?????? { .compatible = "allwinner,sun8i-v3s", }, 
> > > +?????? { .compatible = "allwinner,sun50i-a64", }, 
> > > +?????? { .compatible = "allwinner,sun50i-h5", }, 
> > > +?????? { .compatible = "nextthing,gr8", }, 
> >
> >
> > This needs to be in alphabetical order and please cc cpufreq 
> 
> However I prefer these sequence -- sun50i is later than sun8i.
> 
> Place sun50i between sun4i and sun5i is meaningless, as sun50i in fact have a deep relationship with sun8i, but not sun4/5i.

We aren't really worried about relationship here. The order is important to find
missing entries as soon as possible and that's why I have been forcing people to
add entries in alphabetical order.

-- 
viresh

Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Icenowy Zheng]

2017年4月11日 15:03于 Viresh Kumar <viresh.kumar@linaro.org>写道：
>
> On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote: 
> > Some new Allwinner SoCs get supported in the kernel after the 
> > compatibles are added to cpufreq-dt-platdev driver. 
> > 
> > Add their compatible strings in the cpufreq-dt-platdev driver. 
> > 
> > Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> 
> > --- 
> >  drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++ 
> >  1 file changed, 5 insertions(+) 
> > 
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c 
> > index 921b4a6c3d16..2180e509e383 100644 
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c 
> > @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = { 
> >         { .compatible = "allwinner,sun8i-a23", }, 
> >         { .compatible = "allwinner,sun8i-a33", }, 
> >         { .compatible = "allwinner,sun8i-a83t", }, 
> > +       { .compatible = "allwinner,sun8i-h2-plus", }, 
> >         { .compatible = "allwinner,sun8i-h3", }, 
> > +       { .compatible = "allwinner,sun8i-v3s", }, 
> > +       { .compatible = "allwinner,sun50i-a64", }, 
> > +       { .compatible = "allwinner,sun50i-h5", }, 
> > +       { .compatible = "nextthing,gr8", }, 
>
>
> This needs to be in alphabetical order and please cc cpufreq 

However I prefer these sequence -- sun50i is later than sun8i.

Place sun50i between sun4i and sun5i is meaningless, as sun50i in fact have a deep relationship with sun8i, but not sun4/5i.

> maintainers next time. 
>
> _______________________________________________ 
> linux-arm-kernel mailing list 
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org 
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[PATCH 0/5] Some Allwinner CCU tweaks and basical DVFS support for H3/H2+

[Icenowy Zheng]

This patchset aim to add basical DVFS support for Allwinner H3/H2+ SoCs, they
seem to be nearly the same.

The first patch is a CCU fix for all NKMP-type clocks, not H3 limited. Please
schedule this patch to 4.11 queue, as A33 needs also this patch. It solves the
problem that system hangs when the PLL_CPUX change for the first time.

The second patch allows the PLL_CPUX to change for CPUX clock on H3.

The third patch imports a bunch of new SoCs' compatibles into
cpufreq-dt-platdev driver.

The fourth patch adds several operating points for Allwinner H3/H2+ CPU.

The fifth patch adds the regulator node to Orange Pi Zero board's device
tree.

Icenowy Zheng (5):
  clk: sunxi-ng: prevent NKMP clocks from temporarily get higher freq
  clk: sunxi-ng: allow set parent clock (PLL_CPUX) for CPUX clock on H3
  cpufreq: dt: Add support for some new Allwinner SoCs
  ARM: sun8i: h3: add operating-points-v2 table for CPU
  ARM: sun8i: h2+: add SY8113B regulator used by Orange Pi Zero board

 arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 21 +++++++
 arch/arm/boot/dts/sun8i-h3.dtsi                   | 38 +++++++++++-
 drivers/clk/sunxi-ng/ccu-sun8i-h3.c               |  2 +-
 drivers/clk/sunxi-ng/ccu_nkmp.c                   | 76 +++++++++++++++++++----
 drivers/cpufreq/cpufreq-dt-platdev.c              |  5 ++
 5 files changed, 129 insertions(+), 13 deletions(-)

-- 
2.12.2

[PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Icenowy Zheng]

Some new Allwinner SoCs get supported in the kernel after the
compatibles are added to cpufreq-dt-platdev driver.

Add their compatible strings in the cpufreq-dt-platdev driver.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 921b4a6c3d16..2180e509e383 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
 	{ .compatible = "allwinner,sun8i-a23", },
 	{ .compatible = "allwinner,sun8i-a33", },
 	{ .compatible = "allwinner,sun8i-a83t", },
+	{ .compatible = "allwinner,sun8i-h2-plus", },
 	{ .compatible = "allwinner,sun8i-h3", },
+	{ .compatible = "allwinner,sun8i-v3s", },
+	{ .compatible = "allwinner,sun50i-a64", },
+	{ .compatible = "allwinner,sun50i-h5", },
+	{ .compatible = "nextthing,gr8", },
 
 	{ .compatible = "apm,xgene-shadowcat", },
 
-- 
2.12.2

[PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Icenowy Zheng]

Some new Allwinner SoCs get supported in the kernel after the
compatibles are added to cpufreq-dt-platdev driver.

Add their compatible strings in the cpufreq-dt-platdev driver.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 921b4a6c3d16..2180e509e383 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
 	{ .compatible = "allwinner,sun8i-a23", },
 	{ .compatible = "allwinner,sun8i-a33", },
 	{ .compatible = "allwinner,sun8i-a83t", },
+	{ .compatible = "allwinner,sun8i-h2-plus", },
 	{ .compatible = "allwinner,sun8i-h3", },
+	{ .compatible = "allwinner,sun8i-v3s", },
+	{ .compatible = "allwinner,sun50i-a64", },
+	{ .compatible = "allwinner,sun50i-h5", },
+	{ .compatible = "nextthing,gr8", },
 
 	{ .compatible = "apm,xgene-shadowcat", },
 
-- 
2.12.2

Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Viresh Kumar]

On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Some new Allwinner SoCs get supported in the kernel after the
> compatibles are added to cpufreq-dt-platdev driver.
>
> Add their compatible strings in the cpufreq-dt-platdev driver.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 921b4a6c3d16..2180e509e383 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
>         { .compatible = "allwinner,sun8i-a23", },
>         { .compatible = "allwinner,sun8i-a33", },
>         { .compatible = "allwinner,sun8i-a83t", },
> +       { .compatible = "allwinner,sun8i-h2-plus", },
>         { .compatible = "allwinner,sun8i-h3", },
> +       { .compatible = "allwinner,sun8i-v3s", },
> +       { .compatible = "allwinner,sun50i-a64", },
> +       { .compatible = "allwinner,sun50i-h5", },
> +       { .compatible = "nextthing,gr8", },


This needs to be in alphabetical order and please cc cpufreq
maintainers next time.

[PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Viresh Kumar]

On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Some new Allwinner SoCs get supported in the kernel after the
> compatibles are added to cpufreq-dt-platdev driver.
>
> Add their compatible strings in the cpufreq-dt-platdev driver.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 921b4a6c3d16..2180e509e383 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
>         { .compatible = "allwinner,sun8i-a23", },
>         { .compatible = "allwinner,sun8i-a33", },
>         { .compatible = "allwinner,sun8i-a83t", },
> +       { .compatible = "allwinner,sun8i-h2-plus", },
>         { .compatible = "allwinner,sun8i-h3", },
> +       { .compatible = "allwinner,sun8i-v3s", },
> +       { .compatible = "allwinner,sun50i-a64", },
> +       { .compatible = "allwinner,sun50i-h5", },
> +       { .compatible = "nextthing,gr8", },


This needs to be in alphabetical order and please cc cpufreq
maintainers next time.

Re: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs

[Viresh Kumar]

On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Some new Allwinner SoCs get supported in the kernel after the
> compatibles are added to cpufreq-dt-platdev driver.
>
> Add their compatible strings in the cpufreq-dt-platdev driver.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 921b4a6c3d16..2180e509e383 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
>         { .compatible = "allwinner,sun8i-a23", },
>         { .compatible = "allwinner,sun8i-a33", },
>         { .compatible = "allwinner,sun8i-a83t", },
> +       { .compatible = "allwinner,sun8i-h2-plus", },
>         { .compatible = "allwinner,sun8i-h3", },
> +       { .compatible = "allwinner,sun8i-v3s", },
> +       { .compatible = "allwinner,sun50i-a64", },
> +       { .compatible = "allwinner,sun50i-h5", },
> +       { .compatible = "nextthing,gr8", },


This needs to be in alphabetical order and please cc cpufreq
maintainers next time.