All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/powerplay: fix a signedness bugs
@ 2017-05-16 14:42 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2017-05-16 14:42 UTC (permalink / raw)
  To: Alex Deucher, Rex Zhu
  Cc: David Airlie, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Huang Rui,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Eric Huang, Ken Wang,
	Christian König

Smatch complains about a signedness bug here:

	vega10_hwmgr.c:4202 vega10_force_clock_level()
	warn: always true condition '(i >= 0) => (0-u32max >= 0)'

Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level can't be set on vega10.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index ad30f5d3a10d..2614af2f553f 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct pp_hwmgr *hwmgr,
 		enum pp_clock_type type, uint32_t mask)
 {
 	struct vega10_hwmgr *data = (struct vega10_hwmgr *)(hwmgr->backend);
-	uint32_t i;
+	int i;
 
 	if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL)
 		return -EINVAL;

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] drm/amd/powerplay: fix a signedness bugs
@ 2017-05-16 14:42 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2017-05-16 14:42 UTC (permalink / raw)
  To: Alex Deucher, Rex Zhu
  Cc: David Airlie, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Huang Rui,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Eric Huang, Ken Wang,
	Christian König

Smatch complains about a signedness bug here:

	vega10_hwmgr.c:4202 vega10_force_clock_level()
	warn: always true condition '(i >= 0) => (0-u32max >= 0)'

Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level can't be set on vega10.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index ad30f5d3a10d..2614af2f553f 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct pp_hwmgr *hwmgr,
 		enum pp_clock_type type, uint32_t mask)
 {
 	struct vega10_hwmgr *data = (struct vega10_hwmgr *)(hwmgr->backend);
-	uint32_t i;
+	int i;
 
 	if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL)
 		return -EINVAL;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/powerplay: fix a signedness bugs
  2017-05-16 14:42 ` Dan Carpenter
@ 2017-05-18 16:28   ` Eric Huang
  -1 siblings, 0 replies; 5+ messages in thread
From: Eric Huang @ 2017-05-18 16:28 UTC (permalink / raw)
  To: Dan Carpenter, Alex Deucher, Rex Zhu
  Cc: Christian König, David Airlie, Ken Wang, Huang Rui, amd-gfx,
	dri-devel, kernel-janitors

Reviewed-by: Eric Huang <JinHuiEric.Huang@amd.com>


On 2017-05-16 10:42 AM, Dan Carpenter wrote:
> Smatch complains about a signedness bug here:
>
> 	vega10_hwmgr.c:4202 vega10_force_clock_level()
> 	warn: always true condition '(i >= 0) => (0-u32max >= 0)'
>
> Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level can't be set on vega10.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index ad30f5d3a10d..2614af2f553f 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct pp_hwmgr *hwmgr,
>   		enum pp_clock_type type, uint32_t mask)
>   {
>   	struct vega10_hwmgr *data = (struct vega10_hwmgr *)(hwmgr->backend);
> -	uint32_t i;
> +	int i;
>   
>   	if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL)
>   		return -EINVAL;


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/powerplay: fix a signedness bugs
@ 2017-05-18 16:28   ` Eric Huang
  0 siblings, 0 replies; 5+ messages in thread
From: Eric Huang @ 2017-05-18 16:28 UTC (permalink / raw)
  To: Dan Carpenter, Alex Deucher, Rex Zhu
  Cc: Christian König, David Airlie, Ken Wang, Huang Rui, amd-gfx,
	dri-devel, kernel-janitors

Reviewed-by: Eric Huang <JinHuiEric.Huang@amd.com>


On 2017-05-16 10:42 AM, Dan Carpenter wrote:
> Smatch complains about a signedness bug here:
>
> 	vega10_hwmgr.c:4202 vega10_force_clock_level()
> 	warn: always true condition '(i >= 0) => (0-u32max >= 0)'
>
> Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level can't be set on vega10.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index ad30f5d3a10d..2614af2f553f 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct pp_hwmgr *hwmgr,
>   		enum pp_clock_type type, uint32_t mask)
>   {
>   	struct vega10_hwmgr *data = (struct vega10_hwmgr *)(hwmgr->backend);
> -	uint32_t i;
> +	int i;
>   
>   	if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL)
>   		return -EINVAL;


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/powerplay: fix a signedness bugs
       [not found]   ` <ef4ba551-a52b-d2e0-5ba4-7271ee6f4e85-5C7GfCeVMHo@public.gmane.org>
@ 2017-05-23  5:36     ` Zhu, Rex
  0 siblings, 0 replies; 5+ messages in thread
From: Zhu, Rex @ 2017-05-23  5:36 UTC (permalink / raw)
  To: Huang, JinHuiEric, Dan Carpenter, Deucher, Alexander
  Cc: David Airlie, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Huang, Ray,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Wang, Ken, Koenig,
	Christian


[-- Attachment #1.1: Type: text/plain, Size: 1633 bytes --]

Patches has been applied.


Thanks.


Best Regards

Rex

________________________________
From: Huang, JinHuiEric
Sent: Friday, May 19, 2017 12:28:09 AM
To: Dan Carpenter; Deucher, Alexander; Zhu, Rex
Cc: Koenig, Christian; David Airlie; Wang, Ken; Huang, Ray; amd-gfx@lists.freedesktop.org; dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org; kernel-janitors-u79uwXL29TZNg+MwTxZMZA@public.gmane.orgl.org
Subject: Re: [PATCH] drm/amd/powerplay: fix a signedness bugs

Reviewed-by: Eric Huang <JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org>


On 2017-05-16 10:42 AM, Dan Carpenter wrote:
> Smatch complains about a signedness bug here:
>
>        vega10_hwmgr.c:4202 vega10_force_clock_level()
>        warn: always true condition '(i >= 0) => (0-u32max >= 0)'
>
> Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level can't be set on vega10.")
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index ad30f5d3a10d..2614af2f553f 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct pp_hwmgr *hwmgr,
>                enum pp_clock_type type, uint32_t mask)
>   {
>        struct vega10_hwmgr *data = (struct vega10_hwmgr *)(hwmgr->backend);
> -     uint32_t i;
> +     int i;
>
>        if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL)
>                return -EINVAL;


[-- Attachment #1.2: Type: text/html, Size: 3150 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-23  5:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-16 14:42 [PATCH] drm/amd/powerplay: fix a signedness bugs Dan Carpenter
2017-05-16 14:42 ` Dan Carpenter
2017-05-18 16:28 ` Eric Huang
2017-05-18 16:28   ` Eric Huang
     [not found]   ` <ef4ba551-a52b-d2e0-5ba4-7271ee6f4e85-5C7GfCeVMHo@public.gmane.org>
2017-05-23  5:36     ` Zhu, Rex

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.