* [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk
@ 2017-06-01 7:47 Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2017-06-01 7:47 UTC (permalink / raw)
To: alsa-devel
The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk
for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec
quirk for a MSI mobo. But it turned out that this isn't applied
properly due to the MSI-vendor quirk before this entry. I overlooked
such two MSI entries just because they were put in the wrong position,
although we have a list ordered by PCI SSID numbers.
This patch fixes it by rearranging the unordered entries.
Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo")
Reported-by: Rudolf Schmidt <info@rudolfschmidt.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/hda/patch_realtek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 918e45268915..a57988d617e9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2324,11 +2324,11 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
SND_PCI_QUIRK(0x106b, 0x4a00, "Macbook 5,2", ALC889_FIXUP_MBA11_VREF),
SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC882_FIXUP_EAPD),
- SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD),
- SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3),
SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+ SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD),
SND_PCI_QUIRK(0x1462, 0xda57, "MSI Z270-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+ SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3),
SND_PCI_QUIRK(0x147b, 0x107a, "Abit AW9D-MAX", ALC882_FIXUP_ABIT_AW9D_MAX),
SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD),
SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_FIXUP_EAPD),
--
2.13.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support
@ 2017-06-01 20:58 Takashi Iwai
2017-06-01 20:58 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2017-06-01 20:58 UTC (permalink / raw)
To: alsa-devel
Cc: Takashi Sakamoto, Mark Brown, Hans Verkuil, linux-media,
Felipe Balbi, Greg Kroah-Hartman, linux-usb
Hi,
this is a full patchset of what I sent previously, containing the all
changes instead of the snippet. The main purpose of this patchset is
to eliminate the remaining usages of set_fs(). They are basically
used for in-kernel PCM data transfer, and this patch provides the new
API functions and replaces the hackish set_fs() calls with them.
Unlike the first patchset with the unified copy_silence ops, this adds
a new copy_kernel ops instead. At the same time, copy/silence are
changed to receive the position and size in bytes instead of frames.
This allows us to simplify the PCM core code. As a result, a good
amount of code could be removed from pcm_lib.c.
The difference from the previous patchset is that this is a full
patchset, i.e. all relevant drivers have been covered, and also some
small issues have been addressed, in addition, the documentation
update is provided, too.
I'm Cc'ing the media and the USB people since it touches solo6x10 and
usb-gadget drivers.
The previous ACK was dropped as each patch was rewritten again. Sorry
for the doubly patch-review labours.
thanks,
Takashi
===
Takashi Iwai (26):
ALSA: pcm: Introduce copy_user, copy_kernel and fill_silence ops
ALSA: dummy: Convert to new PCM copy ops
ALSA: es1938: Convert to the new PCM copy ops
ALSA: nm256: Convert to new PCM copy ops
ALSA: korg1212: Convert to the new PCM ops
ALSA: rme32: Convert to the new PCM copy ops
ALSA: rme96: Convert to the new PCM ops
ALSA: rme9652: Convert to the new PCM ops
ALSA: hdsp: Convert to the new PCM ops
ALSA: gus: Convert to the new PCM ops
ALSA: sb: Convert to the new PCM ops
ALSA: sh: Convert to the new PCM ops
ASoC: blackfin: Convert to the new PCM ops
[media] solo6x10: Convert to the new PCM ops
ALSA: pcm: Drop the old copy and silence ops
ALSA: pcm: Check PCM state by a common helper function
ALSA: pcm: Shuffle codes
ALSA: pcm: Call directly the common read/write helpers
ALSA: pcm: More unification of PCM transfer codes
ALSA: pcm: Unify read/write loop
ALSA: pcm: Simplify snd_pcm_playback_silence()
ALSA: pcm: Direct in-kernel read/write support
usb: gadget: u_uac1: Kill set_fs() usage
ALSA: pcm: Kill set_fs() in PCM OSS layer
ALSA: pcm: Build OSS writev/readv helpers conditionally
ALSA: doc: Update copy_user, copy_kernel and fill_silence PCM ops
.../sound/kernel-api/writing-an-alsa-driver.rst | 111 ++--
drivers/media/pci/solo6x10/solo6x10-g723.c | 32 +-
drivers/usb/gadget/function/u_uac1.c | 7 +-
include/sound/pcm.h | 80 ++-
sound/core/oss/io.c | 4 +-
sound/core/oss/pcm_oss.c | 81 +--
sound/core/oss/pcm_plugin.h | 6 +-
sound/core/pcm_lib.c | 564 ++++++++-------------
sound/drivers/dummy.c | 20 +-
sound/isa/gus/gus_pcm.c | 97 ++--
sound/isa/sb/emu8000_pcm.c | 190 ++++---
sound/pci/es1938.c | 33 +-
sound/pci/korg1212/korg1212.c | 112 ++--
sound/pci/nm256/nm256.c | 57 ++-
sound/pci/rme32.c | 65 ++-
sound/pci/rme96.c | 70 ++-
sound/pci/rme9652/hdsp.c | 67 ++-
sound/pci/rme9652/rme9652.c | 71 ++-
sound/sh/sh_dac_audio.c | 54 +-
sound/soc/blackfin/bf5xx-ac97-pcm.c | 27 +-
sound/soc/blackfin/bf5xx-i2s-pcm.c | 36 +-
sound/soc/soc-pcm.c | 5 +-
22 files changed, 977 insertions(+), 812 deletions(-)
--
2.13.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk
2017-06-01 20:58 [PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support Takashi Iwai
@ 2017-06-01 20:58 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2017-06-01 20:58 UTC (permalink / raw)
To: alsa-devel
Cc: Takashi Sakamoto, Mark Brown, Hans Verkuil, linux-media,
Felipe Balbi, Greg Kroah-Hartman, linux-usb
The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk
for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec
quirk for a MSI mobo. But it turned out that this isn't applied
properly due to the MSI-vendor quirk before this entry. I overlooked
such two MSI entries just because they were put in the wrong position,
although we have a list ordered by PCI SSID numbers.
This patch fixes it by rearranging the unordered entries.
Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo")
Reported-by: Rudolf Schmidt <info@rudolfschmidt.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/hda/patch_realtek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 918e45268915..a57988d617e9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2324,11 +2324,11 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
SND_PCI_QUIRK(0x106b, 0x4a00, "Macbook 5,2", ALC889_FIXUP_MBA11_VREF),
SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC882_FIXUP_EAPD),
- SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD),
- SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3),
SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+ SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD),
SND_PCI_QUIRK(0x1462, 0xda57, "MSI Z270-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+ SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3),
SND_PCI_QUIRK(0x147b, 0x107a, "Abit AW9D-MAX", ALC882_FIXUP_ABIT_AW9D_MAX),
SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD),
SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_FIXUP_EAPD),
--
2.13.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk
@ 2017-06-01 20:58 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2017-06-01 20:58 UTC (permalink / raw)
To: alsa-devel
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, Takashi Sakamoto,
Hans Verkuil, Mark Brown, linux-media
The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk
for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec
quirk for a MSI mobo. But it turned out that this isn't applied
properly due to the MSI-vendor quirk before this entry. I overlooked
such two MSI entries just because they were put in the wrong position,
although we have a list ordered by PCI SSID numbers.
This patch fixes it by rearranging the unordered entries.
Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo")
Reported-by: Rudolf Schmidt <info@rudolfschmidt.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/hda/patch_realtek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 918e45268915..a57988d617e9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2324,11 +2324,11 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
SND_PCI_QUIRK(0x106b, 0x4a00, "Macbook 5,2", ALC889_FIXUP_MBA11_VREF),
SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC882_FIXUP_EAPD),
- SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD),
- SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3),
SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+ SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD),
SND_PCI_QUIRK(0x1462, 0xda57, "MSI Z270-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+ SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3),
SND_PCI_QUIRK(0x147b, 0x107a, "Abit AW9D-MAX", ALC882_FIXUP_ABIT_AW9D_MAX),
SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD),
SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_FIXUP_EAPD),
--
2.13.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk
@ 2017-06-02 9:12 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2017-06-02 9:12 UTC (permalink / raw)
To: Takashi Iwai, alsa-devel
Cc: Takashi Sakamoto, Mark Brown, Hans Verkuil, linux-media,
Felipe Balbi, Greg Kroah-Hartman, linux-usb
Hello!
On 6/1/2017 11:58 PM, Takashi Iwai wrote:
> The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk
> for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec
The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda -
Apply dual-codec quirk for MSI Z270-Gaming mobo"), just like in the Fixes: tag.
> quirk for a MSI mobo. But it turned out that this isn't applied
> properly due to the MSI-vendor quirk before this entry. I overlooked
> such two MSI entries just because they were put in the wrong position,
> although we have a list ordered by PCI SSID numbers.
>
> This patch fixes it by rearranging the unordered entries.
>
> Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo")
> Reported-by: Rudolf Schmidt <info@rudolfschmidt.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk
@ 2017-06-02 9:12 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2017-06-02 9:12 UTC (permalink / raw)
To: Takashi Iwai, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw
Cc: Takashi Sakamoto, Mark Brown, Hans Verkuil,
linux-media-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi,
Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA
Hello!
On 6/1/2017 11:58 PM, Takashi Iwai wrote:
> The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk
> for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec
The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda -
Apply dual-codec quirk for MSI Z270-Gaming mobo"), just like in the Fixes: tag.
> quirk for a MSI mobo. But it turned out that this isn't applied
> properly due to the MSI-vendor quirk before this entry. I overlooked
> such two MSI entries just because they were put in the wrong position,
> although we have a list ordered by PCI SSID numbers.
>
> This patch fixes it by rearranging the unordered entries.
>
> Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo")
> Reported-by: Rudolf Schmidt <info-3q2wXJgvQBgtTFl30EOYJwC/G2K4zDHf@public.gmane.org>
> Signed-off-by: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-02 9:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-01 7:47 [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk Takashi Iwai
2017-06-01 20:58 [PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support Takashi Iwai
2017-06-01 20:58 ` [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk Takashi Iwai
2017-06-01 20:58 ` Takashi Iwai
2017-06-02 9:12 ` Sergei Shtylyov
2017-06-02 9:12 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.