From: Mark Brown <broonie@kernel.org>
To: Aravind Thokala <aravind.thk@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings
Date: Wed, 28 Jun 2017 19:45:07 +0100 [thread overview]
Message-ID: <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk> (raw)
In-Reply-To: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
This isn't a good changelog, what are the warnings and why are we fixing
them? The fact that checkpatch complains isn't meaningful in and of
itself - it's OK to say that checkpatch helped identify issues but it's
not perfect and we need to understand what is being changed and why.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Aravind Thokala <aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings
Date: Wed, 28 Jun 2017 19:45:07 +0100 [thread overview]
Message-ID: <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk> (raw)
In-Reply-To: <1498579630-10109-1-git-send-email-aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
This isn't a good changelog, what are the warnings and why are we fixing
them? The fact that checkpatch complains isn't meaningful in and of
itself - it's OK to say that checkpatch helped identify issues but it's
not perfect and we need to understand what is being changed and why.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings
Date: Wed, 28 Jun 2017 19:45:07 +0100 [thread overview]
Message-ID: <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk> (raw)
In-Reply-To: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com>
On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
This isn't a good changelog, what are the warnings and why are we fixing
them? The fact that checkpatch complains isn't meaningful in and of
itself - it's OK to say that checkpatch helped identify issues but it's
not perfect and we need to understand what is being changed and why.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170628/d04596ab/attachment-0001.sig>
next prev parent reply other threads:[~2017-06-28 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 16:07 [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings Aravind Thokala
2017-06-27 16:07 ` Aravind Thokala
2017-06-27 16:07 ` Aravind Thokala
2017-06-28 18:45 ` Mark Brown [this message]
2017-06-28 18:45 ` Mark Brown
2017-06-28 18:45 ` Mark Brown
2017-06-30 17:38 ` Aravind Thokala
2017-06-30 17:38 ` Aravind Thokala
2017-06-30 17:38 ` Aravind Thokala
2017-07-10 18:32 ` Mark Brown
2017-07-10 18:32 ` Mark Brown
2017-07-10 18:42 ` Applied "spi/bcm63xx-hspi: Fix checkpatch warnings" to the spi tree Mark Brown
2017-07-10 18:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aravind.thk@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.