From: Mark Brown <broonie@kernel.org>
To: Aravind Thokala <aravind.thk@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings
Date: Mon, 10 Jul 2017 19:32:44 +0100 [thread overview]
Message-ID: <20170710183244.hds7lyoxoymiza7r@sirena.org.uk> (raw)
In-Reply-To: <CAAUiYHf6n+C9Q7TdApG_7mOdc7fJyTKq9To=4PvgXARQ5eOAOg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
On Fri, Jun 30, 2017 at 11:08:15PM +0530, Aravind Thokala wrote:
> Hello Mark,
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
> These warnings looked straightforward for me so I've fixed those and
> sent the patch.
> Kindly let me know if you want to record the warnings in the patch so
> that I could send v2 patch as soon as possible.
It's not just a case of quoting the warnings, it's a case of explaining
what your patch changes which usually requires more than just quoting
the warning.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings
Date: Mon, 10 Jul 2017 19:32:44 +0100 [thread overview]
Message-ID: <20170710183244.hds7lyoxoymiza7r@sirena.org.uk> (raw)
In-Reply-To: <CAAUiYHf6n+C9Q7TdApG_7mOdc7fJyTKq9To=4PvgXARQ5eOAOg@mail.gmail.com>
On Fri, Jun 30, 2017 at 11:08:15PM +0530, Aravind Thokala wrote:
> Hello Mark,
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
> These warnings looked straightforward for me so I've fixed those and
> sent the patch.
> Kindly let me know if you want to record the warnings in the patch so
> that I could send v2 patch as soon as possible.
It's not just a case of quoting the warnings, it's a case of explaining
what your patch changes which usually requires more than just quoting
the warning.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170710/1998d35f/attachment.sig>
next prev parent reply other threads:[~2017-07-10 18:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 16:07 [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings Aravind Thokala
2017-06-27 16:07 ` Aravind Thokala
2017-06-27 16:07 ` Aravind Thokala
2017-06-28 18:45 ` Mark Brown
2017-06-28 18:45 ` Mark Brown
2017-06-28 18:45 ` Mark Brown
2017-06-30 17:38 ` Aravind Thokala
2017-06-30 17:38 ` Aravind Thokala
2017-06-30 17:38 ` Aravind Thokala
2017-07-10 18:32 ` Mark Brown [this message]
2017-07-10 18:32 ` Mark Brown
2017-07-10 18:42 ` Applied "spi/bcm63xx-hspi: Fix checkpatch warnings" to the spi tree Mark Brown
2017-07-10 18:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710183244.hds7lyoxoymiza7r@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aravind.thk@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.