From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
linux-i2c <linux-i2c@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Linux-SH <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32
Date: Fri, 30 Jun 2017 09:03:55 +0000 [thread overview]
Message-ID: <20170630090354.6s6ahpjhis7ptbfg@ninjato> (raw)
In-Reply-To: <CAHp75Vc+6WGFiJifEExjv3jSFsy+ORGtRoDPmv31sSFN=zkHMg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
> > - i2c->algo_data.i2c_clock = 59000;
> > + ret = device_property_read_u32(&pdev->dev, "clock-frequency",
> > + &i2c->algo_data.i2c_clock);
> > + if (ret)
> > + i2c->algo_data.i2c_clock = 59000;
>
> My idea is to get rid of legacy platform data completely.
> That's why I suggested device_* in the first place.
>
> In similar way like you did with GPIO lookup table, you may use
> PROPERTY_ENTRY*() macros in the board files.
>
> Does it make sense?
Frankly, I am not a big fan of converting board files if we cannot test
the changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
linux-i2c <linux-i2c@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Linux-SH <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32
Date: Fri, 30 Jun 2017 11:03:55 +0200 [thread overview]
Message-ID: <20170630090354.6s6ahpjhis7ptbfg@ninjato> (raw)
In-Reply-To: <CAHp75Vc+6WGFiJifEExjv3jSFsy+ORGtRoDPmv31sSFN=zkHMg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
> > - i2c->algo_data.i2c_clock = 59000;
> > + ret = device_property_read_u32(&pdev->dev, "clock-frequency",
> > + &i2c->algo_data.i2c_clock);
> > + if (ret)
> > + i2c->algo_data.i2c_clock = 59000;
>
> My idea is to get rid of legacy platform data completely.
> That's why I suggested device_* in the first place.
>
> In similar way like you did with GPIO lookup table, you may use
> PROPERTY_ENTRY*() macros in the board files.
>
> Does it make sense?
Frankly, I am not a big fan of converting board files if we cannot test
the changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-30 9:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 0:54 [PATCH 0/6] i2c: pca-platform: additional improvements Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 0:54 ` [PATCH 1/6] sh: sh7785lcr: add GPIO lookup table for i2c controller reset Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-07-02 16:47 ` kbuild test robot
2017-07-02 16:47 ` kbuild test robot
2017-07-02 16:47 ` kbuild test robot
2017-07-02 17:15 ` Geert Uytterhoeven
2017-07-02 17:15 ` Geert Uytterhoeven
2017-06-30 0:54 ` [PATCH 2/6] i2c: pca-platform: correctly set algo_data.reset_chip Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-07-04 14:03 ` Wolfram Sang
2017-07-04 14:03 ` Wolfram Sang
2017-06-30 0:54 ` [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 8:40 ` Andy Shevchenko
2017-06-30 8:40 ` Andy Shevchenko
2017-06-30 9:01 ` Wolfram Sang
2017-06-30 9:01 ` Wolfram Sang
2017-07-02 21:30 ` Chris Packham
2017-07-02 21:30 ` Chris Packham
2017-07-04 14:04 ` Wolfram Sang
2017-07-04 14:04 ` Wolfram Sang
2017-06-30 0:54 ` [PATCH 4/6] i2c: pca-platform: unconditionally use devm_gpiod_get_optional Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 0:54 ` [PATCH 5/6] i2c: pca-platform: use device_property_read_u32 Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 8:44 ` Andy Shevchenko
2017-06-30 8:44 ` Andy Shevchenko
2017-06-30 9:03 ` Wolfram Sang [this message]
2017-06-30 9:03 ` Wolfram Sang
2017-06-30 10:56 ` Andy Shevchenko
2017-06-30 10:56 ` Andy Shevchenko
2017-07-02 21:51 ` Chris Packham
2017-07-02 21:51 ` Chris Packham
2017-07-04 14:07 ` Wolfram Sang
2017-07-04 14:07 ` Wolfram Sang
2017-06-30 0:54 ` [PATCH 6/6] i2c: pca-platform: drop gpio from platform data Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 8:48 ` [PATCH 0/6] i2c: pca-platform: additional improvements Andy Shevchenko
2017-06-30 8:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630090354.6s6ahpjhis7ptbfg@ninjato \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.