From: Wolfram Sang <wsa@the-dreams.de>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: andy.shevchenko@gmail.com, linux-i2c@vger.kernel.org,
ysato@users.sourceforge.jp, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] i2c: pca-platform: correctly set algo_data.reset_chip
Date: Tue, 04 Jul 2017 14:03:34 +0000 [thread overview]
Message-ID: <20170704140333.iahb7udd22ph6awk@ninjato> (raw)
In-Reply-To: <20170630005408.23968-3-chris.packham@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Fri, Jun 30, 2017 at 12:54:04PM +1200, Chris Packham wrote:
> When device tree support was added the setting of algo_data.reset_chip
> was moved. There were two problems with this. The first being that
> i2c_pca_pf_resetchip was only used if platform data was provided. The
> second that it was unconditionally overridden with
> i2c_pca_pf_dummyreset. Ensure that however the reset gpio is defined the
> correct reset_chip function is used.
>
> Fixes: commit 4cc7229daa46 ("i2c: pca-platform: switch to struct gpio_desc")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
It's a bugfix, so I'll include it in this merge window.
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: andy.shevchenko@gmail.com, linux-i2c@vger.kernel.org,
ysato@users.sourceforge.jp, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] i2c: pca-platform: correctly set algo_data.reset_chip
Date: Tue, 4 Jul 2017 16:03:34 +0200 [thread overview]
Message-ID: <20170704140333.iahb7udd22ph6awk@ninjato> (raw)
In-Reply-To: <20170630005408.23968-3-chris.packham@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Fri, Jun 30, 2017 at 12:54:04PM +1200, Chris Packham wrote:
> When device tree support was added the setting of algo_data.reset_chip
> was moved. There were two problems with this. The first being that
> i2c_pca_pf_resetchip was only used if platform data was provided. The
> second that it was unconditionally overridden with
> i2c_pca_pf_dummyreset. Ensure that however the reset gpio is defined the
> correct reset_chip function is used.
>
> Fixes: commit 4cc7229daa46 ("i2c: pca-platform: switch to struct gpio_desc")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
It's a bugfix, so I'll include it in this merge window.
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-07-04 14:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 0:54 [PATCH 0/6] i2c: pca-platform: additional improvements Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 0:54 ` [PATCH 1/6] sh: sh7785lcr: add GPIO lookup table for i2c controller reset Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-07-02 16:47 ` kbuild test robot
2017-07-02 16:47 ` kbuild test robot
2017-07-02 16:47 ` kbuild test robot
2017-07-02 17:15 ` Geert Uytterhoeven
2017-07-02 17:15 ` Geert Uytterhoeven
2017-06-30 0:54 ` [PATCH 2/6] i2c: pca-platform: correctly set algo_data.reset_chip Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-07-04 14:03 ` Wolfram Sang [this message]
2017-07-04 14:03 ` Wolfram Sang
2017-06-30 0:54 ` [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 8:40 ` Andy Shevchenko
2017-06-30 8:40 ` Andy Shevchenko
2017-06-30 9:01 ` Wolfram Sang
2017-06-30 9:01 ` Wolfram Sang
2017-07-02 21:30 ` Chris Packham
2017-07-02 21:30 ` Chris Packham
2017-07-04 14:04 ` Wolfram Sang
2017-07-04 14:04 ` Wolfram Sang
2017-06-30 0:54 ` [PATCH 4/6] i2c: pca-platform: unconditionally use devm_gpiod_get_optional Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 0:54 ` [PATCH 5/6] i2c: pca-platform: use device_property_read_u32 Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 8:44 ` Andy Shevchenko
2017-06-30 8:44 ` Andy Shevchenko
2017-06-30 9:03 ` Wolfram Sang
2017-06-30 9:03 ` Wolfram Sang
2017-06-30 10:56 ` Andy Shevchenko
2017-06-30 10:56 ` Andy Shevchenko
2017-07-02 21:51 ` Chris Packham
2017-07-02 21:51 ` Chris Packham
2017-07-04 14:07 ` Wolfram Sang
2017-07-04 14:07 ` Wolfram Sang
2017-06-30 0:54 ` [PATCH 6/6] i2c: pca-platform: drop gpio from platform data Chris Packham
2017-06-30 0:54 ` Chris Packham
2017-06-30 8:48 ` [PATCH 0/6] i2c: pca-platform: additional improvements Andy Shevchenko
2017-06-30 8:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704140333.iahb7udd22ph6awk@ninjato \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.