All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Linux-SH <linux-sh@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32
Date: Sun, 02 Jul 2017 21:51:44 +0000	[thread overview]
Message-ID: <942893991cc34410bf1515a6a970c5c2@svr-chch-ex1.atlnz.lc> (raw)
In-Reply-To: CAHp75Ve1daNFe4PLAMpqMudE9d+Ss2JpeZ=Sy5x5ij99gAVs_w@mail.gmail.com

On 30/06/17 22:56, Andy Shevchenko wrote:
> On Fri, Jun 30, 2017 at 12:03 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>>>> -               i2c->algo_data.i2c_clock = 59000;
>>>> +               ret = device_property_read_u32(&pdev->dev, "clock-frequency",
>>>> +                                              &i2c->algo_data.i2c_clock);
>>>> +               if (ret)
>>>> +                       i2c->algo_data.i2c_clock = 59000;
>>>
>>> My idea is to get rid of legacy platform data completely.
>>> That's why I suggested device_* in the first place.
>>>
>>> In similar way like you did with GPIO lookup table, you may use
>>> PROPERTY_ENTRY*() macros in the board files.
>>>
>>> Does it make sense?
>>
>> Frankly, I am not a big fan of converting board files if we cannot test
>> the changes.
> 
> So, if no one is using that old boards, should we really take care
> more than just compile test?
> 
> P.S. Legacy platform data makes a burden of development nowadays.
> Built-in device properties API (as a part of Unified Device
> Properties) is exactly for getting rid of legacy stuff and make things
> much cleaner.

We could probably go with an approach of making the device properties 
the default which would suit the new style and leave the platform_data 
to override things if it is present.

If/when the older platforms go away we can drop struct 
i2c_pca9564_pf_platform_data.


WARNING: multiple messages have this Message-ID (diff)
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Linux-SH <linux-sh@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32
Date: Sun, 2 Jul 2017 21:51:44 +0000	[thread overview]
Message-ID: <942893991cc34410bf1515a6a970c5c2@svr-chch-ex1.atlnz.lc> (raw)
In-Reply-To: CAHp75Ve1daNFe4PLAMpqMudE9d+Ss2JpeZ=Sy5x5ij99gAVs_w@mail.gmail.com

On 30/06/17 22:56, Andy Shevchenko wrote:
> On Fri, Jun 30, 2017 at 12:03 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>>>> -               i2c->algo_data.i2c_clock = 59000;
>>>> +               ret = device_property_read_u32(&pdev->dev, "clock-frequency",
>>>> +                                              &i2c->algo_data.i2c_clock);
>>>> +               if (ret)
>>>> +                       i2c->algo_data.i2c_clock = 59000;
>>>
>>> My idea is to get rid of legacy platform data completely.
>>> That's why I suggested device_* in the first place.
>>>
>>> In similar way like you did with GPIO lookup table, you may use
>>> PROPERTY_ENTRY*() macros in the board files.
>>>
>>> Does it make sense?
>>
>> Frankly, I am not a big fan of converting board files if we cannot test
>> the changes.
> 
> So, if no one is using that old boards, should we really take care
> more than just compile test?
> 
> P.S. Legacy platform data makes a burden of development nowadays.
> Built-in device properties API (as a part of Unified Device
> Properties) is exactly for getting rid of legacy stuff and make things
> much cleaner.

We could probably go with an approach of making the device properties 
the default which would suit the new style and leave the platform_data 
to override things if it is present.

If/when the older platforms go away we can drop struct 
i2c_pca9564_pf_platform_data.

  reply	other threads:[~2017-07-02 21:51 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30  0:54 [PATCH 0/6] i2c: pca-platform: additional improvements Chris Packham
2017-06-30  0:54 ` Chris Packham
2017-06-30  0:54 ` [PATCH 1/6] sh: sh7785lcr: add GPIO lookup table for i2c controller reset Chris Packham
2017-06-30  0:54   ` Chris Packham
2017-07-02 16:47   ` kbuild test robot
2017-07-02 16:47     ` kbuild test robot
2017-07-02 16:47     ` kbuild test robot
2017-07-02 17:15     ` Geert Uytterhoeven
2017-07-02 17:15       ` Geert Uytterhoeven
2017-06-30  0:54 ` [PATCH 2/6] i2c: pca-platform: correctly set algo_data.reset_chip Chris Packham
2017-06-30  0:54   ` Chris Packham
2017-07-04 14:03   ` Wolfram Sang
2017-07-04 14:03     ` Wolfram Sang
2017-06-30  0:54 ` [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus Chris Packham
2017-06-30  0:54   ` Chris Packham
2017-06-30  8:40   ` Andy Shevchenko
2017-06-30  8:40     ` Andy Shevchenko
2017-06-30  9:01     ` Wolfram Sang
2017-06-30  9:01       ` Wolfram Sang
2017-07-02 21:30     ` Chris Packham
2017-07-02 21:30       ` Chris Packham
2017-07-04 14:04   ` Wolfram Sang
2017-07-04 14:04     ` Wolfram Sang
2017-06-30  0:54 ` [PATCH 4/6] i2c: pca-platform: unconditionally use devm_gpiod_get_optional Chris Packham
2017-06-30  0:54   ` Chris Packham
2017-06-30  0:54 ` [PATCH 5/6] i2c: pca-platform: use device_property_read_u32 Chris Packham
2017-06-30  0:54   ` Chris Packham
2017-06-30  8:44   ` Andy Shevchenko
2017-06-30  8:44     ` Andy Shevchenko
2017-06-30  9:03     ` Wolfram Sang
2017-06-30  9:03       ` Wolfram Sang
2017-06-30 10:56       ` Andy Shevchenko
2017-06-30 10:56         ` Andy Shevchenko
2017-07-02 21:51         ` Chris Packham [this message]
2017-07-02 21:51           ` Chris Packham
2017-07-04 14:07           ` Wolfram Sang
2017-07-04 14:07             ` Wolfram Sang
2017-06-30  0:54 ` [PATCH 6/6] i2c: pca-platform: drop gpio from platform data Chris Packham
2017-06-30  0:54   ` Chris Packham
2017-06-30  8:48 ` [PATCH 0/6] i2c: pca-platform: additional improvements Andy Shevchenko
2017-06-30  8:48   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=942893991cc34410bf1515a6a970c5c2@svr-chch-ex1.atlnz.lc \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.