[PATCH 00/18] x86: more bool_t to bool cleanup

[PATCH 00/18] x86: more bool_t to bool cleanup

[Wei Liu]

Seeing that bool_t keeps creeping back in new patches I think the only solution
is to get rid of bool_t once and for all, as soon as possible.

Wei Liu (18):
  x86/acpi: use plain bool
  x86/apic.c: use plain bool
  x86/debug.c: use plain bool
  x86/dmi.c: use plain bool
  x86/domctl: use plain bool
  x86/hpet.c: use plain bool
  x86/e820.c: use plan bool
  x86/i387.c: use plain bool
  x86/i8259.c: use plain bool
  x86/monitor.c: use plain bool
  x86/xstate.c: use plain bool
  x86/srat.c: use plain bool
  x86/smpboot.c: use plain bool
  x86/io_apic.c: use plain bool
  x86/mpparse.c: use plain bool
  x86/numa.c: use plain bool
  x86/msi.c: use plain bool
  x86/psr.c: use plain bool

 xen/arch/x86/acpi/boot.c            | 30 ++++++++++++++---------------
 xen/arch/x86/acpi/cpu_idle.c        | 19 ++++++++++---------
 xen/arch/x86/acpi/cpufreq/cpufreq.c |  2 +-
 xen/arch/x86/apic.c                 | 38 ++++++++++++++++++-------------------
 xen/arch/x86/debug.c                |  4 ++--
 xen/arch/x86/dmi_scan.c             |  8 ++++----
 xen/arch/x86/domctl.c               | 38 ++++++++++++++++++-------------------
 xen/arch/x86/e820.c                 |  2 +-
 xen/arch/x86/genapic/bigsmp.c       |  4 ++--
 xen/arch/x86/hpet.c                 |  2 +-
 xen/arch/x86/i387.c                 | 10 +++++-----
 xen/arch/x86/i8259.c                | 10 +++++-----
 xen/arch/x86/io_apic.c              | 36 +++++++++++++++++------------------
 xen/arch/x86/monitor.c              | 20 +++++++++----------
 xen/arch/x86/mpparse.c              | 25 +++++++++++-------------
 xen/arch/x86/msi.c                  | 32 +++++++++++++++----------------
 xen/arch/x86/numa.c                 | 10 +++++-----
 xen/arch/x86/psr.c                  | 14 +++++++-------
 xen/arch/x86/smpboot.c              |  5 +++--
 xen/arch/x86/srat.c                 | 10 +++++-----
 xen/arch/x86/time.c                 |  2 +-
 xen/arch/x86/xstate.c               | 30 ++++++++++++++---------------
 xen/include/asm-x86/acpi.h          |  5 ++---
 xen/include/asm-x86/apic.h          |  4 ++--
 xen/include/asm-x86/cpuidle.h       |  2 +-
 xen/include/asm-x86/io_apic.h       |  6 +++---
 xen/include/asm-x86/irq.h           |  2 +-
 xen/include/asm-x86/monitor.h       |  2 +-
 xen/include/asm-x86/mpspec.h        |  6 +++---
 xen/include/asm-x86/msi.h           |  6 +++---
 xen/include/asm-x86/numa.h          |  2 +-
 xen/include/asm-x86/softirq.h       |  2 +-
 xen/include/asm-x86/time.h          |  2 +-
 xen/include/asm-x86/xstate.h        |  6 +++---
 xen/include/xen/dmi.h               |  2 +-
 35 files changed, 198 insertions(+), 200 deletions(-)

-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 01/18] x86/acpi: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/acpi/boot.c            | 26 +++++++++++++-------------
 xen/arch/x86/acpi/cpu_idle.c        | 19 ++++++++++---------
 xen/arch/x86/acpi/cpufreq/cpufreq.c |  2 +-
 xen/include/asm-x86/acpi.h          |  5 ++---
 xen/include/asm-x86/cpuidle.h       |  2 +-
 xen/include/asm-x86/softirq.h       |  2 +-
 6 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c
index 83cbff95c1..17ba3c39ac 100644
--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -44,14 +44,14 @@
 
 #define PREFIX			"ACPI: "
 
-bool_t __initdata acpi_noirq;	/* skip ACPI IRQ initialization */
-bool_t __initdata acpi_ht = 1;	/* enable HT */
+bool __initdata acpi_noirq;     /* skip ACPI IRQ initialization */
+bool __initdata acpi_ht = true; /* enable HT */
 
-bool_t __initdata acpi_lapic;
-bool_t __initdata acpi_ioapic;
+bool __initdata acpi_lapic;
+bool __initdata acpi_ioapic;
 
 /* acpi_skip_timer_override: Skip IRQ0 overrides. */
-static bool_t acpi_skip_timer_override __initdata;
+static bool acpi_skip_timer_override __initdata;
 boolean_param("acpi_skip_timer_override", acpi_skip_timer_override);
 
 static u64 acpi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE;
@@ -83,7 +83,7 @@ acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end)
 {
 	struct acpi_madt_local_x2apic *processor =
 		container_of(header, struct acpi_madt_local_x2apic, header);
-	bool_t enabled = 0;
+	bool enabled = false;
 
 	if (BAD_MADT_ENTRY(processor, end))
 		return -EINVAL;
@@ -107,7 +107,7 @@ acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end)
 	if (processor->lapic_flags & ACPI_MADT_ENABLED) {
 		x86_acpiid_to_apicid[processor->uid] =
 			processor->local_apic_id;
-		enabled = 1;
+		enabled = true;
 	}
 
 	/*
@@ -127,7 +127,7 @@ acpi_parse_lapic(struct acpi_subtable_header * header, const unsigned long end)
 {
 	struct acpi_madt_local_apic *processor =
 		container_of(header, struct acpi_madt_local_apic, header);
-	bool_t enabled = 0;
+	bool enabled = false;
 
 	if (BAD_MADT_ENTRY(processor, end))
 		return -EINVAL;
@@ -137,7 +137,7 @@ acpi_parse_lapic(struct acpi_subtable_header * header, const unsigned long end)
 	/* Record local apic id only when enabled */
 	if (processor->lapic_flags & ACPI_MADT_ENABLED) {
 		x86_acpiid_to_apicid[processor->processor_id] = processor->id;
-		enabled = 1;
+		enabled = true;
 	}
 
 	/*
@@ -634,7 +634,7 @@ static void __init acpi_process_madt(void)
 		 */
 		error = acpi_parse_madt_lapic_entries();
 		if (!error) {
-			acpi_lapic = 1;
+			acpi_lapic = true;
 			generic_bigsmp_probe();
  
 			/*
@@ -642,7 +642,7 @@ static void __init acpi_process_madt(void)
 			 */
 			error = acpi_parse_madt_ioapic_entries();
 			if (!error) {
-				acpi_ioapic = 1;
+				acpi_ioapic = true;
 
 				smp_found_config = 1;
 				clustered_apic_check();
@@ -670,8 +670,8 @@ static void __init acpi_process_madt(void)
  * other side effects.
  *
  * side effects of acpi_boot_init:
- *	acpi_lapic = 1 if LAPIC found
- *	acpi_ioapic = 1 if IOAPIC found
+ *	acpi_lapic = true if LAPIC found
+ *	acpi_ioapic = true if IOAPIC found
  *	if (acpi_lapic && acpi_ioapic) smp_found_config = 1;
  *	...
  *
diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index e2be474ee1..482b8a78f3 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -78,7 +78,7 @@ static void lapic_timer_nop(void) { }
 void (*__read_mostly lapic_timer_off)(void);
 void (*__read_mostly lapic_timer_on)(void);
 
-bool_t lapic_timer_init(void)
+bool lapic_timer_init(void)
 {
     if ( boot_cpu_has(X86_FEATURE_ARAT) )
     {
@@ -96,9 +96,9 @@ bool_t lapic_timer_init(void)
         lapic_timer_on = pit_broadcast_exit;
     }
     else
-        return 0;
+        return false;
 
-    return 1;
+    return true;
 }
 
 static uint64_t (*__read_mostly tick_to_ns)(uint64_t) = acpi_pm_tick_to_ns;
@@ -106,7 +106,7 @@ static uint64_t (*__read_mostly tick_to_ns)(uint64_t) = acpi_pm_tick_to_ns;
 void (*__read_mostly pm_idle_save)(void);
 unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER - 1;
 integer_param("max_cstate", max_cstate);
-static bool_t __read_mostly local_apic_timer_c2_ok;
+static bool __read_mostly local_apic_timer_c2_ok;
 boolean_param("lapic_timer_c2_ok", local_apic_timer_c2_ok);
 
 struct acpi_processor_power *__read_mostly processor_powers[NR_CPUS];
@@ -373,7 +373,7 @@ void cpuidle_wakeup_mwait(cpumask_t *mask)
     cpumask_andnot(mask, mask, &target);
 }
 
-bool_t arch_skip_send_event_check(unsigned int cpu)
+bool arch_skip_send_event_check(unsigned int cpu)
 {
     /*
      * This relies on softirq_pending() and mwait_wakeup() to access data
@@ -489,7 +489,7 @@ void trace_exit_reason(u32 *irq_traced)
  * may not be sent if software enters core C6 during an interrupt service 
  * routine. So we don't enter deep Cx state if there is an EOI pending.
  */
-bool_t errata_c6_eoi_workaround(void)
+static bool errata_c6_eoi_workaround(void)
 {
     static int8_t fix_needed = -1;
 
@@ -1155,10 +1155,11 @@ long set_cx_pminfo(uint32_t cpu, struct xen_processor_power *power)
     cpu_id = get_cpu_id(cpu);
     if ( cpu_id == -1 )
     {
-        static bool_t warn_once = 1;
+        static bool warn_once = true;
+
         if ( warn_once || opt_cpu_info )
             printk(XENLOG_WARNING "No CPU ID for APIC ID %#x\n", cpu);
-        warn_once = 0;
+        warn_once = false;
         return -EINVAL;
     }
 
@@ -1335,7 +1336,7 @@ void cpuidle_disable_deep_cstate(void)
     hpet_disable_legacy_broadcast();
 }
 
-bool_t cpuidle_using_deep_cstate(void)
+bool cpuidle_using_deep_cstate(void)
 {
     return xen_cpuidle && max_cstate > (local_apic_timer_c2_ok ? 2 : 1);
 }
diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c
index 2e59c7f35e..1f8d02aab9 100644
--- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
+++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
@@ -55,7 +55,7 @@ struct acpi_cpufreq_data *cpufreq_drv_data[NR_CPUS];
 
 static struct cpufreq_driver acpi_cpufreq_driver;
 
-static bool_t __read_mostly acpi_pstate_strict;
+static bool __read_mostly acpi_pstate_strict;
 boolean_param("acpi_pstate_strict", acpi_pstate_strict);
 
 static int check_est_cpu(unsigned int cpuid)
diff --git a/xen/include/asm-x86/acpi.h b/xen/include/asm-x86/acpi.h
index 3ceee1ab36..27ecc654cb 100644
--- a/xen/include/asm-x86/acpi.h
+++ b/xen/include/asm-x86/acpi.h
@@ -76,9 +76,8 @@ int __acpi_release_global_lock(unsigned int *lock);
 	    :"=r"(n_hi), "=r"(n_lo)	\
 	    :"0"(n_hi), "1"(n_lo))
 
-extern bool_t acpi_lapic, acpi_ioapic, acpi_noirq;
-extern bool_t acpi_ht;
-extern bool acpi_force, acpi_disabled;
+extern bool acpi_lapic, acpi_ioapic, acpi_noirq;
+extern bool acpi_force, acpi_ht, acpi_disabled;
 extern u32 acpi_smi_cmd;
 extern u8 acpi_enable_value, acpi_disable_value;
 void acpi_pic_sci_set_trigger(unsigned int, u16);
diff --git a/xen/include/asm-x86/cpuidle.h b/xen/include/asm-x86/cpuidle.h
index 46e614bb50..08da01803f 100644
--- a/xen/include/asm-x86/cpuidle.h
+++ b/xen/include/asm-x86/cpuidle.h
@@ -10,7 +10,7 @@ extern struct acpi_processor_power *processor_powers[];
 
 extern void (*pm_idle_save)(void);
 
-bool_t lapic_timer_init(void);
+bool lapic_timer_init(void);
 extern void (*lapic_timer_off)(void);
 extern void (*lapic_timer_on)(void);
 
diff --git a/xen/include/asm-x86/softirq.h b/xen/include/asm-x86/softirq.h
index ec787d60c3..5c1a7db566 100644
--- a/xen/include/asm-x86/softirq.h
+++ b/xen/include/asm-x86/softirq.h
@@ -10,6 +10,6 @@
 #define HVM_DPCI_SOFTIRQ       (NR_COMMON_SOFTIRQS + 5)
 #define NR_ARCH_SOFTIRQS       6
 
-bool_t arch_skip_send_event_check(unsigned int cpu);
+bool arch_skip_send_event_check(unsigned int cpu);
 
 #endif /* __ASM_SOFTIRQ_H__ */
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 02/18] x86/apic.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/apic.c        | 30 +++++++++++++++---------------
 xen/include/asm-x86/apic.h |  4 ++--
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
index 8c6c2f5819..28a1ef8a58 100644
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -37,8 +37,8 @@
 #include <io_ports.h>
 #include <xen/kexec.h>
 
-static bool_t tdt_enabled __read_mostly;
-static bool_t tdt_enable __initdata = 1;
+static bool tdt_enabled __read_mostly;
+static bool tdt_enable __initdata = true;
 boolean_param("tdt", tdt_enable);
 
 static struct {
@@ -70,7 +70,7 @@ static s8 __initdata enable_local_apic; /* -1=force-disable, +1=force-enable */
  */
 u8 __read_mostly apic_verbosity;
 
-static bool_t __initdata opt_x2apic = 1;
+static bool __initdata opt_x2apic = true;
 boolean_param("x2apic", opt_x2apic);
 
 /*
@@ -79,8 +79,8 @@ boolean_param("x2apic", opt_x2apic);
  */
 static enum apic_mode apic_boot_mode = APIC_MODE_INVALID;
 
-bool_t __read_mostly x2apic_enabled = 0;
-bool_t __read_mostly directed_eoi_enabled = 0;
+bool __read_mostly x2apic_enabled = false;
+bool __read_mostly directed_eoi_enabled = false;
 
 static int modern_apic(void)
 {
@@ -130,9 +130,9 @@ void __init apic_intr_init(void)
 }
 
 /* Using APIC to generate smp_local_timer_interrupt? */
-static bool_t __read_mostly using_apic_timer;
+static bool __read_mostly using_apic_timer;
 
-static bool_t __read_mostly enabled_via_apicbase;
+static bool __read_mostly enabled_via_apicbase;
 
 int get_physical_broadcast(void)
 {
@@ -387,7 +387,7 @@ int __init verify_local_APIC(void)
         else
         {
             ioapic_ack_new = 0;
-            directed_eoi_enabled = 1;
+            directed_eoi_enabled = true;
             printk("Enabled directed EOI with ioapic_ack_old on!\n");
         }
     }
@@ -839,7 +839,7 @@ static int __init detect_init_APIC (void)
             msr_content &= ~MSR_IA32_APICBASE_BASE;
             msr_content |= MSR_IA32_APICBASE_ENABLE | APIC_DEFAULT_PHYS_BASE;
             wrmsrl(MSR_IA32_APICBASE, msr_content);
-            enabled_via_apicbase = 1;
+            enabled_via_apicbase = true;
         }
     }
     /*
@@ -945,7 +945,7 @@ void __init x2apic_bsp_setup(void)
 
     if ( !x2apic_enabled )
     {
-        x2apic_enabled = 1;
+        x2apic_enabled = true;
         __enable_x2apic();
     }
 
@@ -1176,7 +1176,7 @@ void __init setup_boot_APIC_clock(void)
 {
     unsigned long flags;
     apic_printk(APIC_VERBOSE, "Using local APIC timer interrupts.\n");
-    using_apic_timer = 1;
+    using_apic_timer = true;
 
     local_irq_save(flags);
 
@@ -1185,7 +1185,7 @@ void __init setup_boot_APIC_clock(void)
     if ( tdt_enable && boot_cpu_has(X86_FEATURE_TSC_DEADLINE) )
     {
         printk(KERN_DEBUG "TSC deadline timer enabled\n");
-        tdt_enabled = 1;
+        tdt_enabled = true;
     }
 
     setup_APIC_timer();
@@ -1258,12 +1258,12 @@ void apic_timer_interrupt(struct cpu_user_regs * regs)
     raise_softirq(TIMER_SOFTIRQ);
 }
 
-static DEFINE_PER_CPU(bool_t, state_dump_pending);
+static DEFINE_PER_CPU(bool, state_dump_pending);
 
 void smp_send_state_dump(unsigned int cpu)
 {
     /* We overload the spurious interrupt handler to handle the dump. */
-    per_cpu(state_dump_pending, cpu) = 1;
+    per_cpu(state_dump_pending, cpu) = true;
     send_IPI_mask(cpumask_of(cpu), SPURIOUS_APIC_VECTOR);
 }
 
@@ -1280,7 +1280,7 @@ void spurious_interrupt(struct cpu_user_regs *regs)
     if (apic_isr_read(SPURIOUS_APIC_VECTOR)) {
         ack_APIC_irq();
         if (this_cpu(state_dump_pending)) {
-            this_cpu(state_dump_pending) = 0;
+            this_cpu(state_dump_pending) = false;
             dump_execstate(regs);
             goto out;
         }
diff --git a/xen/include/asm-x86/apic.h b/xen/include/asm-x86/apic.h
index ea675b7f0a..9d7ec93042 100644
--- a/xen/include/asm-x86/apic.h
+++ b/xen/include/asm-x86/apic.h
@@ -29,8 +29,8 @@ enum apic_mode {
 };
 
 extern u8 apic_verbosity;
-extern bool_t x2apic_enabled;
-extern bool_t directed_eoi_enabled;
+extern bool x2apic_enabled;
+extern bool directed_eoi_enabled;
 
 void check_x2apic_preenabled(void);
 void x2apic_bsp_setup(void);
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 02/18] x86/apic.c: use plain bool

[Andrew Cooper]

On 30/06/17 18:01, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/arch/x86/apic.c        | 30 +++++++++++++++---------------
>  xen/include/asm-x86/apic.h |  4 ++--
>  2 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
> index 8c6c2f5819..28a1ef8a58 100644
> --- a/xen/arch/x86/apic.c
> +++ b/xen/arch/x86/apic.c
> @@ -37,8 +37,8 @@
>  #include <io_ports.h>
>  #include <xen/kexec.h>
>  
> -static bool_t tdt_enabled __read_mostly;
> -static bool_t tdt_enable __initdata = 1;
> +static bool tdt_enabled __read_mostly;
> +static bool tdt_enable __initdata = true;

As we are cleaning things up,

static bool __read_mostly tdt_enabled;
static bool __initdata tdt_enable = true;

>  boolean_param("tdt", tdt_enable);
>  
>  static struct {
> @@ -70,7 +70,7 @@ static s8 __initdata enable_local_apic; /* -1=force-disable, +1=force-enable */
>   */
>  u8 __read_mostly apic_verbosity;
>  
> -static bool_t __initdata opt_x2apic = 1;
> +static bool __initdata opt_x2apic = true;
>  boolean_param("x2apic", opt_x2apic);
>  
>  /*
> @@ -79,8 +79,8 @@ boolean_param("x2apic", opt_x2apic);
>   */
>  static enum apic_mode apic_boot_mode = APIC_MODE_INVALID;
>  
> -bool_t __read_mostly x2apic_enabled = 0;
> -bool_t __read_mostly directed_eoi_enabled = 0;
> +bool __read_mostly x2apic_enabled = false;
> +bool __read_mostly directed_eoi_enabled = false;

I believe the "= false" are redundant here.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 03/18] x86/debug.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/debug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/debug.c b/xen/arch/x86/debug.c
index 2070077ec5..a5d85a92f9 100644
--- a/xen/arch/x86/debug.c
+++ b/xen/arch/x86/debug.c
@@ -156,7 +156,7 @@ dbg_pv_va2mfn(dbgva_t vaddr, struct domain *dp, uint64_t pgd3val)
 /* Returns: number of bytes remaining to be copied */
 unsigned int dbg_rw_guest_mem(struct domain *dp, void * __user gaddr,
                               void * __user buf, unsigned int len,
-                              bool_t toaddr, uint64_t pgd3)
+                              bool toaddr, uint64_t pgd3)
 {
     while ( len > 0 )
     {
@@ -207,7 +207,7 @@ unsigned int dbg_rw_guest_mem(struct domain *dp, void * __user gaddr,
  * Returns: number of bytes remaining to be copied. 
  */
 unsigned int dbg_rw_mem(void * __user addr, void * __user buf,
-                        unsigned int len, domid_t domid, bool_t toaddr,
+                        unsigned int len, domid_t domid, bool toaddr,
                         uint64_t pgd3)
 {
     DBGP2("gmem:addr:%lx buf:%p len:$%u domid:%d toaddr:%x\n",
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 03/18] x86/debug.c: use plain bool

[Andrew Cooper]

On 30/06/17 18:01, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/arch/x86/debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/debug.c b/xen/arch/x86/debug.c
> index 2070077ec5..a5d85a92f9 100644
> --- a/xen/arch/x86/debug.c
> +++ b/xen/arch/x86/debug.c
> @@ -156,7 +156,7 @@ dbg_pv_va2mfn(dbgva_t vaddr, struct domain *dp, uint64_t pgd3val)
>  /* Returns: number of bytes remaining to be copied */
>  unsigned int dbg_rw_guest_mem(struct domain *dp, void * __user gaddr,
>                                void * __user buf, unsigned int len,
> -                              bool_t toaddr, uint64_t pgd3)
> +                              bool toaddr, uint64_t pgd3)

This can become static, while...

>  {
>      while ( len > 0 )
>      {
> @@ -207,7 +207,7 @@ unsigned int dbg_rw_guest_mem(struct domain *dp, void * __user gaddr,
>   * Returns: number of bytes remaining to be copied. 
>   */
>  unsigned int dbg_rw_mem(void * __user addr, void * __user buf,
> -                        unsigned int len, domid_t domid, bool_t toaddr,
> +                        unsigned int len, domid_t domid, bool toaddr,
>                          uint64_t pgd3)

this one has a prototype which needs updating.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>  {
>      DBGP2("gmem:addr:%lx buf:%p len:$%u domid:%d toaddr:%x\n",


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 04/18] x86/dmi.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/dmi_scan.c | 8 ++++----
 xen/include/xen/dmi.h   | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c
index 8564a77ea0..fcdf2d3952 100644
--- a/xen/arch/x86/dmi_scan.c
+++ b/xen/arch/x86/dmi_scan.c
@@ -183,8 +183,8 @@ static int __init dmi_table(paddr_t base, u32 len, int num,
 }
 
 
-static inline bool_t __init dmi_checksum(const void __iomem *buf,
-					 unsigned int len)
+static inline bool __init dmi_checksum(const void __iomem *buf,
+                                       unsigned int len)
 {
 	u8 sum = 0;
 	const u8 *p = buf;
@@ -753,10 +753,10 @@ fail:		d++;
  *	On return, year, month and day are guaranteed to be in the
  *	range of [0,9999], [0,12] and [0,31] respectively.
  */
-bool_t __init dmi_get_date(int field, int *yearp, int *monthp, int *dayp)
+bool __init dmi_get_date(int field, int *yearp, int *monthp, int *dayp)
 {
 	int year = 0, month = 0, day = 0;
-	bool_t exists;
+	bool exists;
 	const char *s, *e, *y;
 
 	s = field < DMI_STRING_MAX ? dmi_ident[field] : NULL;
diff --git a/xen/include/xen/dmi.h b/xen/include/xen/dmi.h
index df26d4b3e3..eba2c27b2f 100644
--- a/xen/include/xen/dmi.h
+++ b/xen/include/xen/dmi.h
@@ -36,7 +36,7 @@ extern int dmi_check_system(struct dmi_system_id *list);
 extern void dmi_scan_machine(void);
 extern const char *dmi_get_table(paddr_t *base, u32 *len);
 extern void dmi_efi_get_table(const void *smbios, const void *smbios3);
-bool_t dmi_get_date(int field, int *yearp, int *monthp, int *dayp);
+bool dmi_get_date(int field, int *yearp, int *monthp, int *dayp);
 extern void dmi_end_boot(void);
 
 #endif	/* __DMI_H__ */
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 05/18] x86/domctl: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/domctl.c | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index f40e989fd8..7fa58b49af 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -318,7 +318,7 @@ long arch_do_domctl(
     struct vcpu *curr = current;
     struct domain *currd = curr->domain;
     long ret = 0;
-    bool_t copyback = 0;
+    bool copyback = false;
     unsigned long i;
 
     switch ( domctl->cmd )
@@ -330,7 +330,7 @@ long arch_do_domctl(
         if ( ret == -ERESTART )
             return hypercall_create_continuation(__HYPERVISOR_arch_1,
                                                  "h", u_domctl);
-        copyback = 1;
+        copyback = true;
         break;
 
     case XEN_DOMCTL_ioport_permission:
@@ -405,7 +405,7 @@ long arch_do_domctl(
         spin_unlock(&d->page_alloc_lock);
 
         domctl->u.getmemlist.num_pfns = i;
-        copyback = 1;
+        copyback = true;
         break;
     }
 
@@ -576,7 +576,7 @@ long arch_do_domctl(
             ret = -EFAULT;
 
     gethvmcontext_out:
-        copyback = 1;
+        copyback = true;
         xfree(c.data);
         break;
     }
@@ -611,7 +611,7 @@ long arch_do_domctl(
     case XEN_DOMCTL_get_address_size:
         domctl->u.address_size.size = is_pv_32bit_domain(d) ? 32 :
                                                               BITS_PER_LONG;
-        copyback = 1;
+        copyback = true;
         break;
 
     case XEN_DOMCTL_set_machine_address_size:
@@ -623,7 +623,7 @@ long arch_do_domctl(
 
     case XEN_DOMCTL_get_machine_address_size:
         domctl->u.address_size.size = d->arch.physaddr_bitsize;
-        copyback = 1;
+        copyback = true;
         break;
 
     case XEN_DOMCTL_sendtrigger:
@@ -874,7 +874,7 @@ long arch_do_domctl(
 
             ret = 0;
             vcpu_unpause(v);
-            copyback = 1;
+            copyback = true;
         }
         else
         {
@@ -959,7 +959,7 @@ long arch_do_domctl(
                          &domctl->u.tsc_info.gtsc_khz,
                          &domctl->u.tsc_info.incarnation);
             domain_unpause(d);
-            copyback = 1;
+            copyback = true;
         }
         break;
 
@@ -1003,7 +1003,7 @@ long arch_do_domctl(
         domctl->u.gdbsx_guest_memio.remain = domctl->u.gdbsx_guest_memio.len;
         ret = gdbsx_guest_mem_io(domctl->domain, &domctl->u.gdbsx_guest_memio);
         if ( !ret )
-           copyback = 1;
+           copyback = true;
         break;
 
     case XEN_DOMCTL_gdbsx_pausevcpu:
@@ -1060,7 +1060,7 @@ long arch_do_domctl(
                 }
             }
         }
-        copyback = 1;
+        copyback = true;
         break;
     }
 
@@ -1220,7 +1220,7 @@ long arch_do_domctl(
 
     vcpuextstate_out:
         if ( domctl->cmd == XEN_DOMCTL_getvcpuextstate )
-            copyback = 1;
+            copyback = true;
         break;
     }
 
@@ -1238,7 +1238,7 @@ long arch_do_domctl(
                       &domctl->u.audit_p2m.orphans,
                       &domctl->u.audit_p2m.m2p_bad,
                       &domctl->u.audit_p2m.p2m_bad);
-            copyback = 1;
+            copyback = true;
         }
         break;
 #endif /* P2M_AUDIT */
@@ -1282,7 +1282,7 @@ long arch_do_domctl(
 
         if ( domctl->cmd == XEN_DOMCTL_get_vcpu_msrs )
         {
-            ret = 0; copyback = 1;
+            ret = 0; copyback = true;
 
             /* NULL guest handle is a request for max size. */
             if ( guest_handle_is_null(vmsrs->msrs) )
@@ -1379,7 +1379,7 @@ long arch_do_domctl(
             else
             {
                 vmsrs->msr_count = i;
-                copyback = 1;
+                copyback = true;
             }
         }
         break;
@@ -1407,7 +1407,7 @@ long arch_do_domctl(
 
         case XEN_DOMCTL_PSR_CMT_OP_QUERY_RMID:
             domctl->u.psr_cmt_op.data = d->arch.psr_rmid;
-            copyback = 1;
+            copyback = true;
             break;
 
         default:
@@ -1441,21 +1441,21 @@ long arch_do_domctl(
             ret = psr_get_l3_cbm(d, domctl->u.psr_cat_op.target,
                                  &domctl->u.psr_cat_op.data,
                                  PSR_CBM_TYPE_L3);
-            copyback = 1;
+            copyback = true;
             break;
 
         case XEN_DOMCTL_PSR_CAT_OP_GET_L3_CODE:
             ret = psr_get_l3_cbm(d, domctl->u.psr_cat_op.target,
                                  &domctl->u.psr_cat_op.data,
                                  PSR_CBM_TYPE_L3_CODE);
-            copyback = 1;
+            copyback = true;
             break;
 
         case XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA:
             ret = psr_get_l3_cbm(d, domctl->u.psr_cat_op.target,
                                  &domctl->u.psr_cat_op.data,
                                  PSR_CBM_TYPE_L3_DATA);
-            copyback = 1;
+            copyback = true;
             break;
 
         default:
@@ -1490,7 +1490,7 @@ void arch_get_info_guest(struct vcpu *v, vcpu_guest_context_u c)
 {
     unsigned int i;
     const struct domain *d = v->domain;
-    bool_t compat = is_pv_32bit_domain(d);
+    bool compat = is_pv_32bit_domain(d);
 #define c(fld) (!compat ? (c.nat->fld) : (c.cmp->fld))
 
     if ( !is_pv_domain(d) )
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 06/18] x86/hpet.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/hpet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index 7e8b438c0f..46f4c428a1 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -58,7 +58,7 @@ u8 __initdata hpet_flags;
  * if RTC interrupts are enabled. Enable this option if want to always enable
  * legacy hpet broadcast for deep C state
  */
-static bool_t __initdata force_hpet_broadcast;
+static bool __initdata force_hpet_broadcast;
 boolean_param("hpetbroadcast", force_hpet_broadcast);
 
 /*
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 07/18] x86/e820.c: use plan bool

[Wei Liu]

Note that e820_mtrr_clip remains s8 although the command line
parameter is bool, because it is a tristate variable.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/e820.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c
index bc1544a514..7c572bade2 100644
--- a/xen/arch/x86/e820.c
+++ b/xen/arch/x86/e820.c
@@ -29,7 +29,7 @@ static s8 __initdata e820_mtrr_clip = -1;
 boolean_param("e820-mtrr-clip", e820_mtrr_clip);
 
 /* opt_e820_verbose: Be verbose about clipping, the original e820, &c */
-static bool_t __initdata e820_verbose;
+static bool __initdata e820_verbose;
 boolean_param("e820-verbose", e820_verbose);
 
 struct e820map e820;
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 08/18] x86/i387.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/i387.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/i387.c b/xen/arch/x86/i387.c
index 9a172db5dc..88452522ad 100644
--- a/xen/arch/x86/i387.c
+++ b/xen/arch/x86/i387.c
@@ -22,7 +22,7 @@
 /* Restore x87 extended state */
 static inline void fpu_xrstor(struct vcpu *v, uint64_t mask)
 {
-    bool_t ok;
+    bool ok;
 
     ASSERT(v->arch.xsave_area);
     /*
@@ -135,7 +135,7 @@ static inline uint64_t vcpu_xsave_mask(const struct vcpu *v)
 /* Save x87 extended state */
 static inline void fpu_xsave(struct vcpu *v)
 {
-    bool_t ok;
+    bool ok;
     uint64_t mask = vcpu_xsave_mask(v);
 
     ASSERT(mask);
@@ -260,10 +260,10 @@ void vcpu_restore_fpu_lazy(struct vcpu *v)
  * On each context switch, save the necessary FPU info of VCPU being switch 
  * out. It dispatches saving operation based on CPU's capability.
  */
-static bool_t _vcpu_save_fpu(struct vcpu *v)
+static bool _vcpu_save_fpu(struct vcpu *v)
 {
     if ( !v->fpu_dirtied && !v->arch.nonlazy_xstate_used )
-        return 0;
+        return false;
 
     ASSERT(!is_idle_vcpu(v));
 
@@ -277,7 +277,7 @@ static bool_t _vcpu_save_fpu(struct vcpu *v)
 
     v->fpu_dirtied = 0;
 
-    return 1;
+    return true;
 }
 
 void vcpu_save_fpu(struct vcpu *v)
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 09/18] x86/i8259.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/i8259.c      | 10 +++++-----
 xen/include/asm-x86/irq.h |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c
index 07465aace8..166ca1a3e1 100644
--- a/xen/arch/x86/i8259.c
+++ b/xen/arch/x86/i8259.c
@@ -32,9 +32,9 @@
 
 static DEFINE_SPINLOCK(i8259A_lock);
 
-static bool_t _mask_and_ack_8259A_irq(unsigned int irq);
+static bool _mask_and_ack_8259A_irq(unsigned int irq);
 
-bool_t bogus_8259A_irq(unsigned int irq)
+bool bogus_8259A_irq(unsigned int irq)
 {
     return _mask_and_ack_8259A_irq(irq);
 }
@@ -193,11 +193,11 @@ static inline int i8259A_irq_real(unsigned int irq)
  * to the two 8259s is important!  Return a boolean
  * indicating whether the irq was genuine or spurious.
  */
-static bool_t _mask_and_ack_8259A_irq(unsigned int irq)
+static bool _mask_and_ack_8259A_irq(unsigned int irq)
 {
     unsigned int irqmask = 1 << irq;
     unsigned long flags;
-    bool_t is_real_irq = 1; /* Assume real unless spurious */
+    bool is_real_irq = true; /* Assume real unless spurious */
 
     spin_lock_irqsave(&i8259A_lock, flags);
 
@@ -218,7 +218,7 @@ static bool_t _mask_and_ack_8259A_irq(unsigned int irq)
      */
     if ((cached_irq_mask & irqmask) && !i8259A_irq_real(irq)) {
         static int spurious_irq_mask;
-        is_real_irq = 0;
+        is_real_irq = false;
         /* Report spurious IRQ, once per IRQ line. */
         if (!(spurious_irq_mask & irqmask)) {
             printk("spurious 8259A interrupt: IRQ%d.\n", irq);
diff --git a/xen/include/asm-x86/irq.h b/xen/include/asm-x86/irq.h
index 240c3e8bf2..38edc053f8 100644
--- a/xen/include/asm-x86/irq.h
+++ b/xen/include/asm-x86/irq.h
@@ -108,7 +108,7 @@ void mask_8259A(void);
 void unmask_8259A(void);
 void init_8259A(int aeoi);
 void make_8259A_irq(unsigned int irq);
-bool_t bogus_8259A_irq(unsigned int irq);
+bool bogus_8259A_irq(unsigned int irq);
 int i8259A_suspend(void);
 int i8259A_resume(void);
 
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 10/18] x86/monitor.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/monitor.c        | 20 ++++++++++----------
 xen/include/asm-x86/monitor.h |  2 +-
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c
index 764195a7d1..706454f23c 100644
--- a/xen/arch/x86/monitor.c
+++ b/xen/arch/x86/monitor.c
@@ -104,17 +104,17 @@ static int monitor_disable_msr(struct domain *d, u32 msr)
     return 0;
 }
 
-bool_t monitored_msr(const struct domain *d, u32 msr)
+bool monitored_msr(const struct domain *d, u32 msr)
 {
     const unsigned long *bitmap;
 
     if ( !d->arch.monitor.msr_bitmap )
-        return 0;
+        return false;
 
     bitmap = monitor_bitmap_for_msr(d, &msr);
 
     if ( !bitmap )
-        return 0;
+        return false;
 
     return test_bit(msr, bitmap);
 }
@@ -123,14 +123,14 @@ int arch_monitor_domctl_event(struct domain *d,
                               struct xen_domctl_monitor_op *mop)
 {
     struct arch_domain *ad = &d->arch;
-    bool_t requested_status = (XEN_DOMCTL_MONITOR_OP_ENABLE == mop->op);
+    bool requested_status = (XEN_DOMCTL_MONITOR_OP_ENABLE == mop->op);
 
     switch ( mop->event )
     {
     case XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG:
     {
         unsigned int ctrlreg_bitmask;
-        bool_t old_status;
+        bool old_status;
 
         if ( unlikely(mop->u.mov_to_cr.index >=
                       ARRAY_SIZE(ad->monitor.write_ctrlreg_mask)) )
@@ -183,7 +183,7 @@ int arch_monitor_domctl_event(struct domain *d,
 
     case XEN_DOMCTL_MONITOR_EVENT_MOV_TO_MSR:
     {
-        bool_t old_status;
+        bool old_status;
         int rc;
         u32 msr = mop->u.mov_to_msr.msr;
 
@@ -209,7 +209,7 @@ int arch_monitor_domctl_event(struct domain *d,
 
     case XEN_DOMCTL_MONITOR_EVENT_SINGLESTEP:
     {
-        bool_t old_status = ad->monitor.singlestep_enabled;
+        bool old_status = ad->monitor.singlestep_enabled;
 
         if ( unlikely(old_status == requested_status) )
             return -EEXIST;
@@ -243,7 +243,7 @@ int arch_monitor_domctl_event(struct domain *d,
 
     case XEN_DOMCTL_MONITOR_EVENT_SOFTWARE_BREAKPOINT:
     {
-        bool_t old_status = ad->monitor.software_breakpoint_enabled;
+        bool old_status = ad->monitor.software_breakpoint_enabled;
 
         if ( unlikely(old_status == requested_status) )
             return -EEXIST;
@@ -256,7 +256,7 @@ int arch_monitor_domctl_event(struct domain *d,
 
     case XEN_DOMCTL_MONITOR_EVENT_DEBUG_EXCEPTION:
     {
-        bool_t old_status = ad->monitor.debug_exception_enabled;
+        bool old_status = ad->monitor.debug_exception_enabled;
 
         if ( unlikely(old_status == requested_status) )
             return -EEXIST;
@@ -272,7 +272,7 @@ int arch_monitor_domctl_event(struct domain *d,
 
     case XEN_DOMCTL_MONITOR_EVENT_CPUID:
     {
-        bool_t old_status = ad->monitor.cpuid_enabled;
+        bool old_status = ad->monitor.cpuid_enabled;
 
         if ( unlikely(old_status == requested_status) )
             return -EEXIST;
diff --git a/xen/include/asm-x86/monitor.h b/xen/include/asm-x86/monitor.h
index 81a133b679..c5c323b6aa 100644
--- a/xen/include/asm-x86/monitor.h
+++ b/xen/include/asm-x86/monitor.h
@@ -96,6 +96,6 @@ int arch_monitor_init_domain(struct domain *d);
 
 void arch_monitor_cleanup_domain(struct domain *d);
 
-bool_t monitored_msr(const struct domain *d, u32 msr);
+bool monitored_msr(const struct domain *d, u32 msr);
 
 #endif /* __ASM_X86_MONITOR_H__ */
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 10/18] x86/monitor.c: use plain bool

[Andrew Cooper]

On 30/06/17 18:01, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

This file falls under introspection maintainership, so CC'ing them (not
that this change in controversial).

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 10/18] x86/monitor.c: use plain bool

[Razvan Cojocaru]

On 06/30/2017 08:45 PM, Andrew Cooper wrote:
> On 30/06/17 18:01, Wei Liu wrote:
>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> This file falls under introspection maintainership, so CC'ing them (not
> that this change in controversial).
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>


Thanks,
Razvan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 11/18] x86/xstate.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/xstate.c        | 30 +++++++++++++++---------------
 xen/include/asm-x86/xstate.h |  6 +++---
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c
index c2a722c60e..845208c189 100644
--- a/xen/arch/x86/xstate.c
+++ b/xen/arch/x86/xstate.c
@@ -37,7 +37,7 @@ static DEFINE_PER_CPU(uint64_t, xcr0);
 /* Because XCR0 is cached for each CPU, xsetbv() is not exposed. Users should 
  * use set_xcr0() instead.
  */
-static inline bool_t xsetbv(u32 index, u64 xfeatures)
+static inline bool xsetbv(u32 index, u64 xfeatures)
 {
     u32 hi = xfeatures >> 32;
     u32 lo = (u32)xfeatures;
@@ -54,12 +54,12 @@ static inline bool_t xsetbv(u32 index, u64 xfeatures)
     return lo != 0;
 }
 
-bool_t set_xcr0(u64 xfeatures)
+bool set_xcr0(u64 xfeatures)
 {
     if ( !xsetbv(XCR_XFEATURE_ENABLED_MASK, xfeatures) )
-        return 0;
+        return false;
     this_cpu(xcr0) = xfeatures;
-    return 1;
+    return true;
 }
 
 uint64_t get_xcr0(void)
@@ -86,7 +86,7 @@ uint64_t get_msr_xss(void)
     return this_cpu(xss);
 }
 
-static int setup_xstate_features(bool_t bsp)
+static int setup_xstate_features(bool bsp)
 {
     unsigned int leaf, eax, ebx, ecx, edx;
 
@@ -482,10 +482,10 @@ void xrstor(struct vcpu *v, uint64_t mask)
     }
 }
 
-bool_t xsave_enabled(const struct vcpu *v)
+bool xsave_enabled(const struct vcpu *v)
 {
     if ( !cpu_has_xsave )
-        return 0;
+        return false;
 
     ASSERT(xsave_cntxt_size >= XSTATE_AREA_MIN_SIZE);
     ASSERT(v->arch.xsave_area);
@@ -551,7 +551,7 @@ static unsigned int _xstate_ctxt_size(u64 xcr0)
 {
     u64 act_xcr0 = get_xcr0();
     u32 eax, ebx = 0, ecx, edx;
-    bool_t ok = set_xcr0(xcr0);
+    bool ok = set_xcr0(xcr0);
 
     ASSERT(ok);
     cpuid_count(XSTATE_CPUID, 0, &eax, &ebx, &ecx, &edx);
@@ -577,10 +577,10 @@ unsigned int xstate_ctxt_size(u64 xcr0)
 /* Collect the information of processor's extended state */
 void xstate_init(struct cpuinfo_x86 *c)
 {
-    static bool_t __initdata use_xsave = 1;
+    static bool __initdata use_xsave = true;
     boolean_param("xsave", use_xsave);
 
-    bool_t bsp = c == &boot_cpu_data;
+    bool bsp = c == &boot_cpu_data;
     u32 eax, ebx, ecx, edx;
     u64 feature_mask;
 
@@ -645,25 +645,25 @@ void xstate_init(struct cpuinfo_x86 *c)
         BUG();
 }
 
-static bool_t valid_xcr0(u64 xcr0)
+static bool valid_xcr0(u64 xcr0)
 {
     /* FP must be unconditionally set. */
     if ( !(xcr0 & XSTATE_FP) )
-        return 0;
+        return false;
 
     /* YMM depends on SSE. */
     if ( (xcr0 & XSTATE_YMM) && !(xcr0 & XSTATE_SSE) )
-        return 0;
+        return false;
 
     if ( xcr0 & (XSTATE_OPMASK | XSTATE_ZMM | XSTATE_HI_ZMM) )
     {
         /* OPMASK, ZMM, and HI_ZMM require YMM. */
         if ( !(xcr0 & XSTATE_YMM) )
-            return 0;
+            return false;
 
         /* OPMASK, ZMM, and HI_ZMM must be the same. */
         if ( ~xcr0 & (XSTATE_OPMASK | XSTATE_ZMM | XSTATE_HI_ZMM) )
-            return 0;
+            return false;
     }
 
     /* BNDREGS and BNDCSR must be the same. */
diff --git a/xen/include/asm-x86/xstate.h b/xen/include/asm-x86/xstate.h
index b31ad75bdb..d36f422b59 100644
--- a/xen/include/asm-x86/xstate.h
+++ b/xen/include/asm-x86/xstate.h
@@ -107,7 +107,7 @@ struct xstate_bndcsr {
 };
 
 /* extended state operations */
-bool_t __must_check set_xcr0(u64 xfeatures);
+bool __must_check set_xcr0(u64 xfeatures);
 uint64_t get_xcr0(void);
 void set_msr_xss(u64 xss);
 uint64_t get_msr_xss(void);
@@ -115,7 +115,7 @@ uint64_t read_bndcfgu(void);
 void xsave(struct vcpu *v, uint64_t mask);
 void xrstor(struct vcpu *v, uint64_t mask);
 void xstate_set_init(uint64_t mask);
-bool_t xsave_enabled(const struct vcpu *v);
+bool xsave_enabled(const struct vcpu *v);
 int __must_check validate_xstate(u64 xcr0, u64 xcr0_accum,
                                  const struct xsave_hdr *);
 int __must_check handle_xsetbv(u32 index, u64 new_bv);
@@ -128,7 +128,7 @@ int xstate_alloc_save_area(struct vcpu *v);
 void xstate_init(struct cpuinfo_x86 *c);
 unsigned int xstate_ctxt_size(u64 xcr0);
 
-static inline bool_t xstate_all(const struct vcpu *v)
+static inline bool xstate_all(const struct vcpu *v)
 {
     /*
      * XSTATE_FP_SSE may be excluded, because the offsets of XSTATE_FP_SSE
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 12/18] x86/srat.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/srat.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index d86783eddd..cd1283e58c 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -41,7 +41,7 @@ static struct node node_memblk_range[NR_NODE_MEMBLKS];
 static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS];
 static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS);
 
-static inline bool_t node_found(unsigned idx, unsigned pxm)
+static inline bool node_found(unsigned idx, unsigned pxm)
 {
 	return ((pxm2node[idx].pxm == pxm) &&
 		(pxm2node[idx].node != NUMA_NO_NODE));
@@ -65,7 +65,7 @@ nodeid_t setup_node(unsigned pxm)
 {
 	nodeid_t node;
 	unsigned idx;
-	static bool_t warned;
+	static bool warned;
 	static unsigned nodes_found;
 
 	BUILD_BUG_ON(MAX_NUMNODES >= NUMA_NO_NODE);
@@ -88,7 +88,7 @@ nodeid_t setup_node(unsigned pxm)
 	if (!warned) {
 		printk(KERN_WARNING "SRAT: Too many proximity domains (%#x)\n",
 		       pxm);
-		warned = 1;
+		warned = true;
 	}
 
 	return NUMA_NO_NODE;
@@ -311,8 +311,8 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 	if (i < 0)
 		/* everything fine */;
 	else if (memblk_nodeid[i] == node) {
-		bool_t mismatch = !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) !=
-		                  !test_bit(i, memblk_hotplug);
+		bool mismatch = !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) !=
+		                !test_bit(i, memblk_hotplug);
 
 		printk("%sSRAT: PXM %u (%"PRIx64"-%"PRIx64") overlaps with itself (%"PRIx64"-%"PRIx64")\n",
 		       mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end,
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 13/18] x86/smpboot.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/smpboot.c     | 5 +++--
 xen/arch/x86/time.c        | 2 +-
 xen/include/asm-x86/time.h | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index f375eb682d..8d91f6ca01 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -106,7 +106,7 @@ static void smp_store_cpu_info(int id)
  * TSC's upper 32 bits can't be written in earlier CPUs (before
  * Prescott), there is no way to resync one AP against BP.
  */
-bool_t disable_tsc_sync;
+bool disable_tsc_sync;
 
 static atomic_t tsc_count;
 static uint64_t tsc_value;
@@ -975,7 +975,8 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm)
     /* Physically added CPUs do not have synchronised TSC. */
     if ( boot_cpu_has(X86_FEATURE_TSC_RELIABLE) )
     {
-        static bool_t once_only;
+        static bool once_only;
+
         if ( !test_and_set_bool(once_only) )
             printk(XENLOG_WARNING
                    " ** New physical CPU %u may have skewed TSC and hence "
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 780baa55a3..b988b94d2e 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1568,7 +1568,7 @@ static void __init tsc_check_writability(void)
         cpuidle_disable_deep_cstate();
 
     /* synchronize_tsc_slave() must do nothing */
-    disable_tsc_sync = 1;
+    disable_tsc_sync = true;
 }
 
 static void __init reset_percpu_time(void *unused)
diff --git a/xen/include/asm-x86/time.h b/xen/include/asm-x86/time.h
index ef989a69b3..046302ef19 100644
--- a/xen/include/asm-x86/time.h
+++ b/xen/include/asm-x86/time.h
@@ -24,7 +24,7 @@
 
 typedef u64 cycles_t;
 
-extern bool_t disable_tsc_sync;
+extern bool disable_tsc_sync;
 
 static inline cycles_t get_cycles(void)
 {
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 14/18] x86/io_apic.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/apic.c           |  8 ++++----
 xen/arch/x86/io_apic.c        | 34 +++++++++++++++++-----------------
 xen/include/asm-x86/io_apic.h |  6 +++---
 3 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
index 28a1ef8a58..bcd8a7fd8b 100644
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -381,12 +381,12 @@ int __init verify_local_APIC(void)
      */
     if ( reg0 & APIC_LVR_DIRECTED_EOI )
     {
-        if ( ioapic_ack_new == 1 && ioapic_ack_forced == 1 )
+        if ( ioapic_ack_new && ioapic_ack_forced )
             printk("Not enabling directed EOI because ioapic_ack_new has been "
                    "forced on the command line\n");
         else
         {
-            ioapic_ack_new = 0;
+            ioapic_ack_new = false;
             directed_eoi_enabled = true;
             printk("Enabled directed EOI with ioapic_ack_old on!\n");
         }
@@ -1346,7 +1346,7 @@ int __init APIC_init_uniprocessor (void)
         setup_clear_cpu_cap(X86_FEATURE_APIC);
 
     if (!smp_found_config && !cpu_has_apic) {
-        skip_ioapic_setup = 1;
+        skip_ioapic_setup = true;
         return -1;
     }
 
@@ -1356,7 +1356,7 @@ int __init APIC_init_uniprocessor (void)
     if (!cpu_has_apic) {
         printk(KERN_ERR "BIOS bug, local APIC #%d not detected!...\n",
                boot_cpu_physical_apicid);
-        skip_ioapic_setup = 1;
+        skip_ioapic_setup = true;
         return -1;
     }
 
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index bd59e13fbb..29958dd475 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -43,9 +43,9 @@ static struct { int pin, apic; } ioapic_i8259 = { -1, -1 };
 
 static DEFINE_SPINLOCK(ioapic_lock);
 
-bool_t __read_mostly skip_ioapic_setup;
-bool_t __initdata ioapic_ack_new = 1;
-bool_t __initdata ioapic_ack_forced = 0;
+bool __read_mostly skip_ioapic_setup;
+bool __initdata ioapic_ack_new = true;
+bool __initdata ioapic_ack_forced;
 
 /*
  * # of IRQ routing registers
@@ -229,7 +229,7 @@ union entry_union {
 };
 
 struct IO_APIC_route_entry __ioapic_read_entry(
-    unsigned int apic, unsigned int pin, bool_t raw)
+    unsigned int apic, unsigned int pin, bool raw)
 {
     unsigned int (*read)(unsigned int, unsigned int)
         = raw ? __io_apic_read : io_apic_read;
@@ -240,7 +240,7 @@ struct IO_APIC_route_entry __ioapic_read_entry(
 }
 
 static struct IO_APIC_route_entry ioapic_read_entry(
-    unsigned int apic, unsigned int pin, bool_t raw)
+    unsigned int apic, unsigned int pin, bool raw)
 {
     struct IO_APIC_route_entry entry;
     unsigned long flags;
@@ -252,7 +252,7 @@ static struct IO_APIC_route_entry ioapic_read_entry(
 }
 
 void __ioapic_write_entry(
-    unsigned int apic, unsigned int pin, bool_t raw,
+    unsigned int apic, unsigned int pin, bool raw,
     struct IO_APIC_route_entry e)
 {
     void (*write)(unsigned int, unsigned int, unsigned int)
@@ -264,7 +264,7 @@ void __ioapic_write_entry(
 }
 
 static void ioapic_write_entry(
-    unsigned int apic, unsigned int pin, bool_t raw,
+    unsigned int apic, unsigned int pin, bool raw,
     struct IO_APIC_route_entry e)
 {
     unsigned long flags;
@@ -294,7 +294,7 @@ static void __io_apic_eoi(unsigned int apic, unsigned int vector, unsigned int p
         /* Else fake an EOI by switching to edge triggered mode
          * and back */
         struct IO_APIC_route_entry entry;
-        bool_t need_to_unmask = 0;
+        bool need_to_unmask = false;
 
         entry = __ioapic_read_entry(apic, pin, TRUE);
 
@@ -304,7 +304,7 @@ static void __io_apic_eoi(unsigned int apic, unsigned int vector, unsigned int p
              * a note to unmask it later */
             entry.mask = 1;
             __ioapic_write_entry(apic, pin, TRUE, entry);
-            need_to_unmask = 1;
+            need_to_unmask = true;
         }
 
         /* Flip the trigger mode to edge and back */
@@ -1094,7 +1094,7 @@ static inline void UNEXPECTED_IO_APIC(void)
 {
 }
 
-static void /*__init*/ __print_IO_APIC(bool_t boot)
+static void /*__init*/ __print_IO_APIC(bool boot)
 {
     int apic, i;
     union IO_APIC_reg_00 reg_00;
@@ -1585,20 +1585,20 @@ static void __init setup_ioapic_ack(char *s)
 {
     if ( !strcmp(s, "old") )
     {
-        ioapic_ack_new = 0;
-        ioapic_ack_forced = 1;
+        ioapic_ack_new = false;
+        ioapic_ack_forced = true;
     }
     else if ( !strcmp(s, "new") )
     {
-        ioapic_ack_new = 1;
-        ioapic_ack_forced = 1;
+        ioapic_ack_new = true;
+        ioapic_ack_forced = true;
     }
     else
         printk("Unknown ioapic_ack value specified: '%s'\n", s);
 }
 custom_param("ioapic_ack", setup_ioapic_ack);
 
-static bool_t io_apic_level_ack_pending(unsigned int irq)
+static bool io_apic_level_ack_pending(unsigned int irq)
 {
     struct irq_pin_list *entry;
     unsigned long flags;
@@ -2498,7 +2498,7 @@ void dump_ioapic_irq_info(void)
 static unsigned int __initdata max_gsi_irqs;
 integer_param("max_gsi_irqs", max_gsi_irqs);
 
-static __init bool_t bad_ioapic_register(unsigned int idx)
+static __init bool bad_ioapic_register(unsigned int idx)
 {
     union IO_APIC_reg_00 reg_00 = { .raw = io_apic_read(idx, 0) };
     union IO_APIC_reg_01 reg_01 = { .raw = io_apic_read(idx, 1) };
@@ -2532,7 +2532,7 @@ void __init init_ioapic_mappings(void)
                 printk(KERN_ERR "WARNING: bogus zero IO-APIC address "
                        "found in MPTABLE, disabling IO/APIC support!\n");
                 smp_found_config = 0;
-                skip_ioapic_setup = 1;
+                skip_ioapic_setup = true;
                 goto fake_ioapic_page;
             }
         }
diff --git a/xen/include/asm-x86/io_apic.h b/xen/include/asm-x86/io_apic.h
index 1706969c3a..557b3cfb23 100644
--- a/xen/include/asm-x86/io_apic.h
+++ b/xen/include/asm-x86/io_apic.h
@@ -169,9 +169,9 @@ static inline void io_apic_modify(unsigned int apic, unsigned int reg, unsigned
 }
 
 /* 1 if "noapic" boot option passed */
-extern bool_t skip_ioapic_setup;
-extern bool_t ioapic_ack_new;
-extern bool_t ioapic_ack_forced;
+extern bool skip_ioapic_setup;
+extern bool ioapic_ack_new;
+extern bool ioapic_ack_forced;
 
 extern int io_apic_get_unique_id (int ioapic, int apic_id);
 extern int io_apic_get_version (int ioapic);
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 14/18] x86/io_apic.c: use plain bool

[Andrew Cooper]

On 30/06/17 18:01, Wei Liu wrote:
> @@ -229,7 +229,7 @@ union entry_union {
>  };
>  
>  struct IO_APIC_route_entry __ioapic_read_entry(
> -    unsigned int apic, unsigned int pin, bool_t raw)
> +    unsigned int apic, unsigned int pin, bool raw)

Prototype.

>  {
>      unsigned int (*read)(unsigned int, unsigned int)
>          = raw ? __io_apic_read : io_apic_read;
> @@ -240,7 +240,7 @@ struct IO_APIC_route_entry __ioapic_read_entry(
>  }
>  
>  static struct IO_APIC_route_entry ioapic_read_entry(
> -    unsigned int apic, unsigned int pin, bool_t raw)
> +    unsigned int apic, unsigned int pin, bool raw)
>  {
>      struct IO_APIC_route_entry entry;
>      unsigned long flags;
> @@ -252,7 +252,7 @@ static struct IO_APIC_route_entry ioapic_read_entry(
>  }
>  
>  void __ioapic_write_entry(
> -    unsigned int apic, unsigned int pin, bool_t raw,
> +    unsigned int apic, unsigned int pin, bool raw,

Prototype.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 15/18] x86/mpparse.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/acpi/boot.c      |  4 ++--
 xen/arch/x86/genapic/bigsmp.c |  4 ++--
 xen/arch/x86/io_apic.c        |  2 +-
 xen/arch/x86/mpparse.c        | 25 +++++++++++--------------
 xen/include/asm-x86/mpspec.h  |  6 +++---
 5 files changed, 19 insertions(+), 22 deletions(-)

diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c
index 17ba3c39ac..004cb320ea 100644
--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -644,7 +644,7 @@ static void __init acpi_process_madt(void)
 			if (!error) {
 				acpi_ioapic = true;
 
-				smp_found_config = 1;
+				smp_found_config = true;
 				clustered_apic_check();
 			}
 		}
@@ -672,7 +672,7 @@ static void __init acpi_process_madt(void)
  * side effects of acpi_boot_init:
  *	acpi_lapic = true if LAPIC found
  *	acpi_ioapic = true if IOAPIC found
- *	if (acpi_lapic && acpi_ioapic) smp_found_config = 1;
+ *	if (acpi_lapic && acpi_ioapic) smp_found_config = true;
  *	...
  *
  * return value: (currently ignored)
diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c
index c250c8ee24..294902ba85 100644
--- a/xen/arch/x86/genapic/bigsmp.c
+++ b/xen/arch/x86/genapic/bigsmp.c
@@ -14,7 +14,7 @@
 static __init int force_bigsmp(struct dmi_system_id *d)
 {
 	printk(KERN_NOTICE "%s detected: force use of apic=bigsmp\n", d->ident);
-	def_to_bigsmp = 1;
+	def_to_bigsmp = true;
 	return 0;
 }
 
@@ -36,7 +36,7 @@ static __init int probe_bigsmp(void)
 	 */
 	if (acpi_gbl_FADT.flags &
 	    (ACPI_FADT_APIC_CLUSTER | ACPI_FADT_APIC_PHYSICAL))
-		def_to_bigsmp = 1;
+		def_to_bigsmp = true;
 	else if (!def_to_bigsmp)
 		dmi_check_system(bigsmp_dmi_table);
 	return def_to_bigsmp;
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index 29958dd475..2838f6bd99 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -2531,7 +2531,7 @@ void __init init_ioapic_mappings(void)
             {
                 printk(KERN_ERR "WARNING: bogus zero IO-APIC address "
                        "found in MPTABLE, disabling IO/APIC support!\n");
-                smp_found_config = 0;
+                smp_found_config = false;
                 skip_ioapic_setup = true;
                 goto fake_ioapic_page;
             }
diff --git a/xen/arch/x86/mpparse.c b/xen/arch/x86/mpparse.c
index efccde28c9..a1a0738a19 100644
--- a/xen/arch/x86/mpparse.c
+++ b/xen/arch/x86/mpparse.c
@@ -34,7 +34,7 @@
 #include <bios_ebda.h>
 
 /* Have we found an MP table */
-bool_t __initdata smp_found_config;
+bool __initdata smp_found_config;
 
 /*
  * Various Linux-internal data structures created from the
@@ -52,8 +52,8 @@ struct mpc_config_intsrc __read_mostly mp_irqs[MAX_IRQ_SOURCES];
 /* MP IRQ source entries */
 int __read_mostly mp_irq_entries;
 
-bool_t __read_mostly pic_mode;
-bool_t __read_mostly def_to_bigsmp = 0;
+bool __read_mostly pic_mode;
+bool __read_mostly def_to_bigsmp;
 unsigned long __read_mostly mp_lapic_addr;
 
 /* Processor that is doing the boot up */
@@ -119,7 +119,7 @@ static int __init mpf_checksum(unsigned char *mp, int len)
 
 /* Return xen's logical cpu_id of the new added cpu or <0 if error */
 static int MP_processor_info_x(struct mpc_config_processor *m,
-			       u32 apicid, bool_t hotplug)
+			       u32 apicid, bool hotplug)
 {
  	int ver, cpu = 0;
  	
@@ -178,7 +178,7 @@ static int MP_processor_info_x(struct mpc_config_processor *m,
 		 * No need for processor or APIC checks: physical delivery
 		 * (bigsmp) mode should always work.
 		 */
-		def_to_bigsmp = 1;
+		def_to_bigsmp = true;
 	}
 
 	return cpu;
@@ -591,10 +591,10 @@ void __init get_smp_config (void)
 	printk(KERN_INFO "Intel MultiProcessor Specification v1.%d\n", mpf->mpf_specification);
 	if (mpf->mpf_feature2 & (1<<7)) {
 		printk(KERN_INFO "    IMCR and PIC compatibility mode.\n");
-		pic_mode = 1;
+		pic_mode = true;
 	} else {
 		printk(KERN_INFO "    Virtual Wire compatibility mode.\n");
-		pic_mode = 0;
+		pic_mode = false;
 	}
 
 	/*
@@ -613,7 +613,7 @@ void __init get_smp_config (void)
 		 */
 		if (!smp_read_mpc((void *)(unsigned long)mpf->mpf_physptr)) {
 			efi_unmap_mpf();
-			smp_found_config = 0;
+			smp_found_config = false;
 			printk(KERN_ERR "BIOS bug, MP table errors detected!...\n");
 			printk(KERN_ERR "... disabling SMP support. (tell your hw vendor)\n");
 			return;
@@ -664,7 +664,7 @@ static int __init smp_scan_config (unsigned long base, unsigned long length)
 			((mpf->mpf_specification == 1)
 				|| (mpf->mpf_specification == 4)) ) {
 
-			smp_found_config = 1;
+			smp_found_config = true;
 			printk(KERN_INFO "found SMP MP-table at %08lx\n",
 						virt_to_maddr(mpf));
 #if 0
@@ -709,7 +709,7 @@ static void __init efi_check_config(void)
 	    mpf->mpf_length == 1 &&
 	    mpf_checksum((void *)mpf, 16) &&
 	    (mpf->mpf_specification == 1 || mpf->mpf_specification == 4)) {
-		smp_found_config = 1;
+		smp_found_config = true;
 		printk(KERN_INFO "SMP MP-table at %08lx\n", efi.mps);
 		mpf_found = mpf;
 	}
@@ -781,10 +781,7 @@ void __init mp_register_lapic_address (
 }
 
 
-int mp_register_lapic (
-	u32			id,
-	bool_t			enabled,
-	bool_t			hotplug)
+int mp_register_lapic(u32 id, bool enabled, bool hotplug)
 {
 	struct mpc_config_processor processor = {
 		.mpc_type = MP_PROCESSOR,
diff --git a/xen/include/asm-x86/mpspec.h b/xen/include/asm-x86/mpspec.h
index e3e6f50d9e..54fbeb55c2 100644
--- a/xen/include/asm-x86/mpspec.h
+++ b/xen/include/asm-x86/mpspec.h
@@ -7,9 +7,9 @@
 
 extern unsigned char mp_bus_id_to_type[MAX_MP_BUSSES];
 
-extern bool_t def_to_bigsmp;
+extern bool def_to_bigsmp;
 extern unsigned int boot_cpu_physical_apicid;
-extern bool_t smp_found_config;
+extern bool smp_found_config;
 extern void find_smp_config (void);
 extern void get_smp_config (void);
 extern unsigned char apic_version [MAX_APICS];
@@ -17,7 +17,7 @@ extern int mp_irq_entries;
 extern struct mpc_config_intsrc mp_irqs [MAX_IRQ_SOURCES];
 extern int mpc_default_type;
 extern unsigned long mp_lapic_addr;
-extern bool_t pic_mode;
+extern bool pic_mode;
 
 #ifdef CONFIG_ACPI
 extern int mp_register_lapic(u32 id, bool_t enabled, bool_t hotplug);
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 15/18] x86/mpparse.c: use plain bool

[Andrew Cooper]

On 30/06/17 18:01, Wei Liu wrote:
> @@ -781,10 +781,7 @@ void __init mp_register_lapic_address (
>  }
>  
>  
> -int mp_register_lapic (
> -	u32			id,
> -	bool_t			enabled,
> -	bool_t			hotplug)
> +int mp_register_lapic(u32 id, bool enabled, bool hotplug)

Prototype.  Otherwise, Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 16/18] x86/numa.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/numa.c        | 10 +++++-----
 xen/include/asm-x86/numa.h |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 6f4d438690..d45196fafc 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -49,7 +49,7 @@ cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly;
 
 nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
 
-bool_t numa_off = 0;
+bool numa_off;
 s8 acpi_numa = 0;
 
 int srat_disabled(void)
@@ -302,13 +302,13 @@ void numa_set_node(int cpu, nodeid_t node)
 static __init int numa_setup(char *opt) 
 { 
     if ( !strncmp(opt,"off",3) )
-        numa_off = 1;
+        numa_off = true;
     if ( !strncmp(opt,"on",2) )
-        numa_off = 0;
+        numa_off = false;
 #ifdef CONFIG_NUMA_EMU
     if ( !strncmp(opt, "fake=", 5) )
     {
-        numa_off = 0;
+        numa_off = false;
         numa_fake = simple_strtoul(opt+5,NULL,0);
         if ( numa_fake >= MAX_NUMNODES )
             numa_fake = MAX_NUMNODES;
@@ -317,7 +317,7 @@ static __init int numa_setup(char *opt)
 #ifdef CONFIG_ACPI_NUMA
     if ( !strncmp(opt,"noacpi",6) )
     {
-        numa_off = 0;
+        numa_off = false;
         acpi_numa = -1;
     }
 #endif
diff --git a/xen/include/asm-x86/numa.h b/xen/include/asm-x86/numa.h
index 24792381b4..bada2c0bb9 100644
--- a/xen/include/asm-x86/numa.h
+++ b/xen/include/asm-x86/numa.h
@@ -30,7 +30,7 @@ extern nodeid_t pxm_to_node(unsigned int pxm);
 
 extern void numa_add_cpu(int cpu);
 extern void numa_init_array(void);
-extern bool_t numa_off;
+extern bool numa_off;
 
 
 extern int srat_disabled(void);
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 17/18] x86/msi.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/msi.c        | 32 ++++++++++++++++----------------
 xen/include/asm-x86/msi.h |  6 +++---
 2 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index d98f400699..77998f4fb3 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -121,7 +121,7 @@ static void msix_put_fixmap(struct arch_msix *msix, int idx)
     spin_unlock(&msix->table_lock);
 }
 
-static bool_t memory_decoded(const struct pci_dev *dev)
+static bool memory_decoded(const struct pci_dev *dev)
 {
     u8 bus, slot, func;
 
@@ -142,13 +142,13 @@ static bool_t memory_decoded(const struct pci_dev *dev)
               PCI_COMMAND_MEMORY);
 }
 
-static bool_t msix_memory_decoded(const struct pci_dev *dev, unsigned int pos)
+static bool msix_memory_decoded(const struct pci_dev *dev, unsigned int pos)
 {
     u16 control = pci_conf_read16(dev->seg, dev->bus, PCI_SLOT(dev->devfn),
                                   PCI_FUNC(dev->devfn), msix_control_reg(pos));
 
     if ( !(control & PCI_MSIX_FLAGS_ENABLE) )
-        return 0;
+        return false;
 
     return memory_decoded(dev);
 }
@@ -191,7 +191,7 @@ void msi_compose_msg(unsigned vector, const cpumask_t *cpu_mask, struct msi_msg
                 MSI_DATA_VECTOR(vector);
 }
 
-static bool_t read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
+static bool read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
 {
     switch ( entry->msi_attrib.type )
     {
@@ -228,7 +228,7 @@ static bool_t read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
 
         if ( unlikely(!msix_memory_decoded(entry->dev,
                                            entry->msi_attrib.pos)) )
-            return 0;
+            return false;
         msg->address_lo = readl(base + PCI_MSIX_ENTRY_LOWER_ADDR_OFFSET);
         msg->address_hi = readl(base + PCI_MSIX_ENTRY_UPPER_ADDR_OFFSET);
         msg->data = readl(base + PCI_MSIX_ENTRY_DATA_OFFSET);
@@ -241,7 +241,7 @@ static bool_t read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
     if ( iommu_intremap )
         iommu_read_msi_from_ire(entry, msg);
 
-    return 1;
+    return true;
 }
 
 static int write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
@@ -383,13 +383,13 @@ int msi_maskable_irq(const struct msi_desc *entry)
            || entry->msi_attrib.maskbit;
 }
 
-static bool_t msi_set_mask_bit(struct irq_desc *desc, bool_t host, bool_t guest)
+static bool msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest)
 {
     struct msi_desc *entry = desc->msi_desc;
     struct pci_dev *pdev;
     u16 seg, control;
     u8 bus, slot, func;
-    bool_t flag = host || guest, maskall;
+    bool flag = host || guest, maskall;
 
     ASSERT(spin_is_locked(&desc->lock));
     BUG_ON(!entry || !entry->dev);
@@ -434,13 +434,13 @@ static bool_t msi_set_mask_bit(struct irq_desc *desc, bool_t host, bool_t guest)
             entry->msi_attrib.host_masked = host;
             entry->msi_attrib.guest_masked = guest;
 
-            flag = 1;
+            flag = true;
         }
         else if ( flag && !(control & PCI_MSIX_FLAGS_MASKALL) )
         {
             domid_t domid = pdev->domain->domain_id;
 
-            maskall = 1;
+            maskall = true;
             if ( pdev->msix->warned != domid )
             {
                 pdev->msix->warned = domid;
@@ -503,7 +503,7 @@ void unmask_msi_irq(struct irq_desc *desc)
         WARN();
 }
 
-void guest_mask_msi_irq(struct irq_desc *desc, bool_t mask)
+void guest_mask_msi_irq(struct irq_desc *desc, bool mask)
 {
     msi_set_mask_bit(desc, desc->msi_desc->msi_attrib.host_masked, mask);
 }
@@ -850,7 +850,7 @@ static int msix_capability_init(struct pci_dev *dev,
     u8 bus = dev->bus;
     u8 slot = PCI_SLOT(dev->devfn);
     u8 func = PCI_FUNC(dev->devfn);
-    bool_t maskall = msix->host_maskall;
+    bool maskall = msix->host_maskall;
 
     ASSERT(pcidevs_locked());
 
@@ -984,7 +984,7 @@ static int msix_capability_init(struct pci_dev *dev,
 
     if ( !msix->used_entries )
     {
-        maskall = 0;
+        maskall = false;
         if ( !msix->guest_maskall )
             control &= ~PCI_MSIX_FLAGS_MASKALL;
         else
@@ -1161,7 +1161,7 @@ static void __pci_disable_msix(struct msi_desc *entry)
                                            PCI_CAP_ID_MSIX);
     u16 control = pci_conf_read16(seg, bus, slot, func,
                                   msix_control_reg(entry->msi_attrib.pos));
-    bool_t maskall = dev->msix->host_maskall;
+    bool maskall = dev->msix->host_maskall;
 
     if ( unlikely(!(control & PCI_MSIX_FLAGS_ENABLE)) )
     {
@@ -1181,7 +1181,7 @@ static void __pci_disable_msix(struct msi_desc *entry)
                "cannot disable IRQ %d: masking MSI-X on %04x:%02x:%02x.%u\n",
                entry->irq, dev->seg, dev->bus,
                PCI_SLOT(dev->devfn), PCI_FUNC(dev->devfn));
-        maskall = 1;
+        maskall = true;
     }
     dev->msix->host_maskall = maskall;
     if ( maskall || dev->msix->guest_maskall )
@@ -1191,7 +1191,7 @@ static void __pci_disable_msix(struct msi_desc *entry)
     _pci_cleanup_msix(dev->msix);
 }
 
-int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bool_t off)
+int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bool off)
 {
     int rc;
     struct pci_dev *pdev;
diff --git a/xen/include/asm-x86/msi.h b/xen/include/asm-x86/msi.h
index 213ee53f72..37d37b820e 100644
--- a/xen/include/asm-x86/msi.h
+++ b/xen/include/asm-x86/msi.h
@@ -83,7 +83,7 @@ struct msi_desc;
 /* Helper functions */
 extern int pci_enable_msi(struct msi_info *msi, struct msi_desc **desc);
 extern void pci_disable_msi(struct msi_desc *desc);
-extern int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bool_t off);
+extern int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bool off);
 extern void pci_cleanup_msi(struct pci_dev *pdev);
 extern int setup_msi_irq(struct irq_desc *, struct msi_desc *);
 extern int __setup_msi_irq(struct irq_desc *, struct msi_desc *,
@@ -235,7 +235,7 @@ struct arch_msix {
     int table_refcnt[MAX_MSIX_TABLE_PAGES];
     int table_idx[MAX_MSIX_TABLE_PAGES];
     spinlock_t table_lock;
-    bool_t host_maskall, guest_maskall;
+    bool host_maskall, guest_maskall;
     domid_t warned;
 };
 
@@ -245,7 +245,7 @@ void msi_compose_msg(unsigned vector, const cpumask_t *mask,
 void __msi_set_enable(u16 seg, u8 bus, u8 slot, u8 func, int pos, int enable);
 void mask_msi_irq(struct irq_desc *);
 void unmask_msi_irq(struct irq_desc *);
-void guest_mask_msi_irq(struct irq_desc *, bool_t mask);
+void guest_mask_msi_irq(struct irq_desc *, bool mask);
 void ack_nonmaskable_msi_irq(struct irq_desc *);
 void end_nonmaskable_msi_irq(struct irq_desc *, u8 vector);
 void set_msi_affinity(struct irq_desc *, const cpumask_t *);
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 18/18] x86/psr.c: use plain bool

[Wei Liu]

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/psr.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 0b5073c41f..381f9a046d 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -270,7 +270,7 @@ static struct psr_cat_socket_info *get_cat_socket_info(unsigned int socket)
     return cat_socket_info + socket;
 }
 
-static inline bool_t cdp_is_enabled(unsigned int socket)
+static inline bool cdp_is_enabled(unsigned int socket)
 {
     return cdp_socket_enable && test_bit(socket, cdp_socket_enable);
 }
@@ -297,7 +297,7 @@ int psr_get_l3_cbm(struct domain *d, unsigned int socket,
                    uint64_t *cbm, enum cbm_type type)
 {
     struct psr_cat_socket_info *info = get_cat_socket_info(socket);
-    bool_t cdp_enabled = cdp_is_enabled(socket);
+    bool cdp_enabled = cdp_is_enabled(socket);
 
     if ( IS_ERR(info) )
         return PTR_ERR(info);
@@ -331,7 +331,7 @@ int psr_get_l3_cbm(struct domain *d, unsigned int socket,
     return 0;
 }
 
-static bool_t psr_check_cbm(unsigned int cbm_len, uint64_t cbm)
+static bool psr_check_cbm(unsigned int cbm_len, uint64_t cbm)
 {
     unsigned int first_bit, zero_bit;
 
@@ -357,7 +357,7 @@ static bool_t psr_check_cbm(unsigned int cbm_len, uint64_t cbm)
 struct cos_cbm_info
 {
     unsigned int cos;
-    bool_t cdp;
+    bool cdp;
     uint64_t cbm_code;
     uint64_t cbm_data;
 };
@@ -376,7 +376,7 @@ static void do_write_l3_cbm(void *data)
 }
 
 static int write_l3_cbm(unsigned int socket, unsigned int cos,
-                        uint64_t cbm_code, uint64_t cbm_data, bool_t cdp)
+                        uint64_t cbm_code, uint64_t cbm_data, bool cdp)
 {
     struct cos_cbm_info info =
     {
@@ -401,7 +401,7 @@ static int write_l3_cbm(unsigned int socket, unsigned int cos,
 }
 
 static int find_cos(struct psr_cat_cbm *map, unsigned int cos_max,
-                    uint64_t cbm_code, uint64_t cbm_data, bool_t cdp_enabled)
+                    uint64_t cbm_code, uint64_t cbm_data, bool cdp_enabled)
 {
     unsigned int cos;
 
@@ -440,7 +440,7 @@ int psr_set_l3_cbm(struct domain *d, unsigned int socket,
     unsigned int old_cos, cos_max;
     int cos, ret;
     uint64_t cbm_data, cbm_code;
-    bool_t cdp_enabled = cdp_is_enabled(socket);
+    bool cdp_enabled = cdp_is_enabled(socket);
     struct psr_cat_cbm *map;
     struct psr_cat_socket_info *info = get_cat_socket_info(socket);
 
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 00/18] x86: more bool_t to bool cleanup

[Andrew Cooper]

On 30/06/17 18:01, Wei Liu wrote:
> Seeing that bool_t keeps creeping back in new patches I think the only solution
> is to get rid of bool_t once and for all, as soon as possible.

Patches: 4-13, 16-18

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Patch 1 still hasn't arrived in my mailbox yet, so review in shorthand here:

Attribute order on:
static bool __initdata acpi_skip_timer_override;

Prototype for:
cpuidle_using_deep_cstate()

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 00/18] x86: more bool_t to bool cleanup

[Jan Beulich]

>>> On 30.06.17 at 19:01, <wei.liu2@citrix.com> wrote:
> Seeing that bool_t keeps creeping back in new patches I think the only solution
> is to get rid of bool_t once and for all, as soon as possible.

I don't fully agree, and considering the flood of patches you're
submitting in this area I think I finally need to voice my opinion
here (I had really meant to only do this in Budapest, on a BoF
I mean to propose): I appreciate you having and taking the
time to do this cleanup. Nevertheless I'm not overly happy with
it. For one, it requires time (even if not very much) to review.
And as you likely know, patch volume and review bandwidth
don't really fit together very well. (I had managed to deal with
all my old, non-RFC reviews during the last week, only to find
I'm again at almost 50 again this morning, and I haven't
finished working through the all the xen-devel traffic having
come in over the weekend. This is simply frustrating.)

It would perhaps be okay if no comments were needed at all,
but I think in all of the series you sent to this effect there were
further corrections necessary (leaving aside merely desirable
ones). Especially bulk cleanup work like this should introduce as
little overhead to others as possible. Hence the comments here
also apply to the PV code splitting work you've apparently
invested quite a bit of time into.

Furthermore there's the issue of backports: If cleanups like
these are being done over time (as code is being touched
anyway), backports (security and non-security ones) generally
go more smoothly.

But as said, I mean to bring the overall situation up in
Budapest, so I'm not sure how much of need should / needs
to be discussed up front via mail.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 00/18] x86: more bool_t to bool cleanup

[Wei Liu]

On Mon, Jul 03, 2017 at 02:10:03AM -0600, Jan Beulich wrote:
> >>> On 30.06.17 at 19:01, <wei.liu2@citrix.com> wrote:
> > Seeing that bool_t keeps creeping back in new patches I think the only solution
> > is to get rid of bool_t once and for all, as soon as possible.
> 
> I don't fully agree, and considering the flood of patches you're
> submitting in this area I think I finally need to voice my opinion
> here (I had really meant to only do this in Budapest, on a BoF
> I mean to propose): I appreciate you having and taking the
> time to do this cleanup. Nevertheless I'm not overly happy with
> it. For one, it requires time (even if not very much) to review.
> And as you likely know, patch volume and review bandwidth
> don't really fit together very well. (I had managed to deal with
> all my old, non-RFC reviews during the last week, only to find
> I'm again at almost 50 again this morning, and I haven't
> finished working through the all the xen-devel traffic having
> come in over the weekend. This is simply frustrating.)

I can see two aspects in your email. I want to step back and deconstruct
it a bit.

1. The cost / benefit of doing cleanup at once vs gradually (this
   series only)

You seem to think doing tree-wide cleanup in one go is a bad thing
because it will make backporting harder (from below).

I disagree. Changes are just changes. You and Andrew have done a lot of
changes in recent releases. They will also make backporting harder, but
you definitely think it is worthy of the effort.

It now all comes down to how one calculates cost / benefit. I prefer to
do things all at once so that we don't confuse future contributors and
save the need to point out the same issues over and over again. I value
consistency a lot.

Linux kernel has done this sort of tree-wide cleanups, Xen toolstack has
done it too (either by me or external contributors). I think we could do
the same thing for the hypervisor.

Obviously if you don't agree with this approach and my value
proposition, there is no point in me pursuing this further. I will let
you and Andrew figure out what is best suited. I just need a clear
answer from you two.

2. The limited bandwidth of reviewers

You seem to think more patches is a bad thing because you don't have
enough time to review all of them. I don't think there is an easy
solution and I share your frustration. We'd better discuss this during
the summit.

> 
> It would perhaps be okay if no comments were needed at all,

This is just impossible: 1. I can't read yours and Andrew's mind; 2. I
have my own opinions in certain areas - I will try to convince you or be
convinced, but that will require discussions.

> but I think in all of the series you sent to this effect there were
> further corrections necessary (leaving aside merely desirable
> ones). Especially bulk cleanup work like this should introduce as
> little overhead to others as possible. Hence the comments here
> also apply to the PV code splitting work you've apparently
> invested quite a bit of time into.
> 

I do try to be as careful as possible with the code -- I don't think I
ever broke the hypervisor too badly, if at all, in my recent work.  Now
I've mostly figured out what you and Andrew like patch-wise. If you
think of anything that can be done better, do let me know.

And frankly I didn't mean / want to do the cleanup in the first place --
I wanted to do another thing: PV in PVH. But the code as-is is just not
in the right shape to work with. As I went along, it gradually grew into
a useful project of its own right. To be clear, this is not to blame
anyone involved in the past or now. The constraints then were different
from the ones we have now.  I've foolishly signed myself up to this big
project because I think it is worth it. :-)

> Furthermore there's the issue of backports: If cleanups like
> these are being done over time (as code is being touched
> anyway), backports (security and non-security ones) generally
> go more smoothly.
> 
> But as said, I mean to bring the overall situation up in
> Budapest, so I'm not sure how much of need should / needs
> to be discussed up front via mail.
> 

I looked at the proposed session. It only covers the second aspect, so I
wrote this reply to at least make my first point across.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 00/18] x86: more bool_t to bool cleanup

[Jan Beulich]

>>> On 03.07.17 at 14:54, <wei.liu2@citrix.com> wrote:
> On Mon, Jul 03, 2017 at 02:10:03AM -0600, Jan Beulich wrote:
>> >>> On 30.06.17 at 19:01, <wei.liu2@citrix.com> wrote:
>> > Seeing that bool_t keeps creeping back in new patches I think the only 
> solution
>> > is to get rid of bool_t once and for all, as soon as possible.
>> 
>> I don't fully agree, and considering the flood of patches you're
>> submitting in this area I think I finally need to voice my opinion
>> here (I had really meant to only do this in Budapest, on a BoF
>> I mean to propose): I appreciate you having and taking the
>> time to do this cleanup. Nevertheless I'm not overly happy with
>> it. For one, it requires time (even if not very much) to review.
>> And as you likely know, patch volume and review bandwidth
>> don't really fit together very well. (I had managed to deal with
>> all my old, non-RFC reviews during the last week, only to find
>> I'm again at almost 50 again this morning, and I haven't
>> finished working through the all the xen-devel traffic having
>> come in over the weekend. This is simply frustrating.)
> 
> I can see two aspects in your email. I want to step back and deconstruct
> it a bit.
> 
> 1. The cost / benefit of doing cleanup at once vs gradually (this
>    series only)
> 
> You seem to think doing tree-wide cleanup in one go is a bad thing
> because it will make backporting harder (from below).
> 
> I disagree. Changes are just changes. You and Andrew have done a lot of
> changes in recent releases. They will also make backporting harder, but
> you definitely think it is worthy of the effort.

Yes and no. For example, take the integer type cleanup I did: I've
intentionally left untouched the u<nn> and s<nn> types because
there are still too many of them to reasonably replace them all.
The ones I did remove were either unused altogether, or had so
few instances left that a final cleanup was warranted.

> It now all comes down to how one calculates cost / benefit. I prefer to
> do things all at once so that we don't confuse future contributors and
> save the need to point out the same issues over and over again. I value
> consistency a lot.
> 
> Linux kernel has done this sort of tree-wide cleanups, Xen toolstack has
> done it too (either by me or external contributors). I think we could do
> the same thing for the hypervisor.
> 
> Obviously if you don't agree with this approach and my value
> proposition, there is no point in me pursuing this further. I will let
> you and Andrew figure out what is best suited. I just need a clear
> answer from you two.

Well, first of all it's not just Andrew and me. If everyone else
thought differently, even if the two of us agreed we would
probably better accept the other position. And then I don't want
you to give up altogether, and I had tried to make clear that I
value the time and work you've invested here. I certainly
appreciate the result, it is just that your separation in 1 and ...

> 2. The limited bandwidth of reviewers

... 2 can't possibly be a full one - it is also the process to get
there which matters, and hence I would view such broad
cleanup differently depending on other patch volume.

>> It would perhaps be okay if no comments were needed at all,
> 
> This is just impossible: 1. I can't read yours and Andrew's mind; 2. I
> have my own opinions in certain areas - I will try to convince you or be
> convinced, but that will require discussions.

Understood, but ...

>> but I think in all of the series you sent to this effect there were
>> further corrections necessary (leaving aside merely desirable
>> ones). Especially bulk cleanup work like this should introduce as
>> little overhead to others as possible. Hence the comments here
>> also apply to the PV code splitting work you've apparently
>> invested quite a bit of time into.
>> 
> 
> I do try to be as careful as possible with the code -- I don't think I
> ever broke the hypervisor too badly, if at all, in my recent work.  Now
> I've mostly figured out what you and Andrew like patch-wise. If you
> think of anything that can be done better, do let me know.

... while I certainly didn't mean to accuse you of anything, let alone
breaking the hypervisor, there were a few things which neither
would have resulted in breakage nor would have required mind
reading. Best example probably is when you touched definitions but
let declarations alone.

> And frankly I didn't mean / want to do the cleanup in the first place --
> I wanted to do another thing: PV in PVH. But the code as-is is just not
> in the right shape to work with. As I went along, it gradually grew into
> a useful project of its own right. To be clear, this is not to blame
> anyone involved in the past or now. The constraints then were different
> from the ones we have now.  I've foolishly signed myself up to this big
> project because I think it is worth it. :-)

Ah, I didn't realize that was the background even here; I did assume
that to be the background for the PV split work.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 00/18] x86: more bool_t to bool cleanup

[Wei Liu]

On Mon, Jul 03, 2017 at 07:19:21AM -0600, Jan Beulich wrote:
[...]
> > 
> > I do try to be as careful as possible with the code -- I don't think I
> > ever broke the hypervisor too badly, if at all, in my recent work.  Now
> > I've mostly figured out what you and Andrew like patch-wise. If you
> > think of anything that can be done better, do let me know.
> 
> ... while I certainly didn't mean to accuse you of anything, let alone
> breaking the hypervisor, there were a few things which neither
> would have resulted in breakage nor would have required mind
> reading. Best example probably is when you touched definitions but
> let declarations alone.
> 

Right. I make no excuse for the mistakes I made. I will be more careful
next time.

> > And frankly I didn't mean / want to do the cleanup in the first place --
> > I wanted to do another thing: PV in PVH. But the code as-is is just not
> > in the right shape to work with. As I went along, it gradually grew into
> > a useful project of its own right. To be clear, this is not to blame
> > anyone involved in the past or now. The constraints then were different
> > from the ones we have now.  I've foolishly signed myself up to this big
> > project because I think it is worth it. :-)
> 
> Ah, I didn't realize that was the background even here; I did assume
> that to be the background for the PV split work.
> 

It annoyed me a bit to see the code like that, but I can cope with the
inconsistency.

The rest is better to discuss during the summit.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel