From: Lorenzo Bianconi <lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lorenzo.bianconi-qxv4g6HH51o@public.gmane.org Subject: [PATCH 9/9] iio: humidity: hts221: move drdy enable logic in hts221_trig_set_state() Date: Sun, 9 Jul 2017 18:57:04 +0200 [thread overview] Message-ID: <20170709165704.26311-10-lorenzo.bianconi@st.com> (raw) In-Reply-To: <20170709165704.26311-1-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> Move data-ready configuration in hts221_buffer.c since it is only related to trigger logic Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> --- drivers/iio/humidity/hts221.h | 1 - drivers/iio/humidity/hts221_buffer.c | 8 +++++++- drivers/iio/humidity/hts221_core.c | 14 -------------- 3 files changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/iio/humidity/hts221.h b/drivers/iio/humidity/hts221.h index 0fbc89fe213d..2b4e5246447a 100644 --- a/drivers/iio/humidity/hts221.h +++ b/drivers/iio/humidity/hts221.h @@ -66,7 +66,6 @@ struct hts221_hw { extern const struct dev_pm_ops hts221_pm_ops; -int hts221_config_drdy(struct hts221_hw *hw, bool enable); int hts221_write_with_mask(struct hts221_hw *hw, u8 addr, u8 mask, u8 val); int hts221_probe(struct iio_dev *iio_dev); int hts221_set_enable(struct hts221_hw *hw, bool enable); diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c index f29f01a22375..9690dfe9a844 100644 --- a/drivers/iio/humidity/hts221_buffer.c +++ b/drivers/iio/humidity/hts221_buffer.c @@ -28,6 +28,8 @@ #define HTS221_REG_DRDY_HL_MASK BIT(7) #define HTS221_REG_DRDY_PP_OD_ADDR 0x22 #define HTS221_REG_DRDY_PP_OD_MASK BIT(6) +#define HTS221_REG_DRDY_EN_ADDR 0x22 +#define HTS221_REG_DRDY_EN_MASK BIT(2) #define HTS221_REG_STATUS_ADDR 0x27 #define HTS221_RH_DRDY_MASK BIT(1) #define HTS221_TEMP_DRDY_MASK BIT(0) @@ -36,8 +38,12 @@ static int hts221_trig_set_state(struct iio_trigger *trig, bool state) { struct iio_dev *iio_dev = iio_trigger_get_drvdata(trig); struct hts221_hw *hw = iio_priv(iio_dev); + int err; + + err = hts221_write_with_mask(hw, HTS221_REG_DRDY_EN_ADDR, + HTS221_REG_DRDY_EN_MASK, state); - return hts221_config_drdy(hw, state); + return err < 0 ? err : 0; } static const struct iio_trigger_ops hts221_trigger_ops = { diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index dfacf64a6f2e..12c2bc5954e4 100644 --- a/drivers/iio/humidity/hts221_core.c +++ b/drivers/iio/humidity/hts221_core.c @@ -23,7 +23,6 @@ #define HTS221_REG_CNTRL1_ADDR 0x20 #define HTS221_REG_CNTRL2_ADDR 0x21 -#define HTS221_REG_CNTRL3_ADDR 0x22 #define HTS221_REG_AVG_ADDR 0x10 #define HTS221_REG_H_OUT_L 0x28 @@ -36,9 +35,6 @@ #define HTS221_BDU_MASK BIT(2) #define HTS221_ENABLE_MASK BIT(7) -#define HTS221_DRDY_MASK BIT(2) - - /* calibration registers */ #define HTS221_REG_0RH_CAL_X_H 0x36 #define HTS221_REG_1RH_CAL_X_H 0x3a @@ -180,16 +176,6 @@ static int hts221_check_whoami(struct hts221_hw *hw) return 0; } -int hts221_config_drdy(struct hts221_hw *hw, bool enable) -{ - int err; - - err = hts221_write_with_mask(hw, HTS221_REG_CNTRL3_ADDR, - HTS221_DRDY_MASK, enable); - - return err < 0 ? err : 0; -} - static int hts221_update_odr(struct hts221_hw *hw, u8 odr) { int i, err; -- 2.13.1
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> To: jic23@kernel.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, lorenzo.bianconi@st.com Subject: [PATCH 9/9] iio: humidity: hts221: move drdy enable logic in hts221_trig_set_state() Date: Sun, 9 Jul 2017 18:57:04 +0200 [thread overview] Message-ID: <20170709165704.26311-10-lorenzo.bianconi@st.com> (raw) In-Reply-To: <20170709165704.26311-1-lorenzo.bianconi@st.com> Move data-ready configuration in hts221_buffer.c since it is only related to trigger logic Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> --- drivers/iio/humidity/hts221.h | 1 - drivers/iio/humidity/hts221_buffer.c | 8 +++++++- drivers/iio/humidity/hts221_core.c | 14 -------------- 3 files changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/iio/humidity/hts221.h b/drivers/iio/humidity/hts221.h index 0fbc89fe213d..2b4e5246447a 100644 --- a/drivers/iio/humidity/hts221.h +++ b/drivers/iio/humidity/hts221.h @@ -66,7 +66,6 @@ struct hts221_hw { extern const struct dev_pm_ops hts221_pm_ops; -int hts221_config_drdy(struct hts221_hw *hw, bool enable); int hts221_write_with_mask(struct hts221_hw *hw, u8 addr, u8 mask, u8 val); int hts221_probe(struct iio_dev *iio_dev); int hts221_set_enable(struct hts221_hw *hw, bool enable); diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c index f29f01a22375..9690dfe9a844 100644 --- a/drivers/iio/humidity/hts221_buffer.c +++ b/drivers/iio/humidity/hts221_buffer.c @@ -28,6 +28,8 @@ #define HTS221_REG_DRDY_HL_MASK BIT(7) #define HTS221_REG_DRDY_PP_OD_ADDR 0x22 #define HTS221_REG_DRDY_PP_OD_MASK BIT(6) +#define HTS221_REG_DRDY_EN_ADDR 0x22 +#define HTS221_REG_DRDY_EN_MASK BIT(2) #define HTS221_REG_STATUS_ADDR 0x27 #define HTS221_RH_DRDY_MASK BIT(1) #define HTS221_TEMP_DRDY_MASK BIT(0) @@ -36,8 +38,12 @@ static int hts221_trig_set_state(struct iio_trigger *trig, bool state) { struct iio_dev *iio_dev = iio_trigger_get_drvdata(trig); struct hts221_hw *hw = iio_priv(iio_dev); + int err; + + err = hts221_write_with_mask(hw, HTS221_REG_DRDY_EN_ADDR, + HTS221_REG_DRDY_EN_MASK, state); - return hts221_config_drdy(hw, state); + return err < 0 ? err : 0; } static const struct iio_trigger_ops hts221_trigger_ops = { diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index dfacf64a6f2e..12c2bc5954e4 100644 --- a/drivers/iio/humidity/hts221_core.c +++ b/drivers/iio/humidity/hts221_core.c @@ -23,7 +23,6 @@ #define HTS221_REG_CNTRL1_ADDR 0x20 #define HTS221_REG_CNTRL2_ADDR 0x21 -#define HTS221_REG_CNTRL3_ADDR 0x22 #define HTS221_REG_AVG_ADDR 0x10 #define HTS221_REG_H_OUT_L 0x28 @@ -36,9 +35,6 @@ #define HTS221_BDU_MASK BIT(2) #define HTS221_ENABLE_MASK BIT(7) -#define HTS221_DRDY_MASK BIT(2) - - /* calibration registers */ #define HTS221_REG_0RH_CAL_X_H 0x36 #define HTS221_REG_1RH_CAL_X_H 0x3a @@ -180,16 +176,6 @@ static int hts221_check_whoami(struct hts221_hw *hw) return 0; } -int hts221_config_drdy(struct hts221_hw *hw, bool enable) -{ - int err; - - err = hts221_write_with_mask(hw, HTS221_REG_CNTRL3_ADDR, - HTS221_DRDY_MASK, enable); - - return err < 0 ? err : 0; -} - static int hts221_update_odr(struct hts221_hw *hw, u8 odr) { int i, err; -- 2.13.1
next prev parent reply other threads:[~2017-07-09 16:57 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-09 16:56 [PATCH 0/9] hts221: add new features and fix power-off procedure Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-1-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 16:56 ` [PATCH 1/9] iio: humidity: hts221: refactor write_with_mask code Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-2-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:28 ` Jonathan Cameron 2017-07-09 18:28 ` Jonathan Cameron [not found] ` <20170709192827.2c343108-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:18 ` Lorenzo Bianconi 2017-07-09 21:18 ` Lorenzo Bianconi [not found] ` <CAA2SeNJmUFp7WaOsAEq+yLMSKrzQVkhmyMhB2OVWsbBAmv4nCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-10 20:47 ` Jonathan Cameron 2017-07-10 20:47 ` Jonathan Cameron 2017-07-09 16:56 ` [PATCH 2/9] iio: humidity: hts221: move BDU configuration in probe routine Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-3-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:29 ` Jonathan Cameron 2017-07-09 18:29 ` Jonathan Cameron 2017-07-09 16:56 ` [PATCH 3/9] iio: humidity: hts221: do not overwrite reserved data during power-down Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-4-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:30 ` Jonathan Cameron 2017-07-09 18:30 ` Jonathan Cameron [not found] ` <20170709193042.330fcd60-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:26 ` Lorenzo Bianconi 2017-07-09 21:26 ` Lorenzo Bianconi 2017-07-09 16:56 ` [PATCH 4/9] iio: humidity: hts221: avoid useless ODR reconfiguration Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-5-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:32 ` Jonathan Cameron 2017-07-09 18:32 ` Jonathan Cameron [not found] ` <20170709193208.6864b158-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:27 ` Lorenzo Bianconi 2017-07-09 21:27 ` Lorenzo Bianconi 2017-07-09 16:57 ` [PATCH 5/9] iio: humidity: hts221: support active-low interrupts Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-6-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:39 ` Jonathan Cameron 2017-07-09 18:39 ` Jonathan Cameron [not found] ` <20170709193951.14caff79-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-10 9:36 ` Marc Zyngier 2017-07-10 9:36 ` Marc Zyngier [not found] ` <ceef5860-91ee-a922-0dd7-8f2698192b9b-5wv7dgnIgG8@public.gmane.org> 2017-07-11 18:52 ` Jonathan Cameron 2017-07-11 18:52 ` Jonathan Cameron 2017-07-09 16:57 ` [PATCH 6/9] dt-bindings: " Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-7-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-11 2:49 ` Rob Herring 2017-07-11 2:49 ` Rob Herring 2017-07-09 16:57 ` [PATCH 7/9] iio: humidity: hts221: support open drain mode Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi 2017-07-09 16:57 ` [PATCH 8/9] dt-bindings: " Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-9-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-11 2:51 ` Rob Herring 2017-07-11 2:51 ` Rob Herring 2017-07-11 18:26 ` Jonathan Cameron 2017-07-11 18:26 ` Jonathan Cameron [not found] ` <20170711192656.7fd08a1c-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-11 18:42 ` Rob Herring 2017-07-11 18:42 ` Rob Herring [not found] ` <CAL_JsqJa7JeofpG=66AnVrTP4XtVrp9B4-QoLTyK08GzF4L5uQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-11 18:56 ` Jonathan Cameron 2017-07-11 18:56 ` Jonathan Cameron [not found] ` <0462CB71-6762-48F2-99B3-EA62FF81C280-tko9wxEg+fIOOJlXag/Snyp2UmYkHbXO@public.gmane.org> 2017-07-15 14:32 ` Lorenzo Bianconi 2017-07-15 14:32 ` Lorenzo Bianconi [not found] ` <CAA2SeN+2T2-G1khRNpNzccesX=cip0ConT11RJRV-HB8Ojk0pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-17 11:49 ` Jonathan Cameron 2017-07-17 11:49 ` Jonathan Cameron 2017-07-09 16:57 ` Lorenzo Bianconi [this message] 2017-07-09 16:57 ` [PATCH 9/9] iio: humidity: hts221: move drdy enable logic in hts221_trig_set_state() Lorenzo Bianconi [not found] ` <20170709165704.26311-10-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:41 ` Jonathan Cameron 2017-07-09 18:41 ` Jonathan Cameron [not found] ` <20170709194123.39fd6914-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:28 ` Lorenzo Bianconi 2017-07-09 21:28 ` Lorenzo Bianconi [not found] ` <CAA2SeNLhBbTbMGDHyXGN02V4n0RHrwK-Bg0D_q9phpcEa3e7Rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-16 9:45 ` Lorenzo Bianconi 2017-07-16 9:45 ` Lorenzo Bianconi [not found] ` <CAA2SeNK6dd=myMk59j1To9GtvBaj1T8XXwcaqrtO8V5s-bM5WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-16 19:50 ` Jonathan Cameron 2017-07-16 19:50 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170709165704.26311-10-lorenzo.bianconi@st.com \ --to=lorenzo.bianconi83-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=lorenzo.bianconi-qxv4g6HH51o@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.