From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Lorenzo Bianconi <lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lorenzo BIANCONI <lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> Subject: Re: [PATCH 1/9] iio: humidity: hts221: refactor write_with_mask code Date: Mon, 10 Jul 2017 21:47:46 +0100 [thread overview] Message-ID: <20170710214746.39ea98f9@kernel.org> (raw) In-Reply-To: <CAA2SeNJmUFp7WaOsAEq+yLMSKrzQVkhmyMhB2OVWsbBAmv4nCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Sun, 9 Jul 2017 23:18:47 +0200 Lorenzo Bianconi <lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > On Sun, 9 Jul 2017 18:56:56 +0200 > > Lorenzo Bianconi <lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > > >> Move bit-shift in hts221_write_with_mask() instead of coding > >> the shift depth in the configured value. That change will be necessary > >> to fix an issue in device power-down procedure > >> > >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> > > A could of questions inline. > > Hi Jonathan, > > Thanks for quick review :) > > > > > Jonathan > >> --- > >> drivers/iio/humidity/hts221_core.c | 74 +++++++++++++++++--------------------- > >> 1 file changed, 32 insertions(+), 42 deletions(-) > >> > >> diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c > >> index a56da3999e00..f5181e4e1eff 100644 > >> --- a/drivers/iio/humidity/hts221_core.c > >> +++ b/drivers/iio/humidity/hts221_core.c > >> @@ -32,30 +32,12 @@ > >> #define HTS221_HUMIDITY_AVG_MASK 0x07 > >> #define HTS221_TEMP_AVG_MASK 0x38 > >> > >> -#define HTS221_ODR_MASK 0x87 > >> +#define HTS221_ODR_MASK 0x03 > >> #define HTS221_BDU_MASK BIT(2) > >> +#define HTS221_ENABLE_MASK BIT(7) > >> > >> #define HTS221_DRDY_MASK BIT(2) > >> > >> -#define HTS221_ENABLE_SENSOR BIT(7) > >> - > >> -#define HTS221_HUMIDITY_AVG_4 0x00 /* 0.4 %RH */ > >> -#define HTS221_HUMIDITY_AVG_8 0x01 /* 0.3 %RH */ > >> -#define HTS221_HUMIDITY_AVG_16 0x02 /* 0.2 %RH */ > >> -#define HTS221_HUMIDITY_AVG_32 0x03 /* 0.15 %RH */ > >> -#define HTS221_HUMIDITY_AVG_64 0x04 /* 0.1 %RH */ > >> -#define HTS221_HUMIDITY_AVG_128 0x05 /* 0.07 %RH */ > >> -#define HTS221_HUMIDITY_AVG_256 0x06 /* 0.05 %RH */ > >> -#define HTS221_HUMIDITY_AVG_512 0x07 /* 0.03 %RH */ > >> - > >> -#define HTS221_TEMP_AVG_2 0x00 /* 0.08 degC */ > >> -#define HTS221_TEMP_AVG_4 0x08 /* 0.05 degC */ > >> -#define HTS221_TEMP_AVG_8 0x10 /* 0.04 degC */ > >> -#define HTS221_TEMP_AVG_16 0x18 /* 0.03 degC */ > >> -#define HTS221_TEMP_AVG_32 0x20 /* 0.02 degC */ > >> -#define HTS221_TEMP_AVG_64 0x28 /* 0.015 degC */ > >> -#define HTS221_TEMP_AVG_128 0x30 /* 0.01 degC */ > >> -#define HTS221_TEMP_AVG_256 0x38 /* 0.007 degC */ > >> > >> /* calibration registers */ > >> #define HTS221_REG_0RH_CAL_X_H 0x36 > >> @@ -90,28 +72,28 @@ static const struct hts221_avg hts221_avg_list[] = { > >> .addr = HTS221_REG_AVG_ADDR, > >> .mask = HTS221_HUMIDITY_AVG_MASK, > >> .avg_avl = { > >> - { 4, HTS221_HUMIDITY_AVG_4 }, > >> - { 8, HTS221_HUMIDITY_AVG_8 }, > >> - { 16, HTS221_HUMIDITY_AVG_16 }, > >> - { 32, HTS221_HUMIDITY_AVG_32 }, > >> - { 64, HTS221_HUMIDITY_AVG_64 }, > >> - { 128, HTS221_HUMIDITY_AVG_128 }, > >> - { 256, HTS221_HUMIDITY_AVG_256 }, > >> - { 512, HTS221_HUMIDITY_AVG_512 }, > >> + { 4, 0x0 }, /* 0.4 %RH */ > >> + { 8, 0x1 }, /* 0.3 %RH */ > >> + { 16, 0x2 }, /* 0.2 %RH */ > >> + { 32, 0x3 }, /* 0.15 %RH */ > >> + { 64, 0x4 }, /* 0.1 %RH */ > >> + { 128, 0x5 }, /* 0.07 %RH */ > >> + { 256, 0x6 }, /* 0.05 %RH */ > >> + { 512, 0x7 }, /* 0.03 %RH */ > >> }, > >> }, > >> { > >> .addr = HTS221_REG_AVG_ADDR, > >> .mask = HTS221_TEMP_AVG_MASK, > >> .avg_avl = { > >> - { 2, HTS221_TEMP_AVG_2 }, > >> - { 4, HTS221_TEMP_AVG_4 }, > >> - { 8, HTS221_TEMP_AVG_8 }, > >> - { 16, HTS221_TEMP_AVG_16 }, > >> - { 32, HTS221_TEMP_AVG_32 }, > >> - { 64, HTS221_TEMP_AVG_64 }, > >> - { 128, HTS221_TEMP_AVG_128 }, > >> - { 256, HTS221_TEMP_AVG_256 }, > >> + { 2, 0x0 }, /* 0.08 degC */ > >> + { 4, 0x1 }, /* 0.05 degC */ > >> + { 8, 0x2 }, /* 0.04 degC */ > >> + { 16, 0x3 }, /* 0.03 degC */ > >> + { 32, 0x4 }, /* 0.02 degC */ > >> + { 64, 0x5 }, /* 0.015 degC */ > >> + { 128, 0x6 }, /* 0.01 degC */ > >> + { 256, 0x7 }, /* 0.007 degC */ > > Could we potentially use the index directly here rather than > > having to explicitly store it? Would be more elegant perhaps.. > > Ack, will do in v2 > > >> }, > >> }, > >> }; > >> @@ -166,7 +148,7 @@ static int hts221_write_with_mask(struct hts221_hw *hw, u8 addr, u8 mask, > >> goto unlock; > >> } > >> > >> - data = (data & ~mask) | (val & mask); > >> + data = (data & ~mask) | ((val << __ffs(mask)) & mask); > >> > >> err = hw->tf->write(hw->dev, addr, sizeof(data), &data); > >> if (err < 0) > >> @@ -201,11 +183,10 @@ static int hts221_check_whoami(struct hts221_hw *hw) > >> > >> int hts221_config_drdy(struct hts221_hw *hw, bool enable) > >> { > >> - u8 val = enable ? BIT(2) : 0; > >> int err; > >> > >> err = hts221_write_with_mask(hw, HTS221_REG_CNTRL3_ADDR, > >> - HTS221_DRDY_MASK, val); > >> + HTS221_DRDY_MASK, enable); > >> > >> return err < 0 ? err : 0; > >> } > >> @@ -213,7 +194,6 @@ int hts221_config_drdy(struct hts221_hw *hw, bool enable) > >> static int hts221_update_odr(struct hts221_hw *hw, u8 odr) > >> { > >> int i, err; > >> - u8 val; > >> > >> for (i = 0; i < ARRAY_SIZE(hts221_odr_table); i++) > >> if (hts221_odr_table[i].hz == odr) > >> @@ -222,9 +202,19 @@ static int hts221_update_odr(struct hts221_hw *hw, u8 odr) > >> if (i == ARRAY_SIZE(hts221_odr_table)) > >> return -EINVAL; > >> > >> - val = HTS221_ENABLE_SENSOR | HTS221_BDU_MASK | hts221_odr_table[i].val; > >> + /* enable Block Data Update */ > >> + err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR, > >> + HTS221_BDU_MASK, 1); > >> + if (err < 0) > >> + return err; > >> + > >> + err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR, > >> + HTS221_ODR_MASK, hts221_odr_table[i].val); > >> + if (err < 0) > >> + return err; > >> + > >> err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR, > >> - HTS221_ODR_MASK, val); > > This original code looks like a bug given the odr mask should only > > cover the odr bits, not the enable and bdu. > > > > Am I missing something? > > Base on hts221_write_with_mask() code the original mask covers odr, > bdu and enable fields in CNTRL1 register. Ah. That makes sense even if it's rather less elegant than the new code! Thanks for clearing that up. Jonathan > > > > > Taking one write and changing it to 3 isn't that nice, but I guess > > we aren't in a fast path here so fair enough given the cleaner > > resulting code. > >> + HTS221_ENABLE_MASK, 1); > >> if (err < 0) > >> return err; > >> > > > > Regards, > Lorenzo > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Lorenzo BIANCONI <lorenzo.bianconi@st.com> Subject: Re: [PATCH 1/9] iio: humidity: hts221: refactor write_with_mask code Date: Mon, 10 Jul 2017 21:47:46 +0100 [thread overview] Message-ID: <20170710214746.39ea98f9@kernel.org> (raw) In-Reply-To: <CAA2SeNJmUFp7WaOsAEq+yLMSKrzQVkhmyMhB2OVWsbBAmv4nCg@mail.gmail.com> On Sun, 9 Jul 2017 23:18:47 +0200 Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote: > > On Sun, 9 Jul 2017 18:56:56 +0200 > > Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote: > > > >> Move bit-shift in hts221_write_with_mask() instead of coding > >> the shift depth in the configured value. That change will be necessary > >> to fix an issue in device power-down procedure > >> > >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> > > A could of questions inline. > > Hi Jonathan, > > Thanks for quick review :) > > > > > Jonathan > >> --- > >> drivers/iio/humidity/hts221_core.c | 74 +++++++++++++++++--------------------- > >> 1 file changed, 32 insertions(+), 42 deletions(-) > >> > >> diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c > >> index a56da3999e00..f5181e4e1eff 100644 > >> --- a/drivers/iio/humidity/hts221_core.c > >> +++ b/drivers/iio/humidity/hts221_core.c > >> @@ -32,30 +32,12 @@ > >> #define HTS221_HUMIDITY_AVG_MASK 0x07 > >> #define HTS221_TEMP_AVG_MASK 0x38 > >> > >> -#define HTS221_ODR_MASK 0x87 > >> +#define HTS221_ODR_MASK 0x03 > >> #define HTS221_BDU_MASK BIT(2) > >> +#define HTS221_ENABLE_MASK BIT(7) > >> > >> #define HTS221_DRDY_MASK BIT(2) > >> > >> -#define HTS221_ENABLE_SENSOR BIT(7) > >> - > >> -#define HTS221_HUMIDITY_AVG_4 0x00 /* 0.4 %RH */ > >> -#define HTS221_HUMIDITY_AVG_8 0x01 /* 0.3 %RH */ > >> -#define HTS221_HUMIDITY_AVG_16 0x02 /* 0.2 %RH */ > >> -#define HTS221_HUMIDITY_AVG_32 0x03 /* 0.15 %RH */ > >> -#define HTS221_HUMIDITY_AVG_64 0x04 /* 0.1 %RH */ > >> -#define HTS221_HUMIDITY_AVG_128 0x05 /* 0.07 %RH */ > >> -#define HTS221_HUMIDITY_AVG_256 0x06 /* 0.05 %RH */ > >> -#define HTS221_HUMIDITY_AVG_512 0x07 /* 0.03 %RH */ > >> - > >> -#define HTS221_TEMP_AVG_2 0x00 /* 0.08 degC */ > >> -#define HTS221_TEMP_AVG_4 0x08 /* 0.05 degC */ > >> -#define HTS221_TEMP_AVG_8 0x10 /* 0.04 degC */ > >> -#define HTS221_TEMP_AVG_16 0x18 /* 0.03 degC */ > >> -#define HTS221_TEMP_AVG_32 0x20 /* 0.02 degC */ > >> -#define HTS221_TEMP_AVG_64 0x28 /* 0.015 degC */ > >> -#define HTS221_TEMP_AVG_128 0x30 /* 0.01 degC */ > >> -#define HTS221_TEMP_AVG_256 0x38 /* 0.007 degC */ > >> > >> /* calibration registers */ > >> #define HTS221_REG_0RH_CAL_X_H 0x36 > >> @@ -90,28 +72,28 @@ static const struct hts221_avg hts221_avg_list[] = { > >> .addr = HTS221_REG_AVG_ADDR, > >> .mask = HTS221_HUMIDITY_AVG_MASK, > >> .avg_avl = { > >> - { 4, HTS221_HUMIDITY_AVG_4 }, > >> - { 8, HTS221_HUMIDITY_AVG_8 }, > >> - { 16, HTS221_HUMIDITY_AVG_16 }, > >> - { 32, HTS221_HUMIDITY_AVG_32 }, > >> - { 64, HTS221_HUMIDITY_AVG_64 }, > >> - { 128, HTS221_HUMIDITY_AVG_128 }, > >> - { 256, HTS221_HUMIDITY_AVG_256 }, > >> - { 512, HTS221_HUMIDITY_AVG_512 }, > >> + { 4, 0x0 }, /* 0.4 %RH */ > >> + { 8, 0x1 }, /* 0.3 %RH */ > >> + { 16, 0x2 }, /* 0.2 %RH */ > >> + { 32, 0x3 }, /* 0.15 %RH */ > >> + { 64, 0x4 }, /* 0.1 %RH */ > >> + { 128, 0x5 }, /* 0.07 %RH */ > >> + { 256, 0x6 }, /* 0.05 %RH */ > >> + { 512, 0x7 }, /* 0.03 %RH */ > >> }, > >> }, > >> { > >> .addr = HTS221_REG_AVG_ADDR, > >> .mask = HTS221_TEMP_AVG_MASK, > >> .avg_avl = { > >> - { 2, HTS221_TEMP_AVG_2 }, > >> - { 4, HTS221_TEMP_AVG_4 }, > >> - { 8, HTS221_TEMP_AVG_8 }, > >> - { 16, HTS221_TEMP_AVG_16 }, > >> - { 32, HTS221_TEMP_AVG_32 }, > >> - { 64, HTS221_TEMP_AVG_64 }, > >> - { 128, HTS221_TEMP_AVG_128 }, > >> - { 256, HTS221_TEMP_AVG_256 }, > >> + { 2, 0x0 }, /* 0.08 degC */ > >> + { 4, 0x1 }, /* 0.05 degC */ > >> + { 8, 0x2 }, /* 0.04 degC */ > >> + { 16, 0x3 }, /* 0.03 degC */ > >> + { 32, 0x4 }, /* 0.02 degC */ > >> + { 64, 0x5 }, /* 0.015 degC */ > >> + { 128, 0x6 }, /* 0.01 degC */ > >> + { 256, 0x7 }, /* 0.007 degC */ > > Could we potentially use the index directly here rather than > > having to explicitly store it? Would be more elegant perhaps.. > > Ack, will do in v2 > > >> }, > >> }, > >> }; > >> @@ -166,7 +148,7 @@ static int hts221_write_with_mask(struct hts221_hw *hw, u8 addr, u8 mask, > >> goto unlock; > >> } > >> > >> - data = (data & ~mask) | (val & mask); > >> + data = (data & ~mask) | ((val << __ffs(mask)) & mask); > >> > >> err = hw->tf->write(hw->dev, addr, sizeof(data), &data); > >> if (err < 0) > >> @@ -201,11 +183,10 @@ static int hts221_check_whoami(struct hts221_hw *hw) > >> > >> int hts221_config_drdy(struct hts221_hw *hw, bool enable) > >> { > >> - u8 val = enable ? BIT(2) : 0; > >> int err; > >> > >> err = hts221_write_with_mask(hw, HTS221_REG_CNTRL3_ADDR, > >> - HTS221_DRDY_MASK, val); > >> + HTS221_DRDY_MASK, enable); > >> > >> return err < 0 ? err : 0; > >> } > >> @@ -213,7 +194,6 @@ int hts221_config_drdy(struct hts221_hw *hw, bool enable) > >> static int hts221_update_odr(struct hts221_hw *hw, u8 odr) > >> { > >> int i, err; > >> - u8 val; > >> > >> for (i = 0; i < ARRAY_SIZE(hts221_odr_table); i++) > >> if (hts221_odr_table[i].hz == odr) > >> @@ -222,9 +202,19 @@ static int hts221_update_odr(struct hts221_hw *hw, u8 odr) > >> if (i == ARRAY_SIZE(hts221_odr_table)) > >> return -EINVAL; > >> > >> - val = HTS221_ENABLE_SENSOR | HTS221_BDU_MASK | hts221_odr_table[i].val; > >> + /* enable Block Data Update */ > >> + err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR, > >> + HTS221_BDU_MASK, 1); > >> + if (err < 0) > >> + return err; > >> + > >> + err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR, > >> + HTS221_ODR_MASK, hts221_odr_table[i].val); > >> + if (err < 0) > >> + return err; > >> + > >> err = hts221_write_with_mask(hw, HTS221_REG_CNTRL1_ADDR, > >> - HTS221_ODR_MASK, val); > > This original code looks like a bug given the odr mask should only > > cover the odr bits, not the enable and bdu. > > > > Am I missing something? > > Base on hts221_write_with_mask() code the original mask covers odr, > bdu and enable fields in CNTRL1 register. Ah. That makes sense even if it's rather less elegant than the new code! Thanks for clearing that up. Jonathan > > > > > Taking one write and changing it to 3 isn't that nice, but I guess > > we aren't in a fast path here so fair enough given the cleaner > > resulting code. > >> + HTS221_ENABLE_MASK, 1); > >> if (err < 0) > >> return err; > >> > > > > Regards, > Lorenzo > > >
next prev parent reply other threads:[~2017-07-10 20:47 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-09 16:56 [PATCH 0/9] hts221: add new features and fix power-off procedure Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-1-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 16:56 ` [PATCH 1/9] iio: humidity: hts221: refactor write_with_mask code Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-2-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:28 ` Jonathan Cameron 2017-07-09 18:28 ` Jonathan Cameron [not found] ` <20170709192827.2c343108-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:18 ` Lorenzo Bianconi 2017-07-09 21:18 ` Lorenzo Bianconi [not found] ` <CAA2SeNJmUFp7WaOsAEq+yLMSKrzQVkhmyMhB2OVWsbBAmv4nCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-10 20:47 ` Jonathan Cameron [this message] 2017-07-10 20:47 ` Jonathan Cameron 2017-07-09 16:56 ` [PATCH 2/9] iio: humidity: hts221: move BDU configuration in probe routine Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-3-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:29 ` Jonathan Cameron 2017-07-09 18:29 ` Jonathan Cameron 2017-07-09 16:56 ` [PATCH 3/9] iio: humidity: hts221: do not overwrite reserved data during power-down Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-4-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:30 ` Jonathan Cameron 2017-07-09 18:30 ` Jonathan Cameron [not found] ` <20170709193042.330fcd60-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:26 ` Lorenzo Bianconi 2017-07-09 21:26 ` Lorenzo Bianconi 2017-07-09 16:56 ` [PATCH 4/9] iio: humidity: hts221: avoid useless ODR reconfiguration Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-5-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:32 ` Jonathan Cameron 2017-07-09 18:32 ` Jonathan Cameron [not found] ` <20170709193208.6864b158-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:27 ` Lorenzo Bianconi 2017-07-09 21:27 ` Lorenzo Bianconi 2017-07-09 16:57 ` [PATCH 5/9] iio: humidity: hts221: support active-low interrupts Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-6-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:39 ` Jonathan Cameron 2017-07-09 18:39 ` Jonathan Cameron [not found] ` <20170709193951.14caff79-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-10 9:36 ` Marc Zyngier 2017-07-10 9:36 ` Marc Zyngier [not found] ` <ceef5860-91ee-a922-0dd7-8f2698192b9b-5wv7dgnIgG8@public.gmane.org> 2017-07-11 18:52 ` Jonathan Cameron 2017-07-11 18:52 ` Jonathan Cameron 2017-07-09 16:57 ` [PATCH 6/9] dt-bindings: " Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-7-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-11 2:49 ` Rob Herring 2017-07-11 2:49 ` Rob Herring 2017-07-09 16:57 ` [PATCH 7/9] iio: humidity: hts221: support open drain mode Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi 2017-07-09 16:57 ` [PATCH 8/9] dt-bindings: " Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-9-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-11 2:51 ` Rob Herring 2017-07-11 2:51 ` Rob Herring 2017-07-11 18:26 ` Jonathan Cameron 2017-07-11 18:26 ` Jonathan Cameron [not found] ` <20170711192656.7fd08a1c-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-11 18:42 ` Rob Herring 2017-07-11 18:42 ` Rob Herring [not found] ` <CAL_JsqJa7JeofpG=66AnVrTP4XtVrp9B4-QoLTyK08GzF4L5uQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-11 18:56 ` Jonathan Cameron 2017-07-11 18:56 ` Jonathan Cameron [not found] ` <0462CB71-6762-48F2-99B3-EA62FF81C280-tko9wxEg+fIOOJlXag/Snyp2UmYkHbXO@public.gmane.org> 2017-07-15 14:32 ` Lorenzo Bianconi 2017-07-15 14:32 ` Lorenzo Bianconi [not found] ` <CAA2SeN+2T2-G1khRNpNzccesX=cip0ConT11RJRV-HB8Ojk0pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-17 11:49 ` Jonathan Cameron 2017-07-17 11:49 ` Jonathan Cameron 2017-07-09 16:57 ` [PATCH 9/9] iio: humidity: hts221: move drdy enable logic in hts221_trig_set_state() Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-10-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:41 ` Jonathan Cameron 2017-07-09 18:41 ` Jonathan Cameron [not found] ` <20170709194123.39fd6914-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:28 ` Lorenzo Bianconi 2017-07-09 21:28 ` Lorenzo Bianconi [not found] ` <CAA2SeNLhBbTbMGDHyXGN02V4n0RHrwK-Bg0D_q9phpcEa3e7Rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-16 9:45 ` Lorenzo Bianconi 2017-07-16 9:45 ` Lorenzo Bianconi [not found] ` <CAA2SeNK6dd=myMk59j1To9GtvBaj1T8XXwcaqrtO8V5s-bM5WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-16 19:50 ` Jonathan Cameron 2017-07-16 19:50 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170710214746.39ea98f9@kernel.org \ --to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=lorenzo.bianconi-qxv4g6HH51o@public.gmane.org \ --cc=lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.