From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Lorenzo Bianconi <lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lorenzo.bianconi-qxv4g6HH51o@public.gmane.org Subject: Re: [PATCH 8/9] dt-bindings: iio: humidity: hts221: support open drain mode Date: Tue, 11 Jul 2017 19:26:56 +0100 [thread overview] Message-ID: <20170711192656.7fd08a1c@kernel.org> (raw) In-Reply-To: <20170711025158.vpt6bcznkhi3bslm@rob-hp-laptop> On Mon, 10 Jul 2017 21:51:58 -0500 Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > On Sun, Jul 09, 2017 at 06:57:03PM +0200, Lorenzo Bianconi wrote: > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> > > --- > > Documentation/devicetree/bindings/iio/humidity/hts221.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/humidity/hts221.txt b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > index fca263e13400..732b83c06c08 100644 > > --- a/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > +++ b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > @@ -5,6 +5,14 @@ Required properties: > > - reg: i2c address of the sensor / spi cs line > > > > Optional properties: > > +- drive-open-drain: the interrupt/data ready line will be configured > > Needs a vendor prefix and "drdy-open-drain" would be more specific. This is straight out of the pinctrl bindings and has been used in a few other places as well. I can see it should really be more obviously associated with the drdy pin though. A few IIO drivers already use this binding (st sensors and the lsm6dsx). If we are going to decide it's a bad idea we should deprecate those bindings and add whatever we do here as well. Jonathan > > > + as open drain, which is useful if several sensors share the same > > + interrupt line. This is a boolean property. > > + (This binding is taken from pinctrl/pinctrl-bindings.txt) > > + If the requested interrupt is configured as IRQ_TYPE_LEVEL_HIGH or > > + IRQ_TYPE_EDGE_RISING a pull-down resistor is needed to drive the line > > + when it is not active, whereas a pull-up one is needed when interrupt > > + line is configured as IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_EDGE_FALLING. > > - interrupt-parent: should be the phandle for the interrupt controller > > - interrupts: interrupt mapping for IRQ. It should be configured with > > flags IRQ_TYPE_LEVEL_HIGH, IRQ_TYPE_EDGE_RISING, IRQ_TYPE_LEVEL_LOW or > > -- > > 2.13.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Rob Herring <robh@kernel.org> Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, lorenzo.bianconi@st.com Subject: Re: [PATCH 8/9] dt-bindings: iio: humidity: hts221: support open drain mode Date: Tue, 11 Jul 2017 19:26:56 +0100 [thread overview] Message-ID: <20170711192656.7fd08a1c@kernel.org> (raw) In-Reply-To: <20170711025158.vpt6bcznkhi3bslm@rob-hp-laptop> On Mon, 10 Jul 2017 21:51:58 -0500 Rob Herring <robh@kernel.org> wrote: > On Sun, Jul 09, 2017 at 06:57:03PM +0200, Lorenzo Bianconi wrote: > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com> > > --- > > Documentation/devicetree/bindings/iio/humidity/hts221.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/humidity/hts221.txt b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > index fca263e13400..732b83c06c08 100644 > > --- a/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > +++ b/Documentation/devicetree/bindings/iio/humidity/hts221.txt > > @@ -5,6 +5,14 @@ Required properties: > > - reg: i2c address of the sensor / spi cs line > > > > Optional properties: > > +- drive-open-drain: the interrupt/data ready line will be configured > > Needs a vendor prefix and "drdy-open-drain" would be more specific. This is straight out of the pinctrl bindings and has been used in a few other places as well. I can see it should really be more obviously associated with the drdy pin though. A few IIO drivers already use this binding (st sensors and the lsm6dsx). If we are going to decide it's a bad idea we should deprecate those bindings and add whatever we do here as well. Jonathan > > > + as open drain, which is useful if several sensors share the same > > + interrupt line. This is a boolean property. > > + (This binding is taken from pinctrl/pinctrl-bindings.txt) > > + If the requested interrupt is configured as IRQ_TYPE_LEVEL_HIGH or > > + IRQ_TYPE_EDGE_RISING a pull-down resistor is needed to drive the line > > + when it is not active, whereas a pull-up one is needed when interrupt > > + line is configured as IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_EDGE_FALLING. > > - interrupt-parent: should be the phandle for the interrupt controller > > - interrupts: interrupt mapping for IRQ. It should be configured with > > flags IRQ_TYPE_LEVEL_HIGH, IRQ_TYPE_EDGE_RISING, IRQ_TYPE_LEVEL_LOW or > > -- > > 2.13.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-11 18:26 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-09 16:56 [PATCH 0/9] hts221: add new features and fix power-off procedure Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-1-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 16:56 ` [PATCH 1/9] iio: humidity: hts221: refactor write_with_mask code Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-2-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:28 ` Jonathan Cameron 2017-07-09 18:28 ` Jonathan Cameron [not found] ` <20170709192827.2c343108-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:18 ` Lorenzo Bianconi 2017-07-09 21:18 ` Lorenzo Bianconi [not found] ` <CAA2SeNJmUFp7WaOsAEq+yLMSKrzQVkhmyMhB2OVWsbBAmv4nCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-10 20:47 ` Jonathan Cameron 2017-07-10 20:47 ` Jonathan Cameron 2017-07-09 16:56 ` [PATCH 2/9] iio: humidity: hts221: move BDU configuration in probe routine Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-3-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:29 ` Jonathan Cameron 2017-07-09 18:29 ` Jonathan Cameron 2017-07-09 16:56 ` [PATCH 3/9] iio: humidity: hts221: do not overwrite reserved data during power-down Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-4-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:30 ` Jonathan Cameron 2017-07-09 18:30 ` Jonathan Cameron [not found] ` <20170709193042.330fcd60-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:26 ` Lorenzo Bianconi 2017-07-09 21:26 ` Lorenzo Bianconi 2017-07-09 16:56 ` [PATCH 4/9] iio: humidity: hts221: avoid useless ODR reconfiguration Lorenzo Bianconi 2017-07-09 16:56 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-5-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:32 ` Jonathan Cameron 2017-07-09 18:32 ` Jonathan Cameron [not found] ` <20170709193208.6864b158-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:27 ` Lorenzo Bianconi 2017-07-09 21:27 ` Lorenzo Bianconi 2017-07-09 16:57 ` [PATCH 5/9] iio: humidity: hts221: support active-low interrupts Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-6-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:39 ` Jonathan Cameron 2017-07-09 18:39 ` Jonathan Cameron [not found] ` <20170709193951.14caff79-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-10 9:36 ` Marc Zyngier 2017-07-10 9:36 ` Marc Zyngier [not found] ` <ceef5860-91ee-a922-0dd7-8f2698192b9b-5wv7dgnIgG8@public.gmane.org> 2017-07-11 18:52 ` Jonathan Cameron 2017-07-11 18:52 ` Jonathan Cameron 2017-07-09 16:57 ` [PATCH 6/9] dt-bindings: " Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-7-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-11 2:49 ` Rob Herring 2017-07-11 2:49 ` Rob Herring 2017-07-09 16:57 ` [PATCH 7/9] iio: humidity: hts221: support open drain mode Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi 2017-07-09 16:57 ` [PATCH 8/9] dt-bindings: " Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-9-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-11 2:51 ` Rob Herring 2017-07-11 2:51 ` Rob Herring 2017-07-11 18:26 ` Jonathan Cameron [this message] 2017-07-11 18:26 ` Jonathan Cameron [not found] ` <20170711192656.7fd08a1c-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-11 18:42 ` Rob Herring 2017-07-11 18:42 ` Rob Herring [not found] ` <CAL_JsqJa7JeofpG=66AnVrTP4XtVrp9B4-QoLTyK08GzF4L5uQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-11 18:56 ` Jonathan Cameron 2017-07-11 18:56 ` Jonathan Cameron [not found] ` <0462CB71-6762-48F2-99B3-EA62FF81C280-tko9wxEg+fIOOJlXag/Snyp2UmYkHbXO@public.gmane.org> 2017-07-15 14:32 ` Lorenzo Bianconi 2017-07-15 14:32 ` Lorenzo Bianconi [not found] ` <CAA2SeN+2T2-G1khRNpNzccesX=cip0ConT11RJRV-HB8Ojk0pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-17 11:49 ` Jonathan Cameron 2017-07-17 11:49 ` Jonathan Cameron 2017-07-09 16:57 ` [PATCH 9/9] iio: humidity: hts221: move drdy enable logic in hts221_trig_set_state() Lorenzo Bianconi 2017-07-09 16:57 ` Lorenzo Bianconi [not found] ` <20170709165704.26311-10-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org> 2017-07-09 18:41 ` Jonathan Cameron 2017-07-09 18:41 ` Jonathan Cameron [not found] ` <20170709194123.39fd6914-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-07-09 21:28 ` Lorenzo Bianconi 2017-07-09 21:28 ` Lorenzo Bianconi [not found] ` <CAA2SeNLhBbTbMGDHyXGN02V4n0RHrwK-Bg0D_q9phpcEa3e7Rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-16 9:45 ` Lorenzo Bianconi 2017-07-16 9:45 ` Lorenzo Bianconi [not found] ` <CAA2SeNK6dd=myMk59j1To9GtvBaj1T8XXwcaqrtO8V5s-bM5WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-16 19:50 ` Jonathan Cameron 2017-07-16 19:50 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170711192656.7fd08a1c@kernel.org \ --to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=lorenzo.bianconi-qxv4g6HH51o@public.gmane.org \ --cc=lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.