All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h
Date: Wed, 26 Jul 2017 13:29:35 +0200	[thread overview]
Message-ID: <20170726112935.a4ztsb6yke7bhsvo@gmail.com> (raw)
In-Reply-To: <CAPcyv4g1V=1E-cOzHabZswwVGmJGQUNSYxnSyOtwxo79eRYyNw@mail.gmail.com>


* Dan Williams <dan.j.williams@intel.com> wrote:

> On Tue, Jul 25, 2017 at 4:55 PM, Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> > Em Tue, Jul 25, 2017 at 03:36:26PM -0700, Dan Williams escreveu:
> >> Replace the ccan implementation of list primitives, bitmap helpers and
> >> small utility macros with the common definitions available in
> >> tool/include/linux.
> >
> > You should first add what you need in separate patches, paving the way
> > to then use it, and some stuff are already there, see below:
> 
> Ok, I'll break out those changes separately.

BTW., another general observation I have is that ndctl uses autotools - while perf 
uses its own build system, some of which is abstracted out into tools/build/ and 
reused by other tooling projects as well.

I despise autotools with a passion, it's slow, bloated, and encourages all sorts 
of bad API/ABI practices that plagues many OSS projects. I know that Linus 
explicitly did a Makefile based build system for Git for (I think) similar 
reasons.

It might be a good idea to not let autotools into the kernel tooling tree, not 
because ndctl's use of autotools is bad in any fashion (it appears to be a fairly 
straightforward use), but to generally encourage good API/ABI practices in our 
tooling space, and to encourage enhancements to the tools/build/ infrastructure.

Thanks,

	Ingo
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h
Date: Wed, 26 Jul 2017 13:29:35 +0200	[thread overview]
Message-ID: <20170726112935.a4ztsb6yke7bhsvo@gmail.com> (raw)
In-Reply-To: <CAPcyv4g1V=1E-cOzHabZswwVGmJGQUNSYxnSyOtwxo79eRYyNw@mail.gmail.com>


* Dan Williams <dan.j.williams@intel.com> wrote:

> On Tue, Jul 25, 2017 at 4:55 PM, Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> > Em Tue, Jul 25, 2017 at 03:36:26PM -0700, Dan Williams escreveu:
> >> Replace the ccan implementation of list primitives, bitmap helpers and
> >> small utility macros with the common definitions available in
> >> tool/include/linux.
> >
> > You should first add what you need in separate patches, paving the way
> > to then use it, and some stuff are already there, see below:
> 
> Ok, I'll break out those changes separately.

BTW., another general observation I have is that ndctl uses autotools - while perf 
uses its own build system, some of which is abstracted out into tools/build/ and 
reused by other tooling projects as well.

I despise autotools with a passion, it's slow, bloated, and encourages all sorts 
of bad API/ABI practices that plagues many OSS projects. I know that Linus 
explicitly did a Makefile based build system for Git for (I think) similar 
reasons.

It might be a good idea to not let autotools into the kernel tooling tree, not 
because ndctl's use of autotools is bad in any fashion (it appears to be a fairly 
straightforward use), but to generally encourage good API/ABI practices in our 
tooling space, and to encourage enhancements to the tools/build/ infrastructure.

Thanks,

	Ingo

  reply	other threads:[~2017-07-26 11:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 22:36 [PATCH 0/4] ndctl: integrate with tools/ infrastructure Dan Williams
2017-07-25 22:36 ` Dan Williams
2017-07-25 22:36 ` [PATCH 1/4] ndctl: switch to kernel versioning scheme Dan Williams
2017-07-25 22:36   ` Dan Williams
2017-07-25 22:36 ` [PATCH 2/4] MAINTAINERS: add ndctl files to libnvdimm Dan Williams
2017-07-25 22:36   ` Dan Williams
2017-07-25 22:36 ` [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h Dan Williams
2017-07-25 22:36   ` Dan Williams
2017-07-25 23:55   ` Arnaldo Carvalho de Melo
2017-07-25 23:55     ` Arnaldo Carvalho de Melo
2017-07-26  0:03     ` Dan Williams
2017-07-26  0:03       ` Dan Williams
2017-07-26 11:29       ` Ingo Molnar [this message]
2017-07-26 11:29         ` Ingo Molnar
2017-07-26 16:03         ` Dan Williams
2017-07-26 16:03           ` Dan Williams
2017-07-26 17:19           ` Ingo Molnar
2017-07-26 17:19             ` Ingo Molnar
2017-07-26 17:31             ` Dan Williams
2017-07-26 17:31               ` Dan Williams
2017-07-26 17:57               ` Arnaldo Carvalho de Melo
2017-07-26 17:57                 ` Arnaldo Carvalho de Melo
2017-07-26 18:15                 ` Dan Williams
2017-07-26 18:15                   ` Dan Williams
2017-07-27  8:50               ` Ingo Molnar
2017-07-27  8:50                 ` Ingo Molnar
2017-07-25 22:36 ` [PATCH 4/4] ndctl: switch to tools/lib/subcmd/ Dan Williams
2017-07-25 22:36   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726112935.a4ztsb6yke7bhsvo@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.