From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h
Date: Wed, 26 Jul 2017 14:57:39 -0300 [thread overview]
Message-ID: <20170726175739.GF23846@kernel.org> (raw)
In-Reply-To: <CAPcyv4jr4cvs9DSQctrbKo61AxBkGe-S=bUS9+_ce_PbXXpCYw@mail.gmail.com>
Em Wed, Jul 26, 2017 at 10:31:48AM -0700, Dan Williams escreveu:
> On Wed, Jul 26, 2017 at 10:19 AM, Ingo Molnar <mingo@kernel.org> wrote:
> > * Dan Williams <dan.j.williams@intel.com> wrote:
> >> On Wed, Jul 26, 2017 at 4:29 AM, Ingo Molnar <mingo@kernel.org> wrote:
> > which I could initially mistake for a commit about scheduler completions ;-)
> >
> > Or:
> > 2ad6a39c9ae9: Fix attribute sizes to match NFIT 0.8s2
> > cc7cb44385d3: Import initial infrastructure
> > etc.
> > I suppose all that could be corrected, SOBs added, titles clarified and prefixed
> > with tools/ndctl, but then it wouldn't really be unmodified history anymore,
> > right?
> > At that point we might as well do a clean start - and not import ~500 extra
> > commits into the kernel tree?
> I think keeping the history is worth it, similar reasoning to why we
> kept the btrfs history. Also, since the history is linear and already
> rewritten by 'git filter-branch' to move everything to tools/ndctl/ it
> wouldn't be that much more work to go clean up these few commits that
> are problematic.
Hey, but we can have something like:
https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/
It goes all the way to the 0.12 kernel.
If someone wants to go that far, just clone that tree, merge it, etc.
Could that be the solution for this case as well?
I.e. the kernel history prior to what we have in linux.git can be
accessed via that other tree, history.git, can we have ndctl-history.git
and linux.git + ndctl from now on?
If you prefer to go full merge, then I think prefixing + SOB'ing should
be done, right?
- Arnaldo
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h
Date: Wed, 26 Jul 2017 14:57:39 -0300 [thread overview]
Message-ID: <20170726175739.GF23846@kernel.org> (raw)
In-Reply-To: <CAPcyv4jr4cvs9DSQctrbKo61AxBkGe-S=bUS9+_ce_PbXXpCYw@mail.gmail.com>
Em Wed, Jul 26, 2017 at 10:31:48AM -0700, Dan Williams escreveu:
> On Wed, Jul 26, 2017 at 10:19 AM, Ingo Molnar <mingo@kernel.org> wrote:
> > * Dan Williams <dan.j.williams@intel.com> wrote:
> >> On Wed, Jul 26, 2017 at 4:29 AM, Ingo Molnar <mingo@kernel.org> wrote:
> > which I could initially mistake for a commit about scheduler completions ;-)
> >
> > Or:
> > 2ad6a39c9ae9: Fix attribute sizes to match NFIT 0.8s2
> > cc7cb44385d3: Import initial infrastructure
> > etc.
> > I suppose all that could be corrected, SOBs added, titles clarified and prefixed
> > with tools/ndctl, but then it wouldn't really be unmodified history anymore,
> > right?
> > At that point we might as well do a clean start - and not import ~500 extra
> > commits into the kernel tree?
> I think keeping the history is worth it, similar reasoning to why we
> kept the btrfs history. Also, since the history is linear and already
> rewritten by 'git filter-branch' to move everything to tools/ndctl/ it
> wouldn't be that much more work to go clean up these few commits that
> are problematic.
Hey, but we can have something like:
https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/
It goes all the way to the 0.12 kernel.
If someone wants to go that far, just clone that tree, merge it, etc.
Could that be the solution for this case as well?
I.e. the kernel history prior to what we have in linux.git can be
accessed via that other tree, history.git, can we have ndctl-history.git
and linux.git + ndctl from now on?
If you prefer to go full merge, then I think prefixing + SOB'ing should
be done, right?
- Arnaldo
next prev parent reply other threads:[~2017-07-26 17:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 22:36 [PATCH 0/4] ndctl: integrate with tools/ infrastructure Dan Williams
2017-07-25 22:36 ` Dan Williams
2017-07-25 22:36 ` [PATCH 1/4] ndctl: switch to kernel versioning scheme Dan Williams
2017-07-25 22:36 ` Dan Williams
2017-07-25 22:36 ` [PATCH 2/4] MAINTAINERS: add ndctl files to libnvdimm Dan Williams
2017-07-25 22:36 ` Dan Williams
2017-07-25 22:36 ` [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h Dan Williams
2017-07-25 22:36 ` Dan Williams
2017-07-25 23:55 ` Arnaldo Carvalho de Melo
2017-07-25 23:55 ` Arnaldo Carvalho de Melo
2017-07-26 0:03 ` Dan Williams
2017-07-26 0:03 ` Dan Williams
2017-07-26 11:29 ` Ingo Molnar
2017-07-26 11:29 ` Ingo Molnar
2017-07-26 16:03 ` Dan Williams
2017-07-26 16:03 ` Dan Williams
2017-07-26 17:19 ` Ingo Molnar
2017-07-26 17:19 ` Ingo Molnar
2017-07-26 17:31 ` Dan Williams
2017-07-26 17:31 ` Dan Williams
2017-07-26 17:57 ` Arnaldo Carvalho de Melo [this message]
2017-07-26 17:57 ` Arnaldo Carvalho de Melo
2017-07-26 18:15 ` Dan Williams
2017-07-26 18:15 ` Dan Williams
2017-07-27 8:50 ` Ingo Molnar
2017-07-27 8:50 ` Ingo Molnar
2017-07-25 22:36 ` [PATCH 4/4] ndctl: switch to tools/lib/subcmd/ Dan Williams
2017-07-25 22:36 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726175739.GF23846@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.