Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table

From: Wolfram Sang <wsa@the-dreams.de>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: "Linux Kernel" <linux-kernel@vger.kernel.org>,
	"Rob Herring" <robh@kernel.org>, "Florian Larysch" <fl@n621.de>,
	"David Lechner" <david@lechnology.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	"Simon Horman" <horms@verge.net.au>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Will Deacon" <will.deacon@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Sekhar Nori" <nsekhar@ti.com>, "Scott Wood" <oss@buserror.net>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Joachim Eastwood" <manabian@gmail.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Santosh Shilimkar" <ssantosh@kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"Uwe Kleine-König" <kernel@pengutronix.de>,
	"Linux I2C" <linux-i2c@vger.kernel.org>
Subject: Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table
Date: Wed, 30 Aug 2017 19:42:28 +0200	[thread overview]
Message-ID: <20170830174228.sx5jgtxxy56zq47t@ninjato> (raw)
In-Reply-To: <CABxcv=nqbNsTs7D57VOt1-Tav_3i9U=XKn=BV=hPr1tG68eE2g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

On Wed, Aug 30, 2017 at 06:19:02PM +0200, Javier Martinez Canillas wrote:
> Hello Wolfram,
> 
> On Tue, Aug 29, 2017 at 10:48 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> >
> >> I don't have a DT based system at hand now, but I'll test it again and
> >> let you know probably tomorrow.
> >
> > I will try again today, too. Thanks!
> >
> 
> Ok, I had some time to do some tests again. I used an ARM Chromebook
> (Exynos Peach Pi) that has an I2C touchpad (Atmel maXTouch).

I tried again as well and it still fails for me.

> Tested the following cases:

I think we should talk about the same case: Let me repeat what I did:

1) I added your patch "eeprom: at24: Add OF device ID table"
2) I added an EEPROM node to an I2C

+       eeprom@50 {
+               compatible = "renesas,24c01";
+               reg = <0x50>;
+       };

-> no at24 binding to the device

3) I revert your patch

-> at24 binding to the device

I think you should be able to test this DTS snipplet even without a real
eeprom. Especially after applying this to the at24 driver.

diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 79c5c39be29cac..f9f547680c53db 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -805,11 +805,6 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	 * Perform a one-byte test read to verify that the
 	 * chip is functional.
 	 */
-	err = at24_read(at24, 0, &test_byte, 1);
-	if (err) {
-		err = -ENODEV;
-		goto err_clients;
-	}
 
 	at24->nvmem_config.name = dev_name(&client->dev);
 	at24->nvmem_config.dev = &client->dev;


Can you check this?

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
