Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	"Rob Herring" <robh@kernel.org>, "Florian Larysch" <fl@n621.de>,
	"David Lechner" <david@lechnology.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	"Simon Horman" <horms@verge.net.au>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Will Deacon" <will.deacon@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Sekhar Nori" <nsekhar@ti.com>, "Scott Wood" <oss@buserror.net>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Joachim Eastwood" <manabian@gmail.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Santosh Shilimkar" <ssantosh@kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"Uwe Kleine-König" <kernel@pengutronix.de>,
	"Linux I2C" <linux-i2c@vger.kernel.org>
Subject: Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table
Date: Wed, 30 Aug 2017 22:15:45 +0200	[thread overview]
Message-ID: <CAMuHMdXRVnHsvCNfRqRgTusdyhOYcV7bWconD99OgXmVcHT8yw@mail.gmail.com> (raw)
In-Reply-To: <CABxcv==JFm0H_kB8LRyRpZNbajcO3UkxYOepkk=YUAaT1UH1gg@mail.gmail.com>

Hi Javier,

On Wed, Aug 30, 2017 at 9:57 PM, Javier Martinez Canillas
<javier@dowhile0.org> wrote:
>> I think we should talk about the same case: Let me repeat what I did:
>>
>> 1) I added your patch "eeprom: at24: Add OF device ID table"
>> 2) I added an EEPROM node to an I2C
>>
>> +       eeprom@50 {
>> +               compatible = "renesas,24c01";
>> +               reg = <0x50>;
>> +       };
>>
>> -> no at24 binding to the device
>>
>> 3) I revert your patch
>>
>> -> at24 binding to the device
>>
>
> I've tested this and you are right, it fails...
>
> The problem is that the patch also changes how the driver obtains the
> EEPROM parameters (the magic value in the entry's data field).
>
> So even when module autoload and device / driver matching works, the
> driver probe function fails because if (client->dev.of_node) the
> driver attempts to get the entry data using
> of_device_get_match_data(), which is obviously wrong since the
> compatible string in the dev node isn't present in the OF table.
>
> The id->driver_data from the I2C table should be used instead since
> that's the table that matches in this case.
>
> One option is to fallback to id->driver_data if
> of_device_get_match_data() fails, but that's just an (ugly)
> workaround. So I agree with you that the best option is to wait for
> the DTS patches to land first.

Which means new kernels won't work with old DTBs. Oops...
I'm afraid that needs to be fixed.  People care about DTB backward
compatibility on many platforms.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds