All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Javier Martinez Canillas <javier@dowhile0.org>,
	<linux-kernel@vger.kernel.org>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
	"Rob Herring" <robh@kernel.org>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	devicetree@vger.kernel.org,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Russell King" <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v5 10/16] ARM: dts: zynq: Add generic compatible string for I2C EEPROM
Date: Wed, 21 Jun 2017 13:43:10 +0200	[thread overview]
Message-ID: <b22a7db6-7daf-b5c1-3978-cdc699723e30@xilinx.com> (raw)
In-Reply-To: <20170615185418.13980-11-javier@dowhile0.org>

On 15.6.2017 20:54, Javier Martinez Canillas wrote:
> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
> 
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
> 
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
> 
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> 
> ---
> 
> Changes in v5: None
> Changes in v4:
> - Only use the atmel manufacturer in the compatible string instead of
>   keeping the deprecated ones (Rob Herring).
> 
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/boot/dts/zynq-zc702.dts | 2 +-
>  arch/arm/boot/dts/zynq-zc706.dts | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index 0cdad2cc8b78..f8c840f7118f 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -136,7 +136,7 @@
>  			#size-cells = <0>;
>  			reg = <2>;
>  			eeprom@54 {
> -				compatible = "at,24c08";
> +				compatible = "atmel,24c08";
>  				reg = <0x54>;
>  			};
>  		};
> diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts
> index ad4bb06dba25..76492be4a912 100644
> --- a/arch/arm/boot/dts/zynq-zc706.dts
> +++ b/arch/arm/boot/dts/zynq-zc706.dts
> @@ -92,7 +92,7 @@
>  			#size-cells = <0>;
>  			reg = <2>;
>  			eeprom@54 {
> -				compatible = "at,24c08";
> +				compatible = "atmel,24c08";
>  				reg = <0x54>;
>  			};
>  		};
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
To: Javier Martinez Canillas
	<javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: "Wolfram Sang" <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	"Rob Herring" <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Sören Brinkmann"
	<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Michal Simek"
	<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Russell King" <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RESEND PATCH v5 10/16] ARM: dts: zynq: Add generic compatible string for I2C EEPROM
Date: Wed, 21 Jun 2017 13:43:10 +0200	[thread overview]
Message-ID: <b22a7db6-7daf-b5c1-3978-cdc699723e30@xilinx.com> (raw)
In-Reply-To: <20170615185418.13980-11-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>

On 15.6.2017 20:54, Javier Martinez Canillas wrote:
> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
> 
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
> 
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
> 
> Signed-off-by: Javier Martinez Canillas <javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
> 
> ---
> 
> Changes in v5: None
> Changes in v4:
> - Only use the atmel manufacturer in the compatible string instead of
>   keeping the deprecated ones (Rob Herring).
> 
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/boot/dts/zynq-zc702.dts | 2 +-
>  arch/arm/boot/dts/zynq-zc706.dts | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index 0cdad2cc8b78..f8c840f7118f 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -136,7 +136,7 @@
>  			#size-cells = <0>;
>  			reg = <2>;
>  			eeprom@54 {
> -				compatible = "at,24c08";
> +				compatible = "atmel,24c08";
>  				reg = <0x54>;
>  			};
>  		};
> diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts
> index ad4bb06dba25..76492be4a912 100644
> --- a/arch/arm/boot/dts/zynq-zc706.dts
> +++ b/arch/arm/boot/dts/zynq-zc706.dts
> @@ -92,7 +92,7 @@
>  			#size-cells = <0>;
>  			reg = <2>;
>  			eeprom@54 {
> -				compatible = "at,24c08";
> +				compatible = "atmel,24c08";
>  				reg = <0x54>;
>  			};
>  		};
> 

Acked-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v5 10/16] ARM: dts: zynq: Add generic compatible string for I2C EEPROM
Date: Wed, 21 Jun 2017 13:43:10 +0200	[thread overview]
Message-ID: <b22a7db6-7daf-b5c1-3978-cdc699723e30@xilinx.com> (raw)
In-Reply-To: <20170615185418.13980-11-javier@dowhile0.org>

On 15.6.2017 20:54, Javier Martinez Canillas wrote:
> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
> 
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
> 
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
> 
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> 
> ---
> 
> Changes in v5: None
> Changes in v4:
> - Only use the atmel manufacturer in the compatible string instead of
>   keeping the deprecated ones (Rob Herring).
> 
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/boot/dts/zynq-zc702.dts | 2 +-
>  arch/arm/boot/dts/zynq-zc706.dts | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index 0cdad2cc8b78..f8c840f7118f 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -136,7 +136,7 @@
>  			#size-cells = <0>;
>  			reg = <2>;
>  			eeprom at 54 {
> -				compatible = "at,24c08";
> +				compatible = "atmel,24c08";
>  				reg = <0x54>;
>  			};
>  		};
> diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts
> index ad4bb06dba25..76492be4a912 100644
> --- a/arch/arm/boot/dts/zynq-zc706.dts
> +++ b/arch/arm/boot/dts/zynq-zc706.dts
> @@ -92,7 +92,7 @@
>  			#size-cells = <0>;
>  			reg = <2>;
>  			eeprom at 54 {
> -				compatible = "at,24c08";
> +				compatible = "atmel,24c08";
>  				reg = <0x54>;
>  			};
>  		};
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

  reply	other threads:[~2017-06-21 11:43 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 18:54 [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-06-15 18:54 ` Javier Martinez Canillas
2017-06-15 18:54 ` Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 01/16] dt-bindings: i2c: eeprom: Document vendor to be used and deprecated ones Javier Martinez Canillas
2017-06-23 18:17   ` Rob Herring
2017-06-23 18:17     ` Rob Herring
2017-08-28 16:02   ` Wolfram Sang
2017-06-15 18:54 ` [RESEND PATCH v5 02/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 03/16] ARM: dts: efm32: Add generic compatible string for I2C EEPROM Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-08-16 14:21   ` Javier Martinez Canillas
2017-08-16 14:21     ` Javier Martinez Canillas
2017-08-16 14:21     ` Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 04/16] ARM: dts: keystone: " Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 05/16] ARM: dts: lpc18xx: " Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 06/16] ARM: dts: r7s72100: " Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-16 13:36   ` Simon Horman
2017-06-16 13:36     ` Simon Horman
2017-06-15 18:54 ` [RESEND PATCH v5 07/16] ARM: dts: koelsch: " Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-16 13:36   ` Simon Horman
2017-06-16 13:36     ` Simon Horman
2017-06-15 18:54 ` [RESEND PATCH v5 08/16] ARM: dts: socfpga: " Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-11-07  8:20   ` Javier Martinez Canillas
2017-11-07  8:20     ` Javier Martinez Canillas
2017-11-07  8:20     ` Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 09/16] ARM: dts: uniphier: " Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 10/16] ARM: dts: zynq: " Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-21 11:43   ` Michal Simek [this message]
2017-06-21 11:43     ` Michal Simek
2017-06-21 11:43     ` Michal Simek
2017-08-23 14:28     ` Javier Martinez Canillas
2017-08-23 14:28       ` Javier Martinez Canillas
2017-08-23 14:28       ` Javier Martinez Canillas
2017-08-24 13:44       ` Michal Simek
2017-08-24 13:44         ` Michal Simek
2017-09-21  9:41         ` Javier Martinez Canillas
2017-09-21  9:41           ` Javier Martinez Canillas
2017-09-21  9:41           ` Javier Martinez Canillas
2017-09-25  8:06           ` Michal Simek
2017-09-25  8:06             ` Michal Simek
2017-09-26  8:00             ` Javier Martinez Canillas
2017-09-26  8:00               ` Javier Martinez Canillas
2017-09-26  8:00               ` Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 11/16] arm64: zynqmp: " Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-15 18:54   ` Javier Martinez Canillas
2017-06-21 11:43   ` Michal Simek
2017-06-21 11:43     ` Michal Simek
2017-06-21 11:43     ` Michal Simek
2017-08-21 11:27     ` Javier Martinez Canillas
2017-08-21 11:27       ` Javier Martinez Canillas
2017-08-21 12:04       ` Michal Simek
2017-08-21 12:04         ` Michal Simek
2017-08-21 12:58         ` Javier Martinez Canillas
2017-08-21 12:58           ` Javier Martinez Canillas
2017-06-15 18:54 ` [RESEND PATCH v5 12/16] powerpc/5200: " Javier Martinez Canillas
2017-06-29 12:21   ` [RESEND, v5, " Michael Ellerman
2017-06-29 12:21     ` Michael Ellerman
2017-06-15 18:54 ` [RESEND PATCH v5 13/16] powerpc/fsl: " Javier Martinez Canillas
2017-06-29 12:21   ` [RESEND, v5, " Michael Ellerman
2017-06-29 12:21     ` Michael Ellerman
2017-06-15 18:54 ` [RESEND PATCH v5 14/16] powerpc/512x: " Javier Martinez Canillas
2017-06-29 12:21   ` [RESEND, v5, " Michael Ellerman
2017-06-29 12:21     ` Michael Ellerman
2017-06-15 18:54 ` [RESEND PATCH v5 15/16] powerpc/83xx: " Javier Martinez Canillas
2017-06-29 12:21   ` [RESEND, v5, " Michael Ellerman
2017-06-29 12:21     ` Michael Ellerman
2017-06-15 18:54 ` [RESEND PATCH v5 16/16] powerpc/44x: " Javier Martinez Canillas
2017-06-29 12:21   ` [RESEND, v5, " Michael Ellerman
2017-06-29 12:21     ` Michael Ellerman
2017-07-10  7:47 ` [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-07-10  7:47   ` Javier Martinez Canillas
2017-07-10  7:47   ` Javier Martinez Canillas
2017-07-31 15:30 ` Wolfram Sang
2017-07-31 15:30   ` Wolfram Sang
2017-07-31 15:30   ` Wolfram Sang
2017-07-31 16:17   ` Javier Martinez Canillas
2017-07-31 16:17     ` Javier Martinez Canillas
2017-07-31 16:17     ` Javier Martinez Canillas
2017-08-28 16:01     ` Wolfram Sang
2017-08-28 16:01       ` Wolfram Sang
2017-08-28 16:01       ` Wolfram Sang
2017-08-29  8:44       ` Javier Martinez Canillas
2017-08-29  8:44         ` Javier Martinez Canillas
2017-08-29  8:44         ` Javier Martinez Canillas
2017-08-29  8:48         ` Wolfram Sang
2017-08-29  8:48           ` Wolfram Sang
2017-08-29  8:48           ` Wolfram Sang
2017-08-30 16:19           ` Javier Martinez Canillas
2017-08-30 16:19             ` Javier Martinez Canillas
2017-08-30 16:19             ` Javier Martinez Canillas
2017-08-30 17:42             ` Wolfram Sang
2017-08-30 17:42               ` Wolfram Sang
2017-08-30 17:42               ` Wolfram Sang
2017-08-30 19:57               ` Javier Martinez Canillas
2017-08-30 19:57                 ` Javier Martinez Canillas
2017-08-30 19:57                 ` Javier Martinez Canillas
2017-08-30 20:15                 ` Geert Uytterhoeven
2017-08-30 20:15                   ` Geert Uytterhoeven
2017-08-30 20:15                   ` Geert Uytterhoeven
2017-08-30 20:59                   ` Javier Martinez Canillas
2017-08-30 20:59                     ` Javier Martinez Canillas
2017-08-30 20:59                     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b22a7db6-7daf-b5c1-3978-cdc699723e30@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@dowhile0.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.