From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, "James E . J . Bottomley" <jejb@parisc-linux.org>, Helge Deller <deller@gmx.de> Cc: Petr Mladek <pmladek@suse.com>, Steven Rostedt <rostedt@goodmis.org>, Andrew Morton <akpm@linux-foundation.org>, Jessica Yu <jeyu@kernel.org>, Alexei Starovoitov <ast@kernel.org>, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Subject: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Date: Sat, 16 Sep 2017 12:53:42 +0900 [thread overview] Message-ID: <20170916035347.19705-1-sergey.senozhatsky@gmail.com> (raw) Hello RFC On some arches C function pointers are indirect and point to a function descriptor, which contains the actual pointer to the code. This mostly doesn't matter, except for cases when people want to print out function pointers in symbolic format, because the usual '%pS/%ps' does not work on those arches as expected. That's the reason why we have '%pF/%pf', but since it's here because of a subtle ABI detail specific to some arches (ppc64/ia64/parisc64) it's easy to misuse '%pF/%pf' and '%pS/%ps' (see [1], for example). This patch set attempts to move ia64/ppc64/parisc64 C function pointer ABI details out of printk() to arch code. Function dereference code now checks if a pointer belongs to a .opd ELF section and dereferences that pointer only if it does. The kernel and modules have their own .opd sections that's why I use two different ARCH functions: for kernel and for module pointer dereference. I planned to remove dereference_function_descriptor() entirely, but then I discovered a bunch other uses cases (kgdbts, init/main.c, extable, etc.), so I decided to keep dereference_function_descriptor() around because the main point of this patch set is to deprecate %pF/%pf. But at the same time, I think I can go further and handle both kernel and module descriptor dereference in dereference_function_descriptor(). We need a module pointer for module .opd check, so that will come at an extra cost of module lookup (may be there will some other issues along the way, haven't checked it). Right now we've got: - dereference_function_descriptor(addr) a generic (old) function. it simply attempts to dereference whatever pointer we give it. - dereference_kernel_function_descriptor(addr) dereferences a kernel pointer if it's within the kernel's .opd section. - dereference_module_function_descriptor(module, addr) dereference a module pointer if it's within the module's .opd section. *** A BIG NOTE *** I don't own ia64/ppc64/parisc64 hardware, so the patches are not tested. Sorry about that! Another note: I need to check what is BPF symbol lookup and do we need to do any dereference there. [1] https://marc.info/?l=linux-kernel&m=150472969730573 Sergey Senozhatsky (5): sections: split dereference_function_descriptor() ia64: Add .opd based function descriptor dereference powerpc64: Add .opd based function descriptor dereference parisc64: Add .opd based function descriptor dereference symbol lookup: use new kernel and module dereference functions Documentation/printk-formats.txt | 15 +++++---------- arch/ia64/include/asm/sections.h | 14 +++++++++++++- arch/ia64/kernel/module.c | 13 +++++++++++++ arch/ia64/kernel/vmlinux.lds.S | 2 ++ arch/parisc/boot/compressed/vmlinux.lds.S | 2 ++ arch/parisc/include/asm/sections.h | 3 +++ arch/parisc/kernel/module.c | 14 ++++++++++++++ arch/parisc/kernel/process.c | 10 ++++++++++ arch/parisc/kernel/vmlinux.lds.S | 2 ++ arch/powerpc/include/asm/module.h | 3 +++ arch/powerpc/include/asm/sections.h | 13 +++++++++++++ arch/powerpc/kernel/module_64.c | 16 ++++++++++++++++ arch/powerpc/kernel/vmlinux.lds.S | 2 ++ include/asm-generic/sections.h | 4 ++-- include/linux/moduleloader.h | 4 ++++ kernel/kallsyms.c | 1 + kernel/module.c | 7 +++++++ lib/vsprintf.c | 5 +---- 18 files changed, 113 insertions(+), 17 deletions(-) -- 2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, "James E . J . Bottomley" <jejb@parisc-linux.org>, Helge Deller <deller@gmx.de> Cc: Petr Mladek <pmladek@suse.com>, Steven Rostedt <rostedt@goodmis.org>, Andrew Morton <akpm@linux-foundation.org>, Jessica Yu <jeyu@kernel.org>, Alexei Starovoitov <ast@kernel.org>, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Subject: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Date: Sat, 16 Sep 2017 03:53:42 +0000 [thread overview] Message-ID: <20170916035347.19705-1-sergey.senozhatsky@gmail.com> (raw) Hello RFC On some arches C function pointers are indirect and point to a function descriptor, which contains the actual pointer to the code. This mostly doesn't matter, except for cases when people want to print out function pointers in symbolic format, because the usual '%pS/%ps' does not work on those arches as expected. That's the reason why we have '%pF/%pf', but since it's here because of a subtle ABI detail specific to some arches (ppc64/ia64/parisc64) it's easy to misuse '%pF/%pf' and '%pS/%ps' (see [1], for example). This patch set attempts to move ia64/ppc64/parisc64 C function pointer ABI details out of printk() to arch code. Function dereference code now checks if a pointer belongs to a .opd ELF section and dereferences that pointer only if it does. The kernel and modules have their own .opd sections that's why I use two different ARCH functions: for kernel and for module pointer dereference. I planned to remove dereference_function_descriptor() entirely, but then I discovered a bunch other uses cases (kgdbts, init/main.c, extable, etc.), so I decided to keep dereference_function_descriptor() around because the main point of this patch set is to deprecate %pF/%pf. But at the same time, I think I can go further and handle both kernel and module descriptor dereference in dereference_function_descriptor(). We need a module pointer for module .opd check, so that will come at an extra cost of module lookup (may be there will some other issues along the way, haven't checked it). Right now we've got: - dereference_function_descriptor(addr) a generic (old) function. it simply attempts to dereference whatever pointer we give it. - dereference_kernel_function_descriptor(addr) dereferences a kernel pointer if it's within the kernel's .opd section. - dereference_module_function_descriptor(module, addr) dereference a module pointer if it's within the module's .opd section. *** A BIG NOTE *** I don't own ia64/ppc64/parisc64 hardware, so the patches are not tested. Sorry about that! Another note: I need to check what is BPF symbol lookup and do we need to do any dereference there. [1] https://marc.info/?l=linux-kernel&m\x150472969730573 Sergey Senozhatsky (5): sections: split dereference_function_descriptor() ia64: Add .opd based function descriptor dereference powerpc64: Add .opd based function descriptor dereference parisc64: Add .opd based function descriptor dereference symbol lookup: use new kernel and module dereference functions Documentation/printk-formats.txt | 15 +++++---------- arch/ia64/include/asm/sections.h | 14 +++++++++++++- arch/ia64/kernel/module.c | 13 +++++++++++++ arch/ia64/kernel/vmlinux.lds.S | 2 ++ arch/parisc/boot/compressed/vmlinux.lds.S | 2 ++ arch/parisc/include/asm/sections.h | 3 +++ arch/parisc/kernel/module.c | 14 ++++++++++++++ arch/parisc/kernel/process.c | 10 ++++++++++ arch/parisc/kernel/vmlinux.lds.S | 2 ++ arch/powerpc/include/asm/module.h | 3 +++ arch/powerpc/include/asm/sections.h | 13 +++++++++++++ arch/powerpc/kernel/module_64.c | 16 ++++++++++++++++ arch/powerpc/kernel/vmlinux.lds.S | 2 ++ include/asm-generic/sections.h | 4 ++-- include/linux/moduleloader.h | 4 ++++ kernel/kallsyms.c | 1 + kernel/module.c | 7 +++++++ lib/vsprintf.c | 5 +---- 18 files changed, 113 insertions(+), 17 deletions(-) -- 2.14.1
next reply other threads:[~2017-09-16 3:53 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-16 3:53 Sergey Senozhatsky [this message] 2017-09-16 3:53 ` [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Sergey Senozhatsky 2017-09-16 3:53 ` [PATCH 1/5] sections: split dereference_function_descriptor() Sergey Senozhatsky 2017-09-16 3:53 ` Sergey Senozhatsky 2017-09-16 3:53 ` [PATCH 2/5] ia64: Add .opd based function descriptor dereference Sergey Senozhatsky 2017-09-16 3:53 ` Sergey Senozhatsky 2017-09-16 3:53 ` [PATCH 3/5] powerpc64: " Sergey Senozhatsky 2017-09-16 3:53 ` Sergey Senozhatsky 2017-09-16 9:43 ` Naveen N. Rao 2017-09-16 9:55 ` Naveen N. Rao 2017-09-16 11:25 ` Sergey Senozhatsky 2017-09-16 11:25 ` Sergey Senozhatsky 2017-09-19 10:22 ` Michael Ellerman 2017-09-19 10:22 ` Michael Ellerman 2017-09-19 10:31 ` Sergey Senozhatsky 2017-09-19 10:31 ` Sergey Senozhatsky 2017-09-20 1:51 ` Michael Ellerman 2017-09-20 1:51 ` Michael Ellerman 2017-09-20 6:10 ` Sergey Senozhatsky 2017-09-20 6:10 ` Sergey Senozhatsky 2017-09-16 3:53 ` [PATCH 4/5] parisc64: " Sergey Senozhatsky 2017-09-16 3:53 ` Sergey Senozhatsky 2017-09-16 3:53 ` [PATCH 5/5] symbol lookup: use new kernel and module dereference functions Sergey Senozhatsky 2017-09-16 3:53 ` Sergey Senozhatsky 2017-09-18 17:44 ` [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Luck, Tony 2017-09-18 17:44 ` Luck, Tony 2017-09-18 18:39 ` Helge Deller 2017-09-18 18:39 ` Helge Deller 2017-09-19 2:05 ` Sergey Senozhatsky 2017-09-19 2:05 ` Sergey Senozhatsky 2017-09-19 13:38 ` David Laight 2017-09-19 20:07 ` Helge Deller 2017-09-19 20:07 ` Helge Deller 2017-09-20 8:41 ` David Laight 2017-09-20 8:41 ` David Laight 2017-09-20 10:20 ` Helge Deller 2017-09-20 10:20 ` Helge Deller 2017-09-20 16:31 ` Sergey Senozhatsky 2017-09-20 16:31 ` Sergey Senozhatsky 2017-09-19 14:07 ` Helge Deller 2017-09-19 14:07 ` Helge Deller 2017-09-19 20:03 ` Helge Deller 2017-09-19 20:03 ` Helge Deller 2017-09-20 0:47 ` Sergey Senozhatsky 2017-09-20 0:47 ` Sergey Senozhatsky 2017-09-19 2:08 ` Sergey Senozhatsky 2017-09-19 2:08 ` Sergey Senozhatsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170916035347.19705-1-sergey.senozhatsky@gmail.com \ --to=sergey.senozhatsky@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=ast@kernel.org \ --cc=benh@kernel.crashing.org \ --cc=deller@gmx.de \ --cc=fenghua.yu@intel.com \ --cc=jejb@parisc-linux.org \ --cc=jeyu@kernel.org \ --cc=linux-ia64@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-parisc@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=pmladek@suse.com \ --cc=rostedt@goodmis.org \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.