All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: David Laight <David.Laight@ACULAB.COM>,
	"'Sergey Senozhatsky'" <sergey.senozhatsky.work@gmail.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	Petr Mladek <pmladek@suse.com>, Jessica Yu <jeyu@kernel.org>,
	"James E . J . Bottomley" <jejb@parisc-linux.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers
Date: Tue, 19 Sep 2017 22:07:31 +0200	[thread overview]
Message-ID: <a7a0f1f6-781b-eba3-9b81-69b979503990@gmx.de> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>

On 19.09.2017 15:38, David Laight wrote:
> From: Sergey Senozhatsky
>> Sent: 19 September 2017 03:06
> ...
>> I'll simply convert everything to `unsigned long'. including the
>> dereference_function_descriptor() function [I believe there are
>> still some casts happening when we pass addr from kernel/module
>> dereference functions to dereference_function_descriptor(), or
>> when we return `void *' back to symbol resolution code, etc.)
>> besides, it seems that everything that uses
>> dereference_function_descriptor() wants `unsigned long' anyway:
> 
> Using 'unsigned long' for any kind of pointer is an accident
> waiting do happen.
> It also makes it difficult to typecheck the function calls.
> Using 'void *' isn't any better.
> Either a pointer to an undefined struct, or a struct containing
> a single 'char' member, is likely to be safest.

David, you might be right in most cases, but in this case I'd prefer
unsigned long too. I think this will create the least amount of
typecasts here.

Helge

WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de>
To: David Laight <David.Laight@ACULAB.COM>,
	'Sergey Senozhatsky' <sergey.senozhatsky.work@gmail.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	Petr Mladek <pmladek@suse.com>, Jessica Yu <jeyu@kernel.org>,
	"James E . J . Bottomley" <jejb@parisc-linux.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers
Date: Tue, 19 Sep 2017 20:07:31 +0000	[thread overview]
Message-ID: <a7a0f1f6-781b-eba3-9b81-69b979503990@gmx.de> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>

On 19.09.2017 15:38, David Laight wrote:
> From: Sergey Senozhatsky
>> Sent: 19 September 2017 03:06
> ...
>> I'll simply convert everything to `unsigned long'. including the
>> dereference_function_descriptor() function [I believe there are
>> still some casts happening when we pass addr from kernel/module
>> dereference functions to dereference_function_descriptor(), or
>> when we return `void *' back to symbol resolution code, etc.)
>> besides, it seems that everything that uses
>> dereference_function_descriptor() wants `unsigned long' anyway:
> 
> Using 'unsigned long' for any kind of pointer is an accident
> waiting do happen.
> It also makes it difficult to typecheck the function calls.
> Using 'void *' isn't any better.
> Either a pointer to an undefined struct, or a struct containing
> a single 'char' member, is likely to be safest.

David, you might be right in most cases, but in this case I'd prefer
unsigned long too. I think this will create the least amount of
typecasts here.

Helge

  reply	other threads:[~2017-09-19 20:08 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-16  3:53 [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Sergey Senozhatsky
2017-09-16  3:53 ` Sergey Senozhatsky
2017-09-16  3:53 ` [PATCH 1/5] sections: split dereference_function_descriptor() Sergey Senozhatsky
2017-09-16  3:53   ` Sergey Senozhatsky
2017-09-16  3:53 ` [PATCH 2/5] ia64: Add .opd based function descriptor dereference Sergey Senozhatsky
2017-09-16  3:53   ` Sergey Senozhatsky
2017-09-16  3:53 ` [PATCH 3/5] powerpc64: " Sergey Senozhatsky
2017-09-16  3:53   ` Sergey Senozhatsky
2017-09-16  9:43   ` Naveen N. Rao
2017-09-16  9:55     ` Naveen N. Rao
2017-09-16 11:25     ` Sergey Senozhatsky
2017-09-16 11:25       ` Sergey Senozhatsky
2017-09-19 10:22     ` Michael Ellerman
2017-09-19 10:22       ` Michael Ellerman
2017-09-19 10:31       ` Sergey Senozhatsky
2017-09-19 10:31         ` Sergey Senozhatsky
2017-09-20  1:51         ` Michael Ellerman
2017-09-20  1:51           ` Michael Ellerman
2017-09-20  6:10           ` Sergey Senozhatsky
2017-09-20  6:10             ` Sergey Senozhatsky
2017-09-16  3:53 ` [PATCH 4/5] parisc64: " Sergey Senozhatsky
2017-09-16  3:53   ` Sergey Senozhatsky
2017-09-16  3:53 ` [PATCH 5/5] symbol lookup: use new kernel and module dereference functions Sergey Senozhatsky
2017-09-16  3:53   ` Sergey Senozhatsky
2017-09-18 17:44 ` [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Luck, Tony
2017-09-18 17:44   ` Luck, Tony
2017-09-18 18:39   ` Helge Deller
2017-09-18 18:39     ` Helge Deller
2017-09-19  2:05     ` Sergey Senozhatsky
2017-09-19  2:05       ` Sergey Senozhatsky
2017-09-19 13:38       ` David Laight
2017-09-19 20:07         ` Helge Deller [this message]
2017-09-19 20:07           ` Helge Deller
2017-09-20  8:41           ` David Laight
2017-09-20  8:41             ` David Laight
2017-09-20 10:20             ` Helge Deller
2017-09-20 10:20               ` Helge Deller
2017-09-20 16:31               ` Sergey Senozhatsky
2017-09-20 16:31                 ` Sergey Senozhatsky
2017-09-19 14:07       ` Helge Deller
2017-09-19 14:07         ` Helge Deller
2017-09-19 20:03         ` Helge Deller
2017-09-19 20:03           ` Helge Deller
2017-09-20  0:47           ` Sergey Senozhatsky
2017-09-20  0:47             ` Sergey Senozhatsky
2017-09-19  2:08   ` Sergey Senozhatsky
2017-09-19  2:08     ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7a0f1f6-781b-eba3-9b81-69b979503990@gmx.de \
    --to=deller@gmx.de \
    --cc=David.Laight@ACULAB.COM \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=jejb@parisc-linux.org \
    --cc=jeyu@kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.