From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
davem@davemloft.net, kishon@ti.com, andrew@lunn.ch,
jason@lakedaemon.net, sebastian.hesselbarth@gmail.com,
gregory.clement@free-electrons.com, mw@semihalf.com,
stefanc@marvell.com, ymarkman@marvell.com,
thomas.petazzoni@free-electrons.com,
miquel.raynal@free-electrons.com, nadavh@marvell.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface
Date: Wed, 27 Dec 2017 23:42:52 +0100 [thread overview]
Message-ID: <20171227224252.GB2626@kwain> (raw)
In-Reply-To: <20171227222401.GT10595@n2100.armlinux.org.uk>
Hi Russell,
On Wed, Dec 27, 2017 at 10:24:01PM +0000, Russell King - ARM Linux wrote:
> On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote:
> >
> > +&cps_eth2 {
> > + /* CPS Lane 5 */
> > + status = "okay";
> > + phy-mode = "2500base-x";
> > + /* Generic PHY, providing serdes lanes */
> > + phys = <&cps_comphy5 2>;
> > +};
> > +
>
> This is wrong. This lane is connected to a SFP cage which can support
> more than just 2500base-X. Tying it in this way to 2500base-X means
> that this port does not support conenctions at 1000base-X, despite
> that's one of the most popular and more standardised speeds.
What do you suggest to describe this in the dt, to enable a port using
the current PPv2 driver?
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface
Date: Wed, 27 Dec 2017 23:42:52 +0100 [thread overview]
Message-ID: <20171227224252.GB2626@kwain> (raw)
In-Reply-To: <20171227222401.GT10595@n2100.armlinux.org.uk>
Hi Russell,
On Wed, Dec 27, 2017 at 10:24:01PM +0000, Russell King - ARM Linux wrote:
> On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote:
> >
> > +&cps_eth2 {
> > + /* CPS Lane 5 */
> > + status = "okay";
> > + phy-mode = "2500base-x";
> > + /* Generic PHY, providing serdes lanes */
> > + phys = <&cps_comphy5 2>;
> > +};
> > +
>
> This is wrong. This lane is connected to a SFP cage which can support
> more than just 2500base-X. Tying it in this way to 2500base-X means
> that this port does not support conenctions at 1000base-X, despite
> that's one of the most popular and more standardised speeds.
What do you suggest to describe this in the dt, to enable a port using
the current PPv2 driver?
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-27 22:43 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 22:14 [PATCH net-next 0/6] net: mvpp2: 1000BaseX and 2000BaseX support Antoine Tenart
2017-12-27 22:14 ` Antoine Tenart
2017-12-27 22:14 ` [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum Antoine Tenart
2017-12-27 22:14 ` Antoine Tenart
2017-12-28 7:20 ` Andrew Lunn
2017-12-28 7:20 ` Andrew Lunn
2017-12-28 10:06 ` Antoine Tenart
2017-12-28 10:06 ` Antoine Tenart
2017-12-28 14:16 ` Florian Fainelli
2017-12-28 14:16 ` Florian Fainelli
2017-12-28 18:24 ` Antoine Tenart
2017-12-28 18:24 ` Antoine Tenart
2018-01-03 14:35 ` Antoine Tenart
2018-01-03 14:35 ` Antoine Tenart
2018-01-03 15:08 ` Andrew Lunn
2018-01-03 15:08 ` Andrew Lunn
2018-01-03 17:29 ` Russell King - ARM Linux
2018-01-03 17:29 ` Russell King - ARM Linux
2017-12-27 22:14 ` [PATCH net-next 2/6] phy: cp110-comphy: 2.5G SGMII mode Antoine Tenart
2017-12-27 22:14 ` Antoine Tenart
2017-12-27 22:14 ` [PATCH net-next 3/6] net: mvpp2: 1000baseX support Antoine Tenart
2017-12-27 22:14 ` Antoine Tenart
2017-12-27 22:14 ` [PATCH net-next 4/6] net: mvpp2: 2500baseX support Antoine Tenart
2017-12-27 22:14 ` Antoine Tenart
2017-12-27 22:14 ` [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface Antoine Tenart
2017-12-27 22:14 ` Antoine Tenart
2017-12-27 22:24 ` Russell King - ARM Linux
2017-12-27 22:24 ` Russell King - ARM Linux
2017-12-27 22:42 ` Antoine Tenart [this message]
2017-12-27 22:42 ` Antoine Tenart
2017-12-27 23:20 ` Russell King - ARM Linux
2017-12-27 23:20 ` Russell King - ARM Linux
2017-12-28 10:04 ` Antoine Tenart
2017-12-28 10:04 ` Antoine Tenart
2017-12-28 18:59 ` Russell King - ARM Linux
2017-12-28 18:59 ` Russell King - ARM Linux
2017-12-29 21:41 ` Antoine Tenart
2017-12-29 21:41 ` Antoine Tenart
2017-12-28 7:46 ` Andrew Lunn
2017-12-28 7:46 ` Andrew Lunn
2017-12-28 7:46 ` Andrew Lunn
2017-12-28 10:05 ` Antoine Tenart
2017-12-28 10:05 ` Antoine Tenart
2017-12-28 15:02 ` Florian Fainelli
2017-12-28 15:02 ` Florian Fainelli
2017-12-28 18:27 ` Antoine Tenart
2017-12-28 18:27 ` Antoine Tenart
2017-12-28 18:46 ` Russell King - ARM Linux
2017-12-28 18:46 ` Russell King - ARM Linux
2017-12-29 11:12 ` Marcin Wojtas
2017-12-29 11:12 ` Marcin Wojtas
2017-12-29 11:38 ` Russell King - ARM Linux
2017-12-29 11:38 ` Russell King - ARM Linux
2017-12-30 16:34 ` Marcin Wojtas
2017-12-30 16:34 ` Marcin Wojtas
2017-12-30 17:31 ` Russell King - ARM Linux
2017-12-30 17:31 ` Russell King - ARM Linux
2018-01-01 10:18 ` Marcin Wojtas
2018-01-01 10:18 ` Marcin Wojtas
2018-01-01 10:35 ` [EXT] " Stefan Chulski
2018-01-01 10:35 ` Stefan Chulski
2018-01-01 13:25 ` Russell King - ARM Linux
2018-01-01 13:25 ` Russell King - ARM Linux
2018-01-01 13:25 ` Russell King - ARM Linux
2018-01-03 17:00 ` Stefan Chulski
2018-01-03 17:00 ` Stefan Chulski
2018-01-03 17:00 ` Stefan Chulski
2018-01-03 17:54 ` Russell King - ARM Linux
2018-01-03 17:54 ` Russell King - ARM Linux
2018-01-03 17:54 ` Russell King - ARM Linux
2018-01-03 18:17 ` Marcin Wojtas
2018-01-03 18:17 ` Marcin Wojtas
2018-01-03 18:26 ` Stefan Chulski
2018-01-03 18:26 ` Stefan Chulski
2018-01-03 18:26 ` Stefan Chulski
2017-12-27 22:14 ` [PATCH net-next 6/6] arm64: dts: marvell: add Ethernet aliases Antoine Tenart
2017-12-27 22:14 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227224252.GB2626@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.