All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, davem@davemloft.net,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
Date: Mon, 12 Feb 2018 10:29:57 -0200	[thread overview]
Message-ID: <20180212122957.GJ7402@localhost.localdomain> (raw)
In-Reply-To: <2ca12376b0b3b73833878279f20183bf03128626.1518431391.git.lucien.xin@gmail.com>

On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote:
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

> ---
>  net/sctp/debug.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 291c97b..8f6c2e8 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid)
>  	case SCTP_CID_RECONF:
>  		return "RECONF";
>  
> +	case SCTP_CID_I_DATA:
> +		return "I_DATA";
> +
> +	case SCTP_CID_I_FWD_TSN:
> +		return "I_FWD_TSN";
> +
>  	default:
>  		break;
>  	}
> -- 
> 2.1.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, davem@davemloft.net,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
Date: Mon, 12 Feb 2018 12:29:57 +0000	[thread overview]
Message-ID: <20180212122957.GJ7402@localhost.localdomain> (raw)
In-Reply-To: <2ca12376b0b3b73833878279f20183bf03128626.1518431391.git.lucien.xin@gmail.com>

On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote:
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

> ---
>  net/sctp/debug.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 291c97b..8f6c2e8 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid)
>  	case SCTP_CID_RECONF:
>  		return "RECONF";
>  
> +	case SCTP_CID_I_DATA:
> +		return "I_DATA";
> +
> +	case SCTP_CID_I_FWD_TSN:
> +		return "I_FWD_TSN";
> +
>  	default:
>  		break;
>  	}
> -- 
> 2.1.0
> 

  reply	other threads:[~2018-02-12 12:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 10:29 [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname Xin Long
2018-02-12 10:29 ` Xin Long
2018-02-12 12:29 ` Marcelo Ricardo Leitner [this message]
2018-02-12 12:29   ` Marcelo Ricardo Leitner
2018-02-12 14:01 ` Neil Horman
2018-02-12 14:01   ` Neil Horman
2018-02-12 16:47 ` David Miller
2018-02-12 16:47   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212122957.GJ7402@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.