* [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
@ 2018-02-12 10:29 ` Xin Long
0 siblings, 0 replies; 8+ messages in thread
From: Xin Long @ 2018-02-12 10:29 UTC (permalink / raw)
To: network dev, linux-sctp; +Cc: davem, Marcelo Ricardo Leitner, Neil Horman
After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
the corresp conversion in sctp_cname should also be added. Otherwise,
in some places, pr_debug will print them as "unknown chunk".
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/sctp/debug.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/net/sctp/debug.c b/net/sctp/debug.c
index 291c97b..8f6c2e8 100644
--- a/net/sctp/debug.c
+++ b/net/sctp/debug.c
@@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid)
case SCTP_CID_RECONF:
return "RECONF";
+ case SCTP_CID_I_DATA:
+ return "I_DATA";
+
+ case SCTP_CID_I_FWD_TSN:
+ return "I_FWD_TSN";
+
default:
break;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
2018-02-12 10:29 ` Xin Long
@ 2018-02-12 12:29 ` Marcelo Ricardo Leitner
-1 siblings, 0 replies; 8+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-02-12 12:29 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Neil Horman
On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote:
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/debug.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 291c97b..8f6c2e8 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid)
> case SCTP_CID_RECONF:
> return "RECONF";
>
> + case SCTP_CID_I_DATA:
> + return "I_DATA";
> +
> + case SCTP_CID_I_FWD_TSN:
> + return "I_FWD_TSN";
> +
> default:
> break;
> }
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
@ 2018-02-12 12:29 ` Marcelo Ricardo Leitner
0 siblings, 0 replies; 8+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-02-12 12:29 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Neil Horman
On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote:
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/debug.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 291c97b..8f6c2e8 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid)
> case SCTP_CID_RECONF:
> return "RECONF";
>
> + case SCTP_CID_I_DATA:
> + return "I_DATA";
> +
> + case SCTP_CID_I_FWD_TSN:
> + return "I_FWD_TSN";
> +
> default:
> break;
> }
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
2018-02-12 10:29 ` Xin Long
@ 2018-02-12 14:01 ` Neil Horman
-1 siblings, 0 replies; 8+ messages in thread
From: Neil Horman @ 2018-02-12 14:01 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Marcelo Ricardo Leitner
On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote:
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/sctp/debug.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 291c97b..8f6c2e8 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid)
> case SCTP_CID_RECONF:
> return "RECONF";
>
> + case SCTP_CID_I_DATA:
> + return "I_DATA";
> +
> + case SCTP_CID_I_FWD_TSN:
> + return "I_FWD_TSN";
> +
> default:
> break;
> }
> --
> 2.1.0
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
@ 2018-02-12 14:01 ` Neil Horman
0 siblings, 0 replies; 8+ messages in thread
From: Neil Horman @ 2018-02-12 14:01 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Marcelo Ricardo Leitner
On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote:
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/sctp/debug.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 291c97b..8f6c2e8 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid)
> case SCTP_CID_RECONF:
> return "RECONF";
>
> + case SCTP_CID_I_DATA:
> + return "I_DATA";
> +
> + case SCTP_CID_I_FWD_TSN:
> + return "I_FWD_TSN";
> +
> default:
> break;
> }
> --
> 2.1.0
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
2018-02-12 10:29 ` Xin Long
@ 2018-02-12 16:47 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-02-12 16:47 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 12 Feb 2018 18:29:51 +0800
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname
@ 2018-02-12 16:47 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-02-12 16:47 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 12 Feb 2018 18:29:51 +0800
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread