[PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

[PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

[Enric Balletbo i Serra]

From: Vincent Palatin <vpalatin@chromium.org>

If we cannot communicate with the EC chip to detect the protocol version
and its features, it's very likely useless to continue. Else we will
commit all kind of uninformed mistakes (using the wrong protocol, the
wrong buffer size, mixing the EC with other chips).

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Acked-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
 drivers/mfd/cros_ec.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index d61024141e2b..74780f2964a1 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -112,7 +112,11 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
 
 	mutex_init(&ec_dev->lock);
 
-	cros_ec_query_all(ec_dev);
+	err = cros_ec_query_all(ec_dev);
+	if (err) {
+		dev_err(dev, "Cannot identify the EC: error %d\n", err);
+		return err;
+	}
 
 	if (ec_dev->irq) {
 		err = request_threaded_irq(ec_dev->irq, NULL, ec_irq_thread,
-- 
2.16.1

Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

[Gwendal Grignou]

On Mon, Feb 19, 2018 at 2:46 PM, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
> From: Vincent Palatin <vpalatin@chromium.org>
>
> If we cannot communicate with the EC chip to detect the protocol version
> and its features, it's very likely useless to continue. Else we will
> commit all kind of uninformed mistakes (using the wrong protocol, the
> wrong buffer size, mixing the EC with other chips).
>
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> Acked-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
> ---
>  drivers/mfd/cros_ec.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index d61024141e2b..74780f2964a1 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -112,7 +112,11 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
>
>         mutex_init(&ec_dev->lock);
>
> -       cros_ec_query_all(ec_dev);
> +       err = cros_ec_query_all(ec_dev);
> +       if (err) {
> +               dev_err(dev, "Cannot identify the EC: error %d\n", err);
> +               return err;
> +       }
>
>         if (ec_dev->irq) {
>                 err = request_threaded_irq(ec_dev->irq, NULL, ec_irq_thread,
> --
> 2.16.1
>

Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

[Lee Jones]

On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote:

> From: Vincent Palatin <vpalatin@chromium.org>
> 
> If we cannot communicate with the EC chip to detect the protocol version
> and its features, it's very likely useless to continue. Else we will
> commit all kind of uninformed mistakes (using the wrong protocol, the
> wrong buffer size, mixing the EC with other chips).
> 
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> Acked-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>  drivers/mfd/cros_ec.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Unless it is my mailer that is playing up, it looks as though you have
sent this set un-threaded, which means that when others or myself
start replying to them one-by-one, they will be sprawled throughout my
inbox.  It also seems as though there is no 0th (cover letter) patch,
which means I am lacking potentially important information regarding
the history of the set and what you are trying to achieve.

Anyway, the patch has been applied this time (hopefully there aren't
any inter-dependencies.

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

[Lee Jones]

On Wed, 07 Mar 2018, Lee Jones wrote:

> On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote:
> 
> > From: Vincent Palatin <vpalatin@chromium.org>
> > 
> > If we cannot communicate with the EC chip to detect the protocol version
> > and its features, it's very likely useless to continue. Else we will
> > commit all kind of uninformed mistakes (using the wrong protocol, the
> > wrong buffer size, mixing the EC with other chips).
> > 
> > Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> > Acked-by: Benson Leung <bleung@chromium.org>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> >  drivers/mfd/cros_ec.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Unless it is my mailer that is playing up, it looks as though you have
> sent this set un-threaded, which means that when others or myself
> start replying to them one-by-one, they will be sprawled throughout my
> inbox.  It also seems as though there is no 0th (cover letter) patch,
> which means I am lacking potentially important information regarding
> the history of the set and what you are trying to achieve.
> 
> Anyway, the patch has been applied this time (hopefully there aren't
> any inter-dependencies.

As discussed in 2/6, I'm going to un-apply this.

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog