From: Cornelia Huck <cohuck@redhat.com> To: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Thomas Huth <thuth@redhat.com>, Farhan Ali <alifm@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org, geert@linux-m68k.org, tomi.valkeinen@ti.com, b.zolnierkie@samsung.com Subject: Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Date: Wed, 21 Feb 2018 13:07:55 +0100 [thread overview] Message-ID: <20180221130755.17d15f89.cohuck@redhat.com> (raw) In-Reply-To: <f6db4d0a-3578-4162-5de7-6e699f7a02c2@de.ibm.com> On Wed, 21 Feb 2018 12:49:35 +0100 Christian Borntraeger <borntraeger@de.ibm.com> wrote: > On 02/21/2018 12:29 PM, Thomas Huth wrote: > > On 21.02.2018 12:22, Christian Borntraeger wrote: > >> > >> > >> On 02/21/2018 12:14 PM, Thomas Huth wrote: > >>> On 21.02.2018 12:09, Christian Borntraeger wrote: > >>>> > >>>> > >>>> On 02/21/2018 11:32 AM, Cornelia Huck wrote: > >>>>> On Wed, 21 Feb 2018 11:22:38 +0100 > >>>>> Christian Borntraeger <borntraeger@de.ibm.com> wrote: > >>>>> > >>>>>> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: > >>>>>>> > >>>>>>> > >>>>>>> On 02/19/2018 05:38 PM, Farhan Ali wrote: > >>>>>>>> > >>>>>>>> > >>>>>>>> On 02/19/2018 11:25 AM, Thomas Huth wrote: > >>>>>>>>> On 19.02.2018 16:47, Farhan Ali wrote: > >>>>>>>>>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' > >>>>>>>>>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the > >>>>>>>>>> "Graphics support" menu for S390. But if we enable VT layer for S390, > >>>>>>>>>> we would also need to enable the dummy console. So let's remove the > >>>>>>>>>> HAS_IOMEM dependency. > >>>>>>>>>> > >>>>>>>>>> Move this dependency to sub menu items and console drivers that use > >>>>>>>>>> io memory. > >>>>>>>>>> > >>>>>>>>>> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com> > >>>>>>>>>> --- > >>>>>>>>>> drivers/video/Kconfig | 21 +++++++++++---------- > >>>>>>>>>> drivers/video/console/Kconfig | 4 ++-- > >>>>>>>>>> 2 files changed, 13 insertions(+), 12 deletions(-) > >>>>>>>>>> > >>>>>>>>>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > >>>>>>>>>> index 3c20af9..8f10915 100644 > >>>>>>>>>> --- a/drivers/video/Kconfig > >>>>>>>>>> +++ b/drivers/video/Kconfig > >>>>>>>>>> @@ -3,7 +3,6 @@ > >>>>>>>>>> # > >>>>>>>>>> menu "Graphics support" > >>>>>>>>>> - depends on HAS_IOMEM > >>>>>>>>>> config HAVE_FB_ATMEL > >>>>>>>>>> bool > >>>>>>>>>> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > >>>>>>>>>> config SH_LCD_MIPI_DSI > >>>>>>>>>> bool > >>>>>>>>>> -source "drivers/char/agp/Kconfig" > >>>>>>>>>> +if HAS_IOMEM > >>>>>>>>>> + source "drivers/char/agp/Kconfig" > >>>>>>>>>> -source "drivers/gpu/vga/Kconfig" > >>>>>>>>>> + source "drivers/gpu/vga/Kconfig" > >>>>>>>>>> -source "drivers/gpu/host1x/Kconfig" > >>>>>>>>>> -source "drivers/gpu/ipu-v3/Kconfig" > >>>>>>>>>> + source "drivers/gpu/host1x/Kconfig" > >>>>>>>>>> + source "drivers/gpu/ipu-v3/Kconfig" > >>>>>>>>>> -source "drivers/gpu/drm/Kconfig" > >>>>>>>>>> + source "drivers/gpu/drm/Kconfig" > >>>>>>> > >>>>>>> > >>>>>>> Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need still more > >>>>>>> work. > >>>>>>> > >>>>>> Sorry my fault. I had CONFIG_PCI disabled. > >>>>> > >>>>> That smells like the s390 HAS_IOMEM stuff needs more work -- I guess > >>>>> that you want to enable a ccw virtio-gpu device, not a pci one, right? > >>>> > >>>> It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you cannot > >>>> select VIRTIO_GPU, which needs DRM, which need IOMEM. > >>> > >>> So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside > >>> outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way? > >> > >> virtio-gpu depends on drm. So in essence it boils down to if you want virtio-gpu > >> you also need to enable PCI, even if the actual channel is ccw. > > > > But if you need to enable PCI to get IOMEM, I wonder why this patch here > > is needed at all? The Graphics menu / VT dummy console should be > > available in the config if IOMEM is enabled anyway? > > That is a good question. With CONFIG_PCI=y I can select virtio-gpu and dummy-console. > IIRC the issue was that with patch 3 we can have the situation where we have > CONFIG_VT = y and CONFIG_DUMMY_CONSOLE=n and this will crash early during boot as > conswitchp is NULL. So in practice, CONFIG_VT depends on "there's a console available, even if it's only the dummy one"? > This patches goal was to always enable dummy console even without > PCI, but it obviously fails to do so. OTOH, the dummy console really should not depend on anything, as it is only doing dummy things. > > So what about allowing CONFIG_VT on s390 only if we have PCI? > > > diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig > index 84810075a6a0..1c7fe09d6f90 100644 > --- a/drivers/tty/Kconfig > +++ b/drivers/tty/Kconfig > @@ -11,7 +11,7 @@ if TTY > > config VT > bool "Virtual terminal" if EXPERT > - depends on !UML > + depends on !UML && (!S390 || PCI) > select INPUT > default y > ---help--- > Would cover your use case, but feels wrong to me... config dependencies aren't fun :/
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com> To: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Thomas Huth <thuth@redhat.com>, Farhan Ali <alifm@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org, geert@linux-m68k.org, tomi.valkeinen@ti.com, b.zolnierkie@samsung.com Subject: Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Date: Wed, 21 Feb 2018 12:07:55 +0000 [thread overview] Message-ID: <20180221130755.17d15f89.cohuck@redhat.com> (raw) In-Reply-To: <f6db4d0a-3578-4162-5de7-6e699f7a02c2@de.ibm.com> On Wed, 21 Feb 2018 12:49:35 +0100 Christian Borntraeger <borntraeger@de.ibm.com> wrote: > On 02/21/2018 12:29 PM, Thomas Huth wrote: > > On 21.02.2018 12:22, Christian Borntraeger wrote: > >> > >> > >> On 02/21/2018 12:14 PM, Thomas Huth wrote: > >>> On 21.02.2018 12:09, Christian Borntraeger wrote: > >>>> > >>>> > >>>> On 02/21/2018 11:32 AM, Cornelia Huck wrote: > >>>>> On Wed, 21 Feb 2018 11:22:38 +0100 > >>>>> Christian Borntraeger <borntraeger@de.ibm.com> wrote: > >>>>> > >>>>>> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: > >>>>>>> > >>>>>>> > >>>>>>> On 02/19/2018 05:38 PM, Farhan Ali wrote: > >>>>>>>> > >>>>>>>> > >>>>>>>> On 02/19/2018 11:25 AM, Thomas Huth wrote: > >>>>>>>>> On 19.02.2018 16:47, Farhan Ali wrote: > >>>>>>>>>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' > >>>>>>>>>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the > >>>>>>>>>> "Graphics support" menu for S390. But if we enable VT layer for S390, > >>>>>>>>>> we would also need to enable the dummy console. So let's remove the > >>>>>>>>>> HAS_IOMEM dependency. > >>>>>>>>>> > >>>>>>>>>> Move this dependency to sub menu items and console drivers that use > >>>>>>>>>> io memory. > >>>>>>>>>> > >>>>>>>>>> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com> > >>>>>>>>>> --- > >>>>>>>>>> drivers/video/Kconfig | 21 +++++++++++---------- > >>>>>>>>>> drivers/video/console/Kconfig | 4 ++-- > >>>>>>>>>> 2 files changed, 13 insertions(+), 12 deletions(-) > >>>>>>>>>> > >>>>>>>>>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > >>>>>>>>>> index 3c20af9..8f10915 100644 > >>>>>>>>>> --- a/drivers/video/Kconfig > >>>>>>>>>> +++ b/drivers/video/Kconfig > >>>>>>>>>> @@ -3,7 +3,6 @@ > >>>>>>>>>> # > >>>>>>>>>> menu "Graphics support" > >>>>>>>>>> - depends on HAS_IOMEM > >>>>>>>>>> config HAVE_FB_ATMEL > >>>>>>>>>> bool > >>>>>>>>>> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > >>>>>>>>>> config SH_LCD_MIPI_DSI > >>>>>>>>>> bool > >>>>>>>>>> -source "drivers/char/agp/Kconfig" > >>>>>>>>>> +if HAS_IOMEM > >>>>>>>>>> + source "drivers/char/agp/Kconfig" > >>>>>>>>>> -source "drivers/gpu/vga/Kconfig" > >>>>>>>>>> + source "drivers/gpu/vga/Kconfig" > >>>>>>>>>> -source "drivers/gpu/host1x/Kconfig" > >>>>>>>>>> -source "drivers/gpu/ipu-v3/Kconfig" > >>>>>>>>>> + source "drivers/gpu/host1x/Kconfig" > >>>>>>>>>> + source "drivers/gpu/ipu-v3/Kconfig" > >>>>>>>>>> -source "drivers/gpu/drm/Kconfig" > >>>>>>>>>> + source "drivers/gpu/drm/Kconfig" > >>>>>>> > >>>>>>> > >>>>>>> Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need still more > >>>>>>> work. > >>>>>>> > >>>>>> Sorry my fault. I had CONFIG_PCI disabled. > >>>>> > >>>>> That smells like the s390 HAS_IOMEM stuff needs more work -- I guess > >>>>> that you want to enable a ccw virtio-gpu device, not a pci one, right? > >>>> > >>>> It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you cannot > >>>> select VIRTIO_GPU, which needs DRM, which need IOMEM. > >>> > >>> So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside > >>> outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way? > >> > >> virtio-gpu depends on drm. So in essence it boils down to if you want virtio-gpu > >> you also need to enable PCI, even if the actual channel is ccw. > > > > But if you need to enable PCI to get IOMEM, I wonder why this patch here > > is needed at all? The Graphics menu / VT dummy console should be > > available in the config if IOMEM is enabled anyway? > > That is a good question. With CONFIG_PCI=y I can select virtio-gpu and dummy-console. > IIRC the issue was that with patch 3 we can have the situation where we have > CONFIG_VT = y and CONFIG_DUMMY_CONSOLE=n and this will crash early during boot as > conswitchp is NULL. So in practice, CONFIG_VT depends on "there's a console available, even if it's only the dummy one"? > This patches goal was to always enable dummy console even without > PCI, but it obviously fails to do so. OTOH, the dummy console really should not depend on anything, as it is only doing dummy things. > > So what about allowing CONFIG_VT on s390 only if we have PCI? > > > diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig > index 84810075a6a0..1c7fe09d6f90 100644 > --- a/drivers/tty/Kconfig > +++ b/drivers/tty/Kconfig > @@ -11,7 +11,7 @@ if TTY > > config VT > bool "Virtual terminal" if EXPERT > - depends on !UML > + depends on !UML && (!S390 || PCI) > select INPUT > default y > ---help--- > Would cover your use case, but feels wrong to me... config dependencies aren't fun :/
next prev parent reply other threads:[~2018-02-21 12:08 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-19 15:47 [PATCH v3 0/3] Enable CONFIG_VT support for S390 Farhan Ali 2018-02-19 15:47 ` Farhan Ali 2018-02-19 15:47 ` [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Farhan Ali 2018-02-19 15:47 ` Farhan Ali 2018-02-19 16:25 ` Thomas Huth 2018-02-19 16:25 ` Thomas Huth 2018-02-19 16:38 ` Farhan Ali 2018-02-19 16:38 ` Farhan Ali 2018-02-21 10:05 ` Christian Borntraeger 2018-02-21 10:05 ` Christian Borntraeger 2018-02-21 10:22 ` Christian Borntraeger 2018-02-21 10:22 ` Christian Borntraeger 2018-02-21 10:32 ` Cornelia Huck 2018-02-21 10:32 ` Cornelia Huck 2018-02-21 11:09 ` Christian Borntraeger 2018-02-21 11:09 ` Christian Borntraeger 2018-02-21 11:14 ` Thomas Huth 2018-02-21 11:14 ` Thomas Huth 2018-02-21 11:22 ` Christian Borntraeger 2018-02-21 11:22 ` Christian Borntraeger 2018-02-21 11:29 ` Thomas Huth 2018-02-21 11:29 ` Thomas Huth 2018-02-21 11:49 ` Christian Borntraeger 2018-02-21 11:49 ` Christian Borntraeger 2018-02-21 12:07 ` Cornelia Huck [this message] 2018-02-21 12:07 ` Cornelia Huck 2018-02-21 12:11 ` Christian Borntraeger 2018-02-21 12:11 ` Christian Borntraeger 2018-02-21 16:39 ` Farhan Ali 2018-02-21 16:39 ` Farhan Ali 2018-02-22 7:34 ` Christian Borntraeger 2018-02-22 7:34 ` Christian Borntraeger 2018-02-21 11:23 ` Cornelia Huck 2018-02-21 11:23 ` Cornelia Huck 2018-02-21 8:44 ` Christian Borntraeger 2018-02-21 8:44 ` Christian Borntraeger 2018-02-21 11:50 ` Bartlomiej Zolnierkiewicz 2018-02-21 11:50 ` Bartlomiej Zolnierkiewicz 2018-02-19 15:47 ` [PATCH v3 2/3] s390/char : Rename EBCDIC keymap variables Farhan Ali 2018-02-19 15:47 ` Farhan Ali 2018-02-19 19:52 ` Thomas Huth 2018-02-19 19:52 ` Thomas Huth 2018-02-19 15:47 ` [PATCH v3 3/3] s390/setup : enable display support for KVM guest Farhan Ali 2018-02-19 15:47 ` Farhan Ali 2018-02-19 19:55 ` Thomas Huth 2018-02-19 19:55 ` Thomas Huth 2018-02-20 9:43 ` [PATCH v3 0/3] Enable CONFIG_VT support for S390 Christian Borntraeger 2018-02-20 9:43 ` Christian Borntraeger 2018-02-20 13:45 ` Farhan Ali
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180221130755.17d15f89.cohuck@redhat.com \ --to=cohuck@redhat.com \ --cc=alifm@linux.vnet.ibm.com \ --cc=b.zolnierkie@samsung.com \ --cc=borntraeger@de.ibm.com \ --cc=geert@linux-m68k.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=thuth@redhat.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.