From: Farhan Ali <alifm@linux.vnet.ibm.com> To: Thomas Huth <thuth@redhat.com>, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: geert@linux-m68k.org, borntraeger@de.ibm.com, tomi.valkeinen@ti.com, b.zolnierkie@samsung.com Subject: Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Date: Mon, 19 Feb 2018 11:38:59 -0500 [thread overview] Message-ID: <6cae85dc-76d5-1b92-ab13-a5e441eb84a0@linux.vnet.ibm.com> (raw) In-Reply-To: <cce8b082-c780-3559-4491-c39eb09482b0@redhat.com> On 02/19/2018 11:25 AM, Thomas Huth wrote: > On 19.02.2018 16:47, Farhan Ali wrote: >> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' >> added the HAS_IOMEM dependecy for "Graphics support". This disabled the >> "Graphics support" menu for S390. But if we enable VT layer for S390, >> we would also need to enable the dummy console. So let's remove the >> HAS_IOMEM dependency. >> >> Move this dependency to sub menu items and console drivers that use >> io memory. >> >> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com> >> --- >> drivers/video/Kconfig | 21 +++++++++++---------- >> drivers/video/console/Kconfig | 4 ++-- >> 2 files changed, 13 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >> index 3c20af9..8f10915 100644 >> --- a/drivers/video/Kconfig >> +++ b/drivers/video/Kconfig >> @@ -3,7 +3,6 @@ >> # >> >> menu "Graphics support" >> - depends on HAS_IOMEM >> >> config HAVE_FB_ATMEL >> bool >> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL >> config SH_LCD_MIPI_DSI >> bool >> >> -source "drivers/char/agp/Kconfig" >> +if HAS_IOMEM >> + source "drivers/char/agp/Kconfig" >> >> -source "drivers/gpu/vga/Kconfig" >> + source "drivers/gpu/vga/Kconfig" >> >> -source "drivers/gpu/host1x/Kconfig" >> -source "drivers/gpu/ipu-v3/Kconfig" >> + source "drivers/gpu/host1x/Kconfig" >> + source "drivers/gpu/ipu-v3/Kconfig" >> >> -source "drivers/gpu/drm/Kconfig" >> + source "drivers/gpu/drm/Kconfig" >> >> -menu "Frame buffer Devices" >> -source "drivers/video/fbdev/Kconfig" >> -endmenu >> + menu "Frame buffer Devices" >> + source "drivers/video/fbdev/Kconfig" >> + endmenu >> >> -source "drivers/video/backlight/Kconfig" >> + source "drivers/video/backlight/Kconfig" >> +endif >> >> config VGASTATE >> tristate >> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig >> index 7f1f1fb..0023b16 100644 >> --- a/drivers/video/console/Kconfig >> +++ b/drivers/video/console/Kconfig >> @@ -85,7 +85,7 @@ config MDA_CONSOLE >> >> config SGI_NEWPORT_CONSOLE >> tristate "SGI Newport Console support" >> - depends on SGI_IP22 >> + depends on SGI_IP22 && HAS_IOMEM >> select FONT_SUPPORT >> help >> Say Y here if you want the console on the Newport aka XL graphics >> @@ -153,7 +153,7 @@ config FRAMEBUFFER_CONSOLE_ROTATION >> >> config STI_CONSOLE >> bool "STI text console" >> - depends on PARISC >> + depends on PARISC && HAS_IOMEM >> select FONT_SUPPORT >> default y >> help >> > > Maybe config VGA_CONSOLE should depend on HAS_IOMEM, too? I think you > can hardly use a VGA card without IOMEM, can you? True, you can't. And I did think of adding the dependency for VGA, but VGA already is fenced off by many (almost all) architectures and I wasn't sure if it would be necessary. But I can add it. > Anyway, this approach now looks reasonable to me, so either way, feel > free to add my: > > Reviewed-by: Thomas Huth <thuth@redhat.com> > Thank you so much for reviewing. Appreciate your feedback :)
WARNING: multiple messages have this Message-ID (diff)
From: Farhan Ali <alifm@linux.vnet.ibm.com> To: Thomas Huth <thuth@redhat.com>, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: geert@linux-m68k.org, borntraeger@de.ibm.com, tomi.valkeinen@ti.com, b.zolnierkie@samsung.com Subject: Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Date: Mon, 19 Feb 2018 16:38:59 +0000 [thread overview] Message-ID: <6cae85dc-76d5-1b92-ab13-a5e441eb84a0@linux.vnet.ibm.com> (raw) In-Reply-To: <cce8b082-c780-3559-4491-c39eb09482b0@redhat.com> On 02/19/2018 11:25 AM, Thomas Huth wrote: > On 19.02.2018 16:47, Farhan Ali wrote: >> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' >> added the HAS_IOMEM dependecy for "Graphics support". This disabled the >> "Graphics support" menu for S390. But if we enable VT layer for S390, >> we would also need to enable the dummy console. So let's remove the >> HAS_IOMEM dependency. >> >> Move this dependency to sub menu items and console drivers that use >> io memory. >> >> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com> >> --- >> drivers/video/Kconfig | 21 +++++++++++---------- >> drivers/video/console/Kconfig | 4 ++-- >> 2 files changed, 13 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >> index 3c20af9..8f10915 100644 >> --- a/drivers/video/Kconfig >> +++ b/drivers/video/Kconfig >> @@ -3,7 +3,6 @@ >> # >> >> menu "Graphics support" >> - depends on HAS_IOMEM >> >> config HAVE_FB_ATMEL >> bool >> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL >> config SH_LCD_MIPI_DSI >> bool >> >> -source "drivers/char/agp/Kconfig" >> +if HAS_IOMEM >> + source "drivers/char/agp/Kconfig" >> >> -source "drivers/gpu/vga/Kconfig" >> + source "drivers/gpu/vga/Kconfig" >> >> -source "drivers/gpu/host1x/Kconfig" >> -source "drivers/gpu/ipu-v3/Kconfig" >> + source "drivers/gpu/host1x/Kconfig" >> + source "drivers/gpu/ipu-v3/Kconfig" >> >> -source "drivers/gpu/drm/Kconfig" >> + source "drivers/gpu/drm/Kconfig" >> >> -menu "Frame buffer Devices" >> -source "drivers/video/fbdev/Kconfig" >> -endmenu >> + menu "Frame buffer Devices" >> + source "drivers/video/fbdev/Kconfig" >> + endmenu >> >> -source "drivers/video/backlight/Kconfig" >> + source "drivers/video/backlight/Kconfig" >> +endif >> >> config VGASTATE >> tristate >> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig >> index 7f1f1fb..0023b16 100644 >> --- a/drivers/video/console/Kconfig >> +++ b/drivers/video/console/Kconfig >> @@ -85,7 +85,7 @@ config MDA_CONSOLE >> >> config SGI_NEWPORT_CONSOLE >> tristate "SGI Newport Console support" >> - depends on SGI_IP22 >> + depends on SGI_IP22 && HAS_IOMEM >> select FONT_SUPPORT >> help >> Say Y here if you want the console on the Newport aka XL graphics >> @@ -153,7 +153,7 @@ config FRAMEBUFFER_CONSOLE_ROTATION >> >> config STI_CONSOLE >> bool "STI text console" >> - depends on PARISC >> + depends on PARISC && HAS_IOMEM >> select FONT_SUPPORT >> default y >> help >> > > Maybe config VGA_CONSOLE should depend on HAS_IOMEM, too? I think you > can hardly use a VGA card without IOMEM, can you? True, you can't. And I did think of adding the dependency for VGA, but VGA already is fenced off by many (almost all) architectures and I wasn't sure if it would be necessary. But I can add it. > Anyway, this approach now looks reasonable to me, so either way, feel > free to add my: > > Reviewed-by: Thomas Huth <thuth@redhat.com> > Thank you so much for reviewing. Appreciate your feedback :)
next prev parent reply other threads:[~2018-02-19 16:39 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-19 15:47 [PATCH v3 0/3] Enable CONFIG_VT support for S390 Farhan Ali 2018-02-19 15:47 ` Farhan Ali 2018-02-19 15:47 ` [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Farhan Ali 2018-02-19 15:47 ` Farhan Ali 2018-02-19 16:25 ` Thomas Huth 2018-02-19 16:25 ` Thomas Huth 2018-02-19 16:38 ` Farhan Ali [this message] 2018-02-19 16:38 ` Farhan Ali 2018-02-21 10:05 ` Christian Borntraeger 2018-02-21 10:05 ` Christian Borntraeger 2018-02-21 10:22 ` Christian Borntraeger 2018-02-21 10:22 ` Christian Borntraeger 2018-02-21 10:32 ` Cornelia Huck 2018-02-21 10:32 ` Cornelia Huck 2018-02-21 11:09 ` Christian Borntraeger 2018-02-21 11:09 ` Christian Borntraeger 2018-02-21 11:14 ` Thomas Huth 2018-02-21 11:14 ` Thomas Huth 2018-02-21 11:22 ` Christian Borntraeger 2018-02-21 11:22 ` Christian Borntraeger 2018-02-21 11:29 ` Thomas Huth 2018-02-21 11:29 ` Thomas Huth 2018-02-21 11:49 ` Christian Borntraeger 2018-02-21 11:49 ` Christian Borntraeger 2018-02-21 12:07 ` Cornelia Huck 2018-02-21 12:07 ` Cornelia Huck 2018-02-21 12:11 ` Christian Borntraeger 2018-02-21 12:11 ` Christian Borntraeger 2018-02-21 16:39 ` Farhan Ali 2018-02-21 16:39 ` Farhan Ali 2018-02-22 7:34 ` Christian Borntraeger 2018-02-22 7:34 ` Christian Borntraeger 2018-02-21 11:23 ` Cornelia Huck 2018-02-21 11:23 ` Cornelia Huck 2018-02-21 8:44 ` Christian Borntraeger 2018-02-21 8:44 ` Christian Borntraeger 2018-02-21 11:50 ` Bartlomiej Zolnierkiewicz 2018-02-21 11:50 ` Bartlomiej Zolnierkiewicz 2018-02-19 15:47 ` [PATCH v3 2/3] s390/char : Rename EBCDIC keymap variables Farhan Ali 2018-02-19 15:47 ` Farhan Ali 2018-02-19 19:52 ` Thomas Huth 2018-02-19 19:52 ` Thomas Huth 2018-02-19 15:47 ` [PATCH v3 3/3] s390/setup : enable display support for KVM guest Farhan Ali 2018-02-19 15:47 ` Farhan Ali 2018-02-19 19:55 ` Thomas Huth 2018-02-19 19:55 ` Thomas Huth 2018-02-20 9:43 ` [PATCH v3 0/3] Enable CONFIG_VT support for S390 Christian Borntraeger 2018-02-20 9:43 ` Christian Borntraeger 2018-02-20 13:45 ` Farhan Ali
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6cae85dc-76d5-1b92-ab13-a5e441eb84a0@linux.vnet.ibm.com \ --to=alifm@linux.vnet.ibm.com \ --cc=b.zolnierkie@samsung.com \ --cc=borntraeger@de.ibm.com \ --cc=geert@linux-m68k.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=thuth@redhat.com \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.