Re: [RFC PATCH 08/12] libxl: Q35 support (new option device_model_machine)

[Wei Liu <wei.liu2@citrix.com>]

On Tue, Mar 20, 2018 at 09:11:10AM +0000, Roger Pau Monné wrote:
> On Tue, Mar 20, 2018 at 08:11:49AM +1000, Alexey G wrote:
> > On Mon, 19 Mar 2018 17:01:18 +0000
> > Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > >On Tue, Mar 13, 2018 at 04:33:53AM +1000, Alexey Gerasimenko wrote:
> > >> Provide a new domain config option to select the emulated machine
> > >> type, device_model_machine. It has following possible values:
> > >> - "i440" - i440 emulation (default)
> > >> - "q35" - emulate a Q35 machine. By default, the storage interface
> > >> is AHCI.  
> > >
> > >I would rather name this machine_chipset or device_model_chipset.
> > 
> > device_model_ prefix is a must I think -- multiple device model related
> > options have names starting with device_model_.
> > 
> > device_model_chipset... well, maybe, but we're actually specifying a
> > QEMU machine here. In QEMU mailing list there was even a suggestion
> > to allow to pass a machine version number here, like "pc-q35-2.10".
> > I think some opinions are needed here.
> 
> I'm not sure what a 'machine' is in QEMU speak, but in my mind I would
> consider PC a machine (vs ARM for example).
> 
> I think 'chipset' is clearer, but again others should express their
> opinion.

AIUI machine is a collection of chipset and peripherals, i.e. it covers
more than the chipset alone.

Cc Anthony for correction.

Wei.

> 
> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel