From: Sasha Levin <Alexander.Levin@microsoft.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Greg KH <gregkh@linuxfoundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "w@1wt.eu" <w@1wt.eu>, "ksummit-discuss@lists.linuxfoundation.org" <ksummit-discuss@lists.linuxfoundation.org> Subject: Re: [Ksummit-discuss] bug-introducing patches Date: Wed, 2 May 2018 19:51:40 +0000 [thread overview] Message-ID: <20180502195138.GC18390@sasha-vm> (raw) In-Reply-To: <CAMuHMdWNFz_9OpddZ6tTaQcNVH01pkhwd0+3Z31uDcZvbkV6Ow@mail.gmail.com> On Wed, May 02, 2018 at 05:32:37PM +0200, Geert Uytterhoeven wrote: >Hi Sasha, > >On Tue, May 1, 2018 at 6:38 PM, Sasha Levin ><Alexander.Levin@microsoft.com> wrote: >> Working on AUTOSEL, it became even more obvious to me how difficult it is for a >> patch to get a proper review. Maintainers found it difficult to keep up with >> the upstream work for their subsystem, and reviewing additional -stable patches >> put even more load on them which some suggested would be more than what they >> can handle. > >Thanks for your work! > >> - For some reason, the odds of a -rc commit to be targetted for -stable is >> over 20%, while for merge window commits it's about 3%. I can't quite >> explain why that happens, but this would suggest that -rc commits end up >> hurting -stable pretty badly. > >Aren't more -rc commits targeted for -stable because they are bugfixes? >Ideally, new features are supposed to be merged during the merge window, >while -rc commits fix bugs. new features can only be merged during a merge window, bug fixes can be merged at any point. >So they can be categorized like: > 1. Plain -rc commits, What's this exactly? -rc commits are only supposed to fix bugs. > 2. -rc commits fixing a bug: > a. in the same release cycle, > b. in a previous release. > >2a assumes the bug was backported to -stable, too, doesn't it? Bug fixes for features introduced in that release cycle won't be backported to stable. >Do you have statistics for which categories are most buggy? I haven't broken it down to subsystems for a few reasons: - My dataset is based on the Fixes: tag, some subsystems use it less than others. - Maintainers change, so even if one subsystem is being awesome about it today, it might not be the case in a year. - I don't really want to point fingers at a particular subsystem, I think that this is an issue at the kernel level.
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin via Ksummit-discuss <ksummit-discuss@lists.linuxfoundation.org> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Greg KH <gregkh@linuxfoundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "w@1wt.eu" <w@1wt.eu>, "ksummit-discuss@lists.linuxfoundation.org" <ksummit-discuss@lists.linuxfoundation.org> Subject: Re: [Ksummit-discuss] bug-introducing patches Date: Wed, 2 May 2018 19:51:40 +0000 [thread overview] Message-ID: <20180502195138.GC18390@sasha-vm> (raw) In-Reply-To: <CAMuHMdWNFz_9OpddZ6tTaQcNVH01pkhwd0+3Z31uDcZvbkV6Ow@mail.gmail.com> On Wed, May 02, 2018 at 05:32:37PM +0200, Geert Uytterhoeven wrote: >Hi Sasha, > >On Tue, May 1, 2018 at 6:38 PM, Sasha Levin ><Alexander.Levin@microsoft.com> wrote: >> Working on AUTOSEL, it became even more obvious to me how difficult it is for a >> patch to get a proper review. Maintainers found it difficult to keep up with >> the upstream work for their subsystem, and reviewing additional -stable patches >> put even more load on them which some suggested would be more than what they >> can handle. > >Thanks for your work! > >> - For some reason, the odds of a -rc commit to be targetted for -stable is >> over 20%, while for merge window commits it's about 3%. I can't quite >> explain why that happens, but this would suggest that -rc commits end up >> hurting -stable pretty badly. > >Aren't more -rc commits targeted for -stable because they are bugfixes? >Ideally, new features are supposed to be merged during the merge window, >while -rc commits fix bugs. new features can only be merged during a merge window, bug fixes can be merged at any point. >So they can be categorized like: > 1. Plain -rc commits, What's this exactly? -rc commits are only supposed to fix bugs. > 2. -rc commits fixing a bug: > a. in the same release cycle, > b. in a previous release. > >2a assumes the bug was backported to -stable, too, doesn't it? Bug fixes for features introduced in that release cycle won't be backported to stable. >Do you have statistics for which categories are most buggy? I haven't broken it down to subsystems for a few reasons: - My dataset is based on the Fixes: tag, some subsystems use it less than others. - Maintainers change, so even if one subsystem is being awesome about it today, it might not be the case in a year. - I don't really want to point fingers at a particular subsystem, I think that this is an issue at the kernel level. _______________________________________________ Ksummit-discuss mailing list Ksummit-discuss@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
next prev parent reply other threads:[~2018-05-02 19:51 UTC|newest] Thread overview: 289+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-01 16:38 bug-introducing patches Sasha Levin 2018-05-01 16:38 ` [Ksummit-discuss] " Sasha Levin 2018-05-01 19:44 ` Theodore Y. Ts'o 2018-05-01 19:44 ` Theodore Y. Ts'o 2018-05-01 20:00 ` Sasha Levin 2018-05-01 20:00 ` [Ksummit-discuss] " Sasha Levin 2018-05-01 20:33 ` Willy Tarreau 2018-05-01 20:48 ` [Ksummit-discuss] " Willy Tarreau 2018-05-01 20:42 ` Sasha Levin 2018-05-01 20:42 ` [Ksummit-discuss] " Sasha Levin 2018-05-01 20:54 ` Theodore Y. Ts'o 2018-05-01 20:54 ` Theodore Y. Ts'o 2018-05-01 21:15 ` Mark Brown 2018-05-01 21:15 ` Mark Brown 2018-05-02 8:11 ` Daniel Vetter 2018-05-02 8:11 ` Daniel Vetter 2018-05-02 19:46 ` Sasha Levin 2018-05-02 19:46 ` Sasha Levin via Ksummit-discuss 2018-05-03 2:05 ` Mark Brown 2018-05-03 2:05 ` Mark Brown via Ksummit-discuss 2018-05-03 3:10 ` Theodore Y. Ts'o 2018-05-03 3:10 ` Theodore Y. Ts'o 2018-05-03 3:52 ` Guenter Roeck 2018-05-03 3:52 ` Guenter Roeck 2018-05-03 12:03 ` Greg KH 2018-05-03 12:03 ` Greg KH 2018-05-03 22:42 ` Mark Brown 2018-05-03 22:42 ` Mark Brown 2018-05-03 23:09 ` Tony Lindgren 2018-05-03 23:09 ` Tony Lindgren 2018-05-04 14:21 ` Ulf Hansson 2018-05-04 14:21 ` Ulf Hansson 2018-05-09 8:44 ` Mark Brown 2018-05-09 8:44 ` Mark Brown 2018-05-09 8:47 ` Daniel Vetter 2018-05-09 8:47 ` Daniel Vetter 2018-05-09 8:51 ` Geert Uytterhoeven 2018-05-09 8:51 ` Geert Uytterhoeven 2018-05-09 9:03 ` Mark Brown 2018-05-09 9:03 ` Mark Brown 2018-05-09 10:47 ` Stephen Rothwell 2018-05-09 10:47 ` Stephen Rothwell 2018-05-09 10:55 ` Vinod Koul 2018-05-09 10:55 ` Vinod Koul 2018-05-09 12:43 ` Stephen Rothwell 2018-05-09 12:43 ` Stephen Rothwell 2018-05-09 12:47 ` Vinod Koul 2018-05-09 12:47 ` Vinod Koul 2018-05-15 10:42 ` Krzysztof Kozlowski 2018-05-15 10:42 ` Krzysztof Kozlowski 2018-05-15 11:54 ` Stephen Rothwell 2018-05-15 11:54 ` Stephen Rothwell 2018-05-09 14:05 ` Mark Brown 2018-05-09 14:05 ` Mark Brown 2018-05-09 22:09 ` Stephen Rothwell 2018-05-09 22:09 ` Stephen Rothwell 2018-05-10 13:36 ` Mark Brown 2018-05-10 13:36 ` Mark Brown 2018-05-10 22:01 ` Stephen Rothwell 2018-05-10 22:01 ` Stephen Rothwell 2018-05-09 15:57 ` Guenter Roeck 2018-05-09 15:57 ` Guenter Roeck 2018-05-09 21:45 ` Stephen Rothwell 2018-05-09 21:45 ` Stephen Rothwell 2018-05-09 16:04 ` Dan Williams 2018-05-09 16:04 ` Dan Williams 2018-05-09 16:04 ` Dan Williams 2018-05-09 21:51 ` Stephen Rothwell 2018-05-09 21:51 ` Stephen Rothwell 2018-05-09 21:51 ` Stephen Rothwell 2018-05-09 19:35 ` Boris Brezillon 2018-05-09 19:35 ` Boris Brezillon 2018-05-09 21:58 ` Stephen Rothwell 2018-05-09 21:58 ` Stephen Rothwell 2018-05-10 3:15 ` Sasha Levin 2018-05-10 3:15 ` Sasha Levin via Ksummit-discuss 2018-05-10 15:57 ` Tony Lindgren 2018-05-10 15:57 ` Tony Lindgren 2018-05-10 22:05 ` Stephen Rothwell 2018-05-10 22:05 ` Stephen Rothwell 2018-05-11 8:47 ` David Sterba 2018-05-11 8:49 ` David Sterba 2018-05-12 4:03 ` Stephen Rothwell 2018-05-12 4:03 ` Stephen Rothwell 2018-05-12 4:38 ` Stephen Rothwell 2018-05-12 4:38 ` Stephen Rothwell 2018-05-12 18:34 ` Guenter Roeck 2018-05-13 13:53 ` Andy Shevchenko 2018-05-13 13:53 ` Andy Shevchenko 2018-05-14 8:36 ` Ulf Hansson 2018-05-14 8:36 ` Ulf Hansson 2018-05-14 21:45 ` Stephen Rothwell 2018-05-14 21:45 ` Stephen Rothwell 2018-05-17 5:10 ` Mark Brown 2018-05-17 5:10 ` Mark Brown 2018-05-10 16:03 ` Jiri Kosina 2018-05-10 16:03 ` Jiri Kosina 2018-05-10 16:47 ` Sasha Levin 2018-05-10 16:47 ` Sasha Levin via Ksummit-discuss 2018-05-14 7:53 ` Geert Uytterhoeven 2018-05-14 7:53 ` Geert Uytterhoeven 2018-05-14 8:00 ` Geert Uytterhoeven 2018-05-14 8:00 ` Geert Uytterhoeven 2018-05-14 8:12 ` Boris Brezillon 2018-05-14 8:12 ` Boris Brezillon 2018-05-14 8:29 ` Geert Uytterhoeven 2018-05-14 8:29 ` Geert Uytterhoeven 2018-05-14 8:34 ` Boris Brezillon 2018-05-14 8:34 ` Boris Brezillon 2018-05-14 8:40 ` Geert Uytterhoeven 2018-05-14 8:40 ` Geert Uytterhoeven 2018-05-14 8:48 ` Boris Brezillon 2018-05-14 8:48 ` Boris Brezillon 2018-05-14 9:25 ` Fengguang Wu 2018-05-14 9:25 ` Fengguang Wu 2018-05-11 2:10 ` Mark Brown 2018-05-11 2:10 ` Mark Brown 2018-05-08 2:34 ` Sasha Levin 2018-05-08 2:34 ` Sasha Levin 2018-05-08 3:48 ` Theodore Y. Ts'o 2018-05-08 3:48 ` Theodore Y. Ts'o 2018-05-08 14:49 ` Tony Lindgren 2018-05-09 8:13 ` Mark Brown 2018-05-09 8:13 ` Mark Brown 2018-05-10 15:36 ` Tony Lindgren 2018-05-10 15:36 ` Tony Lindgren 2018-05-08 20:29 ` Sasha Levin 2018-05-08 20:29 ` Sasha Levin via Ksummit-discuss 2018-05-08 20:40 ` Matthew Wilcox 2018-05-08 20:40 ` Matthew Wilcox 2018-05-08 20:55 ` Sasha Levin 2018-05-08 20:55 ` Sasha Levin 2018-05-08 20:59 ` David Lang 2018-05-08 21:06 ` David Lang 2018-05-08 21:43 ` Sasha Levin 2018-05-08 21:43 ` Sasha Levin via Ksummit-discuss 2018-05-08 21:51 ` Dan Williams 2018-05-08 21:51 ` Dan Williams 2018-05-08 22:41 ` James Bottomley 2018-05-08 22:41 ` James Bottomley 2018-05-08 21:26 ` Justin Forbes 2018-05-08 21:26 ` Justin Forbes 2018-05-08 21:00 ` Ken Moffat 2018-05-08 21:08 ` Ken Moffat 2018-05-08 22:15 ` Theodore Y. Ts'o 2018-05-10 16:39 ` Sasha Levin 2018-05-09 4:47 ` Willy Tarreau 2018-05-09 4:47 ` Willy Tarreau 2018-05-08 13:58 ` Justin Forbes 2018-05-08 13:58 ` Justin Forbes 2018-05-08 2:39 ` Sasha Levin 2018-05-08 2:39 ` Sasha Levin via Ksummit-discuss 2018-05-01 22:02 ` Sasha Levin 2018-05-01 22:02 ` [Ksummit-discuss] " Sasha Levin 2018-05-02 4:30 ` Willy Tarreau 2018-05-02 4:30 ` [Ksummit-discuss] " Willy Tarreau 2018-05-02 19:42 ` Sasha Levin 2018-05-02 19:42 ` Sasha Levin 2018-05-02 20:02 ` Willy Tarreau 2018-05-02 20:02 ` [Ksummit-discuss] " Willy Tarreau 2018-07-14 17:38 ` Pavel Machek 2018-07-14 17:38 ` Pavel Machek 2018-07-14 18:37 ` [Ksummit-discuss] " Guenter Roeck 2018-07-14 18:37 ` Guenter Roeck 2018-07-14 19:47 ` Pavel Machek 2018-07-14 19:47 ` Pavel Machek 2018-07-14 20:40 ` Guenter Roeck 2018-07-14 20:40 ` Guenter Roeck 2018-07-14 21:09 ` Pavel Machek 2018-07-14 21:09 ` Pavel Machek 2018-07-15 5:57 ` Willy Tarreau 2018-07-15 5:57 ` Willy Tarreau 2018-07-15 8:54 ` Greg KH 2018-07-15 8:54 ` Greg KH 2018-07-15 14:50 ` [Ksummit-discuss] " Theodore Y. Ts'o 2018-07-15 14:50 ` Theodore Y. Ts'o 2018-07-15 20:15 ` [Ksummit-discuss] " Pavel Machek 2018-07-15 20:15 ` Pavel Machek 2018-05-03 11:08 ` [Ksummit-discuss] " Jani Nikula 2018-05-03 11:08 ` Jani Nikula 2018-05-03 14:33 ` James Bottomley 2018-05-03 14:33 ` James Bottomley 2018-05-03 14:48 ` Willy Tarreau 2018-05-03 14:49 ` Willy Tarreau 2018-05-03 15:06 ` Sasha Levin 2018-05-03 15:06 ` Sasha Levin via Ksummit-discuss 2018-05-03 15:27 ` James Bottomley 2018-05-03 15:27 ` James Bottomley 2018-05-03 15:43 ` Sasha Levin 2018-05-03 15:43 ` Sasha Levin via Ksummit-discuss 2018-05-03 17:17 ` Randy Dunlap 2018-05-03 17:17 ` Randy Dunlap 2018-05-03 17:39 ` Sasha Levin 2018-05-03 17:39 ` Sasha Levin via Ksummit-discuss 2018-05-03 18:10 ` James Bottomley 2018-05-03 18:10 ` James Bottomley 2018-05-03 15:56 ` Willy Tarreau 2018-05-03 15:57 ` Willy Tarreau 2018-05-03 18:58 ` Theodore Y. Ts'o 2018-05-03 18:58 ` Theodore Y. Ts'o 2018-05-01 23:28 ` Stephen Rothwell 2018-05-01 23:10 ` Stephen Rothwell 2018-05-02 15:32 ` Geert Uytterhoeven 2018-05-02 15:32 ` Geert Uytterhoeven 2018-05-02 19:51 ` Sasha Levin [this message] 2018-05-02 19:51 ` Sasha Levin via Ksummit-discuss 2018-05-02 20:41 ` Geert Uytterhoeven 2018-05-02 20:41 ` Geert Uytterhoeven 2018-05-03 0:06 ` [Ksummit-discuss] " Theodore Y. Ts'o 2018-05-03 0:06 ` Theodore Y. Ts'o 2018-05-03 0:38 ` Guenter Roeck 2018-05-03 0:38 ` Guenter Roeck 2018-05-03 2:30 ` Willy Tarreau 2018-05-03 2:30 ` Willy Tarreau 2018-05-03 14:55 ` Sasha Levin 2018-05-03 14:55 ` Sasha Levin 2018-05-03 15:49 ` Guenter Roeck 2018-05-03 15:49 ` Guenter Roeck 2018-05-03 16:02 ` Sasha Levin 2018-05-03 16:02 ` Sasha Levin via Ksummit-discuss 2018-05-03 16:50 ` Justin Forbes 2018-05-03 16:50 ` Justin Forbes 2018-05-03 17:09 ` Guenter Roeck 2018-05-03 17:09 ` Guenter Roeck 2018-05-03 11:48 ` Al Viro 2018-05-03 14:46 ` Sasha Levin 2018-05-03 14:46 ` Sasha Levin via Ksummit-discuss 2018-05-03 14:52 ` Willy Tarreau 2018-05-03 14:52 ` Willy Tarreau 2018-05-03 15:01 ` Sasha Levin 2018-05-03 15:01 ` Sasha Levin via Ksummit-discuss 2018-05-03 16:00 ` Willy Tarreau 2018-05-03 16:01 ` Willy Tarreau 2018-05-03 16:14 ` Sasha Levin 2018-05-03 16:15 ` Sasha Levin 2018-05-03 16:35 ` Willy Tarreau 2018-05-03 16:35 ` Willy Tarreau 2018-05-03 17:29 ` Sasha Levin 2018-05-03 17:29 ` Sasha Levin via Ksummit-discuss 2018-05-03 17:57 ` Willy Tarreau 2018-05-03 17:57 ` Willy Tarreau 2018-05-03 18:12 ` Sasha Levin 2018-05-03 18:12 ` Sasha Levin 2018-05-03 18:46 ` Guenter Roeck 2018-05-03 18:46 ` Guenter Roeck 2018-05-03 19:03 ` Willy Tarreau 2018-05-03 19:03 ` Willy Tarreau 2018-05-03 16:54 ` Al Viro 2018-05-03 16:54 ` Al Viro 2018-05-03 17:34 ` Sasha Levin 2018-05-03 17:34 ` Sasha Levin via Ksummit-discuss 2018-05-03 18:20 ` Al Viro 2018-05-03 18:20 ` Al Viro 2018-05-03 18:55 ` Greg KH 2018-05-03 18:55 ` Greg KH 2018-05-03 19:14 ` Willy Tarreau 2018-05-03 19:14 ` Willy Tarreau 2018-05-03 19:17 ` Sasha Levin 2018-05-03 19:17 ` Sasha Levin via Ksummit-discuss 2018-05-03 19:04 ` Sasha Levin 2018-05-03 19:04 ` Sasha Levin 2018-05-04 9:57 ` David Howells 2018-05-04 9:57 ` David Howells 2018-05-04 12:31 ` Jani Nikula 2018-05-04 12:31 ` Jani Nikula 2018-05-04 13:09 ` Theodore Y. Ts'o 2018-05-04 13:09 ` Theodore Y. Ts'o 2018-05-04 17:40 ` Greg KH 2018-05-04 17:40 ` Greg KH 2018-05-04 21:13 ` Theodore Y. Ts'o 2018-05-04 21:13 ` Theodore Y. Ts'o 2018-05-04 21:38 ` James Bottomley 2018-05-04 21:38 ` James Bottomley 2018-05-04 21:51 ` Sasha Levin 2018-05-04 21:51 ` Sasha Levin 2018-05-04 23:35 ` Theodore Y. Ts'o 2018-05-04 23:35 ` Theodore Y. Ts'o 2018-05-05 4:23 ` Willy Tarreau 2018-05-05 4:24 ` Willy Tarreau 2018-05-05 5:02 ` Eric W. Biederman 2018-05-05 5:02 ` Eric W. Biederman 2018-05-05 16:37 ` Greg KH 2018-05-05 16:37 ` Greg KH 2018-05-05 5:27 ` Sasha Levin 2018-05-05 5:27 ` Sasha Levin via Ksummit-discuss 2018-05-03 11:43 ` Al Viro 2018-05-03 11:43 ` Al Viro 2018-05-02 15:32 ` Geert Uytterhoeven 2018-05-02 15:32 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180502195138.GC18390@sasha-vm \ --to=alexander.levin@microsoft.com \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=ksummit-discuss@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=w@1wt.eu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.