* [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N
@ 2018-05-17 15:43 David Ahern
2018-05-17 16:02 ` Sergei Shtylyov
2018-05-17 16:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: David Ahern @ 2018-05-17 15:43 UTC (permalink / raw)
To: netdev; +Cc: alexandre.belloni, David Ahern
Other ethernet drivers default to N. There is no reason for Microsemi
to default to y. I believe Linus has set the bar at a feature that cures
cancer can be enabled by default. [1]
[1] https://lkml.org/lkml/2010/3/2/366
Signed-off-by: David Ahern <dsahern@gmail.com>
---
drivers/net/ethernet/mscc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mscc/Kconfig b/drivers/net/ethernet/mscc/Kconfig
index 36c84625d54e..0ef40b05c8af 100644
--- a/drivers/net/ethernet/mscc/Kconfig
+++ b/drivers/net/ethernet/mscc/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: (GPL-2.0 OR MIT)
config NET_VENDOR_MICROSEMI
bool "Microsemi devices"
- default y
+ default n
help
If you have a network (Ethernet) card belonging to this class, say Y.
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N
2018-05-17 15:43 [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N David Ahern
@ 2018-05-17 16:02 ` Sergei Shtylyov
2018-05-17 16:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2018-05-17 16:02 UTC (permalink / raw)
To: David Ahern, netdev; +Cc: alexandre.belloni
On 05/17/2018 06:43 PM, David Ahern wrote:
> Other ethernet drivers default to N. There is no reason for Microsemi
> to default to y. I believe Linus has set the bar at a feature that cures
> cancer can be enabled by default. [1]
>
> [1] https://lkml.org/lkml/2010/3/2/366
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> drivers/net/ethernet/mscc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mscc/Kconfig b/drivers/net/ethernet/mscc/Kconfig
> index 36c84625d54e..0ef40b05c8af 100644
> --- a/drivers/net/ethernet/mscc/Kconfig
> +++ b/drivers/net/ethernet/mscc/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: (GPL-2.0 OR MIT)
> config NET_VENDOR_MICROSEMI
> bool "Microsemi devices"
> - default y
> + default n
You know that N is the default default? :-)
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N
2018-05-17 15:43 [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N David Ahern
2018-05-17 16:02 ` Sergei Shtylyov
@ 2018-05-17 16:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-05-17 16:32 UTC (permalink / raw)
To: dsahern; +Cc: netdev, alexandre.belloni
From: David Ahern <dsahern@gmail.com>
Date: Thu, 17 May 2018 08:43:30 -0700
> Other ethernet drivers default to N. There is no reason for Microsemi
> to default to y. I believe Linus has set the bar at a feature that cures
> cancer can be enabled by default. [1]
>
> [1] https://lkml.org/lkml/2010/3/2/366
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
For "drivers" yes, those should default to N. But for vendor guards
like this, they should default to Y.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-17 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-17 15:43 [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N David Ahern
2018-05-17 16:02 ` Sergei Shtylyov
2018-05-17 16:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.