All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Ray Jui <ray.jui@broadcom.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Frank Rowand <frowand.list@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] Documentation: DT: Add optional 'timeout-sec' property for sp805
Date: Wed, 23 May 2018 11:10:58 -0700	[thread overview]
Message-ID: <20180523181058.GC27570@roeck-us.net> (raw)
In-Reply-To: <af81ea74-fb80-11e2-7bdc-d3607bdbd46b@arm.com>

On Wed, May 23, 2018 at 11:57:25AM +0100, Robin Murphy wrote:
> On 22/05/18 19:47, Ray Jui wrote:
> >Update the SP805 binding document to add optional 'timeout-sec'
> >devicetree property
> >
> >Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> >Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> >---
> >  Documentation/devicetree/bindings/watchdog/sp805-wdt.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> >diff --git a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
> >index edc4f0e..f898a86 100644
> >--- a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
> >+++ b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
> >@@ -19,6 +19,8 @@ Required properties:
> >  Optional properties:
> >  - interrupts : Should specify WDT interrupt number.
> >+- timeout-sec : Should specify default WDT timeout in seconds. If unset, the
> >+                default timeout is 30 seconds
> 
> According to the SP805 TRM, the default interval is dependent on the rate of
> WDOGCLK, but would typically be a lot longer than that :/
> 
Depends on the definition of "default". In the context of watchdog drivers,
it is (or should be) a driver default, not a chip default.

Guenter

> On a related note, anyone have any idea why we seem to have two subtly
> different SP805 bindings defined?
> 
> Robin.
> 
> >  Examples:
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] Documentation: DT: Add optional 'timeout-sec' property for sp805
Date: Wed, 23 May 2018 11:10:58 -0700	[thread overview]
Message-ID: <20180523181058.GC27570@roeck-us.net> (raw)
In-Reply-To: <af81ea74-fb80-11e2-7bdc-d3607bdbd46b@arm.com>

On Wed, May 23, 2018 at 11:57:25AM +0100, Robin Murphy wrote:
> On 22/05/18 19:47, Ray Jui wrote:
> >Update the SP805 binding document to add optional 'timeout-sec'
> >devicetree property
> >
> >Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> >Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> >---
> >  Documentation/devicetree/bindings/watchdog/sp805-wdt.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> >diff --git a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
> >index edc4f0e..f898a86 100644
> >--- a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
> >+++ b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
> >@@ -19,6 +19,8 @@ Required properties:
> >  Optional properties:
> >  - interrupts : Should specify WDT interrupt number.
> >+- timeout-sec : Should specify default WDT timeout in seconds. If unset, the
> >+                default timeout is 30 seconds
> 
> According to the SP805 TRM, the default interval is dependent on the rate of
> WDOGCLK, but would typically be a lot longer than that :/
> 
Depends on the definition of "default". In the context of watchdog drivers,
it is (or should be) a driver default, not a chip default.

Guenter

> On a related note, anyone have any idea why we seem to have two subtly
> different SP805 bindings defined?
> 
> Robin.
> 
> >  Examples:
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-05-23 18:11 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 18:47 [PATCH 0/5] Enhance support for the SP805 WDT Ray Jui
2018-05-22 18:47 ` Ray Jui
2018-05-22 18:47 ` [PATCH 1/5] Documentation: DT: Add optional 'timeout-sec' property for sp805 Ray Jui
2018-05-22 18:47   ` Ray Jui
2018-05-22 20:56   ` Guenter Roeck
2018-05-22 20:56     ` Guenter Roeck
2018-05-23 10:57   ` Robin Murphy
2018-05-23 10:57     ` Robin Murphy
2018-05-23 16:25     ` Ray Jui
2018-05-23 16:25       ` Ray Jui
2018-05-23 18:59       ` Rob Herring
2018-05-23 18:59         ` Rob Herring
2018-05-23 19:29         ` Ray Jui
2018-05-23 19:29           ` Ray Jui
2018-05-24 13:52           ` Robin Murphy
2018-05-24 13:52             ` Robin Murphy
2018-05-23 18:10     ` Guenter Roeck [this message]
2018-05-23 18:10       ` Guenter Roeck
2018-05-24 13:25       ` Robin Murphy
2018-05-24 13:25         ` Robin Murphy
2018-05-24 16:07         ` Guenter Roeck
2018-05-24 16:07           ` Guenter Roeck
2018-05-22 18:47 ` [PATCH 2/5] watchdog: sp805: add 'timeout-sec' DT property support Ray Jui
2018-05-22 18:47   ` Ray Jui
2018-05-22 20:57   ` Guenter Roeck
2018-05-22 20:57     ` Guenter Roeck
2018-05-22 18:47 ` [PATCH 3/5] watchdog: sp805: set WDOG_HW_RUNNING when appropriate Ray Jui
2018-05-22 18:47   ` Ray Jui
2018-05-22 20:54   ` Guenter Roeck
2018-05-22 20:54     ` Guenter Roeck
2018-05-22 23:24     ` Ray Jui
2018-05-22 23:24       ` Ray Jui
2018-05-23  7:52       ` Scott Branden
2018-05-23  7:52         ` Scott Branden
2018-05-23 11:48         ` Robin Murphy
2018-05-23 11:48           ` Robin Murphy
2018-05-23 16:29           ` Ray Jui
2018-05-23 16:29             ` Ray Jui
2018-05-23 17:15             ` Robin Murphy
2018-05-23 17:15               ` Robin Murphy
2018-05-23 18:09               ` Guenter Roeck
2018-05-23 18:09                 ` Guenter Roeck
2018-05-23 19:35                 ` Ray Jui
2018-05-23 19:35                   ` Ray Jui
2018-05-23 17:15             ` Scott Branden
2018-05-23 17:15               ` Scott Branden
2018-05-23 18:06           ` Guenter Roeck
2018-05-23 18:06             ` Guenter Roeck
2018-05-22 18:47 ` [PATCH 4/5] arm64: dt: set initial SR watchdog timeout to 60 seconds Ray Jui
2018-05-22 18:47   ` Ray Jui
2018-05-22 18:47 ` [PATCH 5/5] arm64: defconfig: add CONFIG_ARM_SP805_WATCHDOG Ray Jui
2018-05-22 18:47   ` Ray Jui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523181058.GC27570@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ray.jui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will.deacon@arm.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.