* [PATCH] sqlite3: consistent set of features for nativesdk
@ 2018-06-15 7:56 S. Lockwood-Childs
2018-06-15 18:54 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: S. Lockwood-Childs @ 2018-06-15 7:56 UTC (permalink / raw)
To: openembedded-core
Enable use of pread() and enable column metadata API for nativesdk builds.
This brings nativesdk in line with target and native builds.
---
meta/recipes-support/sqlite/sqlite3.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
index 95ec89c..30847b9 100644
--- a/meta/recipes-support/sqlite/sqlite3.inc
+++ b/meta/recipes-support/sqlite/sqlite3.inc
@@ -37,10 +37,12 @@ CFLAGS_append = " -fPIC"
# pread() is in POSIX.1-2001 so any reasonable system must surely support it
BUILD_CFLAGS += "-DUSE_PREAD"
+BUILDSDK_CFLAGS += "-DUSE_PREAD"
TARGET_CFLAGS += "-DUSE_PREAD"
# Provide column meta-data API
BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
+BUILDSDK_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
--
1.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sqlite3: consistent set of features for nativesdk
2018-06-15 7:56 [PATCH] sqlite3: consistent set of features for nativesdk S. Lockwood-Childs
@ 2018-06-15 18:54 ` Khem Raj
2018-06-15 19:26 ` [PATCH V2] " S. Lockwood-Childs
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2018-06-15 18:54 UTC (permalink / raw)
To: S. Lockwood-Childs, Patches and discussions about the oe-core layer
On Fri, Jun 15, 2018 at 12:58 AM S. Lockwood-Childs <sjl@vctlabs.com> wrote:
>
> Enable use of pread() and enable column metadata API for nativesdk builds.
> This brings nativesdk in line with target and native builds.
> ---
> meta/recipes-support/sqlite/sqlite3.inc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
> index 95ec89c..30847b9 100644
> --- a/meta/recipes-support/sqlite/sqlite3.inc
> +++ b/meta/recipes-support/sqlite/sqlite3.inc
> @@ -37,10 +37,12 @@ CFLAGS_append = " -fPIC"
>
> # pread() is in POSIX.1-2001 so any reasonable system must surely support it
> BUILD_CFLAGS += "-DUSE_PREAD"
> +BUILDSDK_CFLAGS += "-DUSE_PREAD"
> TARGET_CFLAGS += "-DUSE_PREAD"
>
Perhaps, we can just add it to CPPFLAGS and remove all three lines above
> # Provide column meta-data API
> BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
> +BUILDSDK_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
> TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
>
same as above
> PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
> --
> 1.9.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V2] sqlite3: consistent set of features for nativesdk
2018-06-15 18:54 ` Khem Raj
@ 2018-06-15 19:26 ` S. Lockwood-Childs
0 siblings, 0 replies; 3+ messages in thread
From: S. Lockwood-Childs @ 2018-06-15 19:26 UTC (permalink / raw)
To: openembedded-core
Enable use of pread() and enable column metadata API for all builds.
This brings nativesdk in line with target and native builds.
Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
---
meta/recipes-support/sqlite/sqlite3.inc | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
index 95ec89c..1834867d 100644
--- a/meta/recipes-support/sqlite/sqlite3.inc
+++ b/meta/recipes-support/sqlite/sqlite3.inc
@@ -36,12 +36,10 @@ EXTRA_OECONF = " \
CFLAGS_append = " -fPIC"
# pread() is in POSIX.1-2001 so any reasonable system must surely support it
-BUILD_CFLAGS += "-DUSE_PREAD"
-TARGET_CFLAGS += "-DUSE_PREAD"
+CFLAGS += "-DUSE_PREAD"
# Provide column meta-data API
-BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
-TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
+CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
--
1.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-15 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 7:56 [PATCH] sqlite3: consistent set of features for nativesdk S. Lockwood-Childs
2018-06-15 18:54 ` Khem Raj
2018-06-15 19:26 ` [PATCH V2] " S. Lockwood-Childs
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.