[PATCH] sqlite3: consistent set of features for nativesdk

[PATCH] sqlite3: consistent set of features for nativesdk

[S. Lockwood-Childs]

Enable use of pread() and enable column metadata API for nativesdk builds.
This brings nativesdk in line with target and native builds.
---
 meta/recipes-support/sqlite/sqlite3.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
index 95ec89c..30847b9 100644
--- a/meta/recipes-support/sqlite/sqlite3.inc
+++ b/meta/recipes-support/sqlite/sqlite3.inc
@@ -37,10 +37,12 @@ CFLAGS_append = " -fPIC"
 
 # pread() is in POSIX.1-2001 so any reasonable system must surely support it
 BUILD_CFLAGS += "-DUSE_PREAD"
+BUILDSDK_CFLAGS += "-DUSE_PREAD"
 TARGET_CFLAGS += "-DUSE_PREAD"
 
 # Provide column meta-data API
 BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
+BUILDSDK_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
 TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
 
 PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
-- 
1.9.4

Re: [PATCH] sqlite3: consistent set of features for nativesdk

[Khem Raj]

On Fri, Jun 15, 2018 at 12:58 AM S. Lockwood-Childs <sjl@vctlabs.com> wrote:
>
> Enable use of pread() and enable column metadata API for nativesdk builds.
> This brings nativesdk in line with target and native builds.
> ---
>  meta/recipes-support/sqlite/sqlite3.inc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
> index 95ec89c..30847b9 100644
> --- a/meta/recipes-support/sqlite/sqlite3.inc
> +++ b/meta/recipes-support/sqlite/sqlite3.inc
> @@ -37,10 +37,12 @@ CFLAGS_append = " -fPIC"
>
>  # pread() is in POSIX.1-2001 so any reasonable system must surely support it
>  BUILD_CFLAGS += "-DUSE_PREAD"
> +BUILDSDK_CFLAGS += "-DUSE_PREAD"
>  TARGET_CFLAGS += "-DUSE_PREAD"
>

Perhaps, we can just add it to CPPFLAGS and remove all three lines above

>  # Provide column meta-data API
>  BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
> +BUILDSDK_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
>  TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
>

same as above

>  PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
> --
> 1.9.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[PATCH V2] sqlite3: consistent set of features for nativesdk

[S. Lockwood-Childs]

Enable use of pread() and enable column metadata API for all builds.
This brings nativesdk in line with target and native builds.

Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
---
 meta/recipes-support/sqlite/sqlite3.inc | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-support/sqlite/sqlite3.inc b/meta/recipes-support/sqlite/sqlite3.inc
index 95ec89c..1834867d 100644
--- a/meta/recipes-support/sqlite/sqlite3.inc
+++ b/meta/recipes-support/sqlite/sqlite3.inc
@@ -36,12 +36,10 @@ EXTRA_OECONF = " \
 CFLAGS_append = " -fPIC"
 
 # pread() is in POSIX.1-2001 so any reasonable system must surely support it
-BUILD_CFLAGS += "-DUSE_PREAD"
-TARGET_CFLAGS += "-DUSE_PREAD"
+CFLAGS += "-DUSE_PREAD"
 
 # Provide column meta-data API
-BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
-TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
+CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
 
 PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
 
-- 
1.9.4