* [PATCH] fpga: dfl: fme: error pointer vs NULL bug
@ 2018-08-02 8:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-08-02 8:29 UTC (permalink / raw)
To: Wu Hao, Kang Luwei; +Cc: Alan Tull, Moritz Fischer, linux-fpga, kernel-janitors
The dfl_fme_create_region() function doesn't return NULL pointers, it
returns error pointers.
Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
index fc9fd2d0482f..0b840531ef33 100644
--- a/drivers/fpga/dfl-fme-pr.c
+++ b/drivers/fpga/dfl-fme-pr.c
@@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
/* Create region for each port */
fme_region = dfl_fme_create_region(pdata, mgr,
fme_br->br, i);
- if (!fme_region) {
+ if (IS_ERR(fme_region)) {
ret = PTR_ERR(fme_region);
goto destroy_region;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] fpga: dfl: fme: error pointer vs NULL bug
@ 2018-08-02 8:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-08-02 8:29 UTC (permalink / raw)
To: Wu Hao, Kang Luwei; +Cc: Alan Tull, Moritz Fischer, linux-fpga, kernel-janitors
The dfl_fme_create_region() function doesn't return NULL pointers, it
returns error pointers.
Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
index fc9fd2d0482f..0b840531ef33 100644
--- a/drivers/fpga/dfl-fme-pr.c
+++ b/drivers/fpga/dfl-fme-pr.c
@@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
/* Create region for each port */
fme_region = dfl_fme_create_region(pdata, mgr,
fme_br->br, i);
- if (!fme_region) {
+ if (IS_ERR(fme_region)) {
ret = PTR_ERR(fme_region);
goto destroy_region;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fpga: dfl: fme: error pointer vs NULL bug
2018-08-02 8:29 ` Dan Carpenter
@ 2018-08-02 8:40 ` Wu Hao
-1 siblings, 0 replies; 4+ messages in thread
From: Wu Hao @ 2018-08-02 8:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kang Luwei, Alan Tull, Moritz Fischer, linux-fpga, kernel-janitors
On Thu, Aug 02, 2018 at 11:29:31AM +0300, Dan Carpenter wrote:
> The dfl_fme_create_region() function doesn't return NULL pointers, it
> returns error pointers.
Thanks for your patch. But it's the same fixing as below one. :)
https://marc.info/?l=linux-fpga&m\x153200573532534&w=2
Hao
>
> Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
> index fc9fd2d0482f..0b840531ef33 100644
> --- a/drivers/fpga/dfl-fme-pr.c
> +++ b/drivers/fpga/dfl-fme-pr.c
> @@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
> /* Create region for each port */
> fme_region = dfl_fme_create_region(pdata, mgr,
> fme_br->br, i);
> - if (!fme_region) {
> + if (IS_ERR(fme_region)) {
> ret = PTR_ERR(fme_region);
> goto destroy_region;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fpga: dfl: fme: error pointer vs NULL bug
@ 2018-08-02 8:40 ` Wu Hao
0 siblings, 0 replies; 4+ messages in thread
From: Wu Hao @ 2018-08-02 8:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kang Luwei, Alan Tull, Moritz Fischer, linux-fpga, kernel-janitors
On Thu, Aug 02, 2018 at 11:29:31AM +0300, Dan Carpenter wrote:
> The dfl_fme_create_region() function doesn't return NULL pointers, it
> returns error pointers.
Thanks for your patch. But it's the same fixing as below one. :)
https://marc.info/?l=linux-fpga&m=153200573532534&w=2
Hao
>
> Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
> index fc9fd2d0482f..0b840531ef33 100644
> --- a/drivers/fpga/dfl-fme-pr.c
> +++ b/drivers/fpga/dfl-fme-pr.c
> @@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
> /* Create region for each port */
> fme_region = dfl_fme_create_region(pdata, mgr,
> fme_br->br, i);
> - if (!fme_region) {
> + if (IS_ERR(fme_region)) {
> ret = PTR_ERR(fme_region);
> goto destroy_region;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-02 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02 8:29 [PATCH] fpga: dfl: fme: error pointer vs NULL bug Dan Carpenter
2018-08-02 8:29 ` Dan Carpenter
2018-08-02 8:40 ` Wu Hao
2018-08-02 8:40 ` Wu Hao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.