* [PATCH] ath9k: add reset for airtime station debugfs @ 2018-09-06 3:53 Louie Lu 2018-09-06 9:27 ` Toke Høiland-Jørgensen 2018-10-01 14:06 ` Kalle Valo 0 siblings, 2 replies; 9+ messages in thread From: Louie Lu @ 2018-09-06 3:53 UTC (permalink / raw) To: kvalo; +Cc: ath9k-devel, davem, linux-wireless, netdev, toke Let user can reset station airtime status by debugfs, it will reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx airtime accumulate to 0. Signed-off-by: Louie Lu <git@louie.lu> --- drivers/net/wireless/ath/ath9k/debug_sta.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/debug_sta.c b/drivers/net/wireless/ath/ath9k/debug_sta.c index ed8b77a74630..e8fcd3e1c470 100644 --- a/drivers/net/wireless/ath/ath9k/debug_sta.c +++ b/drivers/net/wireless/ath/ath9k/debug_sta.c @@ -286,9 +286,25 @@ static ssize_t read_airtime(struct file *file, char __user *user_buf, return retval; } +static ssize_t +write_airtime_reset_stub(struct file *file, const char __user *ubuf, + size_t count, loff_t *ppos) +{ + struct ath_node *an = file->private_data; + struct ath_airtime_stats *astats; + int i; + + astats = &an->airtime_stats; + astats->rx_airtime = 0; + astats->tx_airtime = 0; + for (i = 0; i < 4; i++) + an->airtime_deficit[i] = ATH_AIRTIME_QUANTUM; + return count; +} static const struct file_operations fops_airtime = { .read = read_airtime, + .write = write_airtime_reset_stub, .open = simple_open, .owner = THIS_MODULE, .llseek = default_llseek, @@ -304,5 +320,5 @@ void ath9k_sta_add_debugfs(struct ieee80211_hw *hw, debugfs_create_file("node_aggr", 0444, dir, an, &fops_node_aggr); debugfs_create_file("node_recv", 0444, dir, an, &fops_node_recv); - debugfs_create_file("airtime", 0444, dir, an, &fops_airtime); + debugfs_create_file("airtime", 0644, dir, an, &fops_airtime); } -- 2.18.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ath9k: add reset for airtime station debugfs 2018-09-06 3:53 [PATCH] ath9k: add reset for airtime station debugfs Louie Lu @ 2018-09-06 9:27 ` Toke Høiland-Jørgensen 2018-10-01 14:06 ` Kalle Valo 1 sibling, 0 replies; 9+ messages in thread From: Toke Høiland-Jørgensen @ 2018-09-06 9:27 UTC (permalink / raw) To: Louie Lu, kvalo-sgV2jX0FEOL9JmXXK+q4OQ Cc: ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw, davem-fT/PcQaiUtIeIZ0/mPfg9Q, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA Louie Lu <git-sgRGTR89XAc@public.gmane.org> writes: > Let user can reset station airtime status by debugfs, it will > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx > airtime accumulate to 0. No objections to the patch, but I'm curious which issues you were debugging that led you to needing it? :) -Toke ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath9k: add reset for airtime station debugfs @ 2018-09-06 9:27 ` Toke Høiland-Jørgensen 0 siblings, 0 replies; 9+ messages in thread From: Toke Høiland-Jørgensen @ 2018-09-06 9:27 UTC (permalink / raw) To: Louie Lu, kvalo; +Cc: ath9k-devel, davem, linux-wireless, netdev Louie Lu <git@louie.lu> writes: > Let user can reset station airtime status by debugfs, it will > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx > airtime accumulate to 0. No objections to the patch, but I'm curious which issues you were debugging that led you to needing it? :) -Toke ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ@mail.gmail.com>]
[parent not found: <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] ath9k: add reset for airtime station debugfs [not found] ` <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ@mail.gmail.com> @ 2018-09-06 10:40 ` Toke Høiland-Jørgensen 0 siblings, 0 replies; 9+ messages in thread From: Toke Høiland-Jørgensen @ 2018-09-06 10:40 UTC (permalink / raw) To: Louie Lu Cc: kvalo-sgV2jX0FEOL9JmXXK+q4OQ, ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw, davem-fT/PcQaiUtIeIZ0/mPfg9Q, linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA Louie Lu <git-sgRGTR89XAc@public.gmane.org> writes: > Toke Høiland-Jørgensen <toke-LJ9M9ZcSy1A@public.gmane.org> 於 2018年9月6日 週四 下午5:27寫道： > >> Louie Lu <git-sgRGTR89XAc@public.gmane.org> writes: >> >> > Let user can reset station airtime status by debugfs, it will >> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx >> > airtime accumulate to 0. >> >> No objections to the patch, but I'm curious which issues you were >> debugging that led you to needing it? :) >> > I'm testing to get the packet queue time + airtime in > ath_tx_process_buffer, Right; I've been thinking that it would be useful to make the CoDel enqueue time available to drivers. And minstrel, for that matter (lowering the number of retries for packets that has queued for a long time, for instance). Good to hear that others are looking into something similar :) > it would be useful if I can reset the station airtime accumulated > value, so I can observe in each test round (e.g. 5 ping) airtime > accumulated > > Also to reset the deficit to make sure it run like fresh one. Yup, makes sense. -Toke ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath9k: add reset for airtime station debugfs @ 2018-09-06 10:40 ` Toke Høiland-Jørgensen 0 siblings, 0 replies; 9+ messages in thread From: Toke Høiland-Jørgensen @ 2018-09-06 10:40 UTC (permalink / raw) To: Louie Lu; +Cc: kvalo, ath9k-devel, davem, linux-wireless, netdev Louie Lu <git@louie.lu> writes: > Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> =E6=96=BC 2018=E5=B9=B49= =E6=9C=886=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=885:27=E5=AF=AB=E9= =81=93=EF=BC=9A > >> Louie Lu <git@louie.lu> writes: >> >> > Let user can reset station airtime status by debugfs, it will >> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx >> > airtime accumulate to 0. >> >> No objections to the patch, but I'm curious which issues you were >> debugging that led you to needing it? :) >> > I'm testing to get the packet queue time + airtime in > ath_tx_process_buffer, Right; I've been thinking that it would be useful to make the CoDel enqueue time available to drivers. And minstrel, for that matter (lowering the number of retries for packets that has queued for a long time, for instance). Good to hear that others are looking into something similar :) > it would be useful if I can reset the station airtime accumulated > value, so I can observe in each test round (e.g. 5 ping) airtime > accumulated > > Also to reset the deficit to make sure it run like fresh one. Yup, makes sense. -Toke ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath9k: add reset for airtime station debugfs 2018-09-06 10:40 ` Toke Høiland-Jørgensen @ 2018-09-09 23:44 ` Dave Taht -1 siblings, 0 replies; 9+ messages in thread From: Dave Taht @ 2018-09-09 23:44 UTC (permalink / raw) To: Toke Høiland-Jørgensen Cc: git, Kalle Valo, QCA ath9k Development, David S. Miller, linux-wireless, Linux Kernel Network Developers On Thu, Sep 6, 2018 at 4:13 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote: > > Louie Lu <git@louie.lu> writes: > > > Toke Høiland-Jørgensen <toke@toke.dk> 於 2018年9月6日 週四 下午5:27寫道： > > > >> Louie Lu <git@louie.lu> writes: > >> > >> > Let user can reset station airtime status by debugfs, it will > >> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx > >> > airtime accumulate to 0. > >> > >> No objections to the patch, but I'm curious which issues you were > >> debugging that led you to needing it? :) > >> > > I'm testing to get the packet queue time + airtime in > > ath_tx_process_buffer, > > Right; I've been thinking that it would be useful to make the CoDel > enqueue time available to drivers. And minstrel, for that matter > (lowering the number of retries for packets that has queued for a long > time, for instance). Good to hear that others are looking into something > similar :) Yea! Seeing retransmits scale down would be a goodness. Last I looked ath9k was at, like 10?, when it should be, like, 2, at mcs0 and 10 at mcs15. I can't seem to publish a link to this directly, but it's open access if you search via https://scholar.google.com/: "Resolving Bufferbloat in TCP Communication over IEEE 802.11 n WLAN by Reducing MAC Retransmission Limit at Low Data Rate" even their simple bifurcated model worked well. > > > it would be useful if I can reset the station airtime accumulated > > value, so I can observe in each test round (e.g. 5 ping) airtime > > accumulated > > > > Also to reset the deficit to make sure it run like fresh one. > > Yup, makes sense. > > -Toke -- Dave Täht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath9k: add reset for airtime station debugfs @ 2018-09-09 23:44 ` Dave Taht 0 siblings, 0 replies; 9+ messages in thread From: Dave Taht @ 2018-09-09 23:44 UTC (permalink / raw) To: Toke Høiland-Jørgensen Cc: git, Kalle Valo, QCA ath9k Development, David S. Miller, linux-wireless, Linux Kernel Network Developers On Thu, Sep 6, 2018 at 4:13 AM Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.= dk> wrote: > > Louie Lu <git@louie.lu> writes: > > > Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> =E6=96=BC 2018=E5=B9=B4= 9=E6=9C=886=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=885:27=E5=AF=AB=E9= =81=93=EF=BC=9A > > > >> Louie Lu <git@louie.lu> writes: > >> > >> > Let user can reset station airtime status by debugfs, it will > >> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx > >> > airtime accumulate to 0. > >> > >> No objections to the patch, but I'm curious which issues you were > >> debugging that led you to needing it? :) > >> > > I'm testing to get the packet queue time + airtime in > > ath_tx_process_buffer, > > Right; I've been thinking that it would be useful to make the CoDel > enqueue time available to drivers. And minstrel, for that matter > (lowering the number of retries for packets that has queued for a long > time, for instance). Good to hear that others are looking into something > similar :) Yea! Seeing retransmits scale down would be a goodness. Last I looked ath9k was at, like 10?, when it should be, like, 2, at mcs0 and 10 at mcs15. I can't seem to publish a link to this directly, but it's open access if you search via https://scholar.google.com/: "Resolving Bufferbloat in TCP Communication over IEEE 802.11 n WLAN by Reducing MAC Retransmission Limit at Low Data Rate" even their simple bifurcated model worked well. > > > it would be useful if I can reset the station airtime accumulated > > value, so I can observe in each test round (e.g. 5 ping) airtime > > accumulated > > > > Also to reset the deficit to make sure it run like fresh one. > > Yup, makes sense. > > -Toke --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath9k: add reset for airtime station debugfs 2018-09-06 9:27 ` Toke Høiland-Jørgensen (?) (?) @ 2018-09-06 10:41 ` Louie Lu -1 siblings, 0 replies; 9+ messages in thread From: Louie Lu @ 2018-09-06 10:41 UTC (permalink / raw) To: Toke Høiland-Jørgensen Cc: kvalo, ath9k-devel, davem, linux-wireless, netdev Previous mail rejects by mailing list, re-send again... Toke Høiland-Jørgensen <toke@toke.dk> 於 2018年9月6日 週四 下午5:27寫道： > > Louie Lu <git@louie.lu> writes: > > > Let user can reset station airtime status by debugfs, it will > > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx > > airtime accumulate to 0. > > No objections to the patch, but I'm curious which issues you were > debugging that led you to needing it? :) > I'm testing to get the packet queue time + airtime in ath_tx_process_buffer, it would be useful if I can reset the station airtime accumulated value, so I can observe in each test round (e.g. 5 ping) airtime accumulated Also to reset the deficit to make sure it runs like fresh one. Louie. > > -Toke ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath9k: add reset for airtime station debugfs 2018-09-06 3:53 [PATCH] ath9k: add reset for airtime station debugfs Louie Lu 2018-09-06 9:27 ` Toke Høiland-Jørgensen @ 2018-10-01 14:06 ` Kalle Valo 1 sibling, 0 replies; 9+ messages in thread From: Kalle Valo @ 2018-10-01 14:06 UTC (permalink / raw) To: Louie Lu; +Cc: ath9k-devel, davem, linux-wireless, netdev, toke Louie Lu <git@louie.lu> wrote: > Let user can reset station airtime status by debugfs, it will > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx > airtime accumulate to 0. > > Signed-off-by: Louie Lu <git@louie.lu> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 3fa8d2186550 ath9k: add reset for airtime station debugfs -- https://patchwork.kernel.org/patch/10589835/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-10-01 20:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-06 3:53 [PATCH] ath9k: add reset for airtime station debugfs Louie Lu
2018-09-06 9:27 ` Toke Høiland-Jørgensen
2018-09-06 9:27 ` Toke Høiland-Jørgensen
[not found] ` <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ@mail.gmail.com>
[not found] ` <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-09-06 10:40 ` Toke Høiland-Jørgensen
2018-09-06 10:40 ` Toke Høiland-Jørgensen
2018-09-09 23:44 ` Dave Taht
2018-09-09 23:44 ` Dave Taht
2018-09-06 10:41 ` Louie Lu
2018-10-01 14:06 ` Kalle Valo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.