From: Richard Guy Briggs <rgb@redhat.com> To: Jan Kara <jack@suse.cz> Cc: Paul Moore <paul@paul-moore.com>, Al Viro <viro@ZenIV.linux.org.uk>, linux-audit@redhat.com, linux-fsdevel@vger.kernel.org, Amir Goldstein <amir73il@gmail.com> Subject: Re: [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Date: Fri, 14 Sep 2018 15:13:28 -0400 [thread overview] Message-ID: <20180914191328.rljpiakvk4xavrzj@madcap2.tricolour.ca> (raw) In-Reply-To: <20180904160632.21210-1-jack@suse.cz> On 2018-09-04 18:06, Jan Kara wrote: > Hello, Jan, > this is the third revision of the series that addresses problems I have > identified when trying to understand how exactly is kernel/audit_tree.c using > generic fsnotify framework. I hope I have understood all the interactions right > but careful review is certainly welcome. I've tried to review it as carefully as I am able. As best I understand it, this all looks reasonable and an improvement over the previous state. Thanks for the hard work. FWIW, Reviewed-by: Richard Guy Briggs <rgb@redhat.com> > The patches have been tested by a stress test I have written which mounts & > unmounts filesystems in the directory tree while adding and removing audit > rules for this tree in parallel and accessing the tree to generate events. > Still some real-world testing would be welcome. > > Changes since v2: > * Fixed up mark freeing to use proper pointer as pointed out by Amir > * Changed some naming based on Paul's review > > Changes since v1: > * Split the last patch to ease review > * Rewrite test script so that it can be included in audit testsuite > * Some cleanups and improvements suggested by Amir > > Honza - RGB -- Richard Guy Briggs <rgb@redhat.com> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635
WARNING: multiple messages have this Message-ID (diff)
From: Richard Guy Briggs <rgb@redhat.com> To: Jan Kara <jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, linux-audit@redhat.com, Amir Goldstein <amir73il@gmail.com>, Al Viro <viro@ZenIV.linux.org.uk> Subject: Re: [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Date: Fri, 14 Sep 2018 15:13:28 -0400 [thread overview] Message-ID: <20180914191328.rljpiakvk4xavrzj@madcap2.tricolour.ca> (raw) In-Reply-To: <20180904160632.21210-1-jack@suse.cz> On 2018-09-04 18:06, Jan Kara wrote: > Hello, Jan, > this is the third revision of the series that addresses problems I have > identified when trying to understand how exactly is kernel/audit_tree.c using > generic fsnotify framework. I hope I have understood all the interactions right > but careful review is certainly welcome. I've tried to review it as carefully as I am able. As best I understand it, this all looks reasonable and an improvement over the previous state. Thanks for the hard work. FWIW, Reviewed-by: Richard Guy Briggs <rgb@redhat.com> > The patches have been tested by a stress test I have written which mounts & > unmounts filesystems in the directory tree while adding and removing audit > rules for this tree in parallel and accessing the tree to generate events. > Still some real-world testing would be welcome. > > Changes since v2: > * Fixed up mark freeing to use proper pointer as pointed out by Amir > * Changed some naming based on Paul's review > > Changes since v1: > * Split the last patch to ease review > * Rewrite test script so that it can be included in audit testsuite > * Some cleanups and improvements suggested by Amir > > Honza - RGB -- Richard Guy Briggs <rgb@redhat.com> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635
next prev parent reply other threads:[~2018-09-15 0:34 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-04 16:06 [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 01/11] audit_tree: Remove mark->lock locking Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 02/11] audit: Fix possible spurious -ENOSPC error Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 03/11] audit: Fix possible tagging failures Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 04/11] audit: Embed key into chunk Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-13 20:06 ` Richard Guy Briggs 2018-09-13 20:06 ` Richard Guy Briggs 2018-09-04 16:06 ` [PATCH 05/11] audit: Make hash table insertion safe against concurrent lookups Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 06/11] audit: Factor out chunk replacement code Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 07/11] audit: Remove pointless check in insert_hash() Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 08/11] audit: Provide helper for dropping mark's chunk reference Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 09/11] audit: Allocate fsnotify mark independently of chunk Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-14 14:09 ` Richard Guy Briggs 2018-09-14 14:09 ` Richard Guy Briggs 2018-09-17 16:46 ` Jan Kara 2018-09-17 16:46 ` Jan Kara 2018-10-03 22:11 ` Paul Moore 2018-10-03 22:11 ` Paul Moore 2018-10-03 22:08 ` Paul Moore 2018-10-03 22:08 ` Paul Moore 2018-10-03 22:39 ` Richard Guy Briggs 2018-10-03 22:39 ` Richard Guy Briggs 2018-10-04 6:57 ` Jan Kara 2018-10-04 6:57 ` Jan Kara 2018-09-04 16:06 ` [PATCH 10/11] audit: Replace chunk attached to mark instead of replacing mark Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 11/11] audit: Use 'mark' name for fsnotify_mark variables Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-14 18:29 ` Richard Guy Briggs 2018-09-14 18:29 ` Richard Guy Briggs 2018-09-17 16:44 ` Jan Kara 2018-09-17 16:44 ` Jan Kara 2018-09-17 18:13 ` Richard Guy Briggs 2018-09-17 18:13 ` Richard Guy Briggs 2018-09-04 16:06 ` [PATCH 12/11 TESTSUITE] audit_testsuite: Add stress test for tree watches Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-14 18:21 ` Richard Guy Briggs 2018-09-14 18:21 ` Richard Guy Briggs 2018-09-17 16:56 ` Jan Kara 2018-09-17 16:56 ` Jan Kara 2018-10-05 21:06 ` Paul Moore 2018-10-05 21:06 ` Paul Moore 2018-10-09 7:40 ` Jan Kara 2018-10-09 7:40 ` Jan Kara 2018-10-10 6:43 ` Paul Moore 2018-10-10 6:43 ` Paul Moore 2018-10-11 11:39 ` Jan Kara 2018-10-11 11:39 ` Jan Kara 2018-10-11 23:03 ` Paul Moore 2018-10-11 23:03 ` Paul Moore 2018-10-15 10:04 ` Jan Kara 2018-10-15 10:04 ` Jan Kara 2018-10-15 15:39 ` Paul Moore 2018-10-15 15:39 ` Paul Moore 2018-10-17 10:09 ` Jan Kara 2018-10-17 10:09 ` Jan Kara 2018-11-14 0:34 ` Paul Moore 2018-11-14 0:34 ` Paul Moore 2018-11-14 12:16 ` Jan Kara 2018-11-14 12:16 ` Jan Kara 2018-11-19 15:19 ` Paul Moore 2018-11-19 15:19 ` Paul Moore 2018-09-14 19:13 ` Richard Guy Briggs [this message] 2018-09-14 19:13 ` [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Richard Guy Briggs 2018-09-17 16:57 ` Jan Kara 2018-09-17 16:57 ` Jan Kara 2018-10-04 1:20 ` Paul Moore 2018-10-04 1:20 ` Paul Moore 2018-10-04 6:59 ` Jan Kara 2018-10-04 6:59 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180914191328.rljpiakvk4xavrzj@madcap2.tricolour.ca \ --to=rgb@redhat.com \ --cc=amir73il@gmail.com \ --cc=jack@suse.cz \ --cc=linux-audit@redhat.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=paul@paul-moore.com \ --cc=viro@ZenIV.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.