Re: [Outreachy kernel] [PATCH 1/3] staging: mt7621-mmc: remove unnecessary braces from 'if' statements

[Himanshu Jha <himanshujha199640@gmail.com>]

> > Hi, I choose the CONFIG_PCI option, it did solve the undefined symbols,
> but the file still does not compile starting with the error:
> 
> drivers/staging/mt7621-pci/pci-mt7621.c:496:27: error: ‘port’ undeclared
> (first use in this function); did you mean ‘ror8’?
>   list_for_each_entry_safe(port, tmp, &pcie->ports, list) {
> 
> I saw that in other usages of list_for_each_entry_safe, the first parameter
> is a local variable.

Correct! Both port & tmp should be a local variable of the same object
type.

> > > Then in run "make menuconfig" again and under "Device Drivers -> staging
> > > drivers" I chose "MediaTek MT7621 PCI Controller"
> > > Hoping it will solve it , but it didn't.
> > >
> > > The files I prepared the patchset for did compile ok , is it important
> > that
> > > all files will compile?
> >
> > I think for these changes just use that .config supplied by the distro
> > at /boot/config-*
> >
> > But IIRC `make allyesconfig` should be used(not sure though..)
> >
> 
> But I compile on ubuntu on x86 and I want to compile to a specific mips SoC.
> I tried it anyway and it did not compile the file  I prepared the patch for
> (drivers/staging/mt7621-mmc/sd.c)

Cool! 
You found a bug while cross-compiling for MIPS which would not
show up on x86.

Btw, the Cc list should contain developers who might give you
a better feedback. Therefore, use `get_maintainer` to list all
those people.


-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology